64905 2011-07-20 16:55:23 -0700 Set DrawingBuffer's context's parent before publishing its backing store to the parent. 2011-07-20 19:47:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apatrick apatrick jamesr webkit.review.bot oldest_to_newest 440115 0 apatrick 2011-07-20 16:55:23 -0700 [chromium] Set DrawingBuffer's context's parent before publishing its backing store to the parent. This allows accelerated 2D canvas elements to be moved between windows. 440117 1 101528 apatrick 2011-07-20 16:58:03 -0700 Created attachment 101528 Patch 1 440120 2 apatrick 2011-07-20 17:12:31 -0700 The comment isn't exactly accurate. This patch allows an accelerated 2D canvas to be created in a newly opened windows but not moved from one to another. 440129 3 101528 jamesr 2011-07-20 17:19:24 -0700 Comment on attachment 101528 Patch 1 Why are you calling platformTexture()? If you just want m_context to be current, how about calling makeContextCurrent()? 440135 4 apatrick 2011-07-20 17:28:58 -0700 (In reply to comment #3) > (From update of attachment 101528 [details]) > Why are you calling platformTexture()? If you just want m_context to be current, how about calling makeContextCurrent()? GraphicsContext3DChromium::platformTexture sets the context's parent to that of the associated view. It also returns the texture ID in the context of that parent but that is not used for 2D canvas. 440167 5 101540 apatrick 2011-07-20 18:11:11 -0700 Created attachment 101540 Patch 2 440168 6 apatrick 2011-07-20 18:11:54 -0700 Updated patch as discussed with jamesr. 440169 7 101540 jamesr 2011-07-20 18:14:21 -0700 Comment on attachment 101540 Patch 2 Great! R=me 440211 8 101540 webkit.review.bot 2011-07-20 19:47:09 -0700 Comment on attachment 101540 Patch 2 Clearing flags on attachment: 101540 Committed r91441: <http://trac.webkit.org/changeset/91441> 440212 9 webkit.review.bot 2011-07-20 19:47:13 -0700 All reviewed patches have been landed. Closing bug. 101528 2011-07-20 16:58:03 -0700 2011-07-20 18:14:32 -0700 Patch 1 parent.patch text/plain 1418 apatrick SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxNDI0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMjAgIEFsIFBhdHJp Y2sgIDxhcGF0cmlja0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBTZXQgRHJh d2luZ0J1ZmZlcidzIGNvbnRleHQncyBwYXJlbnQgYmVmb3JlIHB1Ymxpc2hpbmcgaXRzIGJhY2tp bmcgc3RvcmUgdG8gdGhlIHBhcmVudC4KKyAgICAgICAgVGhpcyBhbGxvd3MgYWNjZWxlcmF0ZWQg MkQgY2FudmFzIGVsZW1lbnRzIHRvIGJlIG1vdmVkIGJldHdlZW4gd2luZG93cy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0OTA1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hyb21pdW0gYnJvd3NlciB0 ZXN0IHRvIGZvbGxvdyBpbiB0aGUgY2hyb21pdW0gcmVwb3NpdG9yeS4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0RyYXdpbmdCdWZmZXJDaHJvbWl1bS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpEcmF3aW5nQnVmZmVyOjpwdWJsaXNoVG9QbGF0Zm9ybUxheWVyKToKKwog MjAxMS0wNy0yMCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl bW92ZSBzdHJheSByZWZlcmVuY2UgdG8gU3R5bGVGbGV4aWJsZUJveERhdGEuaCB0aGF0IHdhcyBh Y2NpZGVudGFsbHkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL0RyYXdpbmdCdWZmZXJDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRHJhd2luZ0J1ZmZlckNocm9taXVtLmNwcAko cmV2aXNpb24gOTEzMDYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9EcmF3aW5nQnVmZmVyQ2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTQsNyAr MTE0LDkgQEAgdm9pZCBEcmF3aW5nQnVmZmVyOjpwdWJsaXNoVG9QbGF0Zm9ybUxheQogewogICAg IGlmICghbV9jb250ZXh0KQogICAgICAgICByZXR1cm47Ci0gICAgICAgIAorCisgICAgbV9jb250 ZXh0LT5wbGF0Zm9ybVRleHR1cmUoKTsKKwogICAgIGlmIChtX2NhbGxiYWNrKQogICAgICAgICBt X2NhbGxiYWNrLT53aWxsUHVibGlzaCgpOwogICAgIGlmIChtdWx0aXNhbXBsZSgpKQo= 101540 2011-07-20 18:11:11 -0700 2011-07-20 19:47:09 -0700 Patch 2 parent.patch text/plain 2262 apatrick SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5MTQzMikKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDctMjAgIEFsIFBhdHJpY2sgIDxhcGF0cmlja0BjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgU2V0IHRoZSBwYXJlbnQgY29udGV4dCB0byB0aGF0IG9mIHRoZSBhc3NvY2lhdGVkIHZp ZXcgd2hlbiBjYWxsaW5nIEdyYXBoaWNzQ29udGV4dDNEQ2hyb21pdW06OmNvcHlUZXh0dXJlVG9Q YXJlbnRDSFJPTUlVTS4KKyAgICAgICAgVGhpcyBmaXhlcyBhIHJhY2UgY29uZGl0aW9uIHdoZXJl YnkgdGhlIHZpZXcgd2luZG93IGRvZXMgbm90IGV4aXN0IHdoZW4gdGhlIG9mZnNjcmVlbiBjb250 ZXh0IGlzIGNyZWF0ZWQuIEl0IGFsbG93cworICAgICAgICBhY2NlbGVyYXRlZCAyRCBjYW52YXNl cyB0byBiZSBhZGRlZCB0byBuZXdseSBjcmVhdGVkIHdpbmRvdy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0OTA1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzcmMvR3JhcGhpY3NDb250ZXh0M0RDaHJv bWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzREludGVybmFsOjpj b3B5VGV4dHVyZVRvUGFyZW50VGV4dHVyZUNIUk9NSVVNKToKKwogMjAxMS0wNy0xOSAgVnNldm9s b2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9y OiBBZGQgc3VwcG9ydCBmb3IgZGlzYWJsaW5nIGNhY2hlIGluIHdlYiBpbnNwZWN0b3IuCkluZGV4 OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRENocm9taXVtLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRl eHQzRENocm9taXVtLmNwcAkocmV2aXNpb24gOTEzMDYpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRENocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAt ODMxLDcgKzgzMSwxMyBAQCBERUxFR0FURV9UT19JTVBMXzRSKG1hcEJ1ZmZlclN1YkRhdGFDSFJP CiBERUxFR0FURV9UT19JTVBMXzEodW5tYXBCdWZmZXJTdWJEYXRhQ0hST01JVU0sIGNvbnN0IHZv aWQqKQogREVMRUdBVEVfVE9fSU1QTF85UihtYXBUZXhTdWJJbWFnZTJEQ0hST01JVU0sIEdDM0Rl bnVtLCBHQzNEaW50LCBHQzNEaW50LCBHQzNEaW50LCBHQzNEc2l6ZWksIEdDM0RzaXplaSwgR0Mz RGVudW0sIEdDM0RlbnVtLCBHQzNEZW51bSwgdm9pZCopCiBERUxFR0FURV9UT19JTVBMXzEodW5t YXBUZXhTdWJJbWFnZTJEQ0hST01JVU0sIGNvbnN0IHZvaWQqKQotREVMRUdBVEVfVE9fSU1QTF8y KGNvcHlUZXh0dXJlVG9QYXJlbnRUZXh0dXJlQ0hST01JVU0sIFBsYXRmb3JtM0RPYmplY3QsIFBs YXRmb3JtM0RPYmplY3QpCisKK3ZvaWQgR3JhcGhpY3NDb250ZXh0M0RJbnRlcm5hbDo6Y29weVRl eHR1cmVUb1BhcmVudFRleHR1cmVDSFJPTUlVTShQbGF0Zm9ybTNET2JqZWN0IHRleHR1cmUsIFBs YXRmb3JtM0RPYmplY3QgcGFyZW50VGV4dHVyZSkKK3sKKyAgICBtX2ltcGwtPnNldFBhcmVudENv bnRleHQobV93ZWJWaWV3SW1wbC0+Z3JhcGhpY3NDb250ZXh0M0QoKSk7CisgICAgbV9pbXBsLT5j b3B5VGV4dHVyZVRvUGFyZW50VGV4dHVyZUNIUk9NSVVNKHRleHR1cmUsIHBhcmVudFRleHR1cmUp OworfQorCiBERUxFR0FURV9UT19JTVBMXzEwKGJsaXRGcmFtZWJ1ZmZlckNIUk9NSVVNLCBHQzNE aW50LCBHQzNEaW50LCBHQzNEaW50LCBHQzNEaW50LCBHQzNEaW50LCBHQzNEaW50LCBHQzNEaW50 LCBHQzNEaW50LCBHQzNEYml0ZmllbGQsIEdDM0RlbnVtKQogREVMRUdBVEVfVE9fSU1QTF81KHJl bmRlcmJ1ZmZlclN0b3JhZ2VNdWx0aXNhbXBsZUNIUk9NSVVNLCBHQzNEZW51bSwgR0MzRHNpemVp LCBHQzNEZW51bSwgR0MzRHNpemVpLCBHQzNEc2l6ZWkpCiBERUxFR0FURV9UT19JTVBMXzEoZ2V0 UGFyZW50VG9DaGlsZExhdGNoQ0hST01JVU0sIEdDM0R1aW50KikK