64904 2011-07-20 16:50:09 -0700 REGRESSION(r88757): input[type=range] renders incorrectly in RTL context 2011-07-21 05:31:45 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P1 Normal --- 1 groby tkent dglazkov mitz playmobil progame+wk rniwa tkent webkit.review.bot xji oldest_to_newest 440112 0 groby 2011-07-20 16:50:09 -0700 See sample page - the slider 'knob' is rendered outside the actual slider. This is true for both latest nightly (r91186) and a nightly as far back as r89741 - haven't tried earlier nightlies. Safari Version 5.0.5 (6533.21.1) renders this correctly. Reduced error case attached 440113 1 101527 groby 2011-07-20 16:52:57 -0700 Created attachment 101527 repro case 440297 2 playmobil 2011-07-21 00:29:55 -0700 Regressions are P1. groby: Can you bisect to find where this broke? 440298 3 progame+wk 2011-07-21 00:31:29 -0700 i'll have one in a few minutes 440299 4 tkent 2011-07-21 00:35:04 -0700 r88757 is suspective. 440300 5 progame+wk 2011-07-21 00:41:31 -0700 yes, i got as far as WebKit 88697:88789. (and r88757 seems likely) 440301 6 progame+wk 2011-07-21 00:48:48 -0700 It breaks RTL DOMUI-Options Fonts pane in Chromium ( http://crbug.com/87690 ) 440310 7 101562 tkent 2011-07-21 02:05:02 -0700 Created attachment 101562 Patch 440313 8 101562 rniwa 2011-07-21 02:18:51 -0700 Comment on attachment 101562 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101562&action=review > Source/WebCore/html/shadow/SliderThumbElement.cpp:243 > + if (isVertical || !renderBox()->style()->isLeftToRightDirection()) Would this work if isVertical was true and isLeftToRightDirection() was false? 440315 9 101562 tkent 2011-07-21 02:25:02 -0700 Comment on attachment 101562 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101562&action=review >> Source/WebCore/html/shadow/SliderThumbElement.cpp:243 >> + if (isVertical || !renderBox()->style()->isLeftToRightDirection()) > > Would this work if isVertical was true and isLeftToRightDirection() was false? It works. If isVertical is true, isLeftToRightDirection() doesn't matter. We have no LTR/RTL differences in vertical sliders. 440316 10 101562 rniwa 2011-07-21 02:26:41 -0700 Comment on attachment 101562 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101562&action=review ok, looks sane to me. >>> Source/WebCore/html/shadow/SliderThumbElement.cpp:243 >>> + if (isVertical || !renderBox()->style()->isLeftToRightDirection()) >> >> Would this work if isVertical was true and isLeftToRightDirection() was false? > > It works. > If isVertical is true, isLeftToRightDirection() doesn't matter. We have no LTR/RTL differences in vertical sliders. Should we at least add a test case for it? 440319 11 101564 tkent 2011-07-21 02:31:31 -0700 Created attachment 101564 Patch for landing Add a vertical case 440340 12 101564 webkit.review.bot 2011-07-21 04:07:56 -0700 Comment on attachment 101564 Patch for landing Rejecting attachment 101564 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: Unexpected flakiness: text diff mismatch (1) fast/forms/implicit-submission.html = TEXT PASS Regressions: Unexpected image mismatch : (6) fast/forms/input-appearance-range-rtl.html = IMAGE fast/text/atsui-multiple-renderers.html = IMAGE fast/text/international/danda-space.html = IMAGE fast/text/international/thai-baht-space.html = IMAGE fast/text/international/thai-line-breaks.html = IMAGE platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE Full output: http://queues.webkit.org/results/9191618 440345 13 tkent 2011-07-21 04:17:53 -0700 (In reply to comment #12) > Regressions: Unexpected image mismatch : (6) > fast/forms/input-appearance-range-rtl.html = IMAGE I have no idea what's wrong on Chromium-linux. Anyway, it must be a test problem, not a C++ code problem. I'll add the test to test_expectations.txt, land the patch, and see results on Chromium buildbots. 440346 14 tkent 2011-07-21 04:21:55 -0700 Committed r91460: <http://trac.webkit.org/changeset/91460> 440359 15 tkent 2011-07-21 05:31:45 -0700 (In reply to comment #13) > (In reply to comment #12) > > Regressions: Unexpected image mismatch : (6) > > fast/forms/input-appearance-range-rtl.html = IMAGE > > I have no idea what's wrong on Chromium-linux. Anyway, it must be a test problem, not a C++ code problem. I'll add the test to test_expectations.txt, land the patch, and see results on Chromium buildbots. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLargeExpectations=true&showExpectations=true&tests=range-rtl It was due to a Chromium bug: http://code.google.com/p/chromium/issues/detail?id=89616 101527 2011-07-20 16:52:57 -0700 2011-07-20 16:52:57 -0700 repro case range-rtl.html text/html 239 groby PGh0bWwgZGlyPSJydGwiPgoKPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KLmNvbnRhaW5lciB7CiAg ZGlzcGxheTotd2Via2l0LWJveDsKfQouc3BhY2VyIHsKICB3aWR0aDoyMDBweDsKfQo8L3N0eWxl PgoKPGJvZHk+CiAgPGRpdiBjbGFzcz0iY29udGFpbmVyIj4KICAgICAgPGRpdiBjbGFzcz0ic3Bh Y2VyIj48L2Rpdj4KICAgICAgPGRpdj48aW5wdXQgdHlwZT0icmFuZ2UiPjwvZGl2PgogICAgPC9k aXY+CjwvYm9keT4= 101562 2011-07-21 02:05:02 -0700 2011-07-21 02:31:24 -0700 Patch bug-64904-20110721180500.patch text/plain 4544 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogOTE0NDkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2NWIyMmM0MzIxYWRhNjFhNjMzYmE0 NTU4MmJjOTRlZjc4ZmIyYjY2Li4xZWYyMzJkMjk5YzI4MWFmZGNhNjAwMDVlMmYzOThjOTBkMGYz MDA1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDctMjEgIEtlbnQgVGFtdXJhICA8dGtl bnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjg4NzU3KTogaW5wdXRbdHlw ZT1yYW5nZV0gcmVuZGVycyBpbmNvcnJlY3RseSBpbiBSVEwgY29udGV4dC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0OTA0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2lucHV0LWFw cGVhcmFuY2UtcmFuZ2UtcnRsLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv Zm9ybXMvaW5wdXQtYXBwZWFyYW5jZS1yYW5nZS1ydGwuaHRtbDogQWRkZWQuCisKIDIwMTEtMDct MjAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIGNyYXNo IGV4cGVjdGF0aW9uIHRvIGZhc3QvY2FudmFzL3dlYmdsL3JlbmRlcmJ1ZmZlci1pbml0aWFsaXph dGlvbi5odG1sIG9uIENocm9taXVtIFdpbmRvd3MsCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2Zvcm1zL2lucHV0LWFwcGVhcmFuY2UtcmFuZ2UtcnRsLWV4cGVjdGVkLmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL2lucHV0LWFwcGVhcmFuY2UtcmFuZ2UtcnRsLWV4cGVjdGVkLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uNmU4M2QzZTgyMzBkNzRjOTExYWZiMzEyMTcyYzlkZjcyNjRjZDYzMAot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQtYXBwZWFyYW5j ZS1yYW5nZS1ydGwtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDEzIEBACis8IURPQ1RZUEUgaHRt bD4KKzxodG1sPgorPGJvZHk+Cis8ZGl2PjxpbnB1dCB0eXBlPXJhbmdlIHZhbHVlPTEwMD48L2Rp dj4KKzxkaXY+PGlucHV0IHR5cGU9cmFuZ2UgdmFsdWU9NTA+PC9kaXY+Cis8ZGl2PjxpbnB1dCB0 eXBlPXJhbmdlIHZhbHVlPTA+PC9kaXY+Cis8ZGl2PjxpbnB1dCB0eXBlPXJhbmdlIHZhbHVlPTA+ PC9kaXY+Cis8ZGl2PjxpbnB1dCB0eXBlPXJhbmdlIHZhbHVlPTA+PC9kaXY+Cis8ZGl2PjxpbnB1 dCB0eXBlPXJhbmdlIHZhbHVlPTA+PC9kaXY+Cis8ZGl2PjxpbnB1dCB0eXBlPXJhbmdlIHZhbHVl PTA+PC9kaXY+Cis8ZGl2PjxpbnB1dCB0eXBlPXJhbmdlIHZhbHVlPTA+PC9kaXY+Cis8L2JvZHk+ Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lucHV0LWFwcGVh cmFuY2UtcmFuZ2UtcnRsLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lucHV0LWFwcGVh cmFuY2UtcmFuZ2UtcnRsLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uY2ZjNjQyYTgwMWYyNDI5MGM2NTdiNTU4 Mjg1YTAwNzliYzZiMDE4NwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9y bXMvaW5wdXQtYXBwZWFyYW5jZS1yYW5nZS1ydGwuaHRtbApAQCAtMCwwICsxLDE5IEBACis8IURP Q1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8ZGl2PjxpbnB1dCB0eXBlPXJhbmdlIHZhbHVl PTAgZGlyPXJ0bD48L2Rpdj4KKzxkaXY+PGlucHV0IHR5cGU9cmFuZ2UgdmFsdWU9NTAgZGlyPXJ0 bD48L2Rpdj4KKzxkaXY+PGlucHV0IHR5cGU9cmFuZ2UgdmFsdWU9MTAwIGRpcj1ydGw+PC9kaXY+ Cis8ZGl2PjxpbnB1dCB0eXBlPXJhbmdlIHZhbHVlPTEwMCBzdHlsZT0iZGlyZWN0aW9uOnJ0bCI+ PC9kaXY+Cis8ZGl2PjxpbnB1dCB0eXBlPXJhbmdlIHZhbHVlPTEwMCBpZD1yMT48L2Rpdj4KKzxk aXY+PGlucHV0IHR5cGU9cmFuZ2UgdmFsdWU9MTAwIGlkPXIyPjwvZGl2PgorPGRpdj48aW5wdXQg dHlwZT1yYW5nZSB2YWx1ZT0wIGlkPXIzIGRpcj1ydGw+PC9kaXY+Cis8ZGl2PjxpbnB1dCB0eXBl PXJhbmdlIHZhbHVlPTAgaWQ9cjQgc3R5bGU9ImRpcmVjdGlvbjpydGwiPjwvZGl2PgorPHNjcmlw dD4KK2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyMScpLmRpciA9ICdydGwnOworZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoJ3IyJykuc3R5bGUuZGlyZWN0aW9uID0gJ3J0bCc7Citkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgncjMnKS5kaXIgPSAnbHRyJzsKK2RvY3VtZW50LmdldEVsZW1lbnRCeUlk KCdyNCcpLnN0eWxlLmRpcmVjdGlvbiA9ICdsdHInOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0 bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKaW5kZXggNzFhZTBlZTU1MWM0ODg2YTVhYzQ2OGRiMzg4NmZkNTZiMDBkMjEy Zi4uNDA2ZTYxM2RhMmZmZmNlNmFiYTU2NjBhNWI4YmMyMzNkMWQ4MTM1ZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE4IEBACisyMDExLTA3LTIxICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKHI4ODc1Nyk6IGlucHV0W3R5cGU9cmFuZ2VdIHJl bmRlcnMgaW5jb3JyZWN0bHkgaW4gUlRMIGNvbnRleHQuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDkwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RzOiBmYXN0L2Zvcm1zL2lucHV0LWFwcGVhcmFu Y2UtcmFuZ2UtcnRsLmh0bWwKKworICAgICAgICAqIGh0bWwvc2hhZG93L1NsaWRlclRodW1iRWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTbGlkZXJUaHVtYjo6bGF5b3V0KToK KyAgICAgICAgVGhlIHRodW1iIHNob3VsZCBiZSBwb3NpdGlvbmVkIGJhc2VkIG9uICdyaWdodCcg Q1NTIHByb3BlcnR5IGluc3RlYWQgb2YgJ2xlZnQuJworICAgICAgICAoV2ViQ29yZTo6U2xpZGVy VGh1bWJFbGVtZW50OjpzZXRQb3NpdGlvbkZyb21Qb2ludCk6CisgICAgICAgIFRoZSBmcmFjdGlv biBzaG91bGQgYmUgZmxpcHBlZCBpbiBSVEwuCisKIDIwMTEtMDctMjAgIFJ5b3N1a2UgTml3YSAg PHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IGEgVmFsZ3JpbmQgZmFpbHVyZSBjYXVz ZWQgYnkgcjkxNDM1LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvU2xp ZGVyVGh1bWJFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1NsaWRlclRo dW1iRWxlbWVudC5jcHAKaW5kZXggYWYyMzBhY2Q0MWFmZDZmNjIyNTU1OTkzNTNhM2ZjNDk4ZGUy NjY2MS4uZDEyNmI4NWI1MmI3MzgyMzBhNmZkNTQ0ZjBmMmIzNDJkNzQzZTllMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvU2xpZGVyVGh1bWJFbGVtZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9TbGlkZXJUaHVtYkVsZW1lbnQuY3BwCkBAIC0x MTYsOCArMTE2LDEwIEBAIHZvaWQgUmVuZGVyU2xpZGVyVGh1bWI6OmxheW91dCgpCiAgICAgZG91 YmxlIGZyYWN0aW9uID0gc2xpZGVyUG9zaXRpb24oaW5wdXQpICogMTAwOwogICAgIGlmIChpc1Zl cnRpY2FsKQogICAgICAgICBzdHlsZSgpLT5zZXRUb3AoTGVuZ3RoKDEwMCAtIGZyYWN0aW9uLCBQ ZXJjZW50KSk7Ci0gICAgZWxzZQorICAgIGVsc2UgaWYgKHN0eWxlKCktPmlzTGVmdFRvUmlnaHRE aXJlY3Rpb24oKSkKICAgICAgICAgc3R5bGUoKS0+c2V0TGVmdChMZW5ndGgoZnJhY3Rpb24sIFBl cmNlbnQpKTsKKyAgICBlbHNlCisgICAgICAgIHN0eWxlKCktPnNldFJpZ2h0KExlbmd0aChmcmFj dGlvbiwgUGVyY2VudCkpOwogCiAgICAgUmVuZGVyQmxvY2s6OmxheW91dCgpOwogfQpAQCAtMjM4 LDcgKzI0MCw3IEBAIHZvaWQgU2xpZGVyVGh1bWJFbGVtZW50OjpzZXRQb3NpdGlvbkZyb21Qb2lu dChjb25zdCBJbnRQb2ludCYgcG9pbnQpCiAKICAgICBTdGVwUmFuZ2UgcmFuZ2UoaW5wdXQpOwog ICAgIGRvdWJsZSBmcmFjdGlvbiA9IHN0YXRpY19jYXN0PGRvdWJsZT4ocG9zaXRpb24pIC8gdHJh Y2tTaXplOwotICAgIGlmIChpc1ZlcnRpY2FsKQorICAgIGlmIChpc1ZlcnRpY2FsIHx8ICFyZW5k ZXJCb3goKS0+c3R5bGUoKS0+aXNMZWZ0VG9SaWdodERpcmVjdGlvbigpKQogICAgICAgICBmcmFj dGlvbiA9IDEgLSBmcmFjdGlvbjsKICAgICBkb3VibGUgdmFsdWUgPSByYW5nZS5jbGFtcFZhbHVl KHJhbmdlLnZhbHVlRnJvbVByb3BvcnRpb24oZnJhY3Rpb24pKTsKIAo= 101564 2011-07-21 02:31:31 -0700 2011-07-21 04:07:56 -0700 Patch for landing bug-64904-20110721183129.patch text/plain 4744 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogOTE0NDkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2NWIyMmM0MzIxYWRhNjFhNjMzYmE0 NTU4MmJjOTRlZjc4ZmIyYjY2Li5lNDNmMTBiMjJjZTFkZDU1YzgwYjA3OGY5N2VjZjgxNjA1MDRl NWM0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDctMjEgIEtlbnQgVGFtdXJhICA8dGtl bnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjg4NzU3KTogaW5wdXRbdHlw ZT1yYW5nZV0gcmVuZGVycyBpbmNvcnJlY3RseSBpbiBSVEwgY29udGV4dC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0OTA0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgorCisgICAgICAgICogZmFzdC9mb3Jtcy9pbnB1dC1hcHBl YXJhbmNlLXJhbmdlLXJ0bC1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zv cm1zL2lucHV0LWFwcGVhcmFuY2UtcmFuZ2UtcnRsLmh0bWw6IEFkZGVkLgorCiAyMDExLTA3LTIw ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBjcmFzaCBl eHBlY3RhdGlvbiB0byBmYXN0L2NhbnZhcy93ZWJnbC9yZW5kZXJidWZmZXItaW5pdGlhbGl6YXRp b24uaHRtbCBvbiBDaHJvbWl1bSBXaW5kb3dzLApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9pbnB1dC1hcHBlYXJhbmNlLXJhbmdlLXJ0bC1leHBlY3RlZC5odG1sIGIvTGF5b3V0 VGVzdHMvZmFzdC9mb3Jtcy9pbnB1dC1hcHBlYXJhbmNlLXJhbmdlLXJ0bC1leHBlY3RlZC5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjM4NTQ0NDJiM2QyYjI1ZTIyNDI5NjAwMmYwOTg3MDM0M2JjOTJkNjYKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lucHV0LWFwcGVhcmFuY2Ut cmFuZ2UtcnRsLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwxNCBAQAorPCFET0NUWVBFIGh0bWw+ Cis8aHRtbD4KKzxib2R5PgorPGRpdj48aW5wdXQgdHlwZT1yYW5nZSB2YWx1ZT0xMDA+PC9kaXY+ Cis8ZGl2PjxpbnB1dCB0eXBlPXJhbmdlIHZhbHVlPTUwPjwvZGl2PgorPGRpdj48aW5wdXQgdHlw ZT1yYW5nZSB2YWx1ZT0wPjwvZGl2PgorPGRpdj48aW5wdXQgdHlwZT1yYW5nZSB2YWx1ZT0wPjwv ZGl2PgorPGRpdj48aW5wdXQgdHlwZT1yYW5nZSB2YWx1ZT0wPjwvZGl2PgorPGRpdj48aW5wdXQg dHlwZT1yYW5nZSB2YWx1ZT0wPjwvZGl2PgorPGRpdj48aW5wdXQgdHlwZT1yYW5nZSB2YWx1ZT0w PjwvZGl2PgorPGRpdj48aW5wdXQgdHlwZT1yYW5nZSB2YWx1ZT0wPjwvZGl2PgorPGRpdj48aW5w dXQgdHlwZT1yYW5nZSBzdHlsZT0iLXdlYmtpdC1hcHBlYXJhbmNlOnNsaWRlci12ZXJ0aWNhbDsg aGVpZ2h0OjE0MHB4OyIgdmFsdWU9ODA+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lucHV0LWFwcGVhcmFuY2UtcmFuZ2UtcnRsLmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lucHV0LWFwcGVhcmFuY2UtcmFuZ2UtcnRsLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uNzFmMGYwMTRmN2QzMGRlNDE3YzgxOWI4NjhmNjU0MDMwY2I1MzQxNgot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQtYXBwZWFyYW5j ZS1yYW5nZS1ydGwuaHRtbApAQCAtMCwwICsxLDIwIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1s PgorPGJvZHk+Cis8ZGl2PjxpbnB1dCB0eXBlPXJhbmdlIHZhbHVlPTAgZGlyPXJ0bD48L2Rpdj4K KzxkaXY+PGlucHV0IHR5cGU9cmFuZ2UgdmFsdWU9NTAgZGlyPXJ0bD48L2Rpdj4KKzxkaXY+PGlu cHV0IHR5cGU9cmFuZ2UgdmFsdWU9MTAwIGRpcj1ydGw+PC9kaXY+Cis8ZGl2PjxpbnB1dCB0eXBl PXJhbmdlIHZhbHVlPTEwMCBzdHlsZT0iZGlyZWN0aW9uOnJ0bCI+PC9kaXY+Cis8ZGl2PjxpbnB1 dCB0eXBlPXJhbmdlIHZhbHVlPTEwMCBpZD1yMT48L2Rpdj4KKzxkaXY+PGlucHV0IHR5cGU9cmFu Z2UgdmFsdWU9MTAwIGlkPXIyPjwvZGl2PgorPGRpdj48aW5wdXQgdHlwZT1yYW5nZSB2YWx1ZT0w IGlkPXIzIGRpcj1ydGw+PC9kaXY+Cis8ZGl2PjxpbnB1dCB0eXBlPXJhbmdlIHZhbHVlPTAgaWQ9 cjQgc3R5bGU9ImRpcmVjdGlvbjpydGwiPjwvZGl2PgorPGRpdj48aW5wdXQgdHlwZT1yYW5nZSBz dHlsZT0iLXdlYmtpdC1hcHBlYXJhbmNlOnNsaWRlci12ZXJ0aWNhbDsgaGVpZ2h0OjE0MHB4OyIg dmFsdWU9ODAgZGlyPXJ0bD48L2Rpdj4KKzxzY3JpcHQ+Citkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgncjEnKS5kaXIgPSAncnRsJzsKK2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyMicpLnN0eWxl LmRpcmVjdGlvbiA9ICdydGwnOworZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3IzJykuZGlyID0g J2x0cic7Citkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncjQnKS5zdHlsZS5kaXJlY3Rpb24gPSAn bHRyJzsKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDcxYWUwZWU1 NTFjNDg4NmE1YWM0NjhkYjM4ODZmZDU2YjAwZDIxMmYuLmY5OGJkMzc5MjVkYWY4YTFiNjMzNjE4 NGFiMTU5MjgwNDIwMzlmMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMS0wNy0y MSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lP TihyODg3NTcpOiBpbnB1dFt0eXBlPXJhbmdlXSByZW5kZXJzIGluY29ycmVjdGx5IGluIFJUTCBj b250ZXh0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjQ5MDQKKworICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisKKyAgICAgICAgVGVz dHM6IGZhc3QvZm9ybXMvaW5wdXQtYXBwZWFyYW5jZS1yYW5nZS1ydGwuaHRtbAorCisgICAgICAg ICogaHRtbC9zaGFkb3cvU2xpZGVyVGh1bWJFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlclNsaWRlclRodW1iOjpsYXlvdXQpOgorICAgICAgICBUaGUgdGh1bWIgc2hvdWxkIGJl IHBvc2l0aW9uZWQgYmFzZWQgb24gJ3JpZ2h0JyBDU1MgcHJvcGVydHkgaW5zdGVhZCBvZiAnbGVm dC4nCisgICAgICAgIChXZWJDb3JlOjpTbGlkZXJUaHVtYkVsZW1lbnQ6OnNldFBvc2l0aW9uRnJv bVBvaW50KToKKyAgICAgICAgVGhlIGZyYWN0aW9uIHNob3VsZCBiZSBmbGlwcGVkIGluIFJUTC4K KwogMjAxMS0wNy0yMCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAg ICBGaXggYSBWYWxncmluZCBmYWlsdXJlIGNhdXNlZCBieSByOTE0MzUuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9TbGlkZXJUaHVtYkVsZW1lbnQuY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC9zaGFkb3cvU2xpZGVyVGh1bWJFbGVtZW50LmNwcAppbmRleCBhZjIzMGFj ZDQxYWZkNmY2MjI1NTU5OTM1M2EzZmM0OThkZTI2NjYxLi5kMTI2Yjg1YjUyYjczODIzMGE2ZmQ1 NDRmMGYyYjM0MmQ3NDNlOWUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRv dy9TbGlkZXJUaHVtYkVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93 L1NsaWRlclRodW1iRWxlbWVudC5jcHAKQEAgLTExNiw4ICsxMTYsMTAgQEAgdm9pZCBSZW5kZXJT bGlkZXJUaHVtYjo6bGF5b3V0KCkKICAgICBkb3VibGUgZnJhY3Rpb24gPSBzbGlkZXJQb3NpdGlv bihpbnB1dCkgKiAxMDA7CiAgICAgaWYgKGlzVmVydGljYWwpCiAgICAgICAgIHN0eWxlKCktPnNl dFRvcChMZW5ndGgoMTAwIC0gZnJhY3Rpb24sIFBlcmNlbnQpKTsKLSAgICBlbHNlCisgICAgZWxz ZSBpZiAoc3R5bGUoKS0+aXNMZWZ0VG9SaWdodERpcmVjdGlvbigpKQogICAgICAgICBzdHlsZSgp LT5zZXRMZWZ0KExlbmd0aChmcmFjdGlvbiwgUGVyY2VudCkpOworICAgIGVsc2UKKyAgICAgICAg c3R5bGUoKS0+c2V0UmlnaHQoTGVuZ3RoKGZyYWN0aW9uLCBQZXJjZW50KSk7CiAKICAgICBSZW5k ZXJCbG9jazo6bGF5b3V0KCk7CiB9CkBAIC0yMzgsNyArMjQwLDcgQEAgdm9pZCBTbGlkZXJUaHVt YkVsZW1lbnQ6OnNldFBvc2l0aW9uRnJvbVBvaW50KGNvbnN0IEludFBvaW50JiBwb2ludCkKIAog ICAgIFN0ZXBSYW5nZSByYW5nZShpbnB1dCk7CiAgICAgZG91YmxlIGZyYWN0aW9uID0gc3RhdGlj X2Nhc3Q8ZG91YmxlPihwb3NpdGlvbikgLyB0cmFja1NpemU7Ci0gICAgaWYgKGlzVmVydGljYWwp CisgICAgaWYgKGlzVmVydGljYWwgfHwgIXJlbmRlckJveCgpLT5zdHlsZSgpLT5pc0xlZnRUb1Jp Z2h0RGlyZWN0aW9uKCkpCiAgICAgICAgIGZyYWN0aW9uID0gMSAtIGZyYWN0aW9uOwogICAgIGRv dWJsZSB2YWx1ZSA9IHJhbmdlLmNsYW1wVmFsdWUocmFuZ2UudmFsdWVGcm9tUHJvcG9ydGlvbihm cmFjdGlvbikpOwogCg==