64899 2011-07-20 16:04:01 -0700 show a list of average test times in the treemap 2011-07-20 16:15:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan aroben oldest_to_newest 440088 0 ojan 2011-07-20 16:04:01 -0700 show a list of average test times in the treemap 440089 1 101523 ojan 2011-07-20 16:05:25 -0700 Created attachment 101523 Patch 440092 2 101523 aroben 2011-07-20 16:09:31 -0700 Comment on attachment 101523 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101523&action=review > Tools/TestResultServer/static-dashboards/treemap.html:206 > + if (avgA > avgB) > + return -1; > + else if (avgA == avgB) > + return 0; > + else > + return 1; It's simpler to say: return avgB - avgA; 440095 3 ojan 2011-07-20 16:13:57 -0700 (In reply to comment #2) > (From update of attachment 101523 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=101523&action=review > > > Tools/TestResultServer/static-dashboards/treemap.html:206 > > + if (avgA > avgB) > > + return -1; > > + else if (avgA == avgB) > > + return 0; > > + else > > + return 1; > > It's simpler to say: > > return avgB - avgA; Whoops. I had it in my head that this was an issue in some cases, but that's only when strings are involved. 440096 4 ojan 2011-07-20 16:15:35 -0700 Committed r91415: <http://trac.webkit.org/changeset/91415> 101523 2011-07-20 16:05:25 -0700 2011-07-20 16:09:31 -0700 Patch bug-64899-20110720160524.patch text/plain 5739 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogOTE0MTIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5NTk0NjI0ZjgyZWZiY2Y1ZGI5OTUyODg4MDYzOGQ0YWM5 NzYwYzNlLi41NmQyNzZjOTNlYWFiOTNmNTFhYmFiMGFlNzRjOGQ3MjQ1MjNjODZjIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIg QEAKIDIwMTEtMDctMjAgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAorICAgICAg ICBzaG93IGEgbGlzdCBvZiBhdmVyYWdlIHRlc3QgdGltZXMgaW4gdGhlIHRyZWVtYXAKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0ODk5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIG5vdywgeW91IGNs aWNrIGEgbGluayBhbmQgaXQgcmVwbGFjZXMgdGhlIHRyZWVtYXAKKyAgICAgICAgd2l0aCBhIHJl dmVyc2Ugc29ydGVkIGxpc3Qgb2YgZGlyZWN0b3JpZXMgYmFzZWQgb24KKyAgICAgICAgYXZlcmFn ZSB0ZXN0IHJ1bnRpbWUgd2l0aGluIHRoYXQgZGlyZWN0b3J5LgorCisgICAgICAgIFRvIGN1dCBz b21lIG9mIHRoZSBub2lzZSwgd2UgZG9uJ3Qgc2hvdyBkaXJlY3RvcmllcworICAgICAgICB0aGF0 IG9ubHkgaGF2ZSBvbmUgdGVzdCBpbiB0aGVtIG9yIHdoZXJlIHRoZSBhdmVyYWdlCisgICAgICAg IHJ1bnRpbWUgaXMgbGVzcyB0aGFuIDEwMG1zLgorCisgICAgICAgICogVGVzdFJlc3VsdFNlcnZl ci9zdGF0aWMtZGFzaGJvYXJkcy90cmVlbWFwLmh0bWw6CisKKzIwMTEtMDctMjAgIE9qYW4gVmFm YWkgIDxvamFuQGNocm9taXVtLm9yZz4KKwogICAgICAgICBtYWtlIHRoZSB0cmVlbWFwIGRpc3Bs YXkgbW9yZSBodW1hbiBmcmllbmRseQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjQ4OTYKIApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZl ci9zdGF0aWMtZGFzaGJvYXJkcy90cmVlbWFwLmh0bWwgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVy L3N0YXRpYy1kYXNoYm9hcmRzL3RyZWVtYXAuaHRtbAppbmRleCA3MmIxNmZkNDgxZTM2Nzk0Yzdk YzEwN2ExNWIyZThkYjM0NWZkYjNjLi5lZTM2YjJhNGE1NjlmN2Y2ZWIwM2NlNGM2NDUyZjE1ZjVm OTY0ZmZlIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9h cmRzL3RyZWVtYXAuaHRtbAorKysgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNo Ym9hcmRzL3RyZWVtYXAuaHRtbApAQCAtNDUsNiArNDUsMTQgQEAgYm9keSB7CiAgICAgbGVmdDog MDsKIH0KIAordGQ6Zmlyc3QtY2hpbGQgeworICAgIHRleHQtYWxpZ246IGxlZnQ7Cit9CisKK3Rk IHsKKyAgICB0ZXh0LWFsaWduOiByaWdodDsKK30KKwogI21hcCB7CiAgICAgZGlzcGxheTogLW1v ei1ib3g7CiAgICAgZGlzcGxheTogLXdlYmtpdC1ib3g7CkBAIC0xMDQsNyArMTEyLDcgQEAgYm9k eSB7CiA8c2NyaXB0IHNyYz0nd2VidHJlZW1hcC5qcyc+PC9zY3JpcHQ+CiAKIDxkaXYgaWQ9J2hl YWRlci1jb250YWluZXInPjwvZGl2PgotPHA+Q2xpY2sgb24gYSBib3ggdG8gem9vbSBpbi4gICAg Q2xpY2sgb24gdGhlIG91dGVybW9zdCBib3ggdG8gem9vbSBvdXQuPC9wPgorPHA+Q2xpY2sgb24g YSBib3ggdG8gem9vbSBpbi4gQ2xpY2sgb24gdGhlIG91dGVybW9zdCBib3ggdG8gem9vbSBvdXQu IDxhIGhyZWY9IiIgb25jbGljaz0ic2hvd0F2ZXJhZ2VzKCk7cmV0dXJuIGZhbHNlOyI+U2hvdyBh dmVyYWdlczwvYT48L3A+CiA8ZGl2IGlkPSdtYXAnPjwvZGl2PgogCiA8c2NyaXB0PgpAQCAtMTE1 LDkgKzEyMyw5IEBAIHZhciBURVNUX1VSTF9CQVNFX1BBVEggPSAiaHR0cDovL3N2bi53ZWJraXQu b3JnL3JlcG9zaXRvcnkvd2Via2l0L3RydW5rLyI7CiBmdW5jdGlvbiBodW1hblJlYWRhYmxlVGlt ZShtaWxsaXNlY29uZHMpCiB7CiAgICAgaWYgKG1pbGxpc2Vjb25kcyA8IDEwMDApCi0gICAgICAg IHJldHVybiBtaWxsaXNlY29uZHMgKyAnbXMnOworICAgICAgICByZXR1cm4gTWF0aC5mbG9vciht aWxsaXNlY29uZHMpICsgJ21zJzsKICAgICBlbHNlIGlmIChtaWxsaXNlY29uZHMgPCA2MDAwMCkK LSAgICAgICAgcmV0dXJuIE1hdGguZmxvb3IobWlsbGlzZWNvbmRzIC8gMTAwMCkudG9QcmVjaXNp b24oMikgKyAncyc7CisgICAgICAgIHJldHVybiAobWlsbGlzZWNvbmRzIC8gMTAwMCkudG9QcmVj aXNpb24oMikgKyAncyc7CiAKICAgICB2YXIgbWludXRlcyA9IE1hdGguZmxvb3IobWlsbGlzZWNv bmRzIC8gNjAwMDApOwogICAgIHZhciBzZWNvbmRzID0gTWF0aC5mbG9vcigobWlsbGlzZWNvbmRz IC0gbWludXRlcyAqIDYwMDAwKSAvIDEwMDApOwpAQCAtMTI5LDcgKzEzNyw3IEBAIGZ1bmN0aW9u IGh1bWFuUmVhZGFibGVUaW1lKG1pbGxpc2Vjb25kcykKIC8vICAgIm5hbWUiOiAobmFtZSBvZiB0 aGlzIG5vZGUpLAogLy8gICAiY2hpbGRyZW4iOiBbIChjaGlsZCBub2RlcywgaW4gdGhlIHNhbWUg Zm9ybWF0IGFzIHRoaXMpIF0gfQogLy8gY2hpbGRDb3VudCBpcyBhZGRlZCBqdXN0IHRvIGJlIGlu Y2x1ZGVzIGluIHRoZSBub2RlJ3MgbmFtZQotZnVuY3Rpb24gY29udmVydFRvV2ViVHJlZW1hcEZv cm1hdCh0cmVlbmFtZSwgdHJlZSkKK2Z1bmN0aW9uIGNvbnZlcnRUb1dlYlRyZWVtYXBGb3JtYXQo dHJlZW5hbWUsIHRyZWUsIHBhdGgpCiB7CiAgICAgdmFyIHRvdGFsID0gMDsKICAgICB2YXIgY2hp bGRDb3VudCA9IDA7CkBAIC0xNDYsNyArMTU0LDggQEAgZnVuY3Rpb24gY29udmVydFRvV2ViVHJl ZW1hcEZvcm1hdCh0cmVlbmFtZSwgdHJlZSkKICAgICAgICAgICAgIHRvdGFsICs9IHRpbWU7CiAg ICAgICAgICAgICBjaGlsZENvdW50Kys7CiAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICB2 YXIgc3VidHJlZSA9IGNvbnZlcnRUb1dlYlRyZWVtYXBGb3JtYXQobmFtZSwgdHJlZU5vZGUpOwor ICAgICAgICAgICAgdmFyIG5ld1BhdGggPSBwYXRoID8gcGF0aCArICcvJyArIG5hbWUgOiBuYW1l OworICAgICAgICAgICAgdmFyIHN1YnRyZWUgPSBjb252ZXJ0VG9XZWJUcmVlbWFwRm9ybWF0KG5h bWUsIHRyZWVOb2RlLCBuZXdQYXRoKTsKICAgICAgICAgICAgIGNoaWxkcmVuLnB1c2goc3VidHJl ZSk7CiAgICAgICAgICAgICB0b3RhbCArPSBzdWJ0cmVlWyJkYXRhIl1bIiRhcmVhIl07CiAgICAg ICAgICAgICBjaGlsZENvdW50ICs9IHN1YnRyZWVbImNoaWxkQ291bnQiXTsKQEAgLTE2MywxMCAr MTcyLDY1IEBAIGZ1bmN0aW9uIGNvbnZlcnRUb1dlYlRyZWVtYXBGb3JtYXQodHJlZW5hbWUsIHRy ZWUpCiAgICAgICAgICJkYXRhIjogeyIkYXJlYSI6IHRvdGFsfSwKICAgICAgICAgIm5hbWUiOiB0 cmVlbmFtZSArICIgKCIgKyBodW1hblJlYWRhYmxlVGltZSh0b3RhbCkgKyAiIC0gIiArIGNoaWxk Q291bnQgKyAiIHRlc3RzKSIsCiAgICAgICAgICJjaGlsZHJlbiI6IGNoaWxkcmVuLAotICAgICAg ICAiY2hpbGRDb3VudCI6IGNoaWxkQ291bnQKKyAgICAgICAgImNoaWxkQ291bnQiOiBjaGlsZENv dW50LAorICAgICAgICAicGF0aCI6IHBhdGgKICAgICB9OwogfQogCitmdW5jdGlvbiBsaXN0T2ZB bGxOb25MZWFmTm9kZXModHJlZSwgbGlzdCkKK3sKKyAgICBpZiAoIXRyZWUuY2hpbGRyZW4pCisg ICAgICAgIHJldHVybjsKKworICAgIGlmICghbGlzdCkKKyAgICAgICAgbGlzdCA9IFtdOworICAg IGxpc3QucHVzaCh0cmVlKTsKKworICAgIHRyZWUuY2hpbGRyZW4uZm9yRWFjaChmdW5jdGlvbihj aGlsZCkgeworICAgICAgICBsaXN0T2ZBbGxOb25MZWFmTm9kZXMoY2hpbGQsIGxpc3QpOworICAg IH0pOworICAgIHJldHVybiBsaXN0OworfQorCitmdW5jdGlvbiByZXZlcnNlU29ydEJ5QXZlcmFn ZShsaXN0KQoreworICAgIGxpc3Quc29ydChmdW5jdGlvbihhLCBiKSB7CisgICAgICAgIHZhciBh dmdBID0gYS5kYXRhWyckYXJlYSddIC8gYS5jaGlsZENvdW50OworICAgICAgICB2YXIgYXZnQiA9 IGIuZGF0YVsnJGFyZWEnXSAvIGIuY2hpbGRDb3VudDsKKworICAgICAgICBpZiAoYXZnQSA+IGF2 Z0IpCisgICAgICAgICAgICByZXR1cm4gLTE7CisgICAgICAgIGVsc2UgaWYgKGF2Z0EgPT0gYXZn QikKKyAgICAgICAgICAgIHJldHVybiAwOworICAgICAgICBlbHNlCisgICAgICAgICAgICByZXR1 cm4gMTsKKyAgICB9KTsKK30KKworZnVuY3Rpb24gc2hvd0F2ZXJhZ2VzKCkKK3sKKyAgICBpZiAo IWRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdtYXAnKSkKKyAgICAgICAgcmV0dXJuOworCisgICAg dmFyIHRhYmxlID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgndGFibGUnKTsKKyAgICB0YWJsZS5p bm5lckhUTUwgPSAnPHRoPmRpcmVjdG9yeTwvdGg+PHRoPiMgdGVzdHM8L3RoPjx0aD5hdmcgdGlt ZSAvIHRlc3Q8L3RoPic7CisKKyAgICB2YXIgYWxsTm9kZXMgPSBsaXN0T2ZBbGxOb25MZWFmTm9k ZXMoZ193ZWJUcmVlKTsKKyAgICByZXZlcnNlU29ydEJ5QXZlcmFnZShhbGxOb2Rlcyk7CisgICAg YWxsTm9kZXMuZm9yRWFjaChmdW5jdGlvbihub2RlKSB7CisgICAgICAgIHZhciBhdmVyYWdlID0g bm9kZS5kYXRhWyckYXJlYSddIC8gbm9kZS5jaGlsZENvdW50OworICAgICAgICBpZiAoYXZlcmFn ZSA+IDEwMCAmJiBub2RlLmNoaWxkQ291bnQgIT0gMSkgeworICAgICAgICAgICAgdmFyIHRyID0g ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgndHInKTsKKyAgICAgICAgICAgIHRyLmlubmVySFRNTCA9 ICc8dGQ+PC90ZD48dGQ+JyArIG5vZGUuY2hpbGRDb3VudCArICc8L3RkPjx0ZD4nICsgaHVtYW5S ZWFkYWJsZVRpbWUoYXZlcmFnZSkgKyAnPC90ZD4nOworICAgICAgICAgICAgdHIucXVlcnlTZWxl Y3RvcigndGQnKS5pbm5lclRleHQgPSBub2RlLnBhdGg7CisgICAgICAgICAgICB0YWJsZS5hcHBl bmRDaGlsZCh0cik7CisgICAgICAgIH0KKyAgICB9KTsKKworICAgIHZhciBtYXAgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgnbWFwJyk7CisgICAgbWFwLnBhcmVudE5vZGUucmVwbGFjZUNoaWxk KHRhYmxlLCBtYXApOworfQorCiB2YXIgZ19yZXN1bHRzQnlCdWlsZGVyID0ge307CiAKIGZ1bmN0 aW9uIEFERF9SRVNVTFRTKGRhdGEpCkBAIC0xODAsNiArMjQ0LDcgQEAgZnVuY3Rpb24gQUREX1JF U1VMVFMoZGF0YSkKIH0KIAogdmFyIGdfaXNHZW5lcmF0aW5nUGFnZSA9IGZhbHNlOwordmFyIGdf d2ViVHJlZTsKIAogZnVuY3Rpb24gZ2VuZXJhdGVQYWdlKCkKIHsKQEAgLTE5MSw4ICsyNTYsOCBA QCBmdW5jdGlvbiBnZW5lcmF0ZVBhZ2UoKQogICAgIGdfaXNHZW5lcmF0aW5nUGFnZSA9IHRydWU7 CiAKICAgICB2YXIgcmF3VHJlZSA9IGdfcmVzdWx0c0J5QnVpbGRlcltnX2N1cnJlbnRTdGF0ZS5i dWlsZGVyXTsKLSAgICB2YXIgd2VidHJlZSA9IGNvbnZlcnRUb1dlYlRyZWVtYXBGb3JtYXQoJ0xh eW91dFRlc3RzJywgcmF3VHJlZSk7Ci0gICAgYXBwZW5kVHJlZW1hcCgkKCdtYXAnKSwgd2VidHJl ZSk7CisgICAgZ193ZWJUcmVlID0gY29udmVydFRvV2ViVHJlZW1hcEZvcm1hdCgnTGF5b3V0VGVz dHMnLCByYXdUcmVlKTsKKyAgICBhcHBlbmRUcmVlbWFwKCQoJ21hcCcpLCBnX3dlYlRyZWUpOwog CiAgICAgaWYgKGdfY3VycmVudFN0YXRlLnRyZWVtYXBmb2N1cykKICAgICAgICAgZm9jdXNQYXRo KHdlYnRyZWUsIGdfY3VycmVudFN0YXRlLnRyZWVtYXBmb2N1cykK