64873 2011-07-20 08:12:50 -0700 [skia] disable lcd text when drawing on a transparent layer or canvas 2011-07-20 09:43:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reed reed jamesr kbr senorblanco webkit.review.bot oldest_to_newest 439815 0 reed 2011-07-20 08:12:50 -0700 [skia] disable lcd text when drawing on a transparent layer or canvas 439817 1 101473 reed 2011-07-20 08:16:59 -0700 Created attachment 101473 Patch 439837 2 101473 senorblanco 2011-07-20 09:26:44 -0700 Comment on attachment 101473 Patch Looks good. 439844 3 101473 webkit.review.bot 2011-07-20 09:43:03 -0700 Comment on attachment 101473 Patch Clearing flags on attachment: 101473 Committed r91375: <http://trac.webkit.org/changeset/91375> 439845 4 webkit.review.bot 2011-07-20 09:43:07 -0700 All reviewed patches have been landed. Closing bug. 101473 2011-07-20 08:16:59 -0700 2011-07-20 09:43:03 -0700 Patch bug-64873-20110720111657.patch text/plain 3396 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxMzY0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDctMjAgIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBbc2tpYV0gZGlzYWJsZSBsY2QgdGV4dCB3 aGVuIGRyYXdpbmcgb24gYSB0cmFuc3BhcmVudCBsYXllciBvciBjYW52YXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0ODczCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBjYW52YXMg c2l0ZXMgaWxsdXN0cmF0ZSB0aGUgYnVnLiBEUlQgZGlzYWJsZXMgTENECisgICAgICAgIHNvIGV4 aXN0aW5nIGxheW91dHRlc3RzIGFyZSBub3QgYWZmZWN0ZWQgYnkgdGhpcyBjaGFuZ2UuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL1NraWFGb250V2luLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OmlzQ2FudmFzTXVsdGlMYXllcmVkKToKKyAgICAgICAgKFdlYkNvcmU6OmRpc2Fi bGVUZXh0TENEKToKKyAgICAgICAgKFdlYkNvcmU6OnNldHVwUGFpbnRGb3JGb250KToKKyAgICAg ICAgKFdlYkNvcmU6OnBhaW50U2tpYVRleHQpOgorCiAyMDExLTA3LTIwICBUb21teSBXaWRlbmZs eWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAgICAgICAgIE1lZGlhU3RyZWFtIEFQSTogVXBk YXRlIHRoZSB0cmFja2xpc3RzIHRvIHRoZSBsYXRlc3Qgc3BlYwpJbmRleDogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Ta2lhRm9udFdpbi5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Ta2lhRm9udFdpbi5jcHAJKHJl dmlzaW9uIDkxMzU4KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9T a2lhRm9udFdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExOCw3ICsxMTgsMjUgQEAgc3RhdGlj IHZvaWQgc2tpYURyYXdUZXh0KFNrQ2FudmFzKiBjYW52YQogICAgIGNhbnZhcy0+ZHJhd1Bvc1Rl eHQoZ2x5cGhzLCBudW1HbHlwaHMgKiBzaXplb2YodWludDE2X3QpLCBwb3MsICpwYWludCk7CiB9 CiAKLXN0YXRpYyB2b2lkIHNldHVwUGFpbnRGb3JGb250KEhGT05UIGhmb250LCBTa1BhaW50KiBw YWludCkKK3N0YXRpYyBib29sIGlzQ2FudmFzTXVsdGlMYXllcmVkKFNrQ2FudmFzKiBjYW52YXMp Cit7CisgICAgU2tDYW52YXM6OkxheWVySXRlciBsYXllckl0ZXJhdG9yKGNhbnZhcywgZmFsc2Up OworICAgIGxheWVySXRlcmF0b3IubmV4dCgpOworICAgIHJldHVybiAhbGF5ZXJJdGVyYXRvci5k b25lKCk7Cit9CisKKy8vIGxpZnRlZCBmcm9tIEZvbnRTa2lhLmNwcAorc3RhdGljIGJvb2wgZGlz YWJsZVRleHRMQ0QoUGxhdGZvcm1Db250ZXh0U2tpYSogc2tpYUNvbnRleHQpCit7CisgICAgLy8g T3VyIGxheWVycyBvbmx5IGhhdmUgYSBzaW5nbGUgYWxwaGEgY2hhbm5lbC4gVGhpcyBtZWFucyB0 aGF0IHN1YnBpeGVsCisgICAgLy8gcmVuZGVyZWQgdGV4dCBjYW5ub3QgYmUgY29tcG9zaXRpZWQg Y29ycmVjdGx5IHdoZW4gdGhlIGxheWVyIGlzCisgICAgLy8gY29sbGFwc2VkLiBUaGVyZWZvcmUs IHN1YnBpeGVsIHRleHQgaXMgZGlzYWJsZWQgd2hlbiB3ZSBhcmUgZHJhd2luZworICAgIC8vIG9u dG8gYSBsYXllciBvciB3aGVuIHRoZSBjb21wb3NpdG9yIGlzIGJlaW5nIHVzZWQuCisgICAgcmV0 dXJuIGlzQ2FudmFzTXVsdGlMYXllcmVkKHNraWFDb250ZXh0LT5jYW52YXMoKSkKKyAgICAgICAg ICAgfHwgc2tpYUNvbnRleHQtPmlzRHJhd2luZ1RvSW1hZ2VCdWZmZXIoKTsKK30KKworc3RhdGlj IHZvaWQgc2V0dXBQYWludEZvckZvbnQoSEZPTlQgaGZvbnQsIFNrUGFpbnQqIHBhaW50LCBQbGF0 Zm9ybUNvbnRleHRTa2lhKiBwY3MpCiB7CiAgICAgLy8gIEZJWE1FOgogICAgIC8vICBNdWNoIG9m IHRoaXMgbG9naWMgY291bGQgYWxzbyBoYXBwZW4gaW4KQEAgLTEzOSw3ICsxNTcsMTEgQEAgc3Rh dGljIHZvaWQgc2V0dXBQYWludEZvckZvbnQoSEZPTlQgaGZvbgogICAgIHVpbnQzMl90IGZsYWdz ID0gcGFpbnQtPmdldEZsYWdzKCk7CiAgICAgLy8gb3VyIGRlZmF1bHRzCiAgICAgZmxhZ3MgfD0g U2tQYWludDo6a0FudGlBbGlhc19GbGFnOwotICAgIGZsYWdzIHw9IFNrUGFpbnQ6OmtMQ0RSZW5k ZXJUZXh0X0ZsYWc7CisgICAgaWYgKGRpc2FibGVUZXh0TENEKHBjcykpCisgICAgICAgIGZsYWdz ICY9IH5Ta1BhaW50OjprTENEUmVuZGVyVGV4dF9GbGFnOworICAgIGVsc2UKKyAgICAgICAgZmxh Z3MgfD0gU2tQYWludDo6a0xDRFJlbmRlclRleHRfRmxhZzsKKwogICAgIHN3aXRjaCAoaW5mby5s ZlF1YWxpdHkpIHsKICAgICBjYXNlIE5PTkFOVElBTElBU0VEX1FVQUxJVFk6CiAgICAgICAgIGZs YWdzICY9IH5Ta1BhaW50OjprQW50aUFsaWFzX0ZsYWc7CkBAIC0xNzMsNyArMTk1LDcgQEAgdm9p ZCBwYWludFNraWFUZXh0KEdyYXBoaWNzQ29udGV4dCogY29udAogICAgIFNrUGFpbnQgcGFpbnQ7 CiAgICAgcGxhdGZvcm1Db250ZXh0LT5zZXR1cFBhaW50Rm9yRmlsbGluZygmcGFpbnQpOwogICAg IHBhaW50LnNldFRleHRFbmNvZGluZyhTa1BhaW50OjprR2x5cGhJRF9UZXh0RW5jb2RpbmcpOwot ICAgIHNldHVwUGFpbnRGb3JGb250KGhmb250LCAmcGFpbnQpOworICAgIHNldHVwUGFpbnRGb3JG b250KGhmb250LCAmcGFpbnQsIHBsYXRmb3JtQ29udGV4dCk7CiAKICAgICBib29sIGRpZEZpbGwg PSBmYWxzZTsKIApAQCAtMTkwLDcgKzIxMiw3IEBAIHZvaWQgcGFpbnRTa2lhVGV4dChHcmFwaGlj c0NvbnRleHQqIGNvbnQKICAgICAgICAgcGFpbnQucmVzZXQoKTsKICAgICAgICAgcGxhdGZvcm1D b250ZXh0LT5zZXR1cFBhaW50Rm9yU3Ryb2tpbmcoJnBhaW50LCAwLCAwKTsKICAgICAgICAgcGFp bnQuc2V0VGV4dEVuY29kaW5nKFNrUGFpbnQ6OmtHbHlwaElEX1RleHRFbmNvZGluZyk7Ci0gICAg ICAgIHNldHVwUGFpbnRGb3JGb250KGhmb250LCAmcGFpbnQpOworICAgICAgICBzZXR1cFBhaW50 Rm9yRm9udChoZm9udCwgJnBhaW50LCBwbGF0Zm9ybUNvbnRleHQpOwogCiAgICAgICAgIGlmIChk aWRGaWxsKSB7CiAgICAgICAgICAgICAvLyBJZiB0aGVyZSBpcyBhIHNoYWRvdyBhbmQgd2UgZmls bGVkIGFib3ZlLCB0aGVyZSB3aWxsIGFscmVhZHkgYmUK