64871 2011-07-20 07:54:51 -0700 gtk shouldn't have global variables for timers. 2011-07-20 11:11:24 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 64577 1 levin levin mrobinson xan.lopez oldest_to_newest 439805 0 levin 2011-07-20 07:54:51 -0700 Globals slow down start time and more importantly to me cause currentThread() to be called before WTF::initializeThreading() has been called. 439809 1 101470 levin 2011-07-20 07:59:12 -0700 Created attachment 101470 Patch 439839 2 101470 mrobinson 2011-07-20 09:30:01 -0700 Comment on attachment 101470 Patch I'm afraid these are both my fault. Thanks for fixing them! 439882 3 levin 2011-07-20 11:11:24 -0700 No worries. (It wasn't a big problem until my next patch in bug 64577 :).) Committed as http://trac.webkit.org/changeset/91378 101470 2011-07-20 07:59:12 -0700 2011-07-20 09:30:01 -0700 Patch bug-64871-20110720075911.patch text/plain 2841 levin U3VidmVyc2lvbiBSZXZpc2lvbjogOTEzNjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjYTY4MDYxZWY0OTc4ZDAx OTI5NDUzN2IzNTgyMDc0ZTE2MGQ3NTI1Li4zZWU1NWRjM2QwNWNlNWNjODg4YTkwNWVkYjdlMmMw MDRkMmQ0MTFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDctMjAgIERhdmlk IExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIGd0ayBzaG91bGRuJ3QgaGF2 ZSBnbG9iYWwgdmFyaWFibGVzIGZvciB0aW1lcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDg3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyBmdW5jdGlvbmFsaXR5IGV4cG9zZWQgc28gbm8g bmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vQ29udGV4dFNo YWRvd0NhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNjaGVkdWxlU2NyYXRjaEJ1ZmZlclB1 cmdlKTogQ2hhbmdlZCBnbG9iYWwgdmFyaWFibGUgdG8gREVGSU5FX1NUQVRJQ19MT0NBTC4KKyAg ICAgICAgKiBwbGF0Zm9ybS9ndGsvV2lkZ2V0UmVuZGVyaW5nQ29udGV4dC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpzY2hlZHVsZVNjcmF0Y2hCdWZmZXJQdXJnZSk6IERpdHRvLgorCiAyMDExLTA3 LTIwICBTdGV2ZSBCbG9jayAgPHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbVjhd IEphdmFNZXRob2RKb2JqZWN0OjpzaWduYXR1cmUoKSBpbmNvcnJlY3RseSBlbmNvZGVzIGFyZ3Vt ZW50cyBvZiB0eXBlIEphdmFUeXBlU3RyaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Db250ZXh0U2hhZG93Q2Fpcm8uY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vQ29udGV4dFNoYWRvd0NhaXJvLmNwcAppbmRl eCA2NWM3OTI0OGFiM2Y0ZjRmMjQ3MGVmZDRmMTQ2ZTAzZDRkMDZiNTdkLi5iMmY5NTE2MTk3ODRh ZmEwYzc2ZjRjNWVjMjEzZjY4ODMwNWM0OTA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Db250ZXh0U2hhZG93Q2Fpcm8uY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0NvbnRleHRTaGFkb3dDYWlyby5jcHAK QEAgLTM3LDYgKzM3LDcgQEAKICNpbmNsdWRlICJQbGF0Zm9ybUNvbnRleHRDYWlyby5oIgogI2lu Y2x1ZGUgIlRpbWVyLmgiCiAjaW5jbHVkZSA8Y2Fpcm8uaD4KKyNpbmNsdWRlIDx3dGYvU3RkTGli RXh0cmFzLmg+CiAKIHVzaW5nIFdURjo6bWF4OwogCkBAIC01NSw5ICs1NiwxMCBAQCBjbGFzcyBQ dXJnZVNjcmF0Y2hCdWZmZXJUaW1lciA6IHB1YmxpYyBUaW1lckJhc2UgewogcHJpdmF0ZToKICAg ICB2aXJ0dWFsIHZvaWQgZmlyZWQoKSB7IHB1cmdlU2NyYXRjaEJ1ZmZlcigpOyB9CiB9Owotc3Rh dGljIFB1cmdlU2NyYXRjaEJ1ZmZlclRpbWVyIHB1cmdlU2NyYXRjaEJ1ZmZlclRpbWVyOworCiBz dGF0aWMgdm9pZCBzY2hlZHVsZVNjcmF0Y2hCdWZmZXJQdXJnZSgpCiB7CisgICAgREVGSU5FX1NU QVRJQ19MT0NBTChQdXJnZVNjcmF0Y2hCdWZmZXJUaW1lciwgcHVyZ2VTY3JhdGNoQnVmZmVyVGlt ZXIsICgpKTsKICAgICBpZiAocHVyZ2VTY3JhdGNoQnVmZmVyVGltZXIuaXNBY3RpdmUoKSkKICAg ICAgICAgcHVyZ2VTY3JhdGNoQnVmZmVyVGltZXIuc3RvcCgpOwogICAgIHB1cmdlU2NyYXRjaEJ1 ZmZlclRpbWVyLnN0YXJ0T25lU2hvdCgyKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9XaWRnZXRSZW5kZXJpbmdDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9XaWRnZXRSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRleCBmNDNkYzVmNDU2NGMx NTVlYzVkNDAyOWQzMzFhZjU1MTExNWU3YzYxLi4yZjMyMjJlMmUzMWNjZGVkNWVhYjhmOGQ0YmE0 ZmRmMjlmYjM5NTAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvV2lk Z2V0UmVuZGVyaW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Rr L1dpZGdldFJlbmRlcmluZ0NvbnRleHQuY3BwCkBAIC0zOSw2ICszOSw3IEBACiAjaW5jbHVkZSAi VGltZXIuaCIKICNpbmNsdWRlIDxnZGsvZ2RrLmg+CiAjaW5jbHVkZSA8Z3RrL2d0ay5oPgorI2lu Y2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC01 OCw5ICs1OSwxMCBAQCBjbGFzcyBQdXJnZVNjcmF0Y2hCdWZmZXJUaW1lciA6IHB1YmxpYyBUaW1l ckJhc2UgewogcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgZmlyZWQoKSB7IHB1cmdlU2NyYXRj aEJ1ZmZlcigpOyB9CiB9Owotc3RhdGljIFB1cmdlU2NyYXRjaEJ1ZmZlclRpbWVyIHB1cmdlU2Ny YXRjaEJ1ZmZlclRpbWVyOworCiBzdGF0aWMgdm9pZCBzY2hlZHVsZVNjcmF0Y2hCdWZmZXJQdXJn ZSgpCiB7CisgICAgREVGSU5FX1NUQVRJQ19MT0NBTChQdXJnZVNjcmF0Y2hCdWZmZXJUaW1lciwg cHVyZ2VTY3JhdGNoQnVmZmVyVGltZXIsICgpKTsKICAgICBpZiAocHVyZ2VTY3JhdGNoQnVmZmVy VGltZXIuaXNBY3RpdmUoKSkKICAgICAgICAgcHVyZ2VTY3JhdGNoQnVmZmVyVGltZXIuc3RvcCgp OwogICAgIHB1cmdlU2NyYXRjaEJ1ZmZlclRpbWVyLnN0YXJ0T25lU2hvdCgyKTsK