64867 2011-07-20 06:22:06 -0700 [GTK] REGRESSION(r86436): does not add newlines when return is pressed with some modifiers held 2011-07-20 10:59:18 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 gustavo gustavo mrobinson webkit.review.bot xan.lopez oldest_to_newest 439765 0 gustavo 2011-07-20 06:22:06 -0700 My laptop (a lenovo x200s) seems to have numlock in an always-on state; I noticed that after that revision (I bisected), enter no longer generates new lines on any textareas. It is caused apparently by the fact that numlock is on. You can reproduce it in normal keyboards by turning capslock on. 439783 1 101464 gustavo 2011-07-20 06:48:47 -0700 Created attachment 101464 Patch 439784 2 101464 gustavo 2011-07-20 06:49:55 -0700 Comment on attachment 101464 Patch How about this? Makes it simpler and should work regardless of what modifiers are on =P 439842 3 101464 mrobinson 2011-07-20 09:38:34 -0700 Comment on attachment 101464 Patch Nice! We may need to backport this to the stable branch. 439850 4 101464 webkit.review.bot 2011-07-20 09:52:26 -0700 Comment on attachment 101464 Patch Clearing flags on attachment: 101464 Committed r91376: <http://trac.webkit.org/changeset/91376> 439852 5 webkit.review.bot 2011-07-20 09:52:31 -0700 All reviewed patches have been landed. Closing bug. 439866 6 gustavo 2011-07-20 10:15:20 -0700 (In reply to comment #3) > (From update of attachment 101464 [details]) > Nice! We may need to backport this to the stable branch. The stable branch didn't have the patch that caused the regression on it, which means it's key bindings code is very, very different to what we have now in trunk, plus it doesn't have the regression, so I'd recommend against this =) 439876 7 mrobinson 2011-07-20 10:59:18 -0700 (In reply to comment #6) > (In reply to comment #3) > > (From update of attachment 101464 [details] [details]) > > Nice! We may need to backport this to the stable branch. > > The stable branch didn't have the patch that caused the regression on it, which means it's key bindings code is very, very different to what we have now in trunk, plus it doesn't have the regression, so I'd recommend against this =) Even better! 101464 2011-07-20 06:48:47 -0700 2011-07-20 09:52:26 -0700 Patch bug-64867-20110720104845.patch text/plain 4013 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogOTEyNTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyMjZmMGQ3YjliNzkxMWJm M2VkOGE5NmVlMGY5N2Q1ODMwMmIzMDc5Li5mYWY0NmU4ZDA2MDIxZjE4OWZjYjgxMzAwZGNhNTkw MzNhNDI2MGU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMjAgIEd1c3Rh dm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CisKKyAg ICAgICAgW0dUS10gUkVHUkVTU0lPTihyODY0MzYpOiBkb2VzIG5vdCBhZGQgbmV3bGluZXMgd2hl biByZXR1cm4gaXMgcHJlc3NlZCB3aXRoIHNvbWUgbW9kaWZpZXJzIGhlbGQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0ODY3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvS2V5Qmlu ZGluZ1RyYW5zbGF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6S2V5QmluZGluZ1RyYW5zbGF0 b3I6OmdldEVkaXRvckNvbW1hbmRzRm9yS2V5RXZlbnQpOgorICAgICAgICBzcGVjaWFsLWNhc2Ug ZW50ZXIga2V5cyBzbyB0aGF0IHRoZWlyIGNvbW1hbmRzIGFyZSByZXR1cm5lZAorICAgICAgICB3 aGF0ZXZlciB0aGUgbW9kaWZpZXJzIHN0YXRlLgorCiAyMDExLTA3LTE5ICBJbHlhIFRpa2hvbm92 c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBpbXBs ZW1lbnQgaW1wb3J0L2V4cG9ydCBmb3IgdGltZWxpbmUgZGF0YS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9LZXlCaW5kaW5nVHJhbnNsYXRvci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvS2V5QmluZGluZ1RyYW5zbGF0b3IuY3BwCmluZGV4IDg5MDMx YzA5MGZmMGZjNTYyYzQ3M2NmNDVmM2Y5NDdlM2Q1NTkyODAuLjViZDBmYjhjZThjMGMxOGJlYmE4 YmE2MjVjZDcwMGQxMzcwNmJiMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9LZXlCaW5kaW5nVHJhbnNsYXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL0tleUJpbmRpbmdUcmFuc2xhdG9yLmNwcApAQCAtMTc5LDEwICsxNzksNiBAQCBLZXlC aW5kaW5nVHJhbnNsYXRvcjo6S2V5QmluZGluZ1RyYW5zbGF0b3IoKQogICAgIGdfc2lnbmFsX2Nv bm5lY3QobV9uYXRpdmVXaWRnZXQuZ2V0KCksICJzaG93LWhlbHAiLCBHX0NBTExCQUNLKHNob3dI ZWxwQ2FsbGJhY2spLCB0aGlzKTsKIH0KIAotc3RhdGljIGNvbnN0IHVuc2lnbmVkIEN0cmxLZXkg PSAxIDw8IDA7Ci1zdGF0aWMgY29uc3QgdW5zaWduZWQgQWx0S2V5ID0gMSA8PCAxOwotc3RhdGlj IGNvbnN0IHVuc2lnbmVkIFNoaWZ0S2V5ID0gMSA8PCAyOwotCiBzdHJ1Y3QgS2V5Q29tYmluYXRp b25FbnRyeSB7CiAgICAgdW5zaWduZWQgZ2RrS2V5Q29kZTsKICAgICB1bnNpZ25lZCBzdGF0ZTsK QEAgLTIwMSwyMCArMTk3LDYgQEAgc3RhdGljIGNvbnN0IEtleUNvbWJpbmF0aW9uRW50cnkga2V5 RG93bkVudHJpZXNbXSA9IHsKIHN0YXRpYyBjb25zdCBLZXlDb21iaW5hdGlvbkVudHJ5IGtleVBy ZXNzRW50cmllc1tdID0gewogICAgIHsgR0RLX1RhYiwgICAgICAgMCwgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAiSW5zZXJ0VGFiIiAgICAgfSwKICAgICB7IEdES19UYWIsICAgICAgIEdE S19TSElGVF9NQVNLLCAgICAgICAgICAgICAgICAgIkluc2VydEJhY2t0YWIiIH0sCi0gICAgeyBH REtfVGFiLCAgICAgICAwLCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJJbnNlcnRUYWIi ICAgICB9LAotICAgIHsgR0RLX1RhYiwgICAgICAgR0RLX1NISUZUX01BU0ssICAgICAgICAgICAg ICAgICAiSW5zZXJ0QmFja3RhYiIgfSwKLSAgICB7IEdES19SZXR1cm4sICAgIDAsICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIkluc2VydE5ld2xpbmUiIH0sCi0gICAgeyBHREtfUmV0dXJu LCAgICBHREtfQ09OVFJPTF9NQVNLLCAgICAgICAgICAgICAgICJJbnNlcnROZXdsaW5lIiB9LAot ICAgIHsgR0RLX1JldHVybiwgICAgR0RLX01PRDFfTUFTSywgICAgICAgICAgICAgICAgICAiSW5z ZXJ0TmV3bGluZSIgfSwKLSAgICB7IEdES19SZXR1cm4sICAgIEdES19NT0QxX01BU0sgfCBHREtf U0hJRlRfTUFTSywgIkluc2VydE5ld2xpbmUiIH0sCi0gICAgeyBHREtfS1BfRW50ZXIsICAwLCAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICJJbnNlcnROZXdsaW5lIiB9LAotICAgIHsgR0RL X0tQX0VudGVyLCAgR0RLX0NPTlRST0xfTUFTSywgICAgICAgICAgICAgICAiSW5zZXJ0TmV3bGlu ZSIgfSwKLSAgICB7IEdES19LUF9FbnRlciwgIEdES19NT0QxX01BU0ssICAgICAgICAgICAgICAg ICAgIkluc2VydE5ld2xpbmUiIH0sCi0gICAgeyBHREtfS1BfRW50ZXIsICBHREtfTU9EMV9NQVNL IHwgR0RLX1NISUZUX01BU0ssICJJbnNlcnROZXdsaW5lIiB9LAotICAgIHsgR0RLX0lTT19FbnRl ciwgMCwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiSW5zZXJ0TmV3bGluZSIgfSwKLSAg ICB7IEdES19JU09fRW50ZXIsIEdES19DT05UUk9MX01BU0ssICAgICAgICAgICAgICAgIkluc2Vy dE5ld2xpbmUiIH0sCi0gICAgeyBHREtfSVNPX0VudGVyLCBHREtfTU9EMV9NQVNLLCAgICAgICAg ICAgICAgICAgICJJbnNlcnROZXdsaW5lIiB9LAotICAgIHsgR0RLX0lTT19FbnRlciwgR0RLX01P RDFfTUFTSyB8IEdES19TSElGVF9NQVNLLCAiSW5zZXJ0TmV3bGluZSIgfSwKIH07CiAKIHZvaWQg S2V5QmluZGluZ1RyYW5zbGF0b3I6OmdldEVkaXRvckNvbW1hbmRzRm9yS2V5RXZlbnQoR2RrRXZl bnRLZXkqIGV2ZW50LCBFdmVudFR5cGUgdHlwZSwgVmVjdG9yPFdURjo6U3RyaW5nPiYgY29tbWFu ZExpc3QpCkBAIC0yNDMsMTIgKzIyNSwxOCBAQCB2b2lkIEtleUJpbmRpbmdUcmFuc2xhdG9yOjpn ZXRFZGl0b3JDb21tYW5kc0ZvcktleUV2ZW50KEdka0V2ZW50S2V5KiBldmVudCwgRXZlbgogICAg ICAgICAgICAga2V5UHJlc3NDb21tYW5kc01hcC5zZXQoa2V5UHJlc3NFbnRyaWVzW2ldLnN0YXRl IDw8IDE2IHwga2V5UHJlc3NFbnRyaWVzW2ldLmdka0tleUNvZGUsIGtleVByZXNzRW50cmllc1tp XS5uYW1lKTsKICAgICB9CiAKKyAgICAvLyBTcGVjaWFsLWNhc2UgZW50ZXIga2V5cyBmb3Igd2Ug d2FudCB0aGVtIHRvIHdvcmsgcmVnYXJkbGVzcyBvZiBtb2RpZmllci4KKyAgICBpZiAoKGV2ZW50 LT5rZXl2YWwgPT0gR0RLX1JldHVybiB8fCBldmVudC0+a2V5dmFsID09IEdES19LUF9FbnRlciB8 fCBldmVudC0+a2V5dmFsID09IEdES19JU09fRW50ZXIpICYmIHR5cGUgPT0gS2V5UHJlc3MpIHsK KyAgICAgICAgY29tbWFuZExpc3QuYXBwZW5kKCJJbnNlcnROZXdMaW5lIik7CisgICAgICAgIHJl dHVybjsKKyAgICB9CisKICAgICAvLyBGb3Iga2V5cHJlc3MgZXZlbnRzLCB3ZSB3YW50IGNoYXJD b2RlKCksIGJ1dCBrZXlDb2RlKCkgZG9lcyB0aGF0LgogICAgIGludCBtYXBLZXkgPSBldmVudC0+ c3RhdGUgPDwgMTYgfCBldmVudC0+a2V5dmFsOwogICAgIGlmIChtYXBLZXkpIHsKICAgICAgICAg SGFzaE1hcDxpbnQsIGNvbnN0IGNoYXIqPiogY29tbWFuZE1hcCA9IHR5cGUgPT0gS2V5RG93biA/ ICAma2V5RG93bkNvbW1hbmRzTWFwIDogJmtleVByZXNzQ29tbWFuZHNNYXA7CiAgICAgICAgIGlm IChjb25zdCBjaGFyKiBjb21tYW5kU3RyaW5nID0gY29tbWFuZE1hcC0+Z2V0KG1hcEtleSkpIHsK LSAgICAgICAgICAgIGNvbW1hbmRMaXN0LmFwcGVuZChjb21tYW5kU3RyaW5nKTsgIAorICAgICAg ICAgICAgY29tbWFuZExpc3QuYXBwZW5kKGNvbW1hbmRTdHJpbmcpOwogICAgICAgICAgICAgcmV0 dXJuOwogICAgICAgICB9CiAgICAgfQo=