64852 2011-07-20 01:12:10 -0700 [Chromium] Turn on new WebSocket protocol in worker shadow page 2011-07-23 07:55:12 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 50099 1 yutak yutak abarth dimich tkent webkit.review.bot oldest_to_newest 439679 0 yutak 2011-07-20 01:12:10 -0700 I'm trying to turn on the new WebSocket protocol by default. This should be done in the following steps: (1) Change the default preference value in webkit/glue/webpreferences.{h,cc} (in Chromium tree). (2) Change the default preference value in worker shadow page initialized in WebWorkerBase::initializeLoader() (in WebKit tree). This bug takes care of step (2). Step (2) is required to enable the new protocol in WebSocket objects initialized in worker context, because they live in worker loader context and look at the value of a Settings flag of the shadow page. 439756 1 yutak 2011-07-20 05:45:33 -0700 A patch for step (1) is under review at <http://codereview.chromium.org/7462009/>. 439757 2 101454 yutak 2011-07-20 05:48:09 -0700 Created attachment 101454 Patch 439758 3 101454 yutak 2011-07-20 05:48:54 -0700 Comment on attachment 101454 Patch Setting CQ- since this patch should be committed after <http://codereview.chromium.org/7462009/>. 439759 4 yutak 2011-07-20 05:54:07 -0700 Dmitry, could you take a look at this patch? I think it's better to copy the value of Settings::useHixie76WebSocketProtocol() of the main thread (rather than setting a constant "false"), but I could not figure out a good way to do this. 440850 5 tkent 2011-07-21 23:00:46 -0700 (In reply to comment #4) > Dmitry, could you take a look at this patch? > > I think it's better to copy the value of Settings::useHixie76WebSocketProtocol() of the main thread (rather than setting a constant "false"), but I could not figure out a good way to do this. Though I don't know how to retrieve the value from the main thread, I think we need a FIXME comment. 440923 6 101723 yutak 2011-07-22 06:06:59 -0700 Created attachment 101723 Patch v2 (add FIXME comment) 441180 7 101723 dimich 2011-07-22 14:36:03 -0700 Comment on attachment 101723 Patch v2 (add FIXME comment) View in context: https://bugs.webkit.org/attachment.cgi?id=101723&action=review r=me with a note. > Source/WebKit/chromium/src/WebWorkerBase.cpp:242 > + // FIXME: Should copy the value of Settings::hixie76ProtocolEnabled() of a view in the main thread. This code is running in the main WebKit thread, but it runs in a sandboxed Worker process. Settings information should be passed to the Worker process from Browser process when the worker is created (similar to RenderThread::OnCreateNewView). Could you please change the comment to reflect this? 441375 8 101809 yutak 2011-07-23 06:40:53 -0700 Created attachment 101809 Patch for landing 441376 9 101723 yutak 2011-07-23 06:42:56 -0700 Comment on attachment 101723 Patch v2 (add FIXME comment) View in context: https://bugs.webkit.org/attachment.cgi?id=101723&action=review Thank you for your review! >> Source/WebKit/chromium/src/WebWorkerBase.cpp:242 >> + // FIXME: Should copy the value of Settings::hixie76ProtocolEnabled() of a view in the main thread. > > This code is running in the main WebKit thread, but it runs in a sandboxed Worker process. Settings information should be passed to the Worker process from Browser process when the worker is created (similar to RenderThread::OnCreateNewView). Could you please change the comment to reflect this? Updated the comment as per your suggestion. 441383 10 101809 webkit.review.bot 2011-07-23 07:55:07 -0700 Comment on attachment 101809 Patch for landing Clearing flags on attachment: 101809 Committed r91634: <http://trac.webkit.org/changeset/91634> 441384 11 webkit.review.bot 2011-07-23 07:55:12 -0700 All reviewed patches have been landed. Closing bug. 101454 2011-07-20 05:48:09 -0700 2011-07-22 06:06:53 -0700 Patch bug-64852-20110720214807.patch text/plain 1607 yutak U3VidmVyc2lvbiBSZXZpc2lvbjogOTEzMTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MWQ1ODgwN2FiMGViZDgwOTExM2E4NmExNTllZGMzMDNkOTBmNWE3Yy4uMTViYzZmYmE0NWVlNzEy NjI4YzU0ZGI0NDA0MDgzNjQwZjM0MmZhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wNy0yMCAgWXV0YSBLaXRhbXVyYSAgPHl1dGFrQGNocm9taXVt Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIFR1cm4gb24gbmV3IFdlYlNvY2tldCBwcm90b2Nv bCBpbiB3b3JrZXIgc2hhZG93IHBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY0ODUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBzcmMvV2ViV29ya2VyQmFzZS5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYldvcmtlckJhc2U6OmluaXRpYWxpemVMb2FkZXIpOgorICAgICAgICBJbml0aWFsaXplIHRo ZSB2YWx1ZSBvZiBXZWJDb3JlOjpTZXR0aW5nczo6dXNlSGl4aWU3NldlYlNvY2tldFByb3RvY29s KCkKKyAgICAgICAgZm9yIGEgbmV3IHNoYWRvdyBwYWdlLgorCiAyMDExLTA3LTE5ICBEb21pbmlj IE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgogCiAgICAgICAgIEFkZHMgc29tZSBtZXRo b2RzIHRvIHJldHJpZXZlIGFjY2Vzc2libGUgaW5mb3JtYXRpb24gZnJvbSB0YWJsZXMgYW5kCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJXb3JrZXJCYXNlLmNwcCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYldvcmtlckJhc2UuY3BwCmluZGV4IDM1ZjU0 ODA2MzAzNTVmNmJlODMxZTJkNjc2YmNiZDI3MmQyN2Q0ZWIuLmU3M2VhNjdhODkzYWJjNWNkM2Ez MjU3MjMzZDhlMjY1ZjY4N2U1YzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYldvcmtlckJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YldvcmtlckJhc2UuY3BwCkBAIC0yMzksNiArMjM5LDcgQEAgdm9pZCBXZWJXb3JrZXJCYXNlOjpp bml0aWFsaXplTG9hZGVyKGNvbnN0IFdlYlVSTCYgdXJsKQogICAgIEFTU0VSVCghbV93ZWJWaWV3 KTsKICAgICBtX3dlYlZpZXcgPSBXZWJWaWV3OjpjcmVhdGUoMCk7CiAgICAgbV93ZWJWaWV3LT5z ZXR0aW5ncygpLT5zZXRPZmZsaW5lV2ViQXBwbGljYXRpb25DYWNoZUVuYWJsZWQoV2ViUnVudGlt ZUZlYXR1cmVzOjppc0FwcGxpY2F0aW9uQ2FjaGVFbmFibGVkKCkpOworICAgIG1fd2ViVmlldy0+ c2V0dGluZ3MoKS0+c2V0SGl4aWU3NldlYlNvY2tldFByb3RvY29sRW5hYmxlZChmYWxzZSk7CiAg ICAgbV93ZWJWaWV3LT5pbml0aWFsaXplTWFpbkZyYW1lKHRoaXMpOwogCiAgICAgV2ViRnJhbWVJ bXBsKiB3ZWJGcmFtZSA9IHN0YXRpY19jYXN0PFdlYkZyYW1lSW1wbCo+KG1fd2ViVmlldy0+bWFp bkZyYW1lKCkpOwo= 101723 2011-07-22 06:06:59 -0700 2011-07-23 06:42:56 -0700 Patch v2 (add FIXME comment) bug-64852-20110722220657.patch text/plain 1889 yutak U3VidmVyc2lvbiBSZXZpc2lvbjogOTE1NjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg OWJhZThlMzRkOWJhZWIxYjA5MGEyOTNmNGYyODA0MjZjM2ViZTJlYS4uOGI5MmYwMDg1MDIwMzZi MDgwNTkwOWE4ZDkzZmZiMzdkMjViMmExZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNyBAQAorMjAxMS0wNy0yMiAgWXV0YSBLaXRhbXVyYSAgPHl1dGFrQGNocm9taXVt Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIFR1cm4gb24gbmV3IFdlYlNvY2tldCBwcm90b2Nv bCBpbiB3b3JrZXIgc2hhZG93IHBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY0ODUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBzcmMvV2ViV29ya2VyQmFzZS5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYldvcmtlckJhc2U6OmluaXRpYWxpemVMb2FkZXIpOgorICAgICAgICBJbml0aWFsaXplIHRo ZSB2YWx1ZSBvZiBXZWJDb3JlOjpTZXR0aW5nczo6dXNlSGl4aWU3NldlYlNvY2tldFByb3RvY29s KCkKKyAgICAgICAgZm9yIGEgbmV3IHNoYWRvdyBwYWdlLiBUaGUgZGVmYXVsdCB2YWx1ZSBvZiB0 aGlzIGZsYWcgaXMgb3ZlcnJpZGRlbiB0aHJvdWdoCisgICAgICAgIFdlYlByZWZlcmVuY2VzIChs b2NhdGVkIGluIHdlYmtpdC9nbHVlIGluIENocm9taXVtIHNvdXJjZSB0cmVlKSBidXQgYSBzaGFk b3cKKyAgICAgICAgcGFnZSBkb2VzIG5vdCByZWNlaXZlIHRoZSBwcmVmZXJlbmNlIHZhbHVlcyBm cm9tIGl0LgorCiAyMDExLTA3LTIyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmVydCByOTE1MTAgZHVlIHRvIENocm9taXVtIGRlYnVnIHRlc3QgZmFpbHVy ZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJXb3JrZXJCYXNl LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYldvcmtlckJhc2UuY3BwCmluZGV4 IDM1ZjU0ODA2MzAzNTVmNmJlODMxZTJkNjc2YmNiZDI3MmQyN2Q0ZWIuLjRiNDA5MWE2ZTAwMTBj YjdkMzZiZTZlZTE1ZTExYmRlZWI3MTg3MGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYldvcmtlckJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYldvcmtlckJhc2UuY3BwCkBAIC0yMzksNiArMjM5LDggQEAgdm9pZCBXZWJXb3JrZXJC YXNlOjppbml0aWFsaXplTG9hZGVyKGNvbnN0IFdlYlVSTCYgdXJsKQogICAgIEFTU0VSVCghbV93 ZWJWaWV3KTsKICAgICBtX3dlYlZpZXcgPSBXZWJWaWV3OjpjcmVhdGUoMCk7CiAgICAgbV93ZWJW aWV3LT5zZXR0aW5ncygpLT5zZXRPZmZsaW5lV2ViQXBwbGljYXRpb25DYWNoZUVuYWJsZWQoV2Vi UnVudGltZUZlYXR1cmVzOjppc0FwcGxpY2F0aW9uQ2FjaGVFbmFibGVkKCkpOworICAgIC8vIEZJ WE1FOiBTaG91bGQgY29weSB0aGUgdmFsdWUgb2YgU2V0dGluZ3M6OmhpeGllNzZQcm90b2NvbEVu YWJsZWQoKSBvZiBhIHZpZXcgaW4gdGhlIG1haW4gdGhyZWFkLgorICAgIG1fd2ViVmlldy0+c2V0 dGluZ3MoKS0+c2V0SGl4aWU3NldlYlNvY2tldFByb3RvY29sRW5hYmxlZChmYWxzZSk7CiAgICAg bV93ZWJWaWV3LT5pbml0aWFsaXplTWFpbkZyYW1lKHRoaXMpOwogCiAgICAgV2ViRnJhbWVJbXBs KiB3ZWJGcmFtZSA9IHN0YXRpY19jYXN0PFdlYkZyYW1lSW1wbCo+KG1fd2ViVmlldy0+bWFpbkZy YW1lKCkpOwo= 101809 2011-07-23 06:40:53 -0700 2011-07-23 07:55:07 -0700 Patch for landing bug-64852-20110723224052.patch text/plain 2005 yutak U3VidmVyc2lvbiBSZXZpc2lvbjogOTE2MzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NmJiYzhlMzM1OWJjODBhYzM2NzdhNDQ2OTE3Y2Q3NjRhNjYwYjA3Yy4uMDY2MjVlMWZlZjU0MTQ0 Nzc1YTQ3NTk4MTM1N2ZiZjBlNjAzZGJmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNyBAQAorMjAxMS0wNy0yMyAgWXV0YSBLaXRhbXVyYSAgPHl1dGFrQGNocm9taXVt Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIFR1cm4gb24gbmV3IFdlYlNvY2tldCBwcm90b2Nv bCBpbiB3b3JrZXIgc2hhZG93IHBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY0ODUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRG1pdHJ5IFRpdG92 LgorCisgICAgICAgICogc3JjL1dlYldvcmtlckJhc2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJXb3JrZXJCYXNlOjppbml0aWFsaXplTG9hZGVyKToKKyAgICAgICAgSW5pdGlhbGl6ZSB0aGUg dmFsdWUgb2YgV2ViQ29yZTo6U2V0dGluZ3M6OnVzZUhpeGllNzZXZWJTb2NrZXRQcm90b2NvbCgp CisgICAgICAgIGZvciBhIG5ldyBzaGFkb3cgcGFnZS4gVGhlIGRlZmF1bHQgdmFsdWUgb2YgdGhp cyBmbGFnIGlzIG92ZXJyaWRkZW4gdGhyb3VnaAorICAgICAgICBXZWJQcmVmZXJlbmNlcyAobG9j YXRlZCBpbiB3ZWJraXQvZ2x1ZSBpbiBDaHJvbWl1bSBzb3VyY2UgdHJlZSkgYnV0IGEgc2hhZG93 CisgICAgICAgIHBhZ2UgZG9lcyBub3QgcmVjZWl2ZSB0aGUgcHJlZmVyZW5jZSB2YWx1ZXMgZnJv bSBpdC4KKwogMjAxMS0wNy0yMiAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtjaHJvbWl1bV0gUmVtb3ZlIGNvZGUgdGhhdCBhdHRlbXB0ZWQgdG8gZXhw bGljaXRseSBzeW5jIGNvbXBvc2l0aW5nIHN0YXRlIGJlZm9yZSBjb21wb3NpdGluZwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViV29ya2VyQmFzZS5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJXb3JrZXJCYXNlLmNwcAppbmRleCAzNWY1NDgwNjMw MzU1ZjZiZTgzMWUyZDY3NmJjYmQyNzJkMjdkNGViLi5kNjE4NjcyZGE4NWQxNmU0N2U5M2QwNTVj NjlmNjFjYTFkNDZmMjUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJXb3JrZXJCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJXb3Jr ZXJCYXNlLmNwcApAQCAtMjM5LDYgKzIzOSw5IEBAIHZvaWQgV2ViV29ya2VyQmFzZTo6aW5pdGlh bGl6ZUxvYWRlcihjb25zdCBXZWJVUkwmIHVybCkKICAgICBBU1NFUlQoIW1fd2ViVmlldyk7CiAg ICAgbV93ZWJWaWV3ID0gV2ViVmlldzo6Y3JlYXRlKDApOwogICAgIG1fd2ViVmlldy0+c2V0dGlu Z3MoKS0+c2V0T2ZmbGluZVdlYkFwcGxpY2F0aW9uQ2FjaGVFbmFibGVkKFdlYlJ1bnRpbWVGZWF0 dXJlczo6aXNBcHBsaWNhdGlvbkNhY2hlRW5hYmxlZCgpKTsKKyAgICAvLyBGSVhNRTogU2V0dGlu Z3MgaW5mb3JtYXRpb24gc2hvdWxkIGJlIHBhc3NlZCB0byB0aGUgV29ya2VyIHByb2Nlc3MgZnJv bSBCcm93c2VyIHByb2Nlc3Mgd2hlbiB0aGUgd29ya2VyCisgICAgLy8gaXMgY3JlYXRlZCAoc2lt aWxhciB0byBSZW5kZXJUaHJlYWQ6Ok9uQ3JlYXRlTmV3VmlldykuCisgICAgbV93ZWJWaWV3LT5z ZXR0aW5ncygpLT5zZXRIaXhpZTc2V2ViU29ja2V0UHJvdG9jb2xFbmFibGVkKGZhbHNlKTsKICAg ICBtX3dlYlZpZXctPmluaXRpYWxpemVNYWluRnJhbWUodGhpcyk7CiAKICAgICBXZWJGcmFtZUlt cGwqIHdlYkZyYW1lID0gc3RhdGljX2Nhc3Q8V2ViRnJhbWVJbXBsKj4obV93ZWJWaWV3LT5tYWlu RnJhbWUoKSk7Cg==