64846 2011-07-19 21:07:34 -0700 Implement CSSPropertyCounterIncrement and CounterReset in CSSStyleApplyProperty. 2011-07-19 22:41:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson dglazkov macpherson webkit.review.bot oldest_to_newest 439613 0 macpherson 2011-07-19 21:07:34 -0700 Implement CSSPropertyCounterIncrement and CounterReset in CSSStyleApplyProperty. 439614 1 101424 macpherson 2011-07-19 21:09:20 -0700 Created attachment 101424 Patch 439627 2 101424 webkit.review.bot 2011-07-19 22:41:30 -0700 Comment on attachment 101424 Patch Clearing flags on attachment: 101424 Committed r91336: <http://trac.webkit.org/changeset/91336> 439628 3 webkit.review.bot 2011-07-19 22:41:34 -0700 All reviewed patches have been landed. Closing bug. 101424 2011-07-19 21:09:20 -0700 2011-07-19 22:41:30 -0700 Patch bug-64846-20110720140917.patch text/plain 7252 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxMzMxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDctMTkgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbXBsZW1lbnQg Q1NTUHJvcGVydHlDb3VudGVySW5jcmVtZW50IGFuZCBDb3VudGVyUmVzZXQgaW4gQ1NTU3R5bGVB cHBseVByb3BlcnR5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjQ4NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBuZXcgdGVzdHMgLyByZWZhY3RvcmluZyBvbmx5LgorCisgICAgICAgICogY3NzL0NT U1N0eWxlQXBwbHlQcm9wZXJ0eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBcHBseVByb3BlcnR5 Q291bnRlcgorICAgICAgICBBZGRlZCBjbGFzcyB0byBoYW5kbGUgY291bnRlciBwcm9wZXJ0aWVz LgorICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVBcHBseVByb3BlcnR5OjpDU1NTdHlsZUFwcGx5 UHJvcGVydHkpOgorICAgICAgICBJbml0aWFsaXplIGNvdW50ZXIgcHJvcGVydHkgaGFuZGxlcnMu CisgICAgICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eSk6CisgICAgICAgIFJlbW92ZSBvbGQgaGFu ZGxlcnMuCisKIDIwMTEtMDctMTkgIExlbyBZYW5nICA8bGVveWFuZy53ZWJraXRAZ21haWwuY29t PgogCiAgICAgICAgIFNWRzogTWlzc2luZyBpbXBsZW1lbnRhdGlvbiBvZiA8YWx0R2x5cGhEZWY+ LCA8YWx0R2x5cGhJdGVtPiBhbmQgPGdseXBoUmVmPgpJbmRleDogU291cmNlL1dlYkNvcmUvY3Nz L0NTU1N0eWxlQXBwbHlQcm9wZXJ0eS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv Y3NzL0NTU1N0eWxlQXBwbHlQcm9wZXJ0eS5jcHAJKHJldmlzaW9uIDkxMzI2KQorKysgU291cmNl L1dlYkNvcmUvY3NzL0NTU1N0eWxlQXBwbHlQcm9wZXJ0eS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTUwNiw2ICs1MDYsNjAgQEAgcHVibGljOgogICAgIH0KIH07CiAKK2VudW0gQ291bnRlckJlaGF2 aW9yIHtJbmNyZW1lbnQgPSAwLCBSZXNldH07Cit0ZW1wbGF0ZSA8Q291bnRlckJlaGF2aW9yIGNv dW50ZXJCZWhhdmlvcj4KK2NsYXNzIEFwcGx5UHJvcGVydHlDb3VudGVyIDogcHVibGljIEFwcGx5 UHJvcGVydHlCYXNlIHsKK3ByaXZhdGU6CisgICAgdmlydHVhbCB2b2lkIGFwcGx5SW5oZXJpdFZh bHVlKENTU1N0eWxlU2VsZWN0b3IqKSBjb25zdCB7IH0KKyAgICB2aXJ0dWFsIHZvaWQgYXBwbHlJ bml0aWFsVmFsdWUoQ1NTU3R5bGVTZWxlY3RvciopIGNvbnN0IHsgfQorCisgICAgdmlydHVhbCB2 b2lkIGFwcGx5VmFsdWUoQ1NTU3R5bGVTZWxlY3Rvciogc2VsZWN0b3IsIENTU1ZhbHVlKiB2YWx1 ZSkgY29uc3QKKyAgICB7CisgICAgICAgIGlmICghdmFsdWUtPmlzVmFsdWVMaXN0KCkpCisgICAg ICAgICAgICByZXR1cm47CisKKyAgICAgICAgQ1NTVmFsdWVMaXN0KiBsaXN0ID0gc3RhdGljX2Nh c3Q8Q1NTVmFsdWVMaXN0Kj4odmFsdWUpOworCisgICAgICAgIENvdW50ZXJEaXJlY3RpdmVNYXAm IG1hcCA9IHNlbGVjdG9yLT5zdHlsZSgpLT5hY2Nlc3NDb3VudGVyRGlyZWN0aXZlcygpOworICAg ICAgICB0eXBlZGVmIENvdW50ZXJEaXJlY3RpdmVNYXA6Oml0ZXJhdG9yIEl0ZXJhdG9yOworCisg ICAgICAgIEl0ZXJhdG9yIGVuZCA9IG1hcC5lbmQoKTsKKyAgICAgICAgZm9yIChJdGVyYXRvciBp dCA9IG1hcC5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpCisgICAgICAgICAgICBpZiAoY291bnRl ckJlaGF2aW9yKQorICAgICAgICAgICAgICAgIGl0LT5zZWNvbmQubV9yZXNldCA9IGZhbHNlOwor ICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIGl0LT5zZWNvbmQubV9pbmNyZW1lbnQg PSBmYWxzZTsKKworICAgICAgICBpbnQgbGVuZ3RoID0gbGlzdCA/IGxpc3QtPmxlbmd0aCgpIDog MDsKKyAgICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBsZW5ndGg7ICsraSkgeworICAgICAgICAg ICAgQ1NTVmFsdWUqIGN1cnJWYWx1ZSA9IGxpc3QtPml0ZW1XaXRob3V0Qm91bmRzQ2hlY2soaSk7 CisgICAgICAgICAgICBpZiAoIWN1cnJWYWx1ZS0+aXNQcmltaXRpdmVWYWx1ZSgpKQorICAgICAg ICAgICAgICAgIGNvbnRpbnVlOworCisgICAgICAgICAgICBQYWlyKiBwYWlyID0gc3RhdGljX2Nh c3Q8Q1NTUHJpbWl0aXZlVmFsdWUqPihjdXJyVmFsdWUpLT5nZXRQYWlyVmFsdWUoKTsKKyAgICAg ICAgICAgIGlmICghcGFpciB8fCAhcGFpci0+Zmlyc3QoKSB8fCAhcGFpci0+c2Vjb25kKCkpCisg ICAgICAgICAgICAgICAgY29udGludWU7CisKKyAgICAgICAgICAgIEF0b21pY1N0cmluZyBpZGVu dGlmaWVyID0gc3RhdGljX2Nhc3Q8Q1NTUHJpbWl0aXZlVmFsdWUqPihwYWlyLT5maXJzdCgpKS0+ Z2V0U3RyaW5nVmFsdWUoKTsKKyAgICAgICAgICAgIC8vIEZJWE1FOiBXaGF0IGFib3V0IG92ZXJm bG93PworICAgICAgICAgICAgaW50IHZhbHVlID0gc3RhdGljX2Nhc3Q8Q1NTUHJpbWl0aXZlVmFs dWUqPihwYWlyLT5zZWNvbmQoKSktPmdldEludFZhbHVlKCk7CisgICAgICAgICAgICBDb3VudGVy RGlyZWN0aXZlcyYgZGlyZWN0aXZlcyA9IG1hcC5hZGQoaWRlbnRpZmllci5pbXBsKCksIENvdW50 ZXJEaXJlY3RpdmVzKCkpLmZpcnN0LT5zZWNvbmQ7CisgICAgICAgICAgICBpZiAoY291bnRlckJl aGF2aW9yKSB7CisgICAgICAgICAgICAgICAgZGlyZWN0aXZlcy5tX3Jlc2V0ID0gdHJ1ZTsKKyAg ICAgICAgICAgICAgICBkaXJlY3RpdmVzLm1fcmVzZXRWYWx1ZSA9IHZhbHVlOworICAgICAgICAg ICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICBpZiAoZGlyZWN0aXZlcy5tX2luY3JlbWVudCkK KyAgICAgICAgICAgICAgICAgICAgZGlyZWN0aXZlcy5tX2luY3JlbWVudFZhbHVlICs9IHZhbHVl OworICAgICAgICAgICAgICAgIGVsc2UgeworICAgICAgICAgICAgICAgICAgICBkaXJlY3RpdmVz Lm1faW5jcmVtZW50ID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICAgICAgZGlyZWN0aXZlcy5tX2lu Y3JlbWVudFZhbHVlID0gdmFsdWU7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQor ICAgICAgICB9CisgICAgfQorfTsKKworCiBjbGFzcyBBcHBseVByb3BlcnR5Q3Vyc29yIDogcHVi bGljIEFwcGx5UHJvcGVydHlCYXNlIHsKIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIGFwcGx5 SW5oZXJpdFZhbHVlKENTU1N0eWxlU2VsZWN0b3IqIHNlbGVjdG9yKSBjb25zdApAQCAtNjY4LDYg KzcyMiw5IEBAIENTU1N0eWxlQXBwbHlQcm9wZXJ0eTo6Q1NTU3R5bGVBcHBseVByb3AKIAogICAg IHNldFByb3BlcnR5SGFuZGxlcihDU1NQcm9wZXJ0eUN1cnNvciwgbmV3IEFwcGx5UHJvcGVydHlD dXJzb3IoKSk7CiAKKyAgICBzZXRQcm9wZXJ0eUhhbmRsZXIoQ1NTUHJvcGVydHlDb3VudGVySW5j cmVtZW50LCBuZXcgQXBwbHlQcm9wZXJ0eUNvdW50ZXI8SW5jcmVtZW50PigpKTsKKyAgICBzZXRQ cm9wZXJ0eUhhbmRsZXIoQ1NTUHJvcGVydHlDb3VudGVyUmVzZXQsIG5ldyBBcHBseVByb3BlcnR5 Q291bnRlcjxSZXNldD4oKSk7CisKICAgICBzZXRQcm9wZXJ0eUhhbmRsZXIoQ1NTUHJvcGVydHlG b250U3R5bGUsIG5ldyBBcHBseVByb3BlcnR5Rm9udDxGb250SXRhbGljPigmRm9udERlc2NyaXB0 aW9uOjppdGFsaWMsICZGb250RGVzY3JpcHRpb246OnNldEl0YWxpYywgRm9udEl0YWxpY09mZikp OwogICAgIHNldFByb3BlcnR5SGFuZGxlcihDU1NQcm9wZXJ0eUZvbnRWYXJpYW50LCBuZXcgQXBw bHlQcm9wZXJ0eUZvbnQ8Rm9udFNtYWxsQ2Fwcz4oJkZvbnREZXNjcmlwdGlvbjo6c21hbGxDYXBz LCAmRm9udERlc2NyaXB0aW9uOjpzZXRTbWFsbENhcHMsIEZvbnRTbWFsbENhcHNPZmYpKTsKICAg ICBzZXRQcm9wZXJ0eUhhbmRsZXIoQ1NTUHJvcGVydHlUZXh0UmVuZGVyaW5nLCBuZXcgQXBwbHlQ cm9wZXJ0eUZvbnQ8VGV4dFJlbmRlcmluZ01vZGU+KCZGb250RGVzY3JpcHRpb246OnRleHRSZW5k ZXJpbmdNb2RlLCAmRm9udERlc2NyaXB0aW9uOjpzZXRUZXh0UmVuZGVyaW5nTW9kZSwgQXV0b1Rl eHRSZW5kZXJpbmcpKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9y LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5j cHAJKHJldmlzaW9uIDkxMzI2KQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0 b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTYyLDQ2ICszNTYyLDYgQEAgU3RyaW5nIENTU1N0 eWxlU2VsZWN0b3I6OnBhZ2VOYW1lKGludCAvKgogICAgIHJldHVybiAiIjsKIH0KIAotc3RhdGlj IHZvaWQgYXBwbHlDb3VudGVyTGlzdChSZW5kZXJTdHlsZSogc3R5bGUsIENTU1ZhbHVlTGlzdCog bGlzdCwgYm9vbCBpc1Jlc2V0KQotewotICAgIENvdW50ZXJEaXJlY3RpdmVNYXAmIG1hcCA9IHN0 eWxlLT5hY2Nlc3NDb3VudGVyRGlyZWN0aXZlcygpOwotICAgIHR5cGVkZWYgQ291bnRlckRpcmVj dGl2ZU1hcDo6aXRlcmF0b3IgSXRlcmF0b3I7Ci0KLSAgICBJdGVyYXRvciBlbmQgPSBtYXAuZW5k KCk7Ci0gICAgZm9yIChJdGVyYXRvciBpdCA9IG1hcC5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQp Ci0gICAgICAgIGlmIChpc1Jlc2V0KQotICAgICAgICAgICAgaXQtPnNlY29uZC5tX3Jlc2V0ID0g ZmFsc2U7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIGl0LT5zZWNvbmQubV9pbmNyZW1lbnQg PSBmYWxzZTsKLQotICAgIGludCBsZW5ndGggPSBsaXN0ID8gbGlzdC0+bGVuZ3RoKCkgOiAwOwot ICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbGVuZ3RoOyArK2kpIHsKLSAgICAgICAgQ1NTVmFsdWUq IGN1cnJWYWx1ZSA9IGxpc3QtPml0ZW1XaXRob3V0Qm91bmRzQ2hlY2soaSk7Ci0gICAgICAgIGlm ICghY3VyclZhbHVlLT5pc1ByaW1pdGl2ZVZhbHVlKCkpCi0gICAgICAgICAgICBjb250aW51ZTsK LQotICAgICAgICBQYWlyKiBwYWlyID0gc3RhdGljX2Nhc3Q8Q1NTUHJpbWl0aXZlVmFsdWUqPihj dXJyVmFsdWUpLT5nZXRQYWlyVmFsdWUoKTsKLSAgICAgICAgaWYgKCFwYWlyIHx8ICFwYWlyLT5m aXJzdCgpIHx8ICFwYWlyLT5zZWNvbmQoKSkKLSAgICAgICAgICAgIGNvbnRpbnVlOwotCi0gICAg ICAgIEF0b21pY1N0cmluZyBpZGVudGlmaWVyID0gc3RhdGljX2Nhc3Q8Q1NTUHJpbWl0aXZlVmFs dWUqPihwYWlyLT5maXJzdCgpKS0+Z2V0U3RyaW5nVmFsdWUoKTsKLSAgICAgICAgLy8gRklYTUU6 IFdoYXQgYWJvdXQgb3ZlcmZsb3c/Ci0gICAgICAgIGludCB2YWx1ZSA9IHN0YXRpY19jYXN0PENT U1ByaW1pdGl2ZVZhbHVlKj4ocGFpci0+c2Vjb25kKCkpLT5nZXRJbnRWYWx1ZSgpOwotICAgICAg ICBDb3VudGVyRGlyZWN0aXZlcyYgZGlyZWN0aXZlcyA9IG1hcC5hZGQoaWRlbnRpZmllci5pbXBs KCksIENvdW50ZXJEaXJlY3RpdmVzKCkpLmZpcnN0LT5zZWNvbmQ7Ci0gICAgICAgIGlmIChpc1Jl c2V0KSB7Ci0gICAgICAgICAgICBkaXJlY3RpdmVzLm1fcmVzZXQgPSB0cnVlOwotICAgICAgICAg ICAgZGlyZWN0aXZlcy5tX3Jlc2V0VmFsdWUgPSB2YWx1ZTsKLSAgICAgICAgfSBlbHNlIHsKLSAg ICAgICAgICAgIGlmIChkaXJlY3RpdmVzLm1faW5jcmVtZW50KQotICAgICAgICAgICAgICAgIGRp cmVjdGl2ZXMubV9pbmNyZW1lbnRWYWx1ZSArPSB2YWx1ZTsKLSAgICAgICAgICAgIGVsc2Ugewot ICAgICAgICAgICAgICAgIGRpcmVjdGl2ZXMubV9pbmNyZW1lbnQgPSB0cnVlOwotICAgICAgICAg ICAgICAgIGRpcmVjdGl2ZXMubV9pbmNyZW1lbnRWYWx1ZSA9IHZhbHVlOwotICAgICAgICAgICAg fQotICAgICAgICB9Ci0gICAgfQotfQotCiB2b2lkIENTU1N0eWxlU2VsZWN0b3I6OmFwcGx5UHJv cGVydHlUb1N0eWxlKGludCBpZCwgQ1NTVmFsdWUgKnZhbHVlLCBSZW5kZXJTdHlsZSogc3R5bGUp CiB7CiAgICAgaW5pdEVsZW1lbnQoMCk7CkBAIC00MTg3LDE0ICs0MTQ3LDYgQEAgdm9pZCBDU1NT dHlsZVNlbGVjdG9yOjphcHBseVByb3BlcnR5KGludAogICAgICAgICAgICAgICAgIG1fc3R5bGUt PnNldFF1b3RlcyhhZG9wdFJlZihRdW90ZXNEYXRhOjpjcmVhdGUoMCkpKTsKICAgICAgICAgfQog ICAgICAgICByZXR1cm47Ci0KLSAgICBjYXNlIENTU1Byb3BlcnR5Q291bnRlckluY3JlbWVudDoK LSAgICAgICAgYXBwbHlDb3VudGVyTGlzdChzdHlsZSgpLCB2YWx1ZS0+aXNWYWx1ZUxpc3QoKSA/ IHN0YXRpY19jYXN0PENTU1ZhbHVlTGlzdCo+KHZhbHVlKSA6IDAsIGZhbHNlKTsKLSAgICAgICAg cmV0dXJuOwotICAgIGNhc2UgQ1NTUHJvcGVydHlDb3VudGVyUmVzZXQ6Ci0gICAgICAgIGFwcGx5 Q291bnRlckxpc3Qoc3R5bGUoKSwgdmFsdWUtPmlzVmFsdWVMaXN0KCkgPyBzdGF0aWNfY2FzdDxD U1NWYWx1ZUxpc3QqPih2YWx1ZSkgOiAwLCB0cnVlKTsKLSAgICAgICAgcmV0dXJuOwotCiAgICAg Y2FzZSBDU1NQcm9wZXJ0eUZvbnRGYW1pbHk6IHsKICAgICAgICAgLy8gbGlzdCBvZiBzdHJpbmdz IGFuZCBpZHMKICAgICAgICAgaWYgKGlzSW5oZXJpdCkgewpAQCAtNTMzMyw2ICs1Mjg1LDggQEAg dm9pZCBDU1NTdHlsZVNlbGVjdG9yOjphcHBseVByb3BlcnR5KGludAogICAgIGNhc2UgQ1NTUHJv cGVydHlCb3JkZXJTcGFjaW5nOgogICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRCb3JkZXJIb3Jp em9udGFsU3BhY2luZzoKICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0Qm9yZGVyVmVydGljYWxT cGFjaW5nOgorICAgIGNhc2UgQ1NTUHJvcGVydHlDb3VudGVySW5jcmVtZW50OgorICAgIGNhc2Ug Q1NTUHJvcGVydHlDb3VudGVyUmVzZXQ6CiAgICAgY2FzZSBDU1NQcm9wZXJ0eUxldHRlclNwYWNp bmc6CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdvcmRTcGFjaW5nOgogICAgIGNhc2UgQ1NTUHJvcGVy dHlGb250U3R5bGU6Cg==