64832 2011-07-19 15:38:16 -0700 fix links on the flakiness dashboard 2011-07-21 15:13:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan tony oldest_to_newest 439515 0 ojan 2011-07-19 15:38:16 -0700 fix links on the flakiness dashboard 439516 1 101401 ojan 2011-07-19 15:39:07 -0700 Created attachment 101401 Patch 439552 2 101401 tony 2011-07-19 16:32:53 -0700 Comment on attachment 101401 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101401&action=review > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:-1329 > -function showPopupForTest(e, test) > -{ > - showPopup(e, htmlForIndividulTestOnAllBuilders(test)); > - appendExpectations(); > -} Are you just removing dead code here? > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1756 > + // FIXME: Make this DOM creation less verbose. > + var index = document.createElement('div'); > + index.style.cssFloat = 'right'; > + index.textContent = (g_currentState.updateIndex + 1) + ' of ' + keys.length + ' tests'; > + document.body.appendChild(index); Maybe mention this refactoring in the ChangeLog? 440662 3 ojan 2011-07-21 15:11:58 -0700 (In reply to comment #2) > (From update of attachment 101401 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=101401&action=review > > > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:-1329 > > -function showPopupForTest(e, test) > > -{ > > - showPopup(e, htmlForIndividulTestOnAllBuilders(test)); > > - appendExpectations(); > > -} > > Are you just removing dead code here? yes > > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1756 > > + // FIXME: Make this DOM creation less verbose. > > + var index = document.createElement('div'); > > + index.style.cssFloat = 'right'; > > + index.textContent = (g_currentState.updateIndex + 1) + ' of ' + keys.length + ' tests'; > > + document.body.appendChild(index); > > Maybe mention this refactoring in the ChangeLog? k 440664 4 ojan 2011-07-21 15:13:42 -0700 Committed r91518: <http://trac.webkit.org/changeset/91518> 101401 2011-07-19 15:39:07 -0700 2011-07-19 16:32:53 -0700 Patch bug-64832-20110719153906.patch text/plain 3822 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogOTEzMDQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzYjU4ODA4YmU2ZjhkYzQyZDU2MzllZDBkYmQ1NGZhMDcy YWQ1NTY5Li4wZTQ4ZjExMTVkZDlkY2Y3MjE1ZTc1NGNjYTY4NWNkNTA4N2ZlZGFmIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTEtMDctMTkgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAorICAgICAg ICBmaXggbGlua3Mgb24gdGhlIGZsYWtpbmVzcyBkYXNoYm9hcmQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0ODMyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSB0aGVtIGFjdHVhbCBhbmNob3IgdGFn cyBhbmQgbGlua2lmeSB0aGUgdGVzdCBuYW1lIGluc3RlYWQgb2YKKyAgICAgICAgYWRkaW5nIGFu IGV4dHJhIGxpbmsuCisKKyAgICAgICAgKiBUZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9h cmRzL2ZsYWtpbmVzc19kYXNoYm9hcmQuaHRtbDoKKworMjAxMS0wNy0xOSAgT2phbiBWYWZhaSAg PG9qYW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIGZpeCBmbGFraW5lc3MgZGFzaGJvYXJkIGZv ciBYUCBib3RzIHdpdGggWFAgaW4gdGhlIG5hbWUgaW5zdGVhZCBvZiBXSU4KICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0ODI2CiAKZGlmZiAtLWdpdCBh L1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hi b2FyZC5odG1sIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFr aW5lc3NfZGFzaGJvYXJkLmh0bWwKaW5kZXggMmFkY2MzMzYzNTc1ZDQ3ZDVmN2M3NjkwOTZiZDU4 ZTBhZWM2N2M1My4uMWJmYWNlNWFjOWVlOWQzMzYzZjhjNzNiYjRhMDNjOTVmZjFkNmViYyAxMDA2 NDQKLS0tIGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5l c3NfZGFzaGJvYXJkLmh0bWwKKysrIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFz aGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkLmh0bWwKQEAgLTEyMTksNyArMTIxOSw3IEBAIGZ1 bmN0aW9uIGh0bWxGb3JCdWdzKGJ1Z3MpCiAKIGZ1bmN0aW9uIGxpbmtIVE1MVG9PcGVuV2luZG93 KHVybCwgdGV4dCkKIHsKLSAgICByZXR1cm4gJzxkaXYgY2xhc3M9bGluayBvbmNsaWNrPSJ3aW5k b3cub3BlbihcJycgKyB1cmwgKyAnXCcpIj4nICsgdGV4dCArICc8L2Rpdj4nOworICAgIHJldHVy biAnPGEgaHJlZj0iJyArIHVybCArICciIHRhcmdldD0iX2JsYW5rIj4nICsgdGV4dCArICc8L2E+ JzsKIH0KIAogLy8gRklYTUU6IHJlcGxhY2VkIHdpdGggY2hyb21pdW1SZXZpc2lvbkxpbmsvd2Vi S2l0UmV2aXNpb25MaW5rCkBAIC0xMzIyLDEyICsxMzIyLDYgQEAgZnVuY3Rpb24gc2hvd1BvcHVw Rm9yQnVpbGQoZSwgYnVpbGRlciwgaW5kZXgsIG9wdF90ZXN0TmFtZSkKICAgICBzaG93UG9wdXAo ZSwgaHRtbCk7CiB9CiAKLWZ1bmN0aW9uIHNob3dQb3B1cEZvclRlc3QoZSwgdGVzdCkKLXsKLSAg ICBzaG93UG9wdXAoZSwgaHRtbEZvckluZGl2aWR1bFRlc3RPbkFsbEJ1aWxkZXJzKHRlc3QpKTsK LSAgICBhcHBlbmRFeHBlY3RhdGlvbnMoKTsKLX0KLQogZnVuY3Rpb24gaHRtbEZvclRlc3RSZXN1 bHRzKHRlc3QpCiB7CiAgICAgaWYgKCFnX2N1cnJlbnRTdGF0ZS5zaG93UnVuc09uQnVpbGRlclBh Z2UgJiYgIWlzQ3Jvc3NCdWlsZGVyVmlldygpKQpAQCAtMTc1Myw5ICsxNzQ3LDEzIEBAIGZ1bmN0 aW9uIGdlbmVyYXRlUGFnZUZvckV4cGVjdGF0aW9uc1VwZGF0ZSgpCiBmdW5jdGlvbiBzaG93VXBk YXRlSW5mb0ZvclRlc3QodGVzdHNOZWVkaW5nVXBkYXRlLCBrZXlzKQogewogICAgIHZhciB0ZXN0 ID0ga2V5c1tnX2N1cnJlbnRTdGF0ZS51cGRhdGVJbmRleF07Ci0gICAgZG9jdW1lbnQuYm9keS5p bm5lckhUTUwgPSAnPGI+JyArIHRlc3QgKyAnPC9iPicgKwotICAgICAgICAnPGRpdiBzdHlsZT0i ZmxvYXQ6cmlnaHQiPicgKyAoZ19jdXJyZW50U3RhdGUudXBkYXRlSW5kZXggKyAxKSArICcgb2Yg JyArCi0gICAgICAgICsga2V5cy5sZW5ndGggKyAnIHRlc3RzPC9kaXY+PGJyPjxicj4nOworICAg IGRvY3VtZW50LmJvZHkuaW5uZXJIVE1MID0gJyc7CisKKyAgICAvLyBGSVhNRTogTWFrZSB0aGlz IERPTSBjcmVhdGlvbiBsZXNzIHZlcmJvc2UuCisgICAgdmFyIGluZGV4ID0gZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgnZGl2Jyk7CisgICAgaW5kZXguc3R5bGUuY3NzRmxvYXQgPSAncmlnaHQnOwor ICAgIGluZGV4LnRleHRDb250ZW50ID0gKGdfY3VycmVudFN0YXRlLnVwZGF0ZUluZGV4ICsgMSkg KyAnIG9mICcgKyBrZXlzLmxlbmd0aCArICcgdGVzdHMnOworICAgIGRvY3VtZW50LmJvZHkuYXBw ZW5kQ2hpbGQoaW5kZXgpOwogCiAgICAgdmFyIGJ1dHRvblJlZ2lvbiA9IGRvY3VtZW50LmNyZWF0 ZUVsZW1lbnQoJ2RpdicpOwogICAgIHZhciBpbmNsdWRlQnRuID0gZG9jdW1lbnQuY3JlYXRlRWxl bWVudCgnaW5wdXQnKTsKQEAgLTE4ODEsMTIgKzE4NzksMTQgQEAgZnVuY3Rpb24gaHRtbEZvcklu ZGl2aWR1bFRlc3RPbkFsbEJ1aWxkZXJzKHRlc3QpCiAgICAgdmFyIHRlc3RSZXN1bHRzID0gZ190 ZXN0VG9SZXN1bHRzTWFwW3Rlc3RdOwogICAgIHZhciBtYXN0ZXI7CiAgICAgdmFyIGh0bWwgPSAn JzsKKyAgICBpZiAoaXNMYXlvdXRUZXN0UmVzdWx0cygpKSB7CisgICAgICAgIHZhciB0cmFjVVJM ID0gVEVTVF9VUkxfQkFTRV9QQVRIX1RSQUMgKyB0ZXN0CisgICAgICAgIGh0bWwgKz0gJzxoMj4n ICsgbGlua0hUTUxUb09wZW5XaW5kb3codHJhY1VSTCwgdGVzdCkgKyAnPC9oMj4nOworICAgIH0g ZWxzZQorICAgICAgICBodG1sICs9ICc8aDI+JyArIHRlc3QgKyAnPC9oMj4nOworCiAgICAgaWYg KHRlc3RSZXN1bHRzICYmIHRlc3RSZXN1bHRzLmxlbmd0aCkgewogICAgICAgICBtYXN0ZXIgPSBi dWlsZGVyTWFzdGVyKHRlc3RSZXN1bHRzWzBdLmJ1aWxkZXIpOwotICAgICAgICBpZiAoaXNMYXlv dXRUZXN0UmVzdWx0cygpKSB7Ci0gICAgICAgICAgICB2YXIgdHJhY1VSTCA9IFRFU1RfVVJMX0JB U0VfUEFUSF9UUkFDICsgdGVzdAotICAgICAgICAgICAgaHRtbCArPSBsaW5rSFRNTFRvT3Blbldp bmRvdyh0cmFjVVJMLCB0cmFjVVJMKTsKLSAgICAgICAgfQogCiAgICAgICAgIGh0bWwgKz0nPGRp dj48Yj5JZiBhIGJ1aWxkZXIgaXMgbm90IGxpc3RlZCwgdGhhdCBtZWFucyB0aGUgYnVpbGRlciAn ICsKICAgICAgICAgICAgICdkb2VzIG5vdCBydW4gdGhhdCB0ZXN0IChlLmcuIGl0IGlzIHNraXBw ZWQpIG9yIGFsbCBydW5zIG9mIHRoZSAnICsKQEAgLTIzOTEsNyArMjM5MSw3IEBAIGZ1bmN0aW9u IGh0bWxGb3JJbmRpdmlkdWFsVGVzdHModGVzdHMpCiB7CiAgICAgdmFyIHRlc3RzSFRNTCA9IFtd OwogICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGVzdHMubGVuZ3RoOyBpKyspCi0gICAgICAgIHRl c3RzSFRNTC5wdXNoKCc8aDIgb25jbGljaz0ic2VsZWN0Q29udGVudHModGhpcykiPicgKyB0ZXN0 c1tpXSArICc8L2gyPicgKyBodG1sRm9ySW5kaXZpZHVsVGVzdE9uQWxsQnVpbGRlcnModGVzdHNb aV0pKTsKKyAgICAgICAgdGVzdHNIVE1MLnB1c2goaHRtbEZvckluZGl2aWR1bFRlc3RPbkFsbEJ1 aWxkZXJzKHRlc3RzW2ldKSk7CiAgICAgcmV0dXJuIHRlc3RzSFRNTC5qb2luKCc8aHI+Jyk7CiB9 CiAK