64824 2011-07-19 14:09:26 -0700 [Mac] Need to make sure autocorrection panel is dismissed in Document::setFocusNode(). 2011-07-22 00:17:06 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 jiapu.mail jiapu.mail darin ddavidso webkit.review.bot oldest_to_newest 439434 0 jiapu.mail 2011-07-19 14:09:26 -0700 On search webpages, when moving focus away from text field, autocorrection panel won't get dismissed. <rdar://problem/9624232> 439448 1 101386 jiapu.mail 2011-07-19 14:20:06 -0700 Created attachment 101386 Patch v1 439455 2 101386 darin 2011-07-19 14:27:05 -0700 Comment on attachment 101386 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=101386&action=review > Source/WebCore/dom/Document.cpp:3098 > + frame()->editor()->dismissCorrectionPanelAsIgnored(); It seems strange and wrong to put this inside the check for oldFocusedNode->inDetach. It’s irritating that we have to actually utter the words “correction panel” here, but I can’t see a better way to structure this. 439464 3 jiapu.mail 2011-07-19 14:37:43 -0700 (In reply to comment #2) > (From update of attachment 101386 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=101386&action=review > > > Source/WebCore/dom/Document.cpp:3098 > > + frame()->editor()->dismissCorrectionPanelAsIgnored(); > > It seems strange and wrong to put this inside the check for oldFocusedNode->inDetach. Darin, could you elaborate a bit. I don't know these code well enough to clearly know where to put this call. > > It’s irritating that we have to actually utter the words “correction panel” here, but I can’t see a better way to structure this. How about calling dismissal in Editor::didEndEditing(), which is called further down in the function? But that's still inside the if statement you mentioned earlier. 439918 4 darin 2011-07-20 12:12:12 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 101386 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=101386&action=review > > > > > Source/WebCore/dom/Document.cpp:3098 > > > + frame()->editor()->dismissCorrectionPanelAsIgnored(); > > > > It seems strange and wrong to put this inside the check for oldFocusedNode->inDetach. > > Darin, could you elaborate a bit. I don't know these code well enough to clearly know where to put this call. I believe that the call to dismiss the correction panel should be made even if the old node is in the middle of the detach process. The rest of what’s inside the if statement body is about that old node directly, and so it should not be done if the node is in the middle of the detach process. But dismissing the correction panel seems to only obliquely be about the node itself, and so seems that it should be done even if the node happens to be in the middle of the detach process. > > It’s irritating that we have to actually utter the words “correction panel” here, but I can’t see a better way to structure this. > > How about calling dismissal in Editor::didEndEditing(), which is called further down in the function? But that's still inside the if statement you mentioned earlier. I think that’s a good idea. As long as is didEndEditing called often enough. Maybe I’m wrong about the inDetach thing. 440041 5 101516 jiapu.mail 2011-07-20 14:58:13 -0700 Created attachment 101516 Patch v2 440553 6 101516 webkit.review.bot 2011-07-21 12:01:32 -0700 Comment on attachment 101516 Patch v2 Rejecting attachment 101516 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 1 Last 500 characters of output: 085e4efceb0bca35c887ff21de2e522a6394c8ea r91483 = 4f1989c27f3f49d3fb006fcdfadc2a139b2f5f91 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9193770 440570 7 101625 jiapu.mail 2011-07-21 12:14:32 -0700 Created attachment 101625 Patch v3 Added in "Reviewed by ..." line to make build bot happy. 440867 8 101625 webkit.review.bot 2011-07-22 00:17:01 -0700 Comment on attachment 101625 Patch v3 Clearing flags on attachment: 101625 Committed r91559: <http://trac.webkit.org/changeset/91559> 440868 9 webkit.review.bot 2011-07-22 00:17:06 -0700 All reviewed patches have been landed. Closing bug. 101386 2011-07-19 14:20:06 -0700 2011-07-20 14:58:10 -0700 Patch v1 bug-64824-20110719142004.patch text/plain 1388 jiapu.mail U3VidmVyc2lvbiBSZXZpc2lvbjogOTEyMTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyNWFmNDRjOWQ2MDMyMGIw MTFiNWI3N2YwZGE4YTZlYmNkM2JiYjFlLi4zYzc1NjA2OWRlMzBlMDY1ZTBmZDkzYzM4NWY3ZDJi N2M3MjM3MjIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAKKzIwMTEtMDctMTkgIEppYSBQ dSAgPGpwdUBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gTmVlZCB0byBtYWtlIHN1cmUgYXV0 b2NvcnJlY3Rpb24gcGFuZWwgaXMgZGlzbWlzc2VkIGluIERvY3VtZW50OjpzZXRGb2N1c05vZGUo KS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0ODI0 CisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1l bnQ6OnNldEZvY3VzZWROb2RlKTogRGlzbWlzcyBhdXRvY29ycmVjdGlvbiBwYW5lbCB3aGVuIGN1 cnJlbnQgbm9kZSBsb3NpbmcgZm9jdXMuCisKIDIwMTEtMDctMTggIERhbiBCZXJuc3RlaW4gIDxt aXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBTcGVjaWZ5IGEgY2FzY2FkZSBsaXN0IGNvbnNpc3Rp bmcgb2YgdGhlIGxhc3QgcmVzb3J0IGZvbnQgZm9yIENvcmUgVGV4dApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5jcHAKaW5kZXggZDJlMDk0NGZlZTdlY2NmMTZiNTQ1OTE3ZGNmNDk1MGE4MGFkOWEzNy4uNzE5 YzFlMGNlMzE3MWE2OGVhOTRkNzQwMTJhMjE0Mjc4Y2YzYWRjNiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1l bnQuY3BwCkBAIC0zMDk1LDYgKzMwOTUsOCBAQCBib29sIERvY3VtZW50OjpzZXRGb2N1c2VkTm9k ZShQYXNzUmVmUHRyPE5vZGU+IHBycE5ld0ZvY3VzZWROb2RlKQogCiAgICAgLy8gUmVtb3ZlIGZv Y3VzIGZyb20gdGhlIGV4aXN0aW5nIGZvY3VzIG5vZGUgKGlmIGFueSkKICAgICBpZiAob2xkRm9j dXNlZE5vZGUgJiYgIW9sZEZvY3VzZWROb2RlLT5pbkRldGFjaCgpKSB7CisgICAgICAgIGZyYW1l KCktPmVkaXRvcigpLT5kaXNtaXNzQ29ycmVjdGlvblBhbmVsQXNJZ25vcmVkKCk7CisgICAgICAg IAogICAgICAgICAvLyB3aWxsQmx1cigpIHNob3VsZCBiZSBjYWxsZWQgYmVmb3JlIGFueSBzdGF0 dXMgY2hhbmdlcy4KICAgICAgICAgb2xkRm9jdXNlZE5vZGUtPndpbGxCbHVyKCk7CiAgICAgICAg IG1fZm9jdXNlZE5vZGUgPSAwOwo= 101516 2011-07-20 14:58:13 -0700 2011-07-21 12:14:28 -0700 Patch v2 bug-64824-20110720145811.patch text/plain 1260 jiapu.mail U3VidmVyc2lvbiBSZXZpc2lvbjogOTEyMTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyNWFmNDRjOWQ2MDMyMGIw MTFiNWI3N2YwZGE4YTZlYmNkM2JiYjFlLi5jNWQ2MGY5MTJkNjgzY2FhMzVkMTIzNTEzOTI5MDUz NjYyMGNiMGYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDctMjAgIEppYSBQ dSAgPGpwdUBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gTmVlZCB0byBtYWtlIHN1cmUgYXV0 b2NvcnJlY3Rpb24gcGFuZWwgaXMgZGlzbWlzc2VkIGluIERvY3VtZW50OjpzZXRGb2N1c05vZGUo KS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0ODI0 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85NjI0MjMyPgorCisgICAgICAgICogZWRpdGluZy9F ZGl0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjp0ZXh0RmllbGREaWRFbmRFZGl0 aW5nKTogRGlzbWlzcyBhdXRvY29ycmVjdGlvbiBwYW5lbCB3aGVuIGN1cnJlbnQgbm9kZSBsb3Np bmcgZm9jdXMuCisKIDIwMTEtMDctMTggIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4K IAogICAgICAgICBTcGVjaWZ5IGEgY2FzY2FkZSBsaXN0IGNvbnNpc3Rpbmcgb2YgdGhlIGxhc3Qg cmVzb3J0IGZvbnQgZm9yIENvcmUgVGV4dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRp dGluZy9FZGl0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCmluZGV4 IDY0MGNkMDQ0NjM5NzBhOTQ4ZGU5MjI5MTQ0MTFmODE5ZmUyYWQ3M2IuLjhjNGFjNTU2ZWFmMDA4 NTVkMjQ1YTgwYWUyNzEyMTAwNWY0NjhiODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvRWRpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAK QEAgLTI4MzgsNiArMjgzOCw3IEBAIHZvaWQgRWRpdG9yOjp0ZXh0RmllbGREaWRCZWdpbkVkaXRp bmcoRWxlbWVudCogZSkKIAogdm9pZCBFZGl0b3I6OnRleHRGaWVsZERpZEVuZEVkaXRpbmcoRWxl bWVudCogZSkKIHsKKyAgICBkaXNtaXNzQ29ycmVjdGlvblBhbmVsQXNJZ25vcmVkKCk7CiAgICAg aWYgKGNsaWVudCgpKQogICAgICAgICBjbGllbnQoKS0+dGV4dEZpZWxkRGlkRW5kRWRpdGluZyhl KTsKIH0K 101625 2011-07-21 12:14:32 -0700 2011-07-22 00:17:01 -0700 Patch v3 bug-64824-20110721121433.patch text/plain 1299 jiapu.mail U3VidmVyc2lvbiBSZXZpc2lvbjogOTEyMTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyNWFmNDRjOWQ2MDMyMGIw MTFiNWI3N2YwZGE4YTZlYmNkM2JiYjFlLi5lYzhhN2M0YzYxMGVjZWQyMDA2MzVhYzRhMjUwMjlm NDEyMjAxZWU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDctMjAgIEppYSBQ dSAgPGpwdUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW01hY10gTmVlZCB0byBtYWtlIHN1cmUgYXV0b2NvcnJlY3Rpb24gcGFuZWwg aXMgZGlzbWlzc2VkIGluIERvY3VtZW50OjpzZXRGb2N1c05vZGUoKS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0ODI0CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS85NjI0MjMyPgorCisgICAgICAgICogZWRpdGluZy9FZGl0b3IuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RWRpdG9yOjp0ZXh0RmllbGREaWRFbmRFZGl0aW5nKTogRGlzbWlzcyBhdXRv Y29ycmVjdGlvbiBwYW5lbCB3aGVuIGN1cnJlbnQgbm9kZSBsb3NpbmcgZm9jdXMuCisKIDIwMTEt MDctMTggIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBTcGVjaWZ5 IGEgY2FzY2FkZSBsaXN0IGNvbnNpc3Rpbmcgb2YgdGhlIGxhc3QgcmVzb3J0IGZvbnQgZm9yIENv cmUgVGV4dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwIGIv U291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCmluZGV4IDY0MGNkMDQ0NjM5NzBhOTQ4 ZGU5MjI5MTQ0MTFmODE5ZmUyYWQ3M2IuLjhjNGFjNTU2ZWFmMDA4NTVkMjQ1YTgwYWUyNzEyMTAw NWY0NjhiODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKQEAgLTI4MzgsNiArMjgzOCw3 IEBAIHZvaWQgRWRpdG9yOjp0ZXh0RmllbGREaWRCZWdpbkVkaXRpbmcoRWxlbWVudCogZSkKIAog dm9pZCBFZGl0b3I6OnRleHRGaWVsZERpZEVuZEVkaXRpbmcoRWxlbWVudCogZSkKIHsKKyAgICBk aXNtaXNzQ29ycmVjdGlvblBhbmVsQXNJZ25vcmVkKCk7CiAgICAgaWYgKGNsaWVudCgpKQogICAg ICAgICBjbGllbnQoKS0+dGV4dEZpZWxkRGlkRW5kRWRpdGluZyhlKTsKIH0K