64815 2011-07-19 11:40:45 -0700 Possible recursion in GraphicsLayerCA::updateGeometry() 2011-07-19 15:05:25 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 64828 1 simon.fraser simon.fraser cmarrin rniwa simon.fraser oldest_to_newest 439300 0 simon.fraser 2011-07-19 11:40:45 -0700 It's possible to hit infinite recursion in GraphicsLayerCA::updateGeometry()/swapFromOrToTiledLayer()/updateContentsScale()/swapFromOrToTiledLayer()... because updateContentsScale() uses a different size than updateGeometry() for the tiled layer check. 439351 1 101360 simon.fraser 2011-07-19 12:20:49 -0700 Created attachment 101360 Patch 439402 2 simon.fraser 2011-07-19 13:34:07 -0700 http://trac.webkit.org/changeset/91294 101360 2011-07-19 12:20:49 -0700 2011-07-19 13:30:04 -0700 Patch bug-64815-20110719122048.patch text/plain 7200 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogOTEyNzEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0YjMwZTU3NDE3ZmE3ZDYzYzg0NTI0 OGVjOTZmZDFjY2ZmY2Q4YTA3Li42MzIwMGZiNWQyNmJkMWJjNmRhMmM1OGJhYTVjNTk3MjkwZjA3 MzkzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMTkgIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUG9zc2libGUgcmVjdXJzaW5nIGluIEdy YXBoaWNzTGF5ZXJDQTo6dXBkYXRlR2VvbWV0cnkoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ4MTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIE5ldyB0ZXN0cyB0aGF0IHNjYWxlcyBhIHBh Z2Ugc28gdGhhdCBhIGNvbXBvc2l0aW5nIGxheWVyIGZhbGxzCisgICAgICAgIGNsb3NlIHRvIHRo ZSB0aWxpbmcgdGhyZXNob2xkLgorCisgICAgICAgICogY29tcG9zaXRpbmcvc2NhbGluZy90aWxl ZC1sYXllci1yZWN1cnNpb24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBjb21wb3Np dGluZy9zY2FsaW5nL3RpbGVkLWxheWVyLXJlY3Vyc2lvbi5odG1sOiBBZGRlZC4KKwogMjAxMS0w Ny0xOSAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFRl c3RzIHRoYXQgd2UgZG8gbm90IGNyYXNoIHdoZW4gcmVtb3ZpbmcgdW5yZW5kZXJpbmcgbm9kZXMK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3NjYWxpbmcvdGlsZWQtbGF5ZXIt cmVjdXJzaW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3NjYWxpbmcv dGlsZWQtbGF5ZXItcmVjdXJzaW9uLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44YjEzNzg5MTc5 MWZlOTY5MjdhZDc4ZTY0YjBhYWQ3YmRlZDA4YmRjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvY29tcG9zaXRpbmcvc2NhbGluZy90aWxlZC1sYXllci1yZWN1cnNpb24tZXhwZWN0ZWQu dHh0CkBAIC0wLDAgKzEgQEAKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcv c2NhbGluZy90aWxlZC1sYXllci1yZWN1cnNpb24uaHRtbCBiL0xheW91dFRlc3RzL2NvbXBvc2l0 aW5nL3NjYWxpbmcvdGlsZWQtbGF5ZXItcmVjdXJzaW9uLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZjhiMTg5 ZmQ5MDE4NDIyNThjMTU4OTZmODE3YzYzYWUzZmZhNWJjMAotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2NvbXBvc2l0aW5nL3NjYWxpbmcvdGlsZWQtbGF5ZXItcmVjdXJzaW9uLmh0bWwK QEAgLTAsMCArMSwyOSBAQAorPCFET0NUWVBFIGh0bWw+CisKKzxodG1sPgorPGhlYWQ+CisgIDxz dHlsZT4KKyAgICAuY29tcG9zaXRlZCB7CisgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsK KyAgICAgIHdpZHRoOiAyMDBweDsKKyAgICAgIGhlaWdodDogMTMzM3B4OworICAgICAgLXdlYmtp dC10cmFuc2Zvcm06IHRyYW5zbGF0ZVooMCk7CisgICAgfQorICA8L3N0eWxlPgorICA8c2NyaXB0 PgorICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci5kdW1wQXNUZXh0KHRydWUpOworCisgICAgZnVuY3Rpb24gc2NhbGVQYWdlKCkK KyAgICB7CisgICAgICBldmVudFNlbmRlci5zY2FsZVBhZ2VCeSgxLjUwMDI1LCAwLCAwKTsKKyAg ICB9CisgIAorICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgc2NhbGVQYWdlLCBm YWxzZSk7CisgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+CisgIDwhLS0gVGhpcyB0ZXN0IHNo b3VsZCBub3QgY3Jhc2guIC0tPgorICA8ZGl2IGNsYXNzPSJjb21wb3NpdGVkIj48L2Rpdj4KKzwv Ym9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzNzA5MjNlM2M1ZWZiOWJmMGI5MGEwNGVkNjI2 NjJmNmQ4NWM0NGM0Li43MTUxMzFkMWM2Nzk2MzRhYzFmZTg5YzkxOWZkYmRiNTI2YmM3YzY3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMTEtMDctMTkgIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUG9zc2libGUgcmVjdXJzaW9uIGluIEdy YXBoaWNzTGF5ZXJDQTo6dXBkYXRlR2VvbWV0cnkoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ4MTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEl0IHdhcyBwb3NzaWJsZSB0byByZWN1cnNl IHZpYSB1cGRhdGVHZW9tZXRyeS9zd2FwRnJvbU9yVG9UaWxlZExheWVyLworICAgICAgICB1cGRh dGVDb250ZW50c1NjYWxlIGJlY2F1c2UgdXBkYXRlR2VvbWV0cnkoKSBhbmQgdXBkYXRlQ29udGVu dHNTY2FsZSgpCisgICAgICAgIHVzZWQgZGlmZmVyZW50IHNpemVzOyB1cGRhdGVHZW9tZXRyeSgp IHVzZWQgdGhlIHNjYWxlZCBzaXplLCB3aGlsZQorICAgICAgICB1cGRhdGVDb250ZW50c1NjYWxl KCkgdXNlZCB0aGUgdW5zY2FsZWQgc2l6ZS4KKyAgICAgICAgCisgICAgICAgIEFsd2F5cyB1c2Ug dGhlIHVuc2NhbGVkIHNpemU7IHRoZSBzY2FsZWQgc2l6ZSB3aWxsIGJlIGF0IG1vc3QgYSBjb3Vw bGUKKyAgICAgICAgb2YgcGl4ZWxzIGJpZ2dlciwgYW5kIG91ciB0aHJlc2hvbGQgaXMgbm90IGNs b3NlIHRvIHRoZSBtYXggdGV4dHVyZQorICAgICAgICBzaXplIGxpbWl0LCBzbyB1c2luZyB0aGUg c2xpZ2h0bHkgc21hbGxlciBzaXplIGlzIE9LLgorCisgICAgICAgIFRlc3Q6IGNvbXBvc2l0aW5n L3NjYWxpbmcvdGlsZWQtbGF5ZXItcmVjdXJzaW9uLmh0bWwKKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFw aGljc0xheWVyQ0E6OnVwZGF0ZUdlb21ldHJ5KToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNz TGF5ZXJDQTo6dXBkYXRlTGF5ZXJEcmF3c0NvbnRlbnQpOgorICAgICAgICAoV2ViQ29yZTo6R3Jh cGhpY3NMYXllckNBOjp1cGRhdGVDb250ZW50c1NjYWxlKToKKyAgICAgICAgKFdlYkNvcmU6Okdy YXBoaWNzTGF5ZXJDQTo6cmVxdWlyZXNUaWxlZExheWVyKToKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuaDoKKwogMjAxMS0wNy0xOSAgQWJoaXNoZWsgQXJ5 YSAgPGluZmVybm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENyYXNoIHdoZW4gcmVtb3Zpbmcg dW5yZW5kZXJlcmVkIG5vZGVzIGluIHJlcGxhY2VtZW50IGZyYWdtZW50LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAK aW5kZXggM2M3YWJmNmY1N2MwMDZlNWYwNTI0NGJlOGE1ZDM2ZDBhNmQzOWQxZS4uYmQ3OTk0OWI4 ZWRlOGIxZGIzMDlmYWVmNTIyZGUwNWRiMGYyY2FlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwCkBAIC0xMDEw LDcgKzEwMTAsNyBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJDQTo6dXBkYXRlR2VvbWV0cnkoZmxvYXQg cGFnZVNjYWxlRmFjdG9yLCBjb25zdCBGbG9hdFBvaW50JiBwbwogICAgIEZsb2F0U2l6ZSBwaXhl bEFsaWdubWVudE9mZnNldDsKICAgICBjb21wdXRlUGl4ZWxBbGlnbm1lbnQocGFnZVNjYWxlRmFj dG9yLCBwb3NpdGlvblJlbGF0aXZlVG9CYXNlLCBzY2FsZWRQb3NpdGlvbiwgc2NhbGVkU2l6ZSwg c2NhbGVkQW5jaG9yUG9pbnQsIHBpeGVsQWxpZ25tZW50T2Zmc2V0KTsKIAotICAgIGJvb2wgbmVl ZFRpbGVkTGF5ZXIgPSByZXF1aXJlc1RpbGVkTGF5ZXIocGFnZVNjYWxlRmFjdG9yLCBzY2FsZWRT aXplKTsKKyAgICBib29sIG5lZWRUaWxlZExheWVyID0gcmVxdWlyZXNUaWxlZExheWVyKHBhZ2VT Y2FsZUZhY3Rvcik7CiAgICAgaWYgKG5lZWRUaWxlZExheWVyICE9IG1fdXNpbmdUaWxlZExheWVy KQogICAgICAgICBzd2FwRnJvbU9yVG9UaWxlZExheWVyKG5lZWRUaWxlZExheWVyLCBwYWdlU2Nh bGVGYWN0b3IsIHBvc2l0aW9uUmVsYXRpdmVUb0Jhc2UpOwogCkBAIC0xMjYyLDcgKzEyNjIsNyBA QCBHcmFwaGljc0xheWVyQ0E6OlN0cnVjdHVyYWxMYXllclB1cnBvc2UgR3JhcGhpY3NMYXllckNB OjpzdHJ1Y3R1cmFsTGF5ZXJQdXJwb3NlKAogCiB2b2lkIEdyYXBoaWNzTGF5ZXJDQTo6dXBkYXRl TGF5ZXJEcmF3c0NvbnRlbnQoZmxvYXQgcGFnZVNjYWxlRmFjdG9yLCBjb25zdCBGbG9hdFBvaW50 JiBwb3NpdGlvblJlbGF0aXZlVG9CYXNlKQogewotICAgIGJvb2wgbmVlZFRpbGVkTGF5ZXIgPSBy ZXF1aXJlc1RpbGVkTGF5ZXIocGFnZVNjYWxlRmFjdG9yLCBtX3NpemUpOworICAgIGJvb2wgbmVl ZFRpbGVkTGF5ZXIgPSByZXF1aXJlc1RpbGVkTGF5ZXIocGFnZVNjYWxlRmFjdG9yKTsKICAgICBp ZiAobmVlZFRpbGVkTGF5ZXIgIT0gbV91c2luZ1RpbGVkTGF5ZXIpCiAgICAgICAgIHN3YXBGcm9t T3JUb1RpbGVkTGF5ZXIobmVlZFRpbGVkTGF5ZXIsIHBhZ2VTY2FsZUZhY3RvciwgcG9zaXRpb25S ZWxhdGl2ZVRvQmFzZSk7CiAKQEAgLTE5ODgsNyArMTk4OCw3IEBAIHN0YXRpYyBmbG9hdCBjbGFt cGVkQ29udGVudHNTY2FsZUZvclNjYWxlKGZsb2F0IHNjYWxlKQogCiB2b2lkIEdyYXBoaWNzTGF5 ZXJDQTo6dXBkYXRlQ29udGVudHNTY2FsZShmbG9hdCBwYWdlU2NhbGVGYWN0b3IsIGNvbnN0IEZs b2F0UG9pbnQmIHBvc2l0aW9uUmVsYXRpdmVUb0Jhc2UpCiB7Ci0gICAgYm9vbCBuZWVkVGlsZWRM YXllciA9IHJlcXVpcmVzVGlsZWRMYXllcihwYWdlU2NhbGVGYWN0b3IsIG1fc2l6ZSk7CisgICAg Ym9vbCBuZWVkVGlsZWRMYXllciA9IHJlcXVpcmVzVGlsZWRMYXllcihwYWdlU2NhbGVGYWN0b3Ip OwogICAgIGlmIChuZWVkVGlsZWRMYXllciAhPSBtX3VzaW5nVGlsZWRMYXllcikKICAgICAgICAg c3dhcEZyb21PclRvVGlsZWRMYXllcihuZWVkVGlsZWRMYXllciwgcGFnZVNjYWxlRmFjdG9yLCBw b3NpdGlvblJlbGF0aXZlVG9CYXNlKTsKIApAQCAtMjA0Miw3ICsyMDQyLDcgQEAgRmxvYXRTaXpl IEdyYXBoaWNzTGF5ZXJDQTo6Y29uc3RyYWluZWRTaXplKCkgY29uc3QKICAgICByZXR1cm4gY29u c3RyYWluZWRTaXplOwogfQogCi1ib29sIEdyYXBoaWNzTGF5ZXJDQTo6cmVxdWlyZXNUaWxlZExh eWVyKGZsb2F0IHBhZ2VTY2FsZUZhY3RvciwgY29uc3QgRmxvYXRTaXplJiBzaXplKSBjb25zdAor Ym9vbCBHcmFwaGljc0xheWVyQ0E6OnJlcXVpcmVzVGlsZWRMYXllcihmbG9hdCBwYWdlU2NhbGVG YWN0b3IpIGNvbnN0CiB7CiAgICAgaWYgKCFtX2RyYXdzQ29udGVudCB8fCAhbV9hbGxvd1RpbGVk TGF5ZXIpCiAgICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTIwNTAsNyArMjA1MCw3IEBAIGJvb2wg R3JhcGhpY3NMYXllckNBOjpyZXF1aXJlc1RpbGVkTGF5ZXIoZmxvYXQgcGFnZVNjYWxlRmFjdG9y LCBjb25zdCBGbG9hdFNpemUmCiAgICAgZmxvYXQgY29udGVudHNTY2FsZSA9IHBhZ2VTY2FsZUZh Y3RvciAqIGJhY2tpbmdTY2FsZUZhY3RvcigpOwogCiAgICAgLy8gRklYTUU6IGNhdGNoIHplcm8t c2l6ZSBoZWlnaHQgb3Igd2lkdGggaGVyZSAob3IgZWFybGllcik/Ci0gICAgcmV0dXJuIHNpemUu d2lkdGgoKSAqIGNvbnRlbnRzU2NhbGUgPiBjTWF4UGl4ZWxEaW1lbnNpb24gfHwgc2l6ZS5oZWln aHQoKSAqIGNvbnRlbnRzU2NhbGUgPiBjTWF4UGl4ZWxEaW1lbnNpb247CisgICAgcmV0dXJuIG1f c2l6ZS53aWR0aCgpICogY29udGVudHNTY2FsZSA+IGNNYXhQaXhlbERpbWVuc2lvbiB8fCBtX3Np emUuaGVpZ2h0KCkgKiBjb250ZW50c1NjYWxlID4gY01heFBpeGVsRGltZW5zaW9uOwogfQogCiB2 b2lkIEdyYXBoaWNzTGF5ZXJDQTo6c3dhcEZyb21PclRvVGlsZWRMYXllcihib29sIHVzZVRpbGVk TGF5ZXIsIGZsb2F0IHBhZ2VTY2FsZUZhY3RvciwgY29uc3QgRmxvYXRQb2ludCYgcG9zaXRpb25S ZWxhdGl2ZVRvQmFzZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2EvR3JhcGhpY3NMYXllckNBLmgKaW5kZXggZWZjYjQyNWM5NjY2ZGI2NTdjYWJhYjJmMmRi ZDFkOGJhOTk3MDIxYy4uMjA0M2Y1ODk0YjZjYjU1MzM1ZTg4NjY2M2ZjMDNkN2JiZjdhMjBhMiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NM YXllckNBLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhp Y3NMYXllckNBLmgKQEAgLTE4OCw3ICsxODgsNyBAQCBwcml2YXRlOgogCiAgICAgRmxvYXRTaXpl IGNvbnN0cmFpbmVkU2l6ZSgpIGNvbnN0OwogCi0gICAgYm9vbCByZXF1aXJlc1RpbGVkTGF5ZXIo ZmxvYXQgcGFnZVNjYWxlRmFjdG9yLCBjb25zdCBGbG9hdFNpemUmKSBjb25zdDsKKyAgICBib29s IHJlcXVpcmVzVGlsZWRMYXllcihmbG9hdCBwYWdlU2NhbGVGYWN0b3IpIGNvbnN0OwogICAgIHZv aWQgc3dhcEZyb21PclRvVGlsZWRMYXllcihib29sIHVzZVRpbGVkTGF5ZXIsIGZsb2F0IHBhZ2VT Y2FsZUZhY3RvciwgY29uc3QgRmxvYXRQb2ludCYgcG9zaXRpb25SZWxhdGl2ZVRvQmFzZSk7CiAK ICAgICBDb21wb3NpdGluZ0Nvb3JkaW5hdGVzT3JpZW50YXRpb24gZGVmYXVsdENvbnRlbnRzT3Jp ZW50YXRpb24oKSBjb25zdDsK