64814 2011-07-19 11:10:00 -0700 [Qt] Fix leak of QWebPage in errorPageExtension tests 2011-07-20 07:18:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cmarcelo cmarcelo luiz oldest_to_newest 439267 0 cmarcelo 2011-07-19 11:10:00 -0700 [Qt] Fix leak of QWebPage in errorPageExtension tests 439271 1 101346 cmarcelo 2011-07-19 11:13:37 -0700 Created attachment 101346 Patch 439305 2 101346 luiz 2011-07-19 11:43:33 -0700 Comment on attachment 101346 Patch The change in the documentation looks a bit unrelated. Otherwise LGTM. 439372 3 101346 noam 2011-07-19 12:44:51 -0700 Comment on attachment 101346 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101346&action=review > Source/WebKit/qt/Api/qwebview.cpp:375 > + of the object. If the current page is a child of the web This is unrelated, please remove before committing. You can r=me on it as a separate patch. 439459 4 cmarcelo 2011-07-19 14:31:47 -0700 M Source/WebKit/qt/ChangeLog M Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp Committed r91302 101346 2011-07-19 11:13:37 -0700 2011-07-19 12:44:51 -0700 Patch bug-64814-20110719151335.patch text/plain 5628 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogOTEyMDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQv QXBpL3F3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJ2aWV3LmNwcAppbmRl eCBmNGIyM2YzMWJiMWY5YjZjNWYxMWExOTFmM2QyNGE3YzhmODRiODk5Li43NmI5MjdiYWNlMjNk OGRlZTkwOTJkMjQ0ODUzMzMxZDJjOGJiMjQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0 L0FwaS9xd2Vidmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYnZpZXcuY3Bw CkBAIC0zNzIsNyArMzcyLDcgQEAgdm9pZCBRV2ViVmlld1ByaXZhdGU6OmRldGFjaEN1cnJlbnRQ YWdlKCkKICAgICBNYWtlcyBcYSBwYWdlIHRoZSBuZXcgd2ViIHBhZ2Ugb2YgdGhlIHdlYiB2aWV3 LgogCiAgICAgVGhlIHBhcmVudCBRT2JqZWN0IG9mIHRoZSBwcm92aWRlZCBwYWdlIHJlbWFpbnMg dGhlIG93bmVyCi0gICAgb2YgdGhlIG9iamVjdC4gSWYgdGhlIGN1cnJlbnQgZG9jdW1lbnQgaXMg YSBjaGlsZCBvZiB0aGUgd2ViCisgICAgb2YgdGhlIG9iamVjdC4gSWYgdGhlIGN1cnJlbnQgcGFn ZSBpcyBhIGNoaWxkIG9mIHRoZSB3ZWIKICAgICB2aWV3LCBpdCB3aWxsIGJlIGRlbGV0ZWQuCiAK ICAgICBcc2EgcGFnZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDgyNDhiZTVmODVmZTI4OThhNWQ4NWQ2 MGRkZWVhOGQzYzFlZGQ4Y2MuLjRlY2Q1NjcxZmIxZDNmNjZiNWU3NjM3YzczYmRjODZlZmM5NDZh NTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDctMTkgIENhaW8gTWFy Y2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4KKwor ICAgICAgICBbUXRdIEZpeCBsZWFrIG9mIFFXZWJQYWdlIGluIGVycm9yUGFnZUV4dGVuc2lvbiB0 ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ4 MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBRV2Vi Vmlldzo6c2V0UGFnZSgpIGRvZXNuJ3QgdGFrZSBvd25lcnNoaXAsIHNvIHRoZSBFcnJvclBhZ2Vz IHdlcmUgbGVha2luZy4gU28gbm93CisgICAgICAgIGFsbG9jYXRlIHRoZW0gb24gdGhlIHN0YWNr LiBUaGlzIHNob3VsZG4ndCBjaGFuZ2UgYW55IGJlaGF2aW9yLgorCisgICAgICAgICogQXBpL3F3 ZWJ2aWV3LmNwcDogVXNlcyB0aGUgdGVybSAncGFnZScgaW5zdGVhZCBvZiAnZG9jdW1lbnQnLgor CisgICAgICAgICogdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKHRz dF9RV2ViUGFnZTo6ZXJyb3JQYWdlRXh0ZW5zaW9uKToKKyAgICAgICAgKHRzdF9RV2ViUGFnZTo6 ZXJyb3JQYWdlRXh0ZW5zaW9uSW5JRnJhbWVzKToKKyAgICAgICAgKHRzdF9RV2ViUGFnZTo6ZXJy b3JQYWdlRXh0ZW5zaW9uSW5GcmFtZXNldCk6CisKIDIwMTEtMDctMTggIEh1aSBIdWFuZyAgPGh1 aS4yLmh1YW5nQG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIENvbXBpbGluZyBlcnJvciBpbiBT b3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJlbGVtZW50L3RzdF9xd2ViZWxlbWVudC5jcHAgd2l0 aCBRdCA0Ljcgb3Igb2xkZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdl YnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2Uv dHN0X3F3ZWJwYWdlLmNwcAppbmRleCBiMjY5ZmRhNTBmYWIyOWUzYzRhNWJkOTk5MWNjY2JjYjc0 ZmE5MmU0Li5hNmJhYTY0MjI3OWY2NTVkODNlZGVmOGJiYmU5MjBhZTNmMGYxNTI3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKKysr IGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCkBAIC0y NTExLDQyICsyNTExLDQyIEBAIHB1YmxpYzoKIAogdm9pZCB0c3RfUVdlYlBhZ2U6OmVycm9yUGFn ZUV4dGVuc2lvbigpCiB7Ci0gICAgRXJyb3JQYWdlKiBwYWdlID0gbmV3IEVycm9yUGFnZTsKLSAg ICBtX3ZpZXctPnNldFBhZ2UocGFnZSk7CisgICAgRXJyb3JQYWdlIHBhZ2U7CisgICAgbV92aWV3 LT5zZXRQYWdlKCZwYWdlKTsKIAogICAgIFFTaWduYWxTcHkgc3B5TG9hZEZpbmlzaGVkKG1fdmll dywgU0lHTkFMKGxvYWRGaW5pc2hlZChib29sKSkpOwogCiAgICAgbV92aWV3LT5zZXRVcmwoUVVy bCgiZGF0YTp0ZXh0L2h0bWwsZm9vIikpOwogICAgIFFUUllfQ09NUEFSRShzcHlMb2FkRmluaXNo ZWQuY291bnQoKSwgMSk7CiAKLSAgICBwYWdlLT5tYWluRnJhbWUoKS0+c2V0VXJsKFFVcmwoImh0 dHA6Ly9ub24uZXhpc3RlbnQvdXJsIikpOworICAgIHBhZ2UubWFpbkZyYW1lKCktPnNldFVybChR VXJsKCJodHRwOi8vbm9uLmV4aXN0ZW50L3VybCIpKTsKICAgICBRVFJZX0NPTVBBUkUoc3B5TG9h ZEZpbmlzaGVkLmNvdW50KCksIDIpOwotICAgIFFDT01QQVJFKHBhZ2UtPm1haW5GcmFtZSgpLT50 b1BsYWluVGV4dCgpLCBRU3RyaW5nKCJlcnJvciIpKTsKLSAgICBRQ09NUEFSRShwYWdlLT5oaXN0 b3J5KCktPmNvdW50KCksIDIpOwotICAgIFFDT01QQVJFKHBhZ2UtPmhpc3RvcnkoKS0+Y3VycmVu dEl0ZW0oKS51cmwoKSwgUVVybCgiaHR0cDovL25vbi5leGlzdGVudC91cmwiKSk7Ci0gICAgUUNP TVBBUkUocGFnZS0+aGlzdG9yeSgpLT5jYW5Hb0JhY2soKSwgdHJ1ZSk7Ci0gICAgUUNPTVBBUkUo cGFnZS0+aGlzdG9yeSgpLT5jYW5Hb0ZvcndhcmQoKSwgZmFsc2UpOworICAgIFFDT01QQVJFKHBh Z2UubWFpbkZyYW1lKCktPnRvUGxhaW5UZXh0KCksIFFTdHJpbmcoImVycm9yIikpOworICAgIFFD T01QQVJFKHBhZ2UuaGlzdG9yeSgpLT5jb3VudCgpLCAyKTsKKyAgICBRQ09NUEFSRShwYWdlLmhp c3RvcnkoKS0+Y3VycmVudEl0ZW0oKS51cmwoKSwgUVVybCgiaHR0cDovL25vbi5leGlzdGVudC91 cmwiKSk7CisgICAgUUNPTVBBUkUocGFnZS5oaXN0b3J5KCktPmNhbkdvQmFjaygpLCB0cnVlKTsK KyAgICBRQ09NUEFSRShwYWdlLmhpc3RvcnkoKS0+Y2FuR29Gb3J3YXJkKCksIGZhbHNlKTsKIAot ICAgIHBhZ2UtPnRyaWdnZXJBY3Rpb24oUVdlYlBhZ2U6OkJhY2spOwotICAgIFFUUllfQ09NUEFS RShwYWdlLT5oaXN0b3J5KCktPmNhbkdvQmFjaygpLCBmYWxzZSk7Ci0gICAgUVRSWV9DT01QQVJF KHBhZ2UtPmhpc3RvcnkoKS0+Y2FuR29Gb3J3YXJkKCksIHRydWUpOworICAgIHBhZ2UudHJpZ2dl ckFjdGlvbihRV2ViUGFnZTo6QmFjayk7CisgICAgUVRSWV9DT01QQVJFKHBhZ2UuaGlzdG9yeSgp LT5jYW5Hb0JhY2soKSwgZmFsc2UpOworICAgIFFUUllfQ09NUEFSRShwYWdlLmhpc3RvcnkoKS0+ Y2FuR29Gb3J3YXJkKCksIHRydWUpOwogCi0gICAgcGFnZS0+dHJpZ2dlckFjdGlvbihRV2ViUGFn ZTo6Rm9yd2FyZCk7Ci0gICAgUVRSWV9DT01QQVJFKHBhZ2UtPmhpc3RvcnkoKS0+Y2FuR29CYWNr KCksIHRydWUpOwotICAgIFFUUllfQ09NUEFSRShwYWdlLT5oaXN0b3J5KCktPmNhbkdvRm9yd2Fy ZCgpLCBmYWxzZSk7CisgICAgcGFnZS50cmlnZ2VyQWN0aW9uKFFXZWJQYWdlOjpGb3J3YXJkKTsK KyAgICBRVFJZX0NPTVBBUkUocGFnZS5oaXN0b3J5KCktPmNhbkdvQmFjaygpLCB0cnVlKTsKKyAg ICBRVFJZX0NPTVBBUkUocGFnZS5oaXN0b3J5KCktPmNhbkdvRm9yd2FyZCgpLCBmYWxzZSk7CiAK LSAgICBwYWdlLT50cmlnZ2VyQWN0aW9uKFFXZWJQYWdlOjpCYWNrKTsKLSAgICBRVFJZX0NPTVBB UkUocGFnZS0+aGlzdG9yeSgpLT5jYW5Hb0JhY2soKSwgZmFsc2UpOwotICAgIFFUUllfQ09NUEFS RShwYWdlLT5oaXN0b3J5KCktPmNhbkdvRm9yd2FyZCgpLCB0cnVlKTsKLSAgICBRVFJZX0NPTVBB UkUocGFnZS0+aGlzdG9yeSgpLT5jdXJyZW50SXRlbSgpLnVybCgpLCBRVXJsKCJkYXRhOnRleHQv aHRtbCxmb28iKSk7CisgICAgcGFnZS50cmlnZ2VyQWN0aW9uKFFXZWJQYWdlOjpCYWNrKTsKKyAg ICBRVFJZX0NPTVBBUkUocGFnZS5oaXN0b3J5KCktPmNhbkdvQmFjaygpLCBmYWxzZSk7CisgICAg UVRSWV9DT01QQVJFKHBhZ2UuaGlzdG9yeSgpLT5jYW5Hb0ZvcndhcmQoKSwgdHJ1ZSk7CisgICAg UVRSWV9DT01QQVJFKHBhZ2UuaGlzdG9yeSgpLT5jdXJyZW50SXRlbSgpLnVybCgpLCBRVXJsKCJk YXRhOnRleHQvaHRtbCxmb28iKSk7CiAKICAgICBtX3ZpZXctPnNldFBhZ2UoMCk7CiB9CiAKIHZv aWQgdHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNpb25JbklGcmFtZXMoKQogewotICAgIEVy cm9yUGFnZSogcGFnZSA9IG5ldyBFcnJvclBhZ2U7Ci0gICAgbV92aWV3LT5zZXRQYWdlKHBhZ2Up OworICAgIEVycm9yUGFnZSBwYWdlOworICAgIG1fdmlldy0+c2V0UGFnZSgmcGFnZSk7CiAKICAg ICBtX3ZpZXctPnBhZ2UoKS0+bWFpbkZyYW1lKCktPmxvYWQoUVVybCgKICAgICAgICAgImRhdGE6 dGV4dC9odG1sLCIKQEAgLTI1NTYsMjIgKzI1NTYsMjIgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6OmVy cm9yUGFnZUV4dGVuc2lvbkluSUZyYW1lcygpCiAgICAgUVNpZ25hbFNweSBzcHlMb2FkRmluaXNo ZWQobV92aWV3LCBTSUdOQUwobG9hZEZpbmlzaGVkKGJvb2wpKSk7CiAgICAgUVRSWV9DT01QQVJF KHNweUxvYWRGaW5pc2hlZC5jb3VudCgpLCAxKTsKIAotICAgIFFDT01QQVJFKHBhZ2UtPm1haW5G cmFtZSgpLT5jaGlsZEZyYW1lcygpWzFdLT50b1BsYWluVGV4dCgpLCBRU3RyaW5nKCJlcnJvciIp KTsKKyAgICBRQ09NUEFSRShwYWdlLm1haW5GcmFtZSgpLT5jaGlsZEZyYW1lcygpWzFdLT50b1Bs YWluVGV4dCgpLCBRU3RyaW5nKCJlcnJvciIpKTsKIAogICAgIG1fdmlldy0+c2V0UGFnZSgwKTsK IH0KIAogdm9pZCB0c3RfUVdlYlBhZ2U6OmVycm9yUGFnZUV4dGVuc2lvbkluRnJhbWVzZXQoKQog ewotICAgIEVycm9yUGFnZSogcGFnZSA9IG5ldyBFcnJvclBhZ2U7Ci0gICAgbV92aWV3LT5zZXRQ YWdlKHBhZ2UpOworICAgIEVycm9yUGFnZSBwYWdlOworICAgIG1fdmlldy0+c2V0UGFnZSgmcGFn ZSk7CiAKICAgICBtX3ZpZXctPmxvYWQoUVVybCgicXJjOi8vL3Jlc291cmNlcy9pbmRleC5odG1s IikpOwogCiAgICAgUVNpZ25hbFNweSBzcHlMb2FkRmluaXNoZWQobV92aWV3LCBTSUdOQUwobG9h ZEZpbmlzaGVkKGJvb2wpKSk7CiAgICAgUVRSWV9DT01QQVJFKHNweUxvYWRGaW5pc2hlZC5jb3Vu dCgpLCAxKTsKLSAgICBRQ09NUEFSRShwYWdlLT5tYWluRnJhbWUoKS0+Y2hpbGRGcmFtZXMoKS5j b3VudCgpLCAyKTsKLSAgICBRQ09NUEFSRShwYWdlLT5tYWluRnJhbWUoKS0+Y2hpbGRGcmFtZXMo KVsxXS0+dG9QbGFpblRleHQoKSwgUVN0cmluZygiZXJyb3IiKSk7CisgICAgUUNPTVBBUkUocGFn ZS5tYWluRnJhbWUoKS0+Y2hpbGRGcmFtZXMoKS5jb3VudCgpLCAyKTsKKyAgICBRQ09NUEFSRShw YWdlLm1haW5GcmFtZSgpLT5jaGlsZEZyYW1lcygpWzFdLT50b1BsYWluVGV4dCgpLCBRU3RyaW5n KCJlcnJvciIpKTsKIAogICAgIG1fdmlldy0+c2V0UGFnZSgwKTsKIH0K