64809 2011-07-19 09:49:08 -0700 REGRESSION (r91114-r91116): fast/dom/error-to-string-stack-overflow.html failing on Windows 7 Release (Tests) 2011-07-19 14:51:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r91116%20(14820)/results.html LayoutTestFailure, MakingBotsRed, Regression P2 Normal --- 1 aroben webkit-unassigned barraclough sam oldest_to_newest 439214 0 aroben 2011-07-19 09:49:08 -0700 fast/dom/error-to-string-stack-overflow.html started failing on Windows 7 Release (Tests) between r91115 and r91116 (inclusive). http://trac.webkit.org/log/trunk?rev=91116&stop_rev=91115 http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r91114%20(14819)/results.html passed http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r91116%20(14820)/results.html failed 439352 1 barraclough 2011-07-19 12:21:44 -0700 investigating. 439467 2 barraclough 2011-07-19 14:41:23 -0700 I think this just needs new results. The test deliberately triggers a stack overflow, and doesn't catch it, so the error is printed to the console. Previously RangeError had the wrong prototype, and didn't convert the error into a useful error message, printing a blank line in the console. Since r91116 we inherit from Error correctly, and print the error to the console. 439471 3 aroben 2011-07-19 14:46:43 -0700 Thanks for the analysis, Gavin. Could you update the results by grabbing them from the bot? "webkit-patch rebaseline" might be the easiest way. 439476 4 101391 barraclough 2011-07-19 14:49:54 -0700 Created attachment 101391 The patch 439478 5 barraclough 2011-07-19 14:51:47 -0700 Fixed in r91305 101391 2011-07-19 14:49:54 -0700 2011-07-19 14:50:59 -0700 The patch 64809.patch text/plain 1736 barraclough SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDkxMzAzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDctMTkgIEdhdmluIEJhcnJhY2xvdWdo ICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NDgwOQorICAgICAgICBSRUdSRVNTSU9OIChyOTExMTQtcjkx MTE2KTogZmFzdC9kb20vZXJyb3ItdG8tc3RyaW5nLXN0YWNrLW92ZXJmbG93Lmh0bWwgZmFpbGlu ZyBvbiBXaW5kb3dzIDcgUmVsZWFzZSAoVGVzdHMpCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSSB0aGluayB0aGlzIGp1c3QgbmVlZHMgbmV3IHJlc3Vs dHMuIFRoZSB0ZXN0IGRlbGliZXJhdGVseSB0cmlnZ2VycyBhIHN0YWNrIG92ZXJmbG93LAorICAg ICAgICBhbmQgZG9lc24ndCBjYXRjaCBpdCwgc28gdGhlIGVycm9yIGlzIHByaW50ZWQgdG8gdGhl IGNvbnNvbGUuIFByZXZpb3VzbHkgUmFuZ2VFcnJvcgorICAgICAgICBoYWQgdGhlIHdyb25nIHBy b3RvdHlwZSwgYW5kIGRpZG4ndCBjb252ZXJ0IHRoZSBlcnJvciBpbnRvIGEgdXNlZnVsIGVycm9y IG1lc3NhZ2UsCisgICAgICAgIHByaW50aW5nIGEgYmxhbmsgbGluZSBpbiB0aGUgY29uc29sZS4g U2luY2UgcjkxMTE2IHdlIGluaGVyaXQgZnJvbSBFcnJvciBjb3JyZWN0bHksCisgICAgICAgIGFu ZCBwcmludCB0aGUgZXJyb3IgdG8gdGhlIGNvbnNvbGUuCisKKyAgICAgICAgKiBmYXN0L2RvbS9l cnJvci10by1zdHJpbmctc3RhY2stb3ZlcmZsb3ctZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZh c3QvanMvc2NyaXB0LXRlc3RzL29iamVjdC1wcm90b3R5cGUtcHJvcGVydGllcy5qczoKKwogMjAx MS0wNy0xOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBNb3Jl IENocm9taXVtIHJlYmFzZWxpbmVzIGZvciByOTEyNzcuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0 L2RvbS9lcnJvci10by1zdHJpbmctc3RhY2stb3ZlcmZsb3ctZXhwZWN0ZWQudHh0Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2Vycm9yLXRvLXN0cmluZy1zdGFjay1vdmVyZmxv dy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDkxMjgzKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20v ZXJyb3ItdG8tc3RyaW5nLXN0YWNrLW92ZXJmbG93LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5 KQpAQCAtMSw0ICsxLDQgQEAKLUNPTlNPTEUgTUVTU0FHRTogbGluZSAxNzogCitDT05TT0xFIE1F U1NBR0U6IGxpbmUgMTc6IFJhbmdlRXJyb3I6IE1heGltdW0gY2FsbCBzdGFjayBzaXplIGV4Y2Vl ZGVkLgogUmVncmVzc2lvbiB0ZXN0IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzA3NzQuIFRoaXMgdGVzdCBwYXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaC4KIAog T24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9s bG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgo=