64802 2011-07-19 09:00:44 -0700 Custom cursors cause the WebProcess to crash 2011-08-02 09:10:15 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 65459 0 amruthraj webkit-unassigned albo andersca cgarcia darin japhet mrobinson ravi.kasibhatla romaxa webkit.review.bot oldest_to_newest 439184 0 amruthraj 2011-07-19 09:00:44 -0700 With https://bugs.webkit.org/show_bug.cgi?id=64321 there can be a custom Cursor object with an empty Image. Encoding them would lead to a crash since a ShareableBitmap of size 0 would be requested. This returns a NULL and causes a crash. #0 0x00007f141d5ee05a in WebCore::IntSize::width (this=0x8) at ../../Source/WebCore/platform/graphics/IntSize.h:67 #1 0x00007f141d6051ca in WebKit::ShareableBitmap::createCairoSurface (this=0x0) at ../../Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp:69 #2 0x00007f141d604ec9 in WebKit::ShareableBitmap::createGraphicsContext (this=0x0) at ../../Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp:43 #3 0x00007f141d622f51 in CoreIPC::encodeImage (encoder=0x23a8650, image=0x23c3c50) at ../../Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:294 439241 1 101340 amruthraj 2011-07-19 10:35:07 -0700 Created attachment 101340 Handle the case of a custom cursor with a null image 439242 2 mrobinson 2011-07-19 10:36:46 -0700 Nate, what are your thoughts here? 439246 3 japhet 2011-07-19 10:40:34 -0700 (In reply to comment #2) > Nate, what are your thoughts here? It looks fine to me. I think this can be fixed in WebCore to ensure we don't send custom cursors with null Image*s to the embedder, but the patch will be much uglier than this one due to the #if(LAZY_NATIVE_CURSOR) flag. 439249 4 101340 darin 2011-07-19 10:40:36 -0700 Comment on attachment 101340 Handle the case of a custom cursor with a null image This is wrong. It will encode something that the decoder will fail to decode. We need to encode something that indicates there is no image following, perhaps a boolean. 439251 5 japhet 2011-07-19 10:42:54 -0700 (In reply to comment #4) > (From update of attachment 101340 [details]) > This is wrong. It will encode something that the decoder will fail to decode. We need to encode something that indicates there is no image following, perhaps a boolean. Darin, would prefer this just fixed in WebCore to ensure we don't send null images? I'd be happy to write that patch, but it wouldn't get fixed today. 439318 6 darin 2011-07-19 11:54:44 -0700 (In reply to comment #5) > Darin, would you prefer this just fixed in WebCore to ensure we don't send null images? I'd be happy to write that patch, but it wouldn't get fixed today. I think the right question is what behavior we want when such a cursor is specified. Once we know what behavior we want, then we can figure out how to get that behavior. We could start by figuring out what behavior we have here in WebKit1. I’m thinking that a custom cursor with an empty image should probably result in an invisible cursor. Is that right? As far as implementation is concerned, it’s OK with me to fix the encoding machinery so it can successfully send an empty custom cursor across the process boundary. I object to the incorrect patch, not the very notion of what the patch is doing. The patch is wrong because if we encode one of these, the decoder will then try to decode fields that aren’t present and consume additional bytes and thus be unable to decode the rest of the stream. That’s a relatively simple mechanical thing to fix. 439812 7 amruthraj 2011-07-20 08:09:54 -0700 (In reply to comment #6) > (In reply to comment #5) > > Darin, would you prefer this just fixed in WebCore to ensure we don't send null images? I'd be happy to write that patch, but it wouldn't get fixed today. > > I think the right question is what behavior we want when such a cursor is specified. Once we know what behavior we want, then we can figure out how to get that behavior. We could start by figuring out what behavior we have here in WebKit1. I’m thinking that a custom cursor with an empty image should probably result in an invisible cursor. Is that right? In WebKit1, GTK handles this case. In case a NULL image is sent to gdk_window_set_cursor, it uses cursor of the parent window to display. > > As far as implementation is concerned, it’s OK with me to fix the encoding machinery so it can successfully send an empty custom cursor across the process boundary. I object to the incorrect patch, not the very notion of what the patch is doing. The patch is wrong because if we encode one of these, the decoder will then try to decode fields that aren’t present and consume additional bytes and thus be unable to decode the rest of the stream. That’s a relatively simple mechanical thing to fix. I will attach a patch shortly addressing this. 439818 8 101474 amruthraj 2011-07-20 08:18:34 -0700 Created attachment 101474 Indicate the presence of a null image while encoding 439835 9 amruthraj 2011-07-20 09:19:39 -0700 It looks like individual ports needs to additionally handle this. QT port still crashes with my patch. 444495 10 darin 2011-07-31 20:21:13 -0700 *** Bug 65420 has been marked as a duplicate of this bug. *** 444525 11 romaxa 2011-07-31 22:20:58 -0700 Qt port crash with this patch: #0 0xb2e4d8c4 in operator! (this=0x0) at ../../include/QtCore/../../src/corelib/tools/qshareddata.h:198 #1 QPixmap::isNull (this=0x0) at image/qpixmap.cpp:545 #2 0xb2e4d90a in QPixmap::toImage (this=0x0) at image/qpixmap.cpp:484 #3 0xb2d78784 in QCursor::QCursor (this=0x82f1870, pixmap=..., hotX=0, hotY=0) at kernel/qcursor.cpp:313 #4 0xb5d22e2e in WebCore::createCustomCursor (image=0x82f1a08, hotSpot=...) at ../../../Source/WebCore/platform/qt/CursorQt.cpp:79 #5 0xb5d238de in WebCore::Cursor::ensurePlatformCursor (this=0xbfc484bc) at ../../../Source/WebCore/platform/qt/CursorQt.cpp:199 #6 0xb5d1ccf3 in WebCore::Cursor::platformCursor (this=0xbfc484bc) at ../../../Source/WebCore/platform/Cursor.cpp:263 #7 0xb54ae51f in QtWebPageProxy::setCursor (this=0x8283ec0, cursor=...) at ../../../Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:239 #8 0xb546f945 in WebKit::WebPageProxy::setCursor (this=0xaf702068, cursor=...) at ../../../Source/WebKit2/UIProcess/WebPageProxy.cpp:2666 #9 0xb5505535 in CoreIPC::callMemberFunction<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebCore::Cursor const&), WebCore::Cursor> (args=..., object=0xaf702068, function= (void (WebKit::WebPageProxy::*)(WebKit::WebPageProxy *, const WebCore::Cursor &)) 0xb546f920 <WebKit::WebPageProxy::setCursor(WebCore::Cursor const&)>) at ../../../Source/WebKit2/Platform/CoreIPC/HandleMessage.h:19 #10 0xb55010e8 in CoreIPC::handleMessage<Messages::WebPageProxy::SetCursor, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebCore::Cursor const&)> (argumentDecoder=0xaf7034c0, object=0xaf702068, function= (void (WebKit::WebPageProxy::*)(WebKit::WebPageProxy *, const WebCore::Cursor &)) 0xb546f920 <WebKit::WebPageProxy::setCursor(WebCore::Cursor const&)>) at ../../../Source/WebKit2/Platform/CoreIPC/HandleMessage.h:277 #11 0xb54fee14 in WebKit::WebPageProxy::didReceiveWebPageProxyMessage (this=0xaf702068, messageID=..., 444529 12 amruthraj 2011-07-31 22:37:13 -0700 Like I mentioned in comment #9, QT port needs to handle this case at the UI process. In case a null image is passed to GTK, it displays the cursor of parent window. (In reply to comment #11) > Qt port crash with this patch: > #0 0xb2e4d8c4 in operator! (this=0x0) at ../../include/QtCore/../../src/corelib/tools/qshareddata.h:198 > #1 QPixmap::isNull (this=0x0) at image/qpixmap.cpp:545 > #2 0xb2e4d90a in QPixmap::toImage (this=0x0) at image/qpixmap.cpp:484 > #3 0xb2d78784 in QCursor::QCursor (this=0x82f1870, pixmap=..., hotX=0, hotY=0) at kernel/qcursor.cpp:313 > #4 0xb5d22e2e in WebCore::createCustomCursor (image=0x82f1a08, hotSpot=...) > at ../../../Source/WebCore/platform/qt/CursorQt.cpp:79 > #5 0xb5d238de in WebCore::Cursor::ensurePlatformCursor (this=0xbfc484bc) > at ../../../Source/WebCore/platform/qt/CursorQt.cpp:199 > #6 0xb5d1ccf3 in WebCore::Cursor::platformCursor (this=0xbfc484bc) > at ../../../Source/WebCore/platform/Cursor.cpp:263 > #7 0xb54ae51f in QtWebPageProxy::setCursor (this=0x8283ec0, cursor=...) > at ../../../Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:239 > #8 0xb546f945 in WebKit::WebPageProxy::setCursor (this=0xaf702068, cursor=...) > at ../../../Source/WebKit2/UIProcess/WebPageProxy.cpp:2666 > #9 0xb5505535 in CoreIPC::callMemberFunction<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebCore::Cursor const&), WebCore::Cursor> (args=..., object=0xaf702068, function= > (void (WebKit::WebPageProxy::*)(WebKit::WebPageProxy *, const WebCore::Cursor &)) 0xb546f920 <WebKit::WebPageProxy::setCursor(WebCore::Cursor const&)>) at ../../../Source/WebKit2/Platform/CoreIPC/HandleMessage.h:19 > #10 0xb55010e8 in CoreIPC::handleMessage<Messages::WebPageProxy::SetCursor, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebCore::Cursor const&)> (argumentDecoder=0xaf7034c0, object=0xaf702068, function= > (void (WebKit::WebPageProxy::*)(WebKit::WebPageProxy *, const WebCore::Cursor &)) 0xb546f920 <WebKit::WebPageProxy::setCursor(WebCore::Cursor const&)>) at ../../../Source/WebKit2/Platform/CoreIPC/HandleMessage.h:277 > #11 0xb54fee14 in WebKit::WebPageProxy::didReceiveWebPageProxyMessage (this=0xaf702068, messageID=..., 444536 13 romaxa 2011-07-31 23:17:53 -0700 I would suggest to add image null check: static QCursor* createCustomCursor(Image* image, const IntPoint& hotSpot) { + if (image->isNull()) + return NULL; 444582 14 101474 webkit.review.bot 2011-08-01 01:49:21 -0700 Comment on attachment 101474 Indicate the presence of a null image while encoding Clearing flags on attachment: 101474 Committed r92108: <http://trac.webkit.org/changeset/92108> 444584 15 webkit.review.bot 2011-08-01 01:49:28 -0700 All reviewed patches have been landed. Closing bug. 445041 16 mrowe 2011-08-01 17:51:20 -0700 This seems to have been rolled out in r92113. 445156 17 amruthraj 2011-08-02 01:53:51 -0700 I think the problem here is that nullImage() function is not part of the export's file. I will add this and put up a new patch. (In reply to comment #16) > This seems to have been rolled out in r92113. 445180 18 102631 amruthraj 2011-08-02 04:20:35 -0700 Created attachment 102631 Add Image::nullImage() into exports to fix compilation on SL 445195 19 102635 amruthraj 2011-08-02 05:10:14 -0700 Created attachment 102635 Add Image::nullImage() into exports to fix compilation on SL 445204 20 102635 mrobinson 2011-08-02 05:20:30 -0700 Comment on attachment 102635 Add Image::nullImage() into exports to fix compilation on SL View in context: https://bugs.webkit.org/attachment.cgi?id=102635&action=review > Source/WebKit2/ChangeLog:11 > + * Shared/WebCoreArgumentCoders.cpp: > + (CoreIPC::::encode): > + (CoreIPC::::decode): > + In your previous patch you had filled these in. Why remove them? 445206 21 102637 amruthraj 2011-08-02 05:27:01 -0700 Created attachment 102637 Add comments in ChangeLog 445207 22 amruthraj 2011-08-02 05:27:56 -0700 (In reply to comment #20) > (From update of attachment 102635 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=102635&action=review > > > Source/WebKit2/ChangeLog:11 > > + * Shared/WebCoreArgumentCoders.cpp: > > + (CoreIPC::::encode): > > + (CoreIPC::::decode): > > + > > In your previous patch you had filled these in. Why remove them? Done. Added these back. 445218 23 102637 mrobinson 2011-08-02 05:41:52 -0700 Comment on attachment 102637 Add comments in ChangeLog Seems reasonable. 445232 24 102637 webkit.review.bot 2011-08-02 06:39:40 -0700 Comment on attachment 102637 Add comments in ChangeLog Clearing flags on attachment: 102637 Committed r92183: <http://trac.webkit.org/changeset/92183> 445233 25 webkit.review.bot 2011-08-02 06:39:45 -0700 All reviewed patches have been landed. Closing bug. 445306 26 ap 2011-08-02 09:10:15 -0700 *** Bug 65029 has been marked as a duplicate of this bug. *** 101340 2011-07-19 10:35:07 -0700 2011-07-20 08:18:34 -0700 Handle the case of a custom cursor with a null image fix-64802.patch text/plain 1147 amruthraj SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxMjYxKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDctMTkgIEFtcnV0aCBS YWogIDxhbXJ1dGhyYWpAbW90b3JvbGEuY29tPgorCisgICAgICAgIEN1c3RvbSBjdXJzb3JzIGNh dXNlIHRoZSBXZWJQcm9jZXNzIHRvIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NDgwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5jcHA6Cisg ICAgICAgIChDb3JlSVBDOjo6OmVuY29kZSk6CisKIDIwMTEtMDctMTggIEFsZXhpcyBNZW5hcmQg IDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgW1F0XVtXSzJdIE1ha2Ug UURlc2t0b3BXZWJWaWV3OjpuYXZpZ2F0aW9uQWN0aW9uIG1ldGhvZCB1c2FibGUgaW4gUU1MLgpJ bmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5j cHAJKHJldmlzaW9uIDkxMTc0KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1 bWVudENvZGVycy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyMSw2ICszMjEsOSBAQCB2b2lkIEFy Z3VtZW50Q29kZXI8Q3Vyc29yPjo6ZW5jb2RlKEFyZ3VtCiAgICAgaWYgKGN1cnNvci50eXBlKCkg IT0gQ3Vyc29yOjpDdXN0b20pCiAgICAgICAgIHJldHVybjsKIAorICAgIGlmIChjdXJzb3IuaW1h Z2UoKS0+aXNOdWxsKCkpCisgICAgICAgIHJldHVybjsKKwogICAgIGVuY29kZUltYWdlKGVuY29k ZXIsIGN1cnNvci5pbWFnZSgpKTsKICAgICBlbmNvZGVyLT5lbmNvZGUoY3Vyc29yLmhvdFNwb3Qo KSk7CiB9Cg== 101474 2011-07-20 08:18:34 -0700 2011-08-02 04:20:35 -0700 Indicate the presence of a null image while encoding fix-64802-1.patch text/plain 1744 amruthraj SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxMzY0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDctMjAgIEFtcnV0aCBS YWogIDxhbXJ1dGhyYWpAbW90b3JvbGEuY29tPgorCisgICAgICAgIEN1c3RvbSBjdXJzb3JzIGNh dXNlIHRoZSBXZWJQcm9jZXNzIHRvIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NDgwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5jcHA6Cisg ICAgICAgIChDb3JlSVBDOjo6OmVuY29kZSk6IEluIGNhc2Ugb2YgYSBOVUxMIGN1cnNvciBpbWFn ZSwgZW5jb2RlIGEgYm9vbCBpbmRpY2F0aW5nIHRoYXQuCisgICAgICAgIChDb3JlSVBDOjo6OmRl Y29kZSk6IERlY29kZSB0aGUgaW1hZ2Ugb25seSBpZiByZXF1aXJlZC4KKwogMjAxMS0wNy0xOSAg Unlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBmaXggYWZ0 ZXIgcjkxMzA3LgpJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENv ZGVycy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1 bWVudENvZGVycy5jcHAJKHJldmlzaW9uIDkxMzU4KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVk L1dlYkNvcmVBcmd1bWVudENvZGVycy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyMSw2ICszMjEs MTIgQEAgdm9pZCBBcmd1bWVudENvZGVyPEN1cnNvcj46OmVuY29kZShBcmd1bQogICAgIGlmIChj dXJzb3IudHlwZSgpICE9IEN1cnNvcjo6Q3VzdG9tKQogICAgICAgICByZXR1cm47CiAKKyAgICBp ZiAoY3Vyc29yLmltYWdlKCktPmlzTnVsbCgpKSB7CisgICAgICAgIGVuY29kZXItPmVuY29kZUJv b2woZmFsc2UpOyAvLyBUaGVyZSBpcyBubyB2YWxpZCBpbWFnZSBiZWluZyBlbmNvZGVkLgorICAg ICAgICByZXR1cm47CisgICAgfQorCisgICAgZW5jb2Rlci0+ZW5jb2RlQm9vbCh0cnVlKTsKICAg ICBlbmNvZGVJbWFnZShlbmNvZGVyLCBjdXJzb3IuaW1hZ2UoKSk7CiAgICAgZW5jb2Rlci0+ZW5j b2RlKGN1cnNvci5ob3RTcG90KCkpOwogfQpAQCAtMzQ0LDYgKzM1MCwxNSBAQCBib29sIEFyZ3Vt ZW50Q29kZXI8Q3Vyc29yPjo6ZGVjb2RlKEFyZ3VtCiAgICAgICAgIHJldHVybiB0cnVlOwogICAg IH0KIAorICAgIGJvb2wgaXNWYWxpZEltYWdlUHJlc2VudDsKKyAgICBpZiAoIWRlY29kZXItPmRl Y29kZShpc1ZhbGlkSW1hZ2VQcmVzZW50KSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAg aWYgKCFpc1ZhbGlkSW1hZ2VQcmVzZW50KSB7CisgICAgICAgIGN1cnNvciA9IEN1cnNvcihJbWFn ZTo6bnVsbEltYWdlKCksIEludFBvaW50KCkpOworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9 CisKICAgICBSZWZQdHI8SW1hZ2U+IGltYWdlOwogICAgIGlmICghZGVjb2RlSW1hZ2UoZGVjb2Rl ciwgaW1hZ2UpKQogICAgICAgICByZXR1cm4gZmFsc2U7Cg== 102631 2011-08-02 04:20:35 -0700 2011-08-02 05:10:14 -0700 Add Image::nullImage() into exports to fix compilation on SL fix-64802-2.patch text/plain 2940 amruthraj SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMTc3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMDIgIEFtcnV0aCBS YWogIDxhbXJ1dGhyYWpAbW90b3JvbGEuY29tPgorCisgICAgICAgIEN1c3RvbSBjdXJzb3JzIGNh dXNlIHRoZSBXZWJQcm9jZXNzIHRvIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NDgwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogV2Vi Q29yZS5leHAuaW46CisKIDIwMTEtMDgtMDIgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29n bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IF9ub3JtYWxpemVFdmVudFR5cGVzICh2 aWEgY29uc29sZSdzIG1vbml0b3JFdmVudHMpIGRvZXNudCBoYW5kbGUgYWxsIGV2ZW50cyBsaWtl ICdzZWFyY2gnIGFuZCBvdGhlciBhdHlwaWNhbCBvbmVzLgpJbmRleDogU291cmNlL1dlYkNvcmUv V2ViQ29yZS5leHAuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAu aW4JKHJldmlzaW9uIDkyMTczKQorKysgU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4JKHdv cmtpbmcgY29weSkKQEAgLTc0OCw2ICs3NDgsNyBAQCBfX1pON1dlYkNvcmU1RnJhbWU3c2V0Vmll d0VOM1dURjEwUGFzc1JlCiBfX1pON1dlYkNvcmU1RnJhbWU5bm9kZUltYWdlRVBOU180Tm9kZUUK IF9fWk43V2ViQ29yZTVGcmFtZTlzY2FsZVBhZ2VFZlJLTlNfOEludFBvaW50RQogX19aTjdXZWJD b3JlNUZyYW1lRDFFdgorX19aTjdXZWJDb3JlNUltYWdlOW51bGxJbWFnZUV2CiBfX1pON1dlYkNv cmU1SW1hZ2UxMnN1cHBvcnRzVHlwZUVSS04zV1RGNlN0cmluZ0UKIF9fWk43V2ViQ29yZTVJbWFn ZTIwbG9hZFBsYXRmb3JtUmVzb3VyY2VFUEtjCiBfX1pON1dlYkNvcmU1UmFuZ2UxMHNlbGVjdE5v ZGVFUE5TXzROb2RlRVJpCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiA5MjE3NykKKysrIFNvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEx LTA4LTAyICBBbXJ1dGggUmFqICA8YW1ydXRocmFqQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBD dXN0b20gY3Vyc29ycyBjYXVzZSB0aGUgV2ViUHJvY2VzcyB0byBjcmFzaAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ4MDIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9XZWJDb3JlQXJndW1l bnRDb2RlcnMuY3BwOgorICAgICAgICAoQ29yZUlQQzo6OjplbmNvZGUpOgorICAgICAgICAoQ29y ZUlQQzo6OjpkZWNvZGUpOgorCiAyMDExLTA4LTAxICBTY290dCBHcmFoYW0gIDxzY290dG1nQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMzk3MjU/KTogUmVzb3VyY2VzIHJl bW92ZWQgZnJvbSBkb2N1bWVudCBjYW4gbm90IGJlIGZyZWVkIHVudGlsIHRoZSBkb2N1bWVudCBp cyBkZWxldGVkCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29k ZXJzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3Vt ZW50Q29kZXJzLmNwcAkocmV2aXNpb24gOTIxNzMpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQv V2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzIxLDYgKzMyMSwx MiBAQCB2b2lkIEFyZ3VtZW50Q29kZXI8Q3Vyc29yPjo6ZW5jb2RlKEFyZ3VtCiAgICAgaWYgKGN1 cnNvci50eXBlKCkgIT0gQ3Vyc29yOjpDdXN0b20pCiAgICAgICAgIHJldHVybjsKIAorICAgIGlm IChjdXJzb3IuaW1hZ2UoKS0+aXNOdWxsKCkpIHsKKyAgICAgICAgZW5jb2Rlci0+ZW5jb2RlQm9v bChmYWxzZSk7IC8vIFRoZXJlIGlzIG5vIHZhbGlkIGltYWdlIGJlaW5nIGVuY29kZWQuCisgICAg ICAgIHJldHVybjsKKyAgICB9CisKKyAgICBlbmNvZGVyLT5lbmNvZGVCb29sKHRydWUpOwogICAg IGVuY29kZUltYWdlKGVuY29kZXIsIGN1cnNvci5pbWFnZSgpKTsKICAgICBlbmNvZGVyLT5lbmNv ZGUoY3Vyc29yLmhvdFNwb3QoKSk7CiB9CkBAIC0zNDQsNiArMzUwLDE1IEBAIGJvb2wgQXJndW1l bnRDb2RlcjxDdXJzb3I+OjpkZWNvZGUoQXJndW0KICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAg fQogCisgICAgYm9vbCBpc1ZhbGlkSW1hZ2VQcmVzZW50OworICAgIGlmICghZGVjb2Rlci0+ZGVj b2RlKGlzVmFsaWRJbWFnZVByZXNlbnQpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBp ZiAoIWlzVmFsaWRJbWFnZVByZXNlbnQpIHsKKyAgICAgICAgY3Vyc29yID0gQ3Vyc29yKEltYWdl OjpudWxsSW1hZ2UoKSwgSW50UG9pbnQoKSk7CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0K KwogICAgIFJlZlB0cjxJbWFnZT4gaW1hZ2U7CiAgICAgaWYgKCFkZWNvZGVJbWFnZShkZWNvZGVy LCBpbWFnZSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsK 102635 2011-08-02 05:10:14 -0700 2011-08-02 05:27:01 -0700 Add Image::nullImage() into exports to fix compilation on SL fix-64802-3.patch text/plain 2907 amruthraj SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMTc4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgtMDIgIEFtcnV0aCBS YWogIDxhbXJ1dGhyYWpAbW90b3JvbGEuY29tPgorCisgICAgICAgIEN1c3RvbSBjdXJzb3JzIGNh dXNlIHRoZSBXZWJQcm9jZXNzIHRvIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NDgwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogV2ViQ29yZS5leHAuaW46CisKIDIwMTEtMDgtMDIgIFBhdmVs IEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IF9ub3JtYWxpemVFdmVudFR5cGVzICh2aWEgY29uc29sZSdzIG1vbml0b3JFdmVudHMpIGRvZXNu dCBoYW5kbGUgYWxsIGV2ZW50cyBsaWtlICdzZWFyY2gnIGFuZCBvdGhlciBhdHlwaWNhbCBvbmVz LgpJbmRleDogU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4JKHJldmlzaW9uIDkyMTczKQorKysgU291cmNlL1dl YkNvcmUvV2ViQ29yZS5leHAuaW4JKHdvcmtpbmcgY29weSkKQEAgLTc0OCw2ICs3NDgsNyBAQCBf X1pON1dlYkNvcmU1RnJhbWU3c2V0Vmlld0VOM1dURjEwUGFzc1JlCiBfX1pON1dlYkNvcmU1RnJh bWU5bm9kZUltYWdlRVBOU180Tm9kZUUKIF9fWk43V2ViQ29yZTVGcmFtZTlzY2FsZVBhZ2VFZlJL TlNfOEludFBvaW50RQogX19aTjdXZWJDb3JlNUZyYW1lRDFFdgorX19aTjdXZWJDb3JlNUltYWdl OW51bGxJbWFnZUV2CiBfX1pON1dlYkNvcmU1SW1hZ2UxMnN1cHBvcnRzVHlwZUVSS04zV1RGNlN0 cmluZ0UKIF9fWk43V2ViQ29yZTVJbWFnZTIwbG9hZFBsYXRmb3JtUmVzb3VyY2VFUEtjCiBfX1pO N1dlYkNvcmU1UmFuZ2UxMHNlbGVjdE5vZGVFUE5TXzROb2RlRVJpCkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShy ZXZpc2lvbiA5MjE3OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTA4LTAyICBBbXJ1dGggUmFqICA8YW1ydXRocmFqQG1v dG9yb2xhLmNvbT4KKworICAgICAgICBDdXN0b20gY3Vyc29ycyBjYXVzZSB0aGUgV2ViUHJvY2Vz cyB0byBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjQ4MDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuY3BwOgorICAgICAgICAoQ29yZUlQQzo6 OjplbmNvZGUpOgorICAgICAgICAoQ29yZUlQQzo6OjpkZWNvZGUpOgorCiAyMDExLTA4LTAxICBT Y290dCBHcmFoYW0gIDxzY290dG1nQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9O IChyMzk3MjU/KTogUmVzb3VyY2VzIHJlbW92ZWQgZnJvbSBkb2N1bWVudCBjYW4gbm90IGJlIGZy ZWVkIHVudGlsIHRoZSBkb2N1bWVudCBpcyBkZWxldGVkCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9T aGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcAkocmV2aXNpb24gOTIxNzMpCisr KyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMzIxLDYgKzMyMSwxMiBAQCB2b2lkIEFyZ3VtZW50Q29kZXI8Q3Vyc29yPjo6 ZW5jb2RlKEFyZ3VtCiAgICAgaWYgKGN1cnNvci50eXBlKCkgIT0gQ3Vyc29yOjpDdXN0b20pCiAg ICAgICAgIHJldHVybjsKIAorICAgIGlmIChjdXJzb3IuaW1hZ2UoKS0+aXNOdWxsKCkpIHsKKyAg ICAgICAgZW5jb2Rlci0+ZW5jb2RlQm9vbChmYWxzZSk7IC8vIFRoZXJlIGlzIG5vIHZhbGlkIGlt YWdlIGJlaW5nIGVuY29kZWQuCisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBlbmNvZGVy LT5lbmNvZGVCb29sKHRydWUpOwogICAgIGVuY29kZUltYWdlKGVuY29kZXIsIGN1cnNvci5pbWFn ZSgpKTsKICAgICBlbmNvZGVyLT5lbmNvZGUoY3Vyc29yLmhvdFNwb3QoKSk7CiB9CkBAIC0zNDQs NiArMzUwLDE1IEBAIGJvb2wgQXJndW1lbnRDb2RlcjxDdXJzb3I+OjpkZWNvZGUoQXJndW0KICAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCisgICAgYm9vbCBpc1ZhbGlkSW1hZ2VQcmVzZW50 OworICAgIGlmICghZGVjb2Rlci0+ZGVjb2RlKGlzVmFsaWRJbWFnZVByZXNlbnQpKQorICAgICAg ICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAoIWlzVmFsaWRJbWFnZVByZXNlbnQpIHsKKyAgICAg ICAgY3Vyc29yID0gQ3Vyc29yKEltYWdlOjpudWxsSW1hZ2UoKSwgSW50UG9pbnQoKSk7CisgICAg ICAgIHJldHVybiB0cnVlOworICAgIH0KKwogICAgIFJlZlB0cjxJbWFnZT4gaW1hZ2U7CiAgICAg aWYgKCFkZWNvZGVJbWFnZShkZWNvZGVyLCBpbWFnZSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsK 102637 2011-08-02 05:27:01 -0700 2011-08-02 06:39:40 -0700 Add comments in ChangeLog fix-64802-3.patch text/plain 3005 amruthraj SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMTc4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgtMDIgIEFtcnV0aCBS YWogIDxhbXJ1dGhyYWpAbW90b3JvbGEuY29tPgorCisgICAgICAgIEN1c3RvbSBjdXJzb3JzIGNh dXNlIHRoZSBXZWJQcm9jZXNzIHRvIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NDgwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogV2ViQ29yZS5leHAuaW46CisKIDIwMTEtMDgtMDIgIFBhdmVs IEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IF9ub3JtYWxpemVFdmVudFR5cGVzICh2aWEgY29uc29sZSdzIG1vbml0b3JFdmVudHMpIGRvZXNu dCBoYW5kbGUgYWxsIGV2ZW50cyBsaWtlICdzZWFyY2gnIGFuZCBvdGhlciBhdHlwaWNhbCBvbmVz LgpJbmRleDogU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4JKHJldmlzaW9uIDkyMTczKQorKysgU291cmNlL1dl YkNvcmUvV2ViQ29yZS5leHAuaW4JKHdvcmtpbmcgY29weSkKQEAgLTc0OCw2ICs3NDgsNyBAQCBf X1pON1dlYkNvcmU1RnJhbWU3c2V0Vmlld0VOM1dURjEwUGFzc1JlCiBfX1pON1dlYkNvcmU1RnJh bWU5bm9kZUltYWdlRVBOU180Tm9kZUUKIF9fWk43V2ViQ29yZTVGcmFtZTlzY2FsZVBhZ2VFZlJL TlNfOEludFBvaW50RQogX19aTjdXZWJDb3JlNUZyYW1lRDFFdgorX19aTjdXZWJDb3JlNUltYWdl OW51bGxJbWFnZUV2CiBfX1pON1dlYkNvcmU1SW1hZ2UxMnN1cHBvcnRzVHlwZUVSS04zV1RGNlN0 cmluZ0UKIF9fWk43V2ViQ29yZTVJbWFnZTIwbG9hZFBsYXRmb3JtUmVzb3VyY2VFUEtjCiBfX1pO N1dlYkNvcmU1UmFuZ2UxMHNlbGVjdE5vZGVFUE5TXzROb2RlRVJpCkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShy ZXZpc2lvbiA5MjE3OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTA4LTAyICBBbXJ1dGggUmFqICA8YW1ydXRocmFqQG1v dG9yb2xhLmNvbT4KKworICAgICAgICBDdXN0b20gY3Vyc29ycyBjYXVzZSB0aGUgV2ViUHJvY2Vz cyB0byBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjQ4MDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuY3BwOgorICAgICAgICAoQ29yZUlQQzo6 OjplbmNvZGUpOiBJbiBjYXNlIG9mIGEgTlVMTCBjdXJzb3IgaW1hZ2UsIGVuY29kZSBhIGJvb2wg aW5kaWNhdGluZyB0aGF0LgorICAgICAgICAoQ29yZUlQQzo6OjpkZWNvZGUpOiBEZWNvZGUgdGhl IGltYWdlIG9ubHkgaWYgcmVxdWlyZWQuCisKIDIwMTEtMDgtMDEgIFNjb3R0IEdyYWhhbSAgPHNj b3R0bWdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIzOTcyNT8pOiBSZXNv dXJjZXMgcmVtb3ZlZCBmcm9tIGRvY3VtZW50IGNhbiBub3QgYmUgZnJlZWQgdW50aWwgdGhlIGRv Y3VtZW50IGlzIGRlbGV0ZWQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJDb3JlQXJn dW1lbnRDb2RlcnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJD b3JlQXJndW1lbnRDb2RlcnMuY3BwCShyZXZpc2lvbiA5MjE3MykKKysrIFNvdXJjZS9XZWJLaXQy L1NoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMjEs NiArMzIxLDEyIEBAIHZvaWQgQXJndW1lbnRDb2RlcjxDdXJzb3I+OjplbmNvZGUoQXJndW0KICAg ICBpZiAoY3Vyc29yLnR5cGUoKSAhPSBDdXJzb3I6OkN1c3RvbSkKICAgICAgICAgcmV0dXJuOwog CisgICAgaWYgKGN1cnNvci5pbWFnZSgpLT5pc051bGwoKSkgeworICAgICAgICBlbmNvZGVyLT5l bmNvZGVCb29sKGZhbHNlKTsgLy8gVGhlcmUgaXMgbm8gdmFsaWQgaW1hZ2UgYmVpbmcgZW5jb2Rl ZC4KKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIGVuY29kZXItPmVuY29kZUJvb2wodHJ1 ZSk7CiAgICAgZW5jb2RlSW1hZ2UoZW5jb2RlciwgY3Vyc29yLmltYWdlKCkpOwogICAgIGVuY29k ZXItPmVuY29kZShjdXJzb3IuaG90U3BvdCgpKTsKIH0KQEAgLTM0NCw2ICszNTAsMTUgQEAgYm9v bCBBcmd1bWVudENvZGVyPEN1cnNvcj46OmRlY29kZShBcmd1bQogICAgICAgICByZXR1cm4gdHJ1 ZTsKICAgICB9CiAKKyAgICBib29sIGlzVmFsaWRJbWFnZVByZXNlbnQ7CisgICAgaWYgKCFkZWNv ZGVyLT5kZWNvZGUoaXNWYWxpZEltYWdlUHJlc2VudCkpCisgICAgICAgIHJldHVybiBmYWxzZTsK KworICAgIGlmICghaXNWYWxpZEltYWdlUHJlc2VudCkgeworICAgICAgICBjdXJzb3IgPSBDdXJz b3IoSW1hZ2U6Om51bGxJbWFnZSgpLCBJbnRQb2ludCgpKTsKKyAgICAgICAgcmV0dXJuIHRydWU7 CisgICAgfQorCiAgICAgUmVmUHRyPEltYWdlPiBpbWFnZTsKICAgICBpZiAoIWRlY29kZUltYWdl KGRlY29kZXIsIGltYWdlKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwo=