64795 2011-07-19 06:24:05 -0700 update FontSkia to match platform context convention 2011-07-20 12:31:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 caryclark caryclark brettw eric jamesr webkit.review.bot oldest_to_newest 439117 0 caryclark 2011-07-19 06:24:05 -0700 update FontSkia to match platform context convention 439126 1 101311 caryclark 2011-07-19 06:56:50 -0700 Created attachment 101311 Patch 439366 2 101311 eric 2011-07-19 12:31:19 -0700 Comment on attachment 101311 Patch I'm not sure what this does. I assume Skia changed their API? 439411 3 caryclark 2011-07-19 13:41:48 -0700 Looks like jamesr renamed this in https://bugs.webkit.org/show_bug.cgi?id=64214 439460 4 101311 jamesr 2011-07-19 14:31:59 -0700 Comment on attachment 101311 Patch I'm surprised that WebKit compiles without this patch. What's going on with this file? 439743 5 caryclark 2011-07-20 04:46:11 -0700 This file is used to support running Skia on Chromium Mac port. It is compiled for now only when GYP_DEFINES="use_skia=1" 439928 6 101311 webkit.review.bot 2011-07-20 12:31:21 -0700 Comment on attachment 101311 Patch Clearing flags on attachment: 101311 Committed r91388: <http://trac.webkit.org/changeset/91388> 439929 7 webkit.review.bot 2011-07-20 12:31:27 -0700 All reviewed patches have been landed. Closing bug. 101311 2011-07-19 06:56:50 -0700 2011-07-20 12:31:21 -0700 Patch bug-64795-20110719095649.patch text/plain 1463 caryclark SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxMjUxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDctMTkgIENhcnkgQ2xh cmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4KKworICAgICAgICB1cGRhdGUgRm9udFNraWEgdG8g bWF0Y2ggcGxhdGZvcm0gY29udGV4dCBjb252ZW50aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDc5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBwbGF0Zm9ybSB2YXJp YW50IGlzIG5vdAorICAgICAgICBidWlsdCBhdCB0aGlzIHRpbWUuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9za2lhL0ZvbnRTa2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnQ6 OmRyYXdHbHlwaHMpOgorICAgICAgICBDYWxsIG1ha2VHckNvbnRleHRDdXJyZW50IGluc3RlYWQg b2YgdGhlIG9ic29sZXRlIHByZXBhcmVGb3JTb2Z0d2FyZURyYXcuCisKIDIwMTEtMDctMTkgIFZz ZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogUmVuYW1lIGFnZW50SWRlbnRpZmllclByZWZpeCB0byBwcm9jZXNzSWQsIG1vdmUgb3V0 IGZyb20gcGFnZSBhZ2VudCBhbmQgbWFrZSBzdGF0aWMuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9za2lhL0ZvbnRTa2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ZvbnRTa2lhLmNwcAkocmV2aXNpb24gOTEy NDkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ZvbnRTa2lhLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTI5LDcgKzEyOSw3IEBAIHZvaWQgRm9udDo6ZHJhd0dseXBo cyhHcmFwaGljc0NvbnRleHQqIGcKICAgICAgICAgeSArPSBTa0Zsb2F0VG9TY2FsYXIoYWR2W2ld LmhlaWdodCk7CiAgICAgfQogCi0gICAgZ2MtPnBsYXRmb3JtQ29udGV4dCgpLT5wcmVwYXJlRm9y U29mdHdhcmVEcmF3KCk7CisgICAgZ2MtPnBsYXRmb3JtQ29udGV4dCgpLT5tYWtlR3JDb250ZXh0 Q3VycmVudCgpOwogCiAgICAgU2tDYW52YXMqIGNhbnZhcyA9IGdjLT5wbGF0Zm9ybUNvbnRleHQo KS0+Y2FudmFzKCk7CiAgICAgVGV4dERyYXdpbmdNb2RlRmxhZ3MgdGV4dE1vZGUgPSBnYy0+cGxh dGZvcm1Db250ZXh0KCktPmdldFRleHREcmF3aW5nTW9kZSgpOwo=