64782 2011-07-18 22:12:47 -0700 Possible unintentional early return in CSSStyleSelector::applyProperty() for CSSPropertyWebkitTextEmphasisStyle. 2011-08-02 16:51:54 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 64784 64785 65517 1 macpherson webkit-unassigned hyatt macpherson mitz simon.fraser oldest_to_newest 438961 0 macpherson 2011-07-18 22:12:47 -0700 Just looking at CSSStyleSelector::applyProperty() for the CSSPropertyWebkitTextEmphasisStyle case, and I see: HANDLE_INHERIT_AND_INITIAL(textEmphasisFill, TextEmphasisFill) HANDLE_INHERIT_AND_INITIAL(textEmphasisMark, TextEmphasisMark) HANDLE_INHERIT_AND_INITIAL(textEmphasisCustomMark, TextEmphasisCustomMark) if (isInherit || isInitial) return; I wanted to check with mitz (svn blame owner) this was the intended behavior - though the more I look at it the more unlikely that seems. Currently the HANDLE_INHERIT_AND_INITIAL macro will return immediately in the TextEmphasisFill case when (isInherit || isInitial), so the subsequent code is unreachable. If you can confirm that the intended behavior was to call all three cases, I'll fix it up during an upcoming refactoring. 438962 1 macpherson 2011-07-18 22:19:44 -0700 Hmm, I notice the same logical error happens for CSSPropertyWebkitTransformOrigin and CSSPropertyWebkitPerspectiveOrigin have the same issue. Just goes to show how bad hiding a return statement inside a macro is. 438963 2 mitz 2011-07-18 22:21:18 -0700 Thanks for noticing this! 438964 3 simon.fraser 2011-07-18 22:26:58 -0700 I hate those macros! 438966 4 macpherson 2011-07-18 22:36:17 -0700 Working on it, hopefully all those macros will be gone soon.