64775 2011-07-18 19:48:57 -0700 webkit-patch rebaseline crashes on use 2011-07-19 09:13:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam abarth aroben oldest_to_newest 438933 0 sam 2011-07-18 19:48:57 -0700 When trying to rebaseline the Leopard machines, webkit-patch crashes: :-( weinig@il0301a-dhcp72:.../OpenSource/LayoutTests> webkit-patch rebaseline 16 builders failing Which builder to pull results from: 1. Leopard Intel Release (Tests) 2. Leopard Intel Debug (Tests) 3. SnowLeopard Intel Release (Tests) 4. SnowLeopard Intel Debug (Tests) 5. SnowLeopard Intel Leaks 6. SnowLeopard Intel Release (WebKit2 Tests) 7. SnowLeopard Intel Debug (WebKit2 Tests) 8. Windows 7 Release (Tests) 9. Windows XP Debug (Tests) 10. Windows 7 Release (WebKit2 Tests) 11. GTK Linux 32-bit Release 12. GTK Linux 32-bit Debug 13. GTK Linux 64-bit Debug 14. Qt Linux Release 15. SnowLeopard Intel Release (NRWT) 16. CSSRegions SnowLeopard Intel Release (Build) Enter a number: 1 Traceback (most recent call last): File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkit-patch", line 66, in <module> main() File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkit-patch", line 61, in main WebKitPatch(__file__).main() File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 165, in execute for test in self._tests_to_update(build): File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 152, in _tests_to_update failing_tests = build.layout_test_results().tests_matching_failure_types([test_failures.FailureTextMismatch]) File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkitpy/common/net/layouttestresults.py", line 167, in tests_matching_failure_types return [result.filename for result in self.results_matching_failure_types(failure_types)] AttributeError: 'TestResult' object has no attribute 'filename' 439163 1 101324 sam 2011-07-19 08:48:18 -0700 Created attachment 101324 Patch 439171 2 101324 aroben 2011-07-19 08:56:13 -0700 Comment on attachment 101324 Patch No test!?!?!?!? 439193 3 101328 sam 2011-07-19 09:09:51 -0700 Created attachment 101328 Patch 439195 4 sam 2011-07-19 09:13:39 -0700 Committed r91261: <http://trac.webkit.org/changeset/91261> 101324 2011-07-19 08:48:18 -0700 2011-07-19 09:09:48 -0700 Patch bug-64775-20110719084817.patch text/plain 1447 sam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkxMjU3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDctMTkgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAg ICAgICB3ZWJraXQtcGF0Y2ggcmViYXNlbGluZSBjcmFzaGVzIG9uIHVzZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ3NzUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggaW5jb3JyZWN0bHkgc3BlbGxl ZCBhdHRyaWJ1dGUgbmFtZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL25l dC9sYXlvdXR0ZXN0cmVzdWx0cy5weToKKyAgICAgICAgVGhlIGF0dHJpYnV0ZSBpcyB0ZXN0X25h bWUsIG5vdCBmaWxlbmFtZS4KKwogMjAxMS0wNy0xOCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtp dC5vcmc+CiAKICAgICAgICAgbmV3LXJ1bi13ZWJraXQtdGVzdHMgc2hvdWxkIHN1cHBvcnQgLS1s ZWFrcwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2xheW91dHRlc3Ry ZXN1bHRzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25l dC9sYXlvdXR0ZXN0cmVzdWx0cy5weQkocmV2aXNpb24gOTEyMzMpCisrKyBUb29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9uZXQvbGF5b3V0dGVzdHJlc3VsdHMucHkJKHdvcmtpbmcgY29weSkK QEAgLTE2NCw3ICsxNjQsNyBAQCBjbGFzcyBMYXlvdXRUZXN0UmVzdWx0cyhvYmplY3QpOgogICAg ICAgICByZXR1cm4gW3Jlc3VsdCBmb3IgcmVzdWx0IGluIHNlbGYuX3Rlc3RfcmVzdWx0cyBpZiBy ZXN1bHQuaGFzX2ZhaWx1cmVfbWF0Y2hpbmdfdHlwZXMoKmZhaWx1cmVfdHlwZXMpXQogCiAgICAg ZGVmIHRlc3RzX21hdGNoaW5nX2ZhaWx1cmVfdHlwZXMoc2VsZiwgZmFpbHVyZV90eXBlcyk6Ci0g ICAgICAgIHJldHVybiBbcmVzdWx0LmZpbGVuYW1lIGZvciByZXN1bHQgaW4gc2VsZi5yZXN1bHRz X21hdGNoaW5nX2ZhaWx1cmVfdHlwZXMoZmFpbHVyZV90eXBlcyldCisgICAgICAgIHJldHVybiBb cmVzdWx0LnRlc3RfbmFtZSBmb3IgcmVzdWx0IGluIHNlbGYucmVzdWx0c19tYXRjaGluZ19mYWls dXJlX3R5cGVzKGZhaWx1cmVfdHlwZXMpXQogCiAgICAgZGVmIGZhaWxpbmdfdGVzdF9yZXN1bHRz KHNlbGYpOgogICAgICAgICAjIFRoZXNlIHNob3VsZCBtYXRjaCB0aGUgImZhaWwiLCAiY3Jhc2gi LCBhbmQgInRpbWVvdXQiIGtleXMuCg== 101328 2011-07-19 09:09:51 -0700 2011-07-19 09:12:26 -0700 Patch bug-64775-20110719090950.patch text/plain 4652 sam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkxMjYwKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTggQEAKKzIwMTEtMDctMTkgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAg ICAgICB3ZWJraXQtcGF0Y2ggcmViYXNlbGluZSBjcmFzaGVzIG9uIHVzZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ3NzUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggaW5jb3JyZWN0bHkgc3BlbGxl ZCBhdHRyaWJ1dGUgbmFtZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL25l dC9sYXlvdXR0ZXN0cmVzdWx0cy5weToKKyAgICAgICAgVGhlIGF0dHJpYnV0ZSBpcyB0ZXN0X25h bWUsIG5vdCBmaWxlbmFtZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL25l dC9sYXlvdXR0ZXN0cmVzdWx0c191bml0dGVzdC5weToKKyAgICAgICAgQWRkIHRlc3QgZm9yIHRl c3RzX21hdGNoaW5nX2ZhaWx1cmVfdHlwZXMuCisKIDIwMTEtMDctMTggIEVyaWMgU2VpZGVsICA8 ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3RzIHNob3VsZCBz dXBwb3J0IC0tbGVha3MKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9s YXlvdXR0ZXN0cmVzdWx0cy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9uZXQvbGF5b3V0dGVzdHJlc3VsdHMucHkJKHJldmlzaW9uIDkxMjMzKQorKysgVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2xheW91dHRlc3RyZXN1bHRzLnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC0xNjQsNyArMTY0LDcgQEAgY2xhc3MgTGF5b3V0VGVzdFJlc3VsdHMob2Jq ZWN0KToKICAgICAgICAgcmV0dXJuIFtyZXN1bHQgZm9yIHJlc3VsdCBpbiBzZWxmLl90ZXN0X3Jl c3VsdHMgaWYgcmVzdWx0Lmhhc19mYWlsdXJlX21hdGNoaW5nX3R5cGVzKCpmYWlsdXJlX3R5cGVz KV0KIAogICAgIGRlZiB0ZXN0c19tYXRjaGluZ19mYWlsdXJlX3R5cGVzKHNlbGYsIGZhaWx1cmVf dHlwZXMpOgotICAgICAgICByZXR1cm4gW3Jlc3VsdC5maWxlbmFtZSBmb3IgcmVzdWx0IGluIHNl bGYucmVzdWx0c19tYXRjaGluZ19mYWlsdXJlX3R5cGVzKGZhaWx1cmVfdHlwZXMpXQorICAgICAg ICByZXR1cm4gW3Jlc3VsdC50ZXN0X25hbWUgZm9yIHJlc3VsdCBpbiBzZWxmLnJlc3VsdHNfbWF0 Y2hpbmdfZmFpbHVyZV90eXBlcyhmYWlsdXJlX3R5cGVzKV0KIAogICAgIGRlZiBmYWlsaW5nX3Rl c3RfcmVzdWx0cyhzZWxmKToKICAgICAgICAgIyBUaGVzZSBzaG91bGQgbWF0Y2ggdGhlICJmYWls IiwgImNyYXNoIiwgYW5kICJ0aW1lb3V0IiBrZXlzLgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vbmV0L2xheW91dHRlc3RyZXN1bHRzX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9sYXlvdXR0ZXN0cmVzdWx0c191 bml0dGVzdC5weQkocmV2aXNpb24gOTEyMzMpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9uZXQvbGF5b3V0dGVzdHJlc3VsdHNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAg LTYxLDYgKzYxLDQ5IEBAIGNsYXNzIE9SV1RSZXN1bHRzSFRNTFBhcnNlclRlc3QodW5pdHRlc3QK IDwvaHRtbD4KICIiIgogCisgICAgX2V4YW1wbGVfcmVzdWx0c19odG1sX3dpdGhfZmFpbGluZ190 ZXN0cyA9ICIiIgorPGh0bWw+Cis8aGVhZD4KKzx0aXRsZT5MYXlvdXQgVGVzdCBSZXN1bHRzPC90 aXRsZT4KKzwvaGVhZD4KKzxib2R5PgorPHA+VGVzdHMgd2hlcmUgcmVzdWx0cyBkaWQgbm90IG1h dGNoIGV4cGVjdGVkIHJlc3VsdHM6PC9wPgorPHRhYmxlPgorPHRyPgorPHRkPjxhIGhyZWY9Imh0 dHA6Ly90cmFjLndlYmtpdC5vcmcvZXhwb3J0LzkxMjQ1L3RydW5rL0xheW91dFRlc3RzL2NvbXBv c2l0aW5nL3BsdWdpbnMvY29tcG9zaXRlZC1wbHVnaW4uaHRtbCI+Y29tcG9zaXRpbmcvcGx1Z2lu cy9jb21wb3NpdGVkLXBsdWdpbi5odG1sPC9hPjwvdGQ+Cis8dGQ+Cis8YSBocmVmPSJjb21wb3Np dGluZy9wbHVnaW5zL2NvbXBvc2l0ZWQtcGx1Z2luLWV4cGVjdGVkLnR4dCI+ZXhwZWN0ZWQ8L2E+ Cis8L3RkPgorPHRkPgorPGEgaHJlZj0iY29tcG9zaXRpbmcvcGx1Z2lucy9jb21wb3NpdGVkLXBs dWdpbi1hY3R1YWwudHh0Ij5hY3R1YWw8L2E+Cis8L3RkPgorPHRkPgorPGEgaHJlZj0iY29tcG9z aXRpbmcvcGx1Z2lucy9jb21wb3NpdGVkLXBsdWdpbi1kaWZmcy50eHQiPmRpZmY8L2E+Cis8L3Rk PgorPHRkPgorPGEgaHJlZj0iY29tcG9zaXRpbmcvcGx1Z2lucy9jb21wb3NpdGVkLXBsdWdpbi1w cmV0dHktZGlmZi5odG1sIj5wcmV0dHkgZGlmZjwvYT4KKzwvdGQ+Cis8L3RyPgorPC90YWJsZT4K KzxwPlRlc3RzIHRoYXQgaGFkIHN0ZGVyciBvdXRwdXQ6PC9wPgorPHRhYmxlPgorPHRyPgorPHRk PjxhIGhyZWY9Ii92YXIvbGliL2J1aWxkYm90L2J1aWxkL2d0ay1saW51eC02NC1yZWxlYXNlL2J1 aWxkL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvYXJpYS1hY3RpdmVkZXNjZW5kYW50LWNyYXNo Lmh0bWwiPmFjY2Vzc2liaWxpdHkvYXJpYS1hY3RpdmVkZXNjZW5kYW50LWNyYXNoLmh0bWw8L2E+ PC90ZD4KKzx0ZD48YSBocmVmPSJhY2Nlc3NpYmlsaXR5L2FyaWEtYWN0aXZlZGVzY2VuZGFudC1j cmFzaC1zdGRlcnIudHh0Ij5zdGRlcnI8L2E+PC90ZD4KKzwvdHI+Cis8dGQ+PGEgaHJlZj0iL3Zh ci9saWIvYnVpbGRib3QvYnVpbGQvZ3RrLWxpbnV4LTY0LXJlbGVhc2UvYnVpbGQvTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9zZWN1cml0eS9jYW52YXMtcmVtb3RlLXJlYWQtc3ZnLWltYWdlLmh0bWwi Pmh0dHAvdGVzdHMvc2VjdXJpdHkvY2FudmFzLXJlbW90ZS1yZWFkLXN2Zy1pbWFnZS5odG1sPC9h PjwvdGQ+Cis8dGQ+PGEgaHJlZj0iaHR0cC90ZXN0cy9zZWN1cml0eS9jYW52YXMtcmVtb3RlLXJl YWQtc3ZnLWltYWdlLXN0ZGVyci50eHQiPnN0ZGVycjwvYT48L3RkPgorPC90cj4KKzwvdGFibGU+ PHA+VGVzdHMgdGhhdCBoYWQgbm8gZXhwZWN0ZWQgcmVzdWx0cyAocHJvYmFibHkgbmV3KTo8L3A+ Cis8dGFibGU+Cis8dHI+Cis8dGQ+PGEgaHJlZj0iL3Zhci9saWIvYnVpbGRib3QvYnVpbGQvZ3Rr LWxpbnV4LTY0LXJlbGVhc2UvYnVpbGQvTGF5b3V0VGVzdHMvZmFzdC9yZXBhaW50L25vLWNhcmV0 LXJlcGFpbnQtaW4tbm9uLWNvbnRlbnQtZWRpdGFibGUtZWxlbWVudC5odG1sIj5mYXN0L3JlcGFp bnQvbm8tY2FyZXQtcmVwYWludC1pbi1ub24tY29udGVudC1lZGl0YWJsZS1lbGVtZW50Lmh0bWw8 L2E+PC90ZD4KKzx0ZD48YSBocmVmPSJmYXN0L3JlcGFpbnQvbm8tY2FyZXQtcmVwYWludC1pbi1u b24tY29udGVudC1lZGl0YWJsZS1lbGVtZW50LWFjdHVhbC50eHQiPnJlc3VsdDwvYT48L3RkPgor PC90cj4KKzwvdGFibGU+PC9ib2R5PgorPC9odG1sPgorIiIiCisKICAgICBkZWYgdGVzdF9wYXJz ZV9sYXlvdXRfdGVzdF9yZXN1bHRzKHNlbGYpOgogICAgICAgICBmYWlsdXJlcyA9IFt0ZXN0X2Zh aWx1cmVzLkZhaWx1cmVNaXNzaW5nUmVzdWx0KCksIHRlc3RfZmFpbHVyZXMuRmFpbHVyZU1pc3Np bmdJbWFnZUhhc2goKSwgdGVzdF9mYWlsdXJlcy5GYWlsdXJlTWlzc2luZ0ltYWdlKCldCiAgICAg ICAgIHRlc3RuYW1lID0gJ2Zhc3QvcmVwYWludC9uby1jYXJldC1yZXBhaW50LWluLW5vbi1jb250 ZW50LWVkaXRhYmxlLWVsZW1lbnQuaHRtbCcKQEAgLTk2LDMgKzEzOSw4IEBAIGNsYXNzIExheW91 dFRlc3RSZXN1bHRzVGVzdCh1bml0dGVzdC5UZXMKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChM YXlvdXRUZXN0UmVzdWx0cy5yZXN1bHRzX2Zyb21fc3RyaW5nKCIiKSwgTm9uZSkKICAgICAgICAg cmVzdWx0cyA9IExheW91dFRlc3RSZXN1bHRzLnJlc3VsdHNfZnJvbV9zdHJpbmcoT1JXVFJlc3Vs dHNIVE1MUGFyc2VyVGVzdC5fZXhhbXBsZV9yZXN1bHRzX2h0bWwpCiAgICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWwobGVuKHJlc3VsdHMuZmFpbGluZ190ZXN0cygpKSwgMCkKKworICAgIGRlZiB0ZXN0 X3Rlc3RzX21hdGNoaW5nX2ZhaWx1cmVfdHlwZXMoc2VsZik6CisgICAgICAgIHJlc3VsdHMgPSBM YXlvdXRUZXN0UmVzdWx0cy5yZXN1bHRzX2Zyb21fc3RyaW5nKE9SV1RSZXN1bHRzSFRNTFBhcnNl clRlc3QuX2V4YW1wbGVfcmVzdWx0c19odG1sX3dpdGhfZmFpbGluZ190ZXN0cykKKyAgICAgICAg ZmFpbGluZ190ZXN0cyA9IHJlc3VsdHMudGVzdHNfbWF0Y2hpbmdfZmFpbHVyZV90eXBlcyhbdGVz dF9mYWlsdXJlcy5GYWlsdXJlVGV4dE1pc21hdGNoXSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVh bChsZW4ocmVzdWx0cy5mYWlsaW5nX3Rlc3RzKCkpLCAxKQo=