64768 2011-07-18 17:07:18 -0700 Remove drawsUsingCopy now that all ports handle the copying 2011-07-18 17:54:44 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mdelaney7 mdelaney7 hyatt oldest_to_newest 438846 0 mdelaney7 2011-07-18 17:07:18 -0700 Introduced in https://bugs.webkit.org/show_bug.cgi?id=43507, ImageBuffer::drawsUsingCopy was used to know whether or not an ImageBuffer should be explicitly copied before being painted into a context (as was used in HTMLCanvasElement::paint). All platforms now handle the logic of copying or not in their ImageBuffer::draw() implementations, so drawsUsingCopy() is no longer needed. 438847 1 101239 mdelaney7 2011-07-18 17:10:51 -0700 Created attachment 101239 Patch 438870 2 mdelaney7 2011-07-18 17:54:44 -0700 Committed r91228: <http://trac.webkit.org/changeset/91228> 101239 2011-07-18 17:10:51 -0700 2011-07-18 17:31:37 -0700 Patch bug-64768-20110718171050.patch text/plain 6423 mdelaney7 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxMjIxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTEtMDctMTggIE1hdHRoZXcg RGVsYW5leSAgPG1kZWxhbmV5QGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgZHJhd3NVc2lu Z0NvcHkgbm93IHRoYXQgYWxsIHBvcnRzIGhhbmRsZSB0aGUgY29weWluZworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ3NjgKKyAgICAgICAgCisgICAg ICAgIEludHJvZHVjZWQgaW4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQzNTA3LCBJbWFnZUJ1ZmZlcjo6ZHJhd3NVc2luZ0NvcHkKKyAgICAgICAgd2FzIHVzZWQgdG8g a25vdyB3aGV0aGVyIG9yIG5vdCBhbiBJbWFnZUJ1ZmZlciBzaG91bGQgYmUgZXhwbGljaXRseSBj b3BpZWQgYmVmb3JlIGJlaW5nCisgICAgICAgIHBhaW50ZWQgaW50byBhIGNvbnRleHQgKGFzIHdh cyB1c2VkIGluIEhUTUxDYW52YXNFbGVtZW50OjpwYWludCkuIEFsbCBwbGF0Zm9ybXMgbm93Cisg ICAgICAgIGhhbmRsZSB0aGUgbG9naWMgb2YgY29weWluZyBvciBub3QgaW4gdGhlaXIgSW1hZ2VC dWZmZXI6OmRyYXcoKSBpbXBsZW1lbnRhdGlvbnMsIHNvCisgICAgICAgIGRyYXdzVXNpbmdDb3B5 KCkgaXMgbm8gbG9uZ2VyIG5lZWRlZC4gVGhpcyBwYXRjaCByZW1vdmVzIGl0LgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0czsgZG9l cyBub3QgYWZmZWN0IGJlaGF2aW9yLgorCisgICAgICAgICogaHRtbC9IVE1MQ2FudmFzRWxlbWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQ2FudmFzRWxlbWVudDo6cGFpbnQpOgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmg6CisgICAgICAgIChXZWJDb3Jl OjpJbWFnZUJ1ZmZlcjo6aXNBY2NlbGVyYXRlZCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyby5jcHA6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvY2cvSW1hZ2VCdWZmZXJDRy5jcHA6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQv SW1hZ2VCdWZmZXJRdC5jcHA6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFn ZUJ1ZmZlclNraWEuY3BwOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3dpbmNlL0ltYWdl QnVmZmVyV2luQ0UuY3BwOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3d4L0ltYWdlQnVm ZmVyV3guY3BwOgorCiAyMDExLTA3LTE4ICBKb24gSG9uZXljdXR0ICA8amhvbmV5Y3V0dEBhcHBs ZS5jb20+CiAKICAgICAgICAgRm9jdXMgYW5kIHNlbGVjdGlvbiBldmVudHMgYXJlIG5vdCBmaXJl ZCB3aGVuIGEgPHNlbGVjdD4ncyBzZWxlY3Rpb24KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTENhbnZhc0VsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTENhbnZhc0VsZW1lbnQuY3BwCShyZXZpc2lvbiA5MDc4MCkKKysrIFNvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODEsOCArMjgx LDYgQEAgdm9pZCBIVE1MQ2FudmFzRWxlbWVudDo6cGFpbnQoR3JhcGhpY3NDbwogICAgICAgICBp ZiAoaW1hZ2VCdWZmZXIpIHsKICAgICAgICAgICAgIGlmIChtX3ByZXNlbnRlZEltYWdlKQogICAg ICAgICAgICAgICAgIGNvbnRleHQtPmRyYXdJbWFnZShtX3ByZXNlbnRlZEltYWdlLmdldCgpLCBD b2xvclNwYWNlRGV2aWNlUkdCLCByLCBDb21wb3NpdGVTb3VyY2VPdmVyLCB1c2VMb3dRdWFsaXR5 U2NhbGUpOwotICAgICAgICAgICAgZWxzZSBpZiAoaW1hZ2VCdWZmZXItPmRyYXdzVXNpbmdDb3B5 KCkpCi0gICAgICAgICAgICAgICAgY29udGV4dC0+ZHJhd0ltYWdlKGNvcGllZEltYWdlKCksIENv bG9yU3BhY2VEZXZpY2VSR0IsIHIsIENvbXBvc2l0ZVNvdXJjZU92ZXIsIHVzZUxvd1F1YWxpdHlT Y2FsZSk7CiAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgY29udGV4dC0+ZHJhd0lt YWdlQnVmZmVyKGltYWdlQnVmZmVyLCBDb2xvclNwYWNlRGV2aWNlUkdCLCByLCBDb21wb3NpdGVT b3VyY2VPdmVyLCB1c2VMb3dRdWFsaXR5U2NhbGUpOwogICAgICAgICB9CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmgJKHJldmlzaW9uIDkw NzgwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZmZXIuaAko d29ya2luZyBjb3B5KQpAQCAtODMsNyArODMsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAg ICAgIEdyYXBoaWNzQ29udGV4dCogY29udGV4dCgpIGNvbnN0OwogCiAgICAgICAgIGJvb2wgaXNB Y2NlbGVyYXRlZCgpIGNvbnN0IHsgcmV0dXJuIG1fYWNjZWxlcmF0ZVJlbmRlcmluZzsgfQotICAg ICAgICBib29sIGRyYXdzVXNpbmdDb3B5KCkgY29uc3Q7IC8vIElmIHRoZSBpbWFnZSBidWZmZXIg aGFzIHRvIHJlbmRlciB1c2luZyBhIGNvcGllZCBpbWFnZSwgaXQgd2lsbCByZXR1cm4gdHJ1ZS4K ICAgICAgICAgUGFzc1JlZlB0cjxJbWFnZT4gY29weUltYWdlKCkgY29uc3Q7IC8vIFJldHVybiBh IG5ldyBpbWFnZSB0aGF0IGlzIGEgY29weSBvZiB0aGUgYnVmZmVyLgogCiAgICAgICAgIFBhc3NS ZWZQdHI8Qnl0ZUFycmF5PiBnZXRVbm11bHRpcGxpZWRJbWFnZURhdGEoY29uc3QgSW50UmVjdCYp IGNvbnN0OwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1h Z2VCdWZmZXJDYWlyby5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyby5jcHAJKHJldmlzaW9uIDkwNzgwKQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyby5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTg2LDExICs4Niw2IEBAIEdyYXBoaWNzQ29udGV4dCogSW1h Z2VCdWZmZXI6OmNvbnRleHQoKSAKICAgICByZXR1cm4gbV9jb250ZXh0LmdldCgpOwogfQogCi1i b29sIEltYWdlQnVmZmVyOjpkcmF3c1VzaW5nQ29weSgpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIGZh bHNlOwotfQotCiBQYXNzUmVmUHRyPEltYWdlPiBJbWFnZUJ1ZmZlcjo6Y29weUltYWdlKCkgY29u c3QKIHsKICAgICAvLyBCaXRtYXBJbWFnZSB3aWxsIHJlbGVhc2UgdGhlIHBhc3NlZCBpbiBzdXJm YWNlIG9uIGRlc3RydWN0aW9uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jZy9JbWFnZUJ1ZmZlckNHLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUJ1ZmZlckNHLmNwcAkocmV2aXNpb24gOTA3ODApCisrKyBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUJ1ZmZlckNHLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTc3LDExICsxNzcsNiBAQCBHcmFwaGljc0NvbnRleHQqIEltYWdlQnVm ZmVyOjpjb250ZXh0KCkgCiAgICAgcmV0dXJuIG1fY29udGV4dC5nZXQoKTsKIH0KIAotYm9vbCBJ bWFnZUJ1ZmZlcjo6ZHJhd3NVc2luZ0NvcHkoKSBjb25zdAotewotICAgIHJldHVybiBmYWxzZTsK LX0KLQogUGFzc1JlZlB0cjxJbWFnZT4gSW1hZ2VCdWZmZXI6OmNvcHlJbWFnZSgpIGNvbnN0CiB7 CiAgICAgLy8gQml0bWFwSW1hZ2Ugd2lsbCByZWxlYXNlIHRoZSBwYXNzZWQgaW4gQ0dJbWFnZSBv biBkZXN0cnVjdGlvbgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQv SW1hZ2VCdWZmZXJRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHAJKHJldmlzaW9uIDkwNzgwKQorKysgU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTEyMSwxMSArMTIxLDYgQEAgR3JhcGhpY3NDb250ZXh0KiBJbWFnZUJ1ZmZlcjo6 Y29udGV4dCgpIAogICAgIHJldHVybiBtX2NvbnRleHQuZ2V0KCk7CiB9CiAKLWJvb2wgSW1hZ2VC dWZmZXI6OmRyYXdzVXNpbmdDb3B5KCkgY29uc3QKLXsKLSAgICByZXR1cm4gZmFsc2U7Ci19Ci0K IFBhc3NSZWZQdHI8SW1hZ2U+IEltYWdlQnVmZmVyOjpjb3B5SW1hZ2UoKSBjb25zdAogewogICAg IHJldHVybiBTdGlsbEltYWdlOjpjcmVhdGUobV9kYXRhLm1fcGl4bWFwKTsKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVm ZmVyU2tpYS5jcHAJKHJldmlzaW9uIDkwNzgwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05OCwx MSArOTgsNiBAQCBzaXplX3QgSW1hZ2VCdWZmZXI6OmRhdGFTaXplKCkgY29uc3QKICAgICByZXR1 cm4gbV9zaXplLndpZHRoKCkgKiBtX3NpemUuaGVpZ2h0KCkgKiA0OwogfQogCi1ib29sIEltYWdl QnVmZmVyOjpkcmF3c1VzaW5nQ29weSgpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIGZhbHNlOwotfQot CiBQYXNzUmVmUHRyPEltYWdlPiBJbWFnZUJ1ZmZlcjo6Y29weUltYWdlKCkgY29uc3QKIHsKICAg ICBtX2NvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgpLT5zeW5jU29mdHdhcmVDYW52YXMoKTsKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbmNlL0ltYWdlQnVmZmVyV2lu Q0UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dp bmNlL0ltYWdlQnVmZmVyV2luQ0UuY3BwCShyZXZpc2lvbiA5MDc4MCkKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbmNlL0ltYWdlQnVmZmVyV2luQ0UuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC05OCwxMSArOTgsNiBAQCBHcmFwaGljc0NvbnRleHQqIEltYWdlQnVmZmVyOjpj b250ZXh0KCkgCiAgICAgcmV0dXJuIG1fY29udGV4dC5nZXQoKTsKIH0KIAotYm9vbCBJbWFnZUJ1 ZmZlcjo6ZHJhd3NVc2luZ0NvcHkoKSBjb25zdAotewotICAgIHJldHVybiB0cnVlOwotfQotCiBQ YXNzUmVmUHRyPEltYWdlPiBJbWFnZUJ1ZmZlcjo6Y29weUltYWdlKCkgY29uc3QKIHsKICAgICBy ZXR1cm4gYWRvcHRSZWYobmV3IEJ1ZmZlcmVkSW1hZ2UoJm1fZGF0YSkpOwpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvSW1hZ2VCdWZmZXJXeC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvSW1hZ2VCdWZmZXJXeC5j cHAJKHJldmlzaW9uIDkwNzgwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv d3gvSW1hZ2VCdWZmZXJXeC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg4LDExICs4OCw2IEBAIFN0 cmluZyBJbWFnZUJ1ZmZlcjo6dG9EYXRhVVJMKGNvbnN0IFN0cmkKICAgICByZXR1cm4gU3RyaW5n KCk7CiB9CiAKLWJvb2wgSW1hZ2VCdWZmZXI6OmRyYXdzVXNpbmdDb3B5KCkgY29uc3QKLXsKLSAg ICByZXR1cm4gdHJ1ZTsKLX0KLQogUGFzc1JlZlB0cjxJbWFnZT4gSW1hZ2VCdWZmZXI6OmNvcHlJ bWFnZSgpIGNvbnN0CiB7CiAgICAgbm90SW1wbGVtZW50ZWQoKTsK