64733 2011-07-18 10:53:13 -0700 Forms with display:none on the submit button do not get submitted on enter 2016-12-05 06:52:56 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 39021 1 groby webkit-unassigned ap arv darin dglazkov kaustubh.ra ojan rniwa robertknight oldest_to_newest 438572 0 groby 2011-07-18 10:53:13 -0700 1. Create a form with a hidden (display:none;) submit button 2. Press return on a form field to submit the form 3. Form does not submit See http://jsfiddle.net/B59rV/2/ for a repro case. Verified against nightly r91186 438711 1 ap 2011-07-18 14:15:56 -0700 Duplicate of bug 45224? The history of that bug is super confusing though - it was filed in Bugzilla without any details, but the related chromium bug kept changing beneath it. 439255 2 groby 2011-07-19 10:47:51 -0700 Looks similar to bug 45224, yes, but it's definitely working in other browsers. All tests on OSX 10.6.8 FF 5.0: PASS Opera 11.50(b1074): PASS Webkit nightly (r91186): FAIL Safari5.0.5(6533.21.1): FAIL Chrome 12.0.742.122: FAIL The related bug in Chromium is http://crbug.com/89586 reduced testcase: http://jsfiddle.net/groby/47ALP/3/ 462088 3 kaustubh.ra 2011-09-05 03:03:08 -0700 Just wanted to know is this required as per the specs? 462112 4 106322 kaustubh.ra 2011-09-05 04:51:02 -0700 Created attachment 106322 Patch Ryosuke, can u review this patch ? There was extra check for renderer() on submit button which can be ignored in display:none case. 462217 5 ap 2011-09-05 12:11:35 -0700 Kaustubh, could you please follow the history of the renderer check in svn to see why it was added? The check certainly looks like it's intentional, not "extra". 462241 6 rniwa 2011-09-05 13:19:42 -0700 (In reply to comment #5) > Kaustubh, could you please follow the history of the renderer check in svn to see why it was added? The check certainly looks like it's intentional, not "extra". Two changesets touched that line: http://trac.webkit.org/changeset/59173 http://trac.webkit.org/changeset/5367 And the latter is the one that introduced renderer check. As far as I can tell the check was introduced because the the code started calling element->renderer()->absolutePosition(x,y); and static_cast<QButton *>(static_cast<RenderWidget *>(element->renderer())->widget())->simulateClick(); But given that the test passes, dispatchSimulatedClick doesn't appear to be dependent on renderer at this point. So I'd say this fix is correct. 462243 7 106322 rniwa 2011-09-05 13:24:44 -0700 Comment on attachment 106322 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106322&action=review r- due to various nits. > Source/WebCore/ChangeLog:4 > + on enter. Nit: it seems like "on enter" can hit on the previous line. > Source/WebCore/ChangeLog:9 > + Removed check for render() on submit button. Even if submit button has Nit: s/render/renderer/ > LayoutTests/fast/forms/hidden-submit-button-form-action.html:3 > + <script> Nit: I don't think we normally indent script element or the actual script like this. > LayoutTests/fast/forms/hidden-submit-button-form-action.html:18 > +<body onload="test()"> Do we really need to wait until the page is loaded? Can't we just put script element below the form element and call submit? > LayoutTests/fast/forms/hidden-submit-button-form-action.html:19 > + <form onsubmit="log('Test Passed'); return false;"> Nit: We normally just print "PASS" instead of "Test Passed". > LayoutTests/fast/forms/hidden-submit-button-form-action.html:21 > + <input id="txtbox1"/> Nit: Please don't use abbreviations such as txt. > LayoutTests/fast/forms/hidden-submit-button-form-action.html:22 > + <input id="txtbox2"/> Nit: Why do we need to have two input elements? 462373 8 kaustubh.ra 2011-09-05 23:18:28 -0700 Hi Alexy, Adding to Ryosuke's comments, this check for renderer() is only to check if the submit button is displayed or not. The earlier check if (formElement->isSuccessfulSubmitButton()) does check if the submit button is there or not. There might be cases where user just want to show the form with submit action but dont want to show typical submit button. In that case the he can add a button with display:none which will destroy its renderer. And he wont be able to submit form. Removing this check will support as per the bug requirement. Also from the specs http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#implicit-submission on the last line it says - "If the form has no submit button, then the implicit submission mechanism must just submit the form element from the form element itself." (In reply to comment #6) > (In reply to comment #5) > > Kaustubh, could you please follow the history of the renderer check in svn to see why it was added? The check certainly looks like it's intentional, not "extra". > > Two changesets touched that line: > http://trac.webkit.org/changeset/59173 > http://trac.webkit.org/changeset/5367 > > And the latter is the one that introduced renderer check. As far as I can tell the check was introduced because the the code started calling element->renderer()->absolutePosition(x,y); and static_cast<QButton *>(static_cast<RenderWidget *>(element->renderer())->widget())->simulateClick(); > > But given that the test passes, dispatchSimulatedClick doesn't appear to be dependent on renderer at this point. So I'd say this fix is correct. 462384 9 kaustubh.ra 2011-09-05 23:51:12 -0700 > > LayoutTests/fast/forms/hidden-submit-button-form-action.html:22 > > + <input id="txtbox2"/> > > Nit: Why do we need to have two input elements? The reason being the issue is not reproducible for only one input box element inside form. I m trying to figure out why so? Will update soon. 462390 10 ap 2011-09-06 00:09:45 -0700 > And the latter is the one that introduced renderer check. As far as I can tell the check was introduced because the the code started calling element->renderer()->absolutePosition(x,y); and static_cast<QButton *>(static_cast<RenderWidget *>(element->renderer())->widget())->simulateClick(); Thanks, that makes sense. The key to going forward with this is to check IE. Per Dimitri, this is expected behavior since it matches IE. I see that http://crbug.com/89586 claims identical behavior in IE and Firefox, but did we confirm that? 462403 11 kaustubh.ra 2011-09-06 00:46:38 -0700 For Single input box, there is check added in http://trac.webkit.org/changeset/58520. And which makes single input box forms to be submitted on enter. (Use case would be "Search" field ) 462448 12 106402 kaustubh.ra 2011-09-06 03:28:18 -0700 Created attachment 106402 Updated Patch Updated patch with Ryosuke's comments. 462546 13 106402 rniwa 2011-09-06 08:35:25 -0700 Comment on attachment 106402 Updated Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106402&action=review > LayoutTests/fast/forms/hidden-submit-button-form-action.html:1 > +<html> Nit: is there a reason we don't have a DOCTYPE here? As far as I can tell, the bug reproduces on both quirks and strict modes. > LayoutTests/fast/forms/hidden-submit-button-form-action.html:4 > + <form onsubmit="log('PASS'); return false;"> > + This tests that hitting the enter key on a input box element with hidden submit button submits the form.<br> Nit: I don't think there's need for indenting elements like this. The reason I advocate for not-indenting text/elements is that indentation takes space. Since the "svn up" time is constantly complained about, we should try to minimize the file size as much. > LayoutTests/fast/forms/hidden-submit-button-form-action.html:11 > + var textbox2 = document.getElementById('textbox2'); Nit: I don't think there's need for indenting scripts. > LayoutTests/fast/forms/hidden-submit-button-form-action.html:18 > + function log(msg) { > + var console = document.getElementById('console'); If you just outdent function log(msg) { and }, then the function definition will be properly indented as in: function log(msg) { var console = document.getElementById('console'); console.innerHTML = console.innerHTML + msg + "<br>"; } 462547 14 rniwa 2011-09-06 08:36:22 -0700 (In reply to comment #9) > > > LayoutTests/fast/forms/hidden-submit-button-form-action.html:22 > > > + <input id="txtbox2"/> > > > > Nit: Why do we need to have two input elements? > > The reason being the issue is not reproducible for only one input box element inside form. I m trying to figure out why so? Will update soon. THAT is surely odd. Did you figure out why? 462549 15 rniwa 2011-09-06 08:37:01 -0700 (In reply to comment #10) > The key to going forward with this is to check IE. Per Dimitri, this is expected behavior since it matches IE. I see that http://crbug.com/89586 claims identical behavior in IE and Firefox, but did we confirm that? New behavior matches Firefox 3.6 at least. 462573 16 106402 darin 2011-09-06 09:02:51 -0700 Comment on attachment 106402 Updated Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106402&action=review > Source/WebCore/html/HTMLFormElement.cpp:190 > if (formElement->isSuccessfulSubmitButton()) { > - if (formElement->renderer()) { > - formElement->dispatchSimulatedClick(event); > - return; > - } > + formElement->dispatchSimulatedClick(event); > + return; > } else if (formElement->canTriggerImplicitSubmission()) In the WebKit project our coding style is to not do else after return. So this patch should remove the else and put the if following it on a new line. > LayoutTests/ChangeLog:11 > + * fast/forms/hidden-submit-button-form-action-expected.txt: Added. "hidden" is not a good name for "display: none" since CSS also has "visibility: hidden" So that’s not a good name for this test. >> LayoutTests/fast/forms/hidden-submit-button-form-action.html:4 >> + This tests that hitting the enter key on a input box element with hidden submit button submits the form.<br> > > Nit: I don't think there's need for indenting elements like this. > > The reason I advocate for not-indenting text/elements is that indentation takes space. Since the "svn up" time is constantly complained about, we should try to minimize the file size as much. I don’t want to start an argument about something irrelevant, but I don’t think we should try to economize on bytes by not indenting. The extra characters from indenting are not a factor in "svn up". 462622 17 106402 ap 2011-09-06 10:22:31 -0700 Comment on attachment 106402 Updated Patch Talked to Darin in person, and canceling r+ for now - until IE behavior is checked. Please feel free to land with Darin's comments addressed if IE agrees with the new behavior. 462637 18 rniwa 2011-09-06 10:40:15 -0700 The current behavior matches that of MSIE 9. 462674 19 ap 2011-09-06 11:12:11 -0700 Given that the combined market share of IE and WebKit browsers is much higher than that of Gecko (Firefox), it's likely best for compatibility to WONTFIX this bug. 462773 20 kaustubh.ra 2011-09-06 13:02:38 -0700 > > The reason being the issue is not reproducible for only one input box element inside form. I m trying to figure out why so? Will update soon. > > THAT is surely odd. Did you figure out why? Ryosuke, there is a change in which it checks for the } else if (formElement->canTriggerImplicitSubmission()) ++submissionTriggerCount; } if (fromImplicitSubmissionTrigger && submissionTriggerCount == 1) prepareSubmit(event); This is why when there is only one input box element, submissionTriggerCount become 1 and it triggers prepareSubmit(event) which cause the use case to work with only one input box. This is designed keeping "Searchbox" in mind, where u can have submit action on enter key press. Also I will take care of indentation as well just to keep code as simple as possible. From the specs mentioned in "http://www.w3.org/TR/html5/association-of-controls-and-forms.html#implicit-submission" I think the form submission should be possible even if there is no active submit button. The spec clearly mentions if there is a submit button in the form's tree order (may it be displayed or not is upto developer's choice) the default action on enter should be submitting the form. So, IMHO, i think this bug is valid and should be fixed. 462787 21 rniwa 2011-09-06 13:13:30 -0700 (In reply to comment #20) > Ryosuke, there is a change in which it checks for the > } else if (formElement->canTriggerImplicitSubmission()) > ++submissionTriggerCount; > } > if (fromImplicitSubmissionTrigger && submissionTriggerCount == 1) > prepareSubmit(event); > > This is why when there is only one input box element, submissionTriggerCount become 1 and it triggers prepareSubmit(event) which cause the use case to work with only one input box. This is designed keeping "Searchbox" in mind, where u can have submit action on enter key press. Also I will take care of indentation as well just to keep code as simple as possible. I see. Very interesting design. It'll be nice to mention that comment in the change log. > From the specs mentioned in "http://www.w3.org/TR/html5/association-of-controls-and-forms.html#implicit-submission" I think the form submission should be possible even if there is no active submit button. The spec clearly mentions if there is a submit button in the form's tree order (may it be displayed or not is upto developer's choice) the default action on enter should be submitting the form. I agree that fixing this bug seems logical but I'm also worried about the Web compatibility as Alexey pointed out. +ojan, +arv since they tend to know about these compat. issues better than me. 463021 22 ojan 2011-09-06 17:47:16 -0700 I'm inclined to agree with Alexey. Eventually we want all browsers to agree on a behavior though. We need more data: 1. Are there sites that we know break due to this bug? That would provide evidence for matching FF/Opera. 2. What is the IE8 behavior? IE9 is a totally different engine and much of the existing web is written towards IE6-8. Assuming IE6-9 and WebKit agree, we should do the following: 1. File Mozilla/Opera bugs to change behavior. 2. Email whatwg suggesting that the spec be changed. If IE6-8 have the FF/Opera behavior it's less clear to me what the best path forward is. Still a whatwg email is probably in order to make sure all browser vendors agree on a path forward. 463029 23 106527 rniwa 2011-09-06 18:05:30 -0700 Created attachment 106527 test I'm attaching the test because I've got tired of extracting it every time I test it on new browser. 463040 24 rniwa 2011-09-06 18:23:27 -0700 (In reply to comment #22) > 2. What is the IE8 behavior? IE9 is a totally different engine and much of the existing web is written towards IE6-8. I've checked behaviors of IE6, IE7, and IE8. They all agree with IE9 on both quirks and strict modes. So there's a significant compat. implications if we change our behavior. 465541 25 kaustubh.ra 2011-09-12 02:44:27 -0700 I have started a thread at whatwg.org about this. http://forums.whatwg.org/bb3/viewtopic.php?f=1&t=4718 472716 26 kaustubh.ra 2011-09-23 21:26:18 -0700 Whatwg.org discussion - http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2011-September/033281.html 472773 27 rniwa 2011-09-24 09:57:48 -0700 Upon further investigation, I found that: WebKit does implicit submission in the following conditions: One text fields Two text fields One text field with one visible submit button Two text fields with one visible submit button Two text fields with one visibility:hidden submit button One text field with one display:none submit button However, it doesn't submit when we have: Two text fields with one display:none submit button Given that WebKit implicitly submits form even in the presence of a visible submit button or an invisible submit button (visibility: hidden, or display: none with exactly one text field), I don't see why we should avoid implicit submission only when there are multiple form controls and a display:none submit button. 472782 28 darin 2011-09-24 11:42:46 -0700 I’m curious: Which of those behaviors are different from IE? 472793 29 rniwa 2011-09-24 13:35:35 -0700 (In reply to comment #28) > I’m curious: Which of those behaviors are different from IE? IE does implicit submission in the following conditions: * One text field * One text field with one visible submit button * One text field with one display:none submit button * Two text fields with one visible submit button It does not do implicit submissio in the following conditions: * Two text fields * Two text fields with one visibility:hidden submit button * Two text fields with one display:none submit button Basically, IE only does implicit submission when there is exactly one text field (you can have checkbox, hidden, etc...) or there is a visible button (i.e. not diplay: none nor visibility: hidden). I'd say IE's behavior is much saner. 472795 30 rniwa 2011-09-24 13:41:58 -0700 Firefox 5 does implicit submission in the following conditions: * One text field * One text field with one visible submit button * One text field with one display:none submit button * Two text fields with one visible submit button * Two text fields with one visibility:hidden submit button * Two text fields with one display:none submit button It does not do implicit submissio in the following conditions: * Two text fields In summary, Firefox special cases one text field (can have checkbox, hidden, etc...) like MSIE and requires a submit button with more than two text fields regardless of presence of visibility: hidden or display: none. 472803 31 rniwa 2011-09-24 13:56:30 -0700 One correction. WebKit does not implicitly submit when there are two text fields without any submit buttons. So WebKit matches IE quite well except: * Two text fields with one visibility:hidden submit button Basically IE treats visibility: hidden like display: none for the purpose of determining whether a submit button is visible or not. This seems reasonable given a user won't be able to see a submit button with visibility: hidden. Alternatively we can change our behavior and match Firefox (and possibily Opeara). Given the market share of Trident and WebKit combined, I'm more inclined to prefer the former option. 472857 32 kaustubh.ra 2011-09-24 22:55:22 -0700 (In reply to comment #31) > One correction. WebKit does not implicitly submit when there are two text fields without any submit buttons. > > So WebKit matches IE quite well except: > * Two text fields with one visibility:hidden submit button > > Basically IE treats visibility: hidden like display: none for the purpose of determining whether a submit button is visible or not. This seems reasonable given a user won't be able to see a submit button with visibility: hidden. > > Alternatively we can change our behavior and match Firefox (and possibily Opeara). > Just to add more analysis Opera - Does Implicit submission in following cases - * One text field * One text field with one visible submit button * One text field with one display:none submit button * Two text fields with one visible submit button * Two text fields with one visibility:hidden submit button * Two text fields with one display:none submit button Only in following case it does not - * Two text fields > Given the market share of Trident and WebKit combined, I'm more inclined to prefer the former option. http://www.w3schools.com/browsers/browsers_stats.asp Considering Increasing share of Firefox (more than 40%) and decreasing share of IE (less than 25%) & also for Mobiles & Tablets there is Opera Mini which is increasing in use. IMHO we can match compliance with FF & Opera & also the specs which clearly allows to implicitly submit without respecting visibility/display of submit button. 472860 33 ap 2011-09-24 23:28:26 -0700 > http://www.w3schools.com/browsers/browsers_stats.asp > Considering Increasing share of Firefox (more than 40%) and decreasing share of IE (less than 25%) & also for Mobiles & Tablets there is Opera Mini which is increasing in use. This site only has data about its own users. See <http://www.netmarketshare.com/browser-market-share.aspx?qprid=1&qpcustomb=0> for more balanced data. IE and WebKit browsers have roughly 75% share, and growing. Investigating Opera behavior in particular is not very interesting in compatibility studies. Besides low market share, Opera has many site specific hacks, which can mask compatibility risks from following its behavior. 480845 34 kaustubh.ra 2011-10-09 23:46:41 -0700 Just reopening the bug to conclude. Should we mark this as WONTFIX or can this be fixed? 518555 35 106402 eric 2011-12-09 14:57:45 -0800 Comment on attachment 106402 Updated Patch What's the status of this fix? It looks like it never got set r? 518562 36 rniwa 2011-12-09 15:07:44 -0800 Given that both IE and WebKit have been disabling implicit form submission for years when the button has display: none, I don't think we can change our behavior here. Please reopen the bug if and only if you find an empirical evidence that this change improves the Web compatibility. 1256293 37 robertknight 2016-12-05 06:52:56 -0800 This issue was fixed in Chrome in Feb 2014 citing web compatibility, although no affected sites are explicitly named - https://bugs.chromium.org/p/chromium/issues/detail?id=89586 Since this behavior now differs from both Firefox and Chrome, would you reconsider re-opening this? 106322 2011-09-05 04:51:02 -0700 2011-09-06 03:28:18 -0700 Patch patch.txt text/plain 3317 kaustubh.ra SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0NTI0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDktMDUgIEthdXN0dWJo IEF0cmF3YWxrYXIgIDxrYXVzdHViaEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgRm9ybXMgd2l0 aCBkaXNwbGF5Om5vbmUgb24gdGhlIHN1Ym1pdCBidXR0b24gZG8gbm90IGdldCBzdWJtaXR0ZWQK KyAgICAgICAgb24gZW50ZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02NDczMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJlbW92ZWQgY2hlY2sgZm9yIHJlbmRlcigpIG9uIHN1Ym1pdCBidXR0b24uIEV2 ZW4gaWYgc3VibWl0IGJ1dHRvbiBoYXMKKyAgICAgICAgZGlzcGxheTpub25lIGZvcm0gc2hvdWxk IGJlIHN1Ym1pdHRlZC4KKworICAgICAgICBUZXN0OiBmYXN0L2Zvcm1zL2hpZGRlbi1zdWJtaXQt YnV0dG9uLWZvcm0tYWN0aW9uLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTEZvcm1FbGVtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGb3JtRWxlbWVudDo6c3VibWl0SW1wbGljaXRs eSk6CisKIDIwMTEtMDktMDUgIEthdXN0dWJoIEF0cmF3YWxrYXIgIDxrYXVzdHViaEBtb3Rvcm9s YS5jb20+CiAKICAgICAgICAgTG9naWMgZnJvbSBIVE1MRWxlbWVudDo6ZGVwcmVjYXRlZENyZWF0 ZUNvbnRleHR1YWxGcmFnbWVudCBtb3ZlZCBpbnRvCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxGb3JtRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MRm9ybUVsZW1lbnQuY3BwCShyZXZpc2lvbiA5NDUyMCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTEZvcm1FbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg1LDEwICsxODUsOCBA QCB2b2lkIEhUTUxGb3JtRWxlbWVudDo6c3VibWl0SW1wbGljaXRseShFCiAgICAgICAgICAgICBj b250aW51ZTsKICAgICAgICAgSFRNTEZvcm1Db250cm9sRWxlbWVudCogZm9ybUVsZW1lbnQgPSBz dGF0aWNfY2FzdDxIVE1MRm9ybUNvbnRyb2xFbGVtZW50Kj4oZm9ybUFzc29jaWF0ZWRFbGVtZW50 KTsKICAgICAgICAgaWYgKGZvcm1FbGVtZW50LT5pc1N1Y2Nlc3NmdWxTdWJtaXRCdXR0b24oKSkg ewotICAgICAgICAgICAgaWYgKGZvcm1FbGVtZW50LT5yZW5kZXJlcigpKSB7Ci0gICAgICAgICAg ICAgICAgZm9ybUVsZW1lbnQtPmRpc3BhdGNoU2ltdWxhdGVkQ2xpY2soZXZlbnQpOwotICAgICAg ICAgICAgICAgIHJldHVybjsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGZvcm1FbGVtZW50 LT5kaXNwYXRjaFNpbXVsYXRlZENsaWNrKGV2ZW50KTsKKyAgICAgICAgICAgIHJldHVybjsKICAg ICAgICAgfSBlbHNlIGlmIChmb3JtRWxlbWVudC0+Y2FuVHJpZ2dlckltcGxpY2l0U3VibWlzc2lv bigpKQogICAgICAgICAgICAgKytzdWJtaXNzaW9uVHJpZ2dlckNvdW50OwogICAgIH0KSW5kZXg6 IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvaGlkZGVuLXN1Ym1pdC1idXR0b24tZm9ybS1hY3Rpb24t ZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvaGlkZGVu LXN1Ym1pdC1idXR0b24tZm9ybS1hY3Rpb24tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9oaWRkZW4tc3VibWl0LWJ1dHRvbi1mb3JtLWFjdGlvbi1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAorVGhpcyB0ZXN0cyB0aGF0 IGhpdHRpbmcgdGhlIGVudGVyIGtleSBvbiBhIGlucHV0IGJveCBlbGVtZW50IHdpdGggaGlkZGVu IHN1Ym1pdCBidXR0b24gc3VibWl0cyB0aGUgZm9ybS4KKyAgCitUZXN0IFBhc3NlZAorCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2hpZGRlbi1zdWJtaXQtYnV0dG9uLWZvcm0tYWN0aW9u Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9oaWRkZW4tc3VibWl0 LWJ1dHRvbi1mb3JtLWFjdGlvbi5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9oaWRkZW4tc3VibWl0LWJ1dHRvbi1mb3JtLWFjdGlvbi5odG1sCShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDI3IEBACis8aHRtbD4KKzxoZWFkPgorICAgIDxzY3JpcHQ+CisgICAgZnVu Y3Rpb24gdGVzdCgpIHsKKyAgICAgICAgdmFyIHR4dGJveDIgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgndHh0Ym94MicpOworICAgICAgICB0eHRib3gyLmZvY3VzKCk7CisgICAgICAgIGlmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgICAgICAgIGxheW91dFRlc3RDb250 cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24oIlxy IiwgW10pOworICAgICAgICB9CisgICAgfQorICAgIGZ1bmN0aW9uIGxvZyhtc2cpIHsKKyAgICAg ICAgdmFyIGNvbnNvbGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29uc29sZScpOworICAg ICAgICBjb25zb2xlLmlubmVySFRNTCA9IGNvbnNvbGUuaW5uZXJIVE1MICsgbXNnICsgIjxicj4i OworICAgIH0KKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0idGVzdCgpIj4K KyAgICA8Zm9ybSBvbnN1Ym1pdD0ibG9nKCdUZXN0IFBhc3NlZCcpOyByZXR1cm4gZmFsc2U7Ij4K KyAgICAgICAgVGhpcyB0ZXN0cyB0aGF0IGhpdHRpbmcgdGhlIGVudGVyIGtleSBvbiBhIGlucHV0 IGJveCBlbGVtZW50IHdpdGggaGlkZGVuIHN1Ym1pdCBidXR0b24gc3VibWl0cyB0aGUgZm9ybS48 YnI+CisgICAgICAgIDxpbnB1dCBpZD0idHh0Ym94MSIvPgorICAgICAgICA8aW5wdXQgaWQ9InR4 dGJveDIiLz4KKyAgICAgICAgPGlucHV0IHR5cGU9InN1Ym1pdCIgc3R5bGU9ImRpc3BsYXk6IG5v bmU7IiA+CisgICAgPC9mb3JtPgorICAgIDxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPC9ib2R5 PgorPC9odG1sPgo= 106402 2011-09-06 03:28:18 -0700 2011-12-09 14:57:45 -0800 Updated Patch patch3.txt text/plain 4031 kaustubh.ra SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0NTU4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDktMDYgIEthdXN0dWJo IEF0cmF3YWxrYXIgIDxrYXVzdHViaEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgRm9ybXMgd2l0 aCBkaXNwbGF5Om5vbmUgb24gdGhlIHN1Ym1pdCBidXR0b24gZG8gbm90IGdldCBzdWJtaXR0ZWQg b24gZW50ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY0NzMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVtb3ZlZCBjaGVjayBmb3IgcmVuZGVyZXIoKSBvbiBzdWJtaXQgYnV0dG9uLiBFdmVuIGlmIHN1 Ym1pdCBidXR0b24gaGFzCisgICAgICAgIGRpc3BsYXk6bm9uZSBmb3JtIHNob3VsZCBiZSBzdWJt aXR0ZWQuCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9oaWRkZW4tc3VibWl0LWJ1dHRvbi1m b3JtLWFjdGlvbi5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxGb3JtRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUVsZW1lbnQ6OnN1Ym1pdEltcGxpY2l0bHkpOgorCiAy MDExLTA5LTA2ICBEaXJrIFNjaHVsemUgIDxrcml0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV0 dXJuIHRvIHRyYW5zZm9ybSBtdWx0aXBsaWNhdGlvbjogbW90aW9uIHRyYW5zZm9ybSAqIG90aGVy IHRyYW5zZm9ybXMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVudC5jcHAJ KHJldmlzaW9uIDk0NTUwKQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODUsMTAgKzE4NSw4IEBAIHZvaWQgSFRNTEZvcm1FbGVt ZW50OjpzdWJtaXRJbXBsaWNpdGx5KEUKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICBI VE1MRm9ybUNvbnRyb2xFbGVtZW50KiBmb3JtRWxlbWVudCA9IHN0YXRpY19jYXN0PEhUTUxGb3Jt Q29udHJvbEVsZW1lbnQqPihmb3JtQXNzb2NpYXRlZEVsZW1lbnQpOwogICAgICAgICBpZiAoZm9y bUVsZW1lbnQtPmlzU3VjY2Vzc2Z1bFN1Ym1pdEJ1dHRvbigpKSB7Ci0gICAgICAgICAgICBpZiAo Zm9ybUVsZW1lbnQtPnJlbmRlcmVyKCkpIHsKLSAgICAgICAgICAgICAgICBmb3JtRWxlbWVudC0+ ZGlzcGF0Y2hTaW11bGF0ZWRDbGljayhldmVudCk7Ci0gICAgICAgICAgICAgICAgcmV0dXJuOwot ICAgICAgICAgICAgfQorICAgICAgICAgICAgZm9ybUVsZW1lbnQtPmRpc3BhdGNoU2ltdWxhdGVk Q2xpY2soZXZlbnQpOworICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9IGVsc2UgaWYgKGZv cm1FbGVtZW50LT5jYW5UcmlnZ2VySW1wbGljaXRTdWJtaXNzaW9uKCkpCiAgICAgICAgICAgICAr K3N1Ym1pc3Npb25UcmlnZ2VyQ291bnQ7CiAgICAgfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gOTQ1NTgp CisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBA QAorMjAxMS0wOS0wNiAgS2F1c3R1YmggQXRyYXdhbGthciAgPGthdXN0dWJoQG1vdG9yb2xhLmNv bT4KKworICAgICAgICBGb3JtcyB3aXRoIGRpc3BsYXk6bm9uZSBvbiB0aGUgc3VibWl0IGJ1dHRv biBkbyBub3QgZ2V0IHN1Ym1pdHRlZCBvbiBlbnRlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0NzMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlZCBjaGVjayBmb3IgcmVuZGVyZXIoKSBvbiBz dWJtaXQgYnV0dG9uLiBFdmVuIGlmIHN1Ym1pdCBidXR0b24gaGFzCisgICAgICAgIGRpc3BsYXk6 bm9uZSBmb3JtIHNob3VsZCBiZSBzdWJtaXR0ZWQuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2hp ZGRlbi1zdWJtaXQtYnV0dG9uLWZvcm0tYWN0aW9uLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogZmFzdC9mb3Jtcy9oaWRkZW4tc3VibWl0LWJ1dHRvbi1mb3JtLWFjdGlvbi5odG1sOiBB ZGRlZC4KKwogMjAxMS0wOS0wNiAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldHVybiB0byB0cmFuc2Zvcm0gbXVsdGlwbGljYXRpb246IG1vdGlvbiB0cmFuc2Zv cm0gKiBvdGhlciB0cmFuc2Zvcm1zCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2hpZGRl bi1zdWJtaXQtYnV0dG9uLWZvcm0tYWN0aW9uLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2hpZGRlbi1zdWJtaXQtYnV0dG9uLWZvcm0tYWN0aW9uLWV4 cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvaGlkZGVu LXN1Ym1pdC1idXR0b24tZm9ybS1hY3Rpb24tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAt MCwwICsxLDQgQEAKK1RoaXMgdGVzdHMgdGhhdCBoaXR0aW5nIHRoZSBlbnRlciBrZXkgb24gYSBp bnB1dCBib3ggZWxlbWVudCB3aXRoIGhpZGRlbiBzdWJtaXQgYnV0dG9uIHN1Ym1pdHMgdGhlIGZv cm0uCisgIAorUEFTUworCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2hpZGRlbi1zdWJt aXQtYnV0dG9uLWZvcm0tYWN0aW9uLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9oaWRkZW4tc3VibWl0LWJ1dHRvbi1mb3JtLWFjdGlvbi5odG1sCShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9oaWRkZW4tc3VibWl0LWJ1dHRvbi1mb3JtLWFj dGlvbi5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIzIEBACis8aHRtbD4KKzxib2R5Pgor ICAgIDxmb3JtIG9uc3VibWl0PSJsb2coJ1BBU1MnKTsgcmV0dXJuIGZhbHNlOyI+CisgICAgICAg IFRoaXMgdGVzdHMgdGhhdCBoaXR0aW5nIHRoZSBlbnRlciBrZXkgb24gYSBpbnB1dCBib3ggZWxl bWVudCB3aXRoIGhpZGRlbiBzdWJtaXQgYnV0dG9uIHN1Ym1pdHMgdGhlIGZvcm0uPGJyPgorICAg ICAgICA8aW5wdXQgaWQ9InRleHRib3gxIi8+CisgICAgICAgIDxpbnB1dCBpZD0idGV4dGJveDIi Lz4KKyAgICAgICAgPGlucHV0IHR5cGU9InN1Ym1pdCIgc3R5bGU9ImRpc3BsYXk6IG5vbmU7IiA+ CisgICAgPC9mb3JtPgorICAgIDxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdD4KKyAg ICB2YXIgdGV4dGJveDIgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGV4dGJveDInKTsKKyAg ICB0ZXh0Ym94Mi5mb2N1cygpOworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp IHsKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAgICBl dmVudFNlbmRlci5rZXlEb3duKCJcciIsIFtdKTsKKyAgICB9CisgICAgZnVuY3Rpb24gbG9nKG1z ZykgeworICAgIHZhciBjb25zb2xlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvbnNvbGUn KTsKKyAgICBjb25zb2xlLmlubmVySFRNTCA9IGNvbnNvbGUuaW5uZXJIVE1MICsgbXNnICsgIjxi cj4iOworICAgIH0KKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo= 106527 2011-09-06 18:05:30 -0700 2011-09-06 18:05:30 -0700 test form-submit.html text/html 700 rniwa PGh0bWw+DQo8Ym9keT4gDQogPGZvcm0gYWN0aW9uPSIvIiBvbnN1Ym1pdD0ibG9nKCdQQVNTJyk7 IHJldHVybiBmYWxzZTsiPiANCiBUaGlzIHRlc3RzIHRoYXQgaGl0dGluZyB0aGUgZW50ZXIga2V5 IG9uIGEgaW5wdXQgYm94IGVsZW1lbnQgd2l0aCBoaWRkZW4gc3VibWl0IGJ1dHRvbiBzdWJtaXRz IHRoZSBmb3JtLjxicj4gDQogPGlucHV0IGlkPSJ0ZXh0Ym94MSIvPiANCiA8aW5wdXQgaWQ9InRl eHRib3gyIi8+IA0KIDxpbnB1dCB0eXBlPSJzdWJtaXQiIHN0eWxlPSJkaXNwbGF5OiBub25lOyIg PiANCiA8L2Zvcm0+IA0KIDxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PiANCjxzY3JpcHQ+IA0KIHZh ciB0ZXh0Ym94MiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0ZXh0Ym94MicpOyANCiB0ZXh0 Ym94Mi5mb2N1cygpOyANCiBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7IA0KIGxh eW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsgDQogZXZlbnRTZW5kZXIua2V5RG93bigi XHIiLCBbXSk7IA0KIH0gDQogZnVuY3Rpb24gbG9nKG1zZykgeyANCiB2YXIgY29uc29sZSA9IGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCdjb25zb2xlJyk7IA0KIGNvbnNvbGUuaW5uZXJIVE1MID0g Y29uc29sZS5pbm5lckhUTUwgKyBtc2cgKyAiPGJyPiI7IA0KIH0gDQo8L3NjcmlwdD4gDQo8L2Jv ZHk+IA0KPC9odG1sPiANCg==