64730 2011-07-18 10:02:35 -0700 REGRESSION (r82194): jvalueToJavaValue() does not correctly set length of String property 2011-07-19 08:57:19 -0700 1 1 1 Unclassified WebKit Java 528+ (Nightly build) All All RESOLVED FIXED Regression P1 Normal --- 1 steveblock steveblock ap steveblock oldest_to_newest 438535 0 steveblock 2011-07-18 10:02:35 -0700 jvalueToJavaValue() does not correctly set the length of the String property created for JavaTypeString because the character array returned by getUCharactersFromJStringInEnv() is not null-terminated. This is due to http://trac.webkit.org/changeset/82194, which switched from using GetStringUTFChars() (via getCharactersFromJString()) to using GetStringChars() (via getUCharactersFromJStringInEnv()). GetStringUTFChars() does null-terminate the character array whereas GetStringChars() does not. 438713 1 ap 2011-07-18 14:17:19 -0700 Marking as a regression per the above. 439062 2 101291 steveblock 2011-07-19 02:46:59 -0700 Created attachment 101291 Patch 439174 3 steveblock 2011-07-19 08:57:19 -0700 Committed r91260: <http://trac.webkit.org/changeset/91260> 101291 2011-07-19 02:46:59 -0700 2011-07-19 08:48:43 -0700 Patch bug-64730-20110719104658.patch text/plain 1894 steveblock U3VidmVyc2lvbiBSZXZpc2lvbjogOTEyNDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkNGJjOGQxMDQ2OGJiYjQ3 OWZjNWIyMWE4ZTYwOWQzY2Q5YmJkYTEzLi5kZmM0YjE4NThkOWQ1YzFhNTk2MDZiOGNhNmM0NWM3 MzNiNjQ1YTU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMTkgIFN0ZXZl IEJsb2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHI4 MjE5NCk6IGp2YWx1ZVRvSmF2YVZhbHVlKCkgZG9lcyBub3QgY29ycmVjdGx5IHNldCBsZW5ndGgg b2YgU3RyaW5nIHByb3BlcnR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02NDczMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBicmlkZ2Uv am5pL3Y4L0pOSVV0aWxpdHlQcml2YXRlLmNwcDoKKyAgICAgICAgKEpTQzo6QmluZGluZ3M6Omp2 YWx1ZVRvSmF2YVZhbHVlKToKKwogMjAxMS0wNy0xOSAgUm9iaW4gUWl1ICA8cm9iaW4ucWl1QHRv cmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYnJpZGdlL2puaS92OC9KTklVdGlsaXR5UHJpdmF0 ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9icmlkZ2Uvam5pL3Y4L0pOSVV0aWxpdHlQcml2YXRlLmNw cAppbmRleCBjOTcxOWQxZGEwYTFiNDViYjliYTgyNjYwYzI4Mjk1OTdlYTBkYWRmLi41YmZlZWJh MThmMzYxMDAyNDYxZWI1Y2Q5YjVlN2Y4NDAzMjJkZTEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9icmlkZ2Uvam5pL3Y4L0pOSVV0aWxpdHlQcml2YXRlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9icmlkZ2Uvam5pL3Y4L0pOSVV0aWxpdHlQcml2YXRlLmNwcApAQCAtMjQ3LDEwICsyNDcs MTAgQEAgSmF2YVZhbHVlIGp2YWx1ZVRvSmF2YVZhbHVlKGNvbnN0IGp2YWx1ZSYgdmFsdWUsIGNv bnN0IEphdmFUeXBlJiB0eXBlKQogICAgIGNhc2UgSmF2YVR5cGVTdHJpbmc6CiAgICAgICAgIHsK ICAgICAgICAgICAgIGpzdHJpbmcgamF2YVN0cmluZyA9IHN0YXRpY19jYXN0PGpzdHJpbmc+KHZh bHVlLmwpOwotICAgICAgICAgICAgY29uc3QgVUNoYXIqIGEgPSBnZXRVQ2hhcmFjdGVyc0Zyb21K U3RyaW5nSW5FbnYoZ2V0Sk5JRW52KCksIGphdmFTdHJpbmcpOworICAgICAgICAgICAgY29uc3Qg VUNoYXIqIGNoYXJhY3RlcnMgPSBnZXRVQ2hhcmFjdGVyc0Zyb21KU3RyaW5nSW5FbnYoZ2V0Sk5J RW52KCksIGphdmFTdHJpbmcpOwogICAgICAgICAgICAgLy8gV2UgdGFrZSBhIGNvcHkgdG8gYWxs b3cgdGhlIEphdmEgU3RyaW5nIHRvIGJlIHJlbGVhc2VkLgotICAgICAgICAgICAgcmVzdWx0Lm1f c3RyaW5nVmFsdWUgPSBTdHJpbmcoYSkudGhyZWFkc2FmZUNvcHkoKTsKLSAgICAgICAgICAgIHJl bGVhc2VVQ2hhcmFjdGVyc0ZvckpTdHJpbmdJbkVudihnZXRKTklFbnYoKSwgamF2YVN0cmluZywg YSk7CisgICAgICAgICAgICByZXN1bHQubV9zdHJpbmdWYWx1ZSA9IFN0cmluZyhjaGFyYWN0ZXJz LCBnZXRKTklFbnYoKS0+R2V0U3RyaW5nTGVuZ3RoKGphdmFTdHJpbmcpKTsKKyAgICAgICAgICAg IHJlbGVhc2VVQ2hhcmFjdGVyc0ZvckpTdHJpbmdJbkVudihnZXRKTklFbnYoKSwgamF2YVN0cmlu ZywgY2hhcmFjdGVycyk7CiAgICAgICAgIH0KICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBKYXZh VHlwZUJvb2xlYW46Cg==