64690 2011-07-18 06:02:45 -0700 [Qt][WK2] Make QDesktopWebView::navigationAction method usable in QML. 2011-07-19 04:07:05 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 menard menard benjamin kling webkit.review.bot oldest_to_newest 438426 0 menard 2011-07-18 06:02:45 -0700 [Qt][WK2] Implement load/back/forward/stop/reload for QDesktopWebView. 438428 1 101153 menard 2011-07-18 06:05:37 -0700 Created attachment 101153 Patch 438429 2 webkit.review.bot 2011-07-18 06:08:19 -0700 Attachment 101153 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp:24: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 438430 3 menard 2011-07-18 06:11:02 -0700 (In reply to comment #2) > Attachment 101153 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 > > Source/WebKit2/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] > Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp:24: Alphabetical sorting problem. [build/include_order] [4] > Total errors found: 2 in 3 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. I believe it's good like that. 438433 4 101153 benjamin 2011-07-18 06:29:45 -0700 Comment on attachment 101153 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101153&action=review + this needs tests :) >> Source/WebKit2/ChangeLog:6 >> + Just hook up to the QtWebPage proxy to trigger the appropriate actions. > > Line contains tab character. [whitespace/tab] [5] Uh :) > Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp:202 > +void QDesktopWebView::back() > +{ > + d->page.triggerAction(QtWebPageProxy::Back); > +} > + > +void QDesktopWebView::forward() > +{ > + d->page.triggerAction(QtWebPageProxy::Forward); > +} > + > +void QDesktopWebView::reload() > +{ > + d->page.triggerAction(QtWebPageProxy::Reload); > +} > + > +void QDesktopWebView::stop() > +{ > + d->page.triggerAction(QtWebPageProxy::Stop); > +} > + Those should call navigationAction(). > Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:57 > + void back(); > + void forward(); > + void reload(); > + void stop(); I am not fan of this. I like the "goBack", "goForward" from Cocoa's WebView :) The stop, reload, back and forward action are all conditional to the state of the engine. Because of that QAction make much more sense than those slots. 438646 5 menard 2011-07-18 12:56:34 -0700 I think in general we should make QDesktopWebView usable directly in QML. People should be able to do import QtWebKit 2.0 and get a ready to use QML element. Today we need to create a stupid wrapper just to QML_DECLARE_TYPE, forward the signals, add properties declarations and add the proper Q_INVOKABLE. I don't see why QDesktopWebView could not inherits from QDeclarativeItem directly (or whatever replacement comes with Qt Quick 2.0) because anyway our supported path in the future is QML, the C++ API being a nice fallback. Any thoughts? 438665 6 101196 menard 2011-07-18 13:26:56 -0700 Created attachment 101196 Patch 438841 7 101196 benjamin 2011-07-18 16:58:37 -0700 Comment on attachment 101196 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101196&action=review > Source/WebKit2/ChangeLog:3 > + [Qt][WK2] Make QDesktopWebView QML friendly. You should have a more descriptive title for this. 439086 8 menard 2011-07-19 04:07:05 -0700 Committed r91248: <http://trac.webkit.org/changeset/91248> 101153 2011-07-18 06:05:37 -0700 2011-07-18 13:26:50 -0700 Patch bug-64690-20110718100455.patch text/plain 2397 menard SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxMTc4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDctMTggIEFsZXhpcyBN ZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1F0XVtXSzJd IEltcGxlbWVudCBsb2FkL2JhY2svZm9yd2FyZC9zdG9wL3JlbG9hZCBmb3IgUURlc2t0b3BXZWJW aWV3LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ2 OTAKKworCUp1c3QgaG9vayB1cCB0byB0aGUgUXRXZWJQYWdlIHByb3h5IHRvIHRyaWdnZXIgdGhl IGFwcHJvcHJpYXRlIGFjdGlvbnMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FkZXNrdG9wd2Vidmlldy5jcHA6Cisg ICAgICAgIChRRGVza3RvcFdlYlZpZXc6OmxvYWQpOgorICAgICAgICAoUURlc2t0b3BXZWJWaWV3 OjpiYWNrKToKKyAgICAgICAgKFFEZXNrdG9wV2ViVmlldzo6Zm9yd2FyZCk6CisgICAgICAgIChR RGVza3RvcFdlYlZpZXc6OnJlbG9hZCk6CisgICAgICAgIChRRGVza3RvcFdlYlZpZXc6OnN0b3Ap OgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcWRlc2t0b3B3ZWJ2aWV3Lmg6CisKIDIwMTEt MDctMTcgIEFtcnV0aCBSYWogIDxhbXJ1dGhyYWpAbW90b3JvbGEuY29tPgogCiAgICAgICAgIFtH VEtdIEZpeCBzZWxlY3Rpb24gb2YgZWxlbWVudHMgaW4gYSBtdWx0aSBzZWxlY3QgbGlzdCBhbmQg cmVtb3ZlIGFuIHVubmVjZXNzYXJ5IGluY2x1ZGUgaW4gV29ya1F1ZXVlCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FkZXNrdG9wd2Vidmlldy5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZGVza3RvcHdlYnZpZXcuY3BwCShy ZXZpc2lvbiA5MTE3NykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWRlc2t0 b3B3ZWJ2aWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjEsNiArMjEsNyBAQAogI2luY2x1ZGUg ImNvbmZpZy5oIgogI2luY2x1ZGUgInFkZXNrdG9wd2Vidmlldy5oIgogI2luY2x1ZGUgInFkZXNr dG9wd2Vidmlld19wLmgiCisjaW5jbHVkZSAiUXRXZWJQYWdlUHJveHkuaCIKICNpbmNsdWRlICJx d2tjb250ZXh0LmgiCiAKICNpbmNsdWRlIDxRQ3Vyc29yPgpAQCAtMTc5LDYgKzE4MCwyNiBAQCB2 b2lkIFFEZXNrdG9wV2ViVmlldzo6bG9hZChjb25zdCBRVXJsJiB1CiAgICAgZC0+cGFnZS5sb2Fk KHVybCk7CiB9CiAKK3ZvaWQgUURlc2t0b3BXZWJWaWV3OjpiYWNrKCkKK3sKKyAgICBkLT5wYWdl LnRyaWdnZXJBY3Rpb24oUXRXZWJQYWdlUHJveHk6OkJhY2spOworfQorCit2b2lkIFFEZXNrdG9w V2ViVmlldzo6Zm9yd2FyZCgpCit7CisgICAgZC0+cGFnZS50cmlnZ2VyQWN0aW9uKFF0V2ViUGFn ZVByb3h5OjpGb3J3YXJkKTsKK30KKwordm9pZCBRRGVza3RvcFdlYlZpZXc6OnJlbG9hZCgpCit7 CisgICAgZC0+cGFnZS50cmlnZ2VyQWN0aW9uKFF0V2ViUGFnZVByb3h5OjpSZWxvYWQpOworfQor Cit2b2lkIFFEZXNrdG9wV2ViVmlldzo6c3RvcCgpCit7CisgICAgZC0+cGFnZS50cmlnZ2VyQWN0 aW9uKFF0V2ViUGFnZVByb3h5OjpTdG9wKTsKK30KKwogUVVybCBRRGVza3RvcFdlYlZpZXc6OnVy bCgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIGQtPnBhZ2UudXJsKCk7CkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FkZXNrdG9wd2Vidmlldy5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWRlc2t0b3B3ZWJ2aWV3LmgJKHJldmlzaW9u IDkxMTc3KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZGVza3RvcHdlYnZp ZXcuaAkod29ya2luZyBjb3B5KQpAQCAtNTEsNiArNTEsMTAgQEAgcHVibGljOgogCiBwdWJsaWMg UV9TTE9UUzoKICAgICAgdm9pZCBsb2FkKGNvbnN0IFFVcmwmKTsKKyAgICAgdm9pZCBiYWNrKCk7 CisgICAgIHZvaWQgZm9yd2FyZCgpOworICAgICB2b2lkIHJlbG9hZCgpOworICAgICB2b2lkIHN0 b3AoKTsKIAogUV9TSUdOQUxTOgogICAgIHZvaWQgdGl0bGVDaGFuZ2VkKGNvbnN0IFFTdHJpbmcm KTsK 101196 2011-07-18 13:26:56 -0700 2011-07-18 16:58:37 -0700 Patch bug-64690-20110718172613.patch text/plain 1466 menard SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxMjA0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDctMTggIEFsZXhpcyBN ZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1F0XVtXSzJd IE1ha2UgUURlc2t0b3BXZWJWaWV3IFFNTCBmcmllbmRseS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0NjkwCisKKyAgICAgICAgTWFrZSB0aGUgQVBJ IHVzYWJsZSB3aXRoIFFNTC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcWRlc2t0b3B3ZWJ2aWV3Lmg6CisKIDIwMTEt MDctMTggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBN YWtlIHVzaW5nIGxvd2VyY2FzZSBwYXJhbWV0ZXIgbmFtZXMgZm9yIEFwcGxlQ29ubmVjdCBiZSBh IHBsdWctaW4gcXVpcmsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWRl c2t0b3B3ZWJ2aWV3LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9xdC9xZGVza3RvcHdlYnZpZXcuaAkocmV2aXNpb24gOTExNzcpCisrKyBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL3F0L3FkZXNrdG9wd2Vidmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC00 MCw2ICs0MCw4IEBAIGNsYXNzIFFXRUJLSVRfRVhQT1JUIFFEZXNrdG9wV2ViVmlldyA6IHAKICAg ICBRX1BST1BFUlRZKFFTdHJpbmcgdGl0bGUgUkVBRCB0aXRsZSBOT1RJRlkgdGl0bGVDaGFuZ2Vk KQogICAgIFFfUFJPUEVSVFkoUVVybCB1cmwgUkVBRCB1cmwgTk9USUZZIHVybENoYW5nZWQpCiAK KyAgICBRX0VOVU1TKE5hdmlnYXRpb25BY3Rpb24pCisKIHB1YmxpYzoKICAgICBRRGVza3RvcFdl YlZpZXcoKTsKICAgICB2aXJ0dWFsIH5RRGVza3RvcFdlYlZpZXcoKTsKQEAgLTQ3LDcgKzQ5LDcg QEAgcHVibGljOgogICAgIFFVcmwgdXJsKCkgY29uc3Q7CiAgICAgUVN0cmluZyB0aXRsZSgpIGNv bnN0OwogCi0gICAgUUFjdGlvbiogbmF2aWdhdGlvbkFjdGlvbihRdFdlYktpdDo6TmF2aWdhdGlv bkFjdGlvbiB3aGljaCkgY29uc3Q7CisgICAgUV9JTlZPS0FCTEUgUUFjdGlvbiogbmF2aWdhdGlv bkFjdGlvbihRdFdlYktpdDo6TmF2aWdhdGlvbkFjdGlvbiB3aGljaCkgY29uc3Q7CiAKIHB1Ymxp YyBRX1NMT1RTOgogICAgICB2b2lkIGxvYWQoY29uc3QgUVVybCYpOwo=