64680 2011-07-18 00:00:48 -0700 Style bot complains about EFL-specific forward declaration naming. 2011-07-27 23:20:02 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi abarth eric gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 438357 0 ryuan.choi 2011-07-18 00:00:48 -0700 It's for teaching the style scripts to ignore EFL specific types, Ecore_XXX and Evas_XXX and Eina_XXX. 438359 1 101133 ryuan.choi 2011-07-18 00:07:36 -0700 Created attachment 101133 Patch 439619 2 gyuyoung.kim 2011-07-19 22:17:45 -0700 LGTM. 443359 3 101133 webkit.review.bot 2011-07-27 23:19:57 -0700 Comment on attachment 101133 Patch Clearing flags on attachment: 101133 Committed r91911: <http://trac.webkit.org/changeset/91911> 443360 4 webkit.review.bot 2011-07-27 23:20:02 -0700 All reviewed patches have been landed. Closing bug. 101133 2011-07-18 00:07:36 -0700 2011-07-27 23:19:57 -0700 Patch bug-64680-20110718160731.patch text/plain 2912 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogOTExNzMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0ZDQzZjFlZGJkOWQzMDUxNmYxZWUzMDNkMzc4MzRhNmQ4 ZTMyOTcwLi4wOTM4M2M0MDcwMzQ2OGE5NWE3MmNjOGE3MWZjZDUzYTQ0NDg4ZDllIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDctMTggIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisg ICAgICAgIFN0eWxlIGJvdCBjb21wbGFpbnMgYWJvdXQgRUZMLXNwZWNpZmljIGZvcndhcmQgZGVj bGFyYXRpb24gbmFtaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjQ2ODAKKworICAgICAgICBFeGNsdWRlIEVGTC1zcGVjaWZpYyBmb3J3YXJkIGRl Y2xhcmF0aW9ucyBmcm9tIGluZGVudGlmaWVycyB3aXRoIHVuZGVyc2NvcmVzIGNoZWNrcy4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorCiAyMDExLTA3LTE3ICBQaGlsaXBw ZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICB0ZXN0LXdlYmtpdHB5 IGZhaWxpbmcgd2l0aCBQeXRob24gMi41CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwLnB5CmluZGV4IDk2M2MwZjJiZWI4MmUxY2ZjNzlmNmM3ODRlYWJiOWJkODlh YjMxZmUuLjYyMjdhNmJmNmMxNjYxYWM2MjYzNzBmMDkwMDliOTE1MDQxYjU2OWQgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0zMDUxLDYgKzMw NTEsOSBAQCBkZWYgY2hlY2tfaWRlbnRpZmllcl9uYW1lX2luX2RlY2xhcmF0aW9uKGZpbGVuYW1l LCBsaW5lX251bWJlciwgbGluZSwgZmlsZV9zdGF0ZQogICAgICAgICAgICAgICAgIGFuZCBub3Qg bW9kaWZpZWRfaWRlbnRpZmllci5zdGFydHN3aXRoKCdOUF8nKQogICAgICAgICAgICAgICAgIGFu ZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllci5zdGFydHN3aXRoKCdxdF8nKQogICAgICAgICAgICAg ICAgIGFuZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllci5zdGFydHN3aXRoKCdjYWlyb18nKQorICAg ICAgICAgICAgICAgIGFuZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllci5zdGFydHN3aXRoKCdFY29y ZV8nKQorICAgICAgICAgICAgICAgIGFuZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllci5zdGFydHN3 aXRoKCdFaW5hXycpCisgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVy LnN0YXJ0c3dpdGgoJ0V2YXNfJykKICAgICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lk ZW50aWZpZXIuZmluZCgnOjpxdF8nKSA+PSAwCiAgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2Rp ZmllZF9pZGVudGlmaWVyID09ICJjb25zdF9pdGVyYXRvciIKICAgICAgICAgICAgICAgICBhbmQg bm90IG1vZGlmaWVkX2lkZW50aWZpZXIgPT0gInZtX3Rocm93Iik6CmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IDI4 MjlhOWY2ZWRlMTRlZjg3YzY4YzAzNTRmM2JhNTY5NjAxMDdhZjQuLjNkMjE1ODg4MzVhOTE4NGQ0 ZDI0OGFmM2JjM2JhYjYzOTdjZDlmYTkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC00Mzc1LDYgKzQzNzUsMTIg QEAgY2xhc3MgV2ViS2l0U3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICBzZWxm LmFzc2VydF9saW50KCd0eXBlZGVmIHN0cnVjdCBfY2Fpcm9fc3VyZmFjZSBjYWlyb19zdXJmYWNl X3Q7JywgJycpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ3R5cGVkZWYgc3RydWN0IF9jYWly b19zY2FsZWRfZm9udCBjYWlyb19zY2FsZWRfZm9udF90OycsICcnKQogCisgICAgICAgICMgRUZM IGZvcndhcmQtZGVjbGFyYXRpb25zIHNob3VsZCBub3QgYmUgYSBmYWlsdXJlLgorICAgICAgICBz ZWxmLmFzc2VydF9saW50KCd0eXBlZGVmIHN0cnVjdCBfRWNvcmVfRXZhcyBFY29yZV9FdmFzOycs ICcnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCd0eXBlZGVmIHN0cnVjdCBfRWNvcmVfUGlw ZSBFY29yZV9QaXBlOycsICcnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCd0eXBlZGVmIHN0 cnVjdCBfRWluYV9SZWN0YW5nbGUgRWluYV9SZWN0YW5nbGU7JywgJycpCisgICAgICAgIHNlbGYu YXNzZXJ0X2xpbnQoJ3R5cGVkZWYgc3RydWN0IF9FdmFzX09iamVjdCBFdmFzX09iamVjdDsnLCAn JykKKwogICAgICAgICAjIE5QQVBJIGZ1bmN0aW9ucyB0aGF0IHN0YXJ0IHdpdGggTlBOXywgTlBQ XyBvciBOUF8gYXJlIGFsbG93ZWQuCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ3ZvaWQgTlBO X1N0YXR1cyhOUFAsIGNvbnN0IGNoYXIqKScsICcnKQogICAgICAgICBzZWxmLmFzc2VydF9saW50 KCdOUEVycm9yIE5QUF9TZXRXaW5kb3coTlBQIGluc3RhbmNlLCBOUFdpbmRvdyAqd2luZG93KScs ICcnKQo=