64666 2011-07-17 00:23:14 -0700 [GTK] Fix selection of elements in a multi select list and remove an unnecessary include in WorkQueue 2011-07-17 23:30:47 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 amruthraj webkit-unassigned cgarcia mrobinson ravi.kasibhatla webkit.review.bot oldest_to_newest 438261 0 amruthraj 2011-07-17 00:23:14 -0700 Selecting multiple elements in a multi select list isn't working. 438262 1 101112 amruthraj 2011-07-17 00:38:08 -0700 Created attachment 101112 Enable multiple items selection in a multi select list 438294 2 101112 mrobinson 2011-07-17 10:29:14 -0700 Comment on attachment 101112 Enable multiple items selection in a multi select list View in context: https://bugs.webkit.org/attachment.cgi?id=101112&action=review > Source/WebKit2/Shared/gtk/WebEventFactory.cpp:54 > + bool isStatePresent = gdk_event_get_state(event, &state); > + if (!isStatePresent) Might as well compress this into one line: if (!gdk_event_get_state(event, &state)) or is there a reason why that isn't a good idea? 438296 3 mrobinson 2011-07-17 10:31:32 -0700 *** This bug has been marked as a duplicate of bug 63081 *** 438332 4 amruthraj 2011-07-17 21:59:11 -0700 The bug here is that the modifier key information like ctrl/alt is not being sent during mouse clicks. Hence, when ctrl-click is done to select multiple items, it fails. This is not a dup of 63081. I will address your comment and upload a new patch. I wanted to capture why gdk_event_get_state may return false and hence I kept a variable indicating it. I will instead put it as a comment. 438335 5 101125 amruthraj 2011-07-17 22:09:18 -0700 Created attachment 101125 Enable multiple items selection in a multi select list 438337 6 101126 amruthraj 2011-07-17 22:14:09 -0700 Created attachment 101126 Enable multiple items selection in a multi select list 438340 7 mrobinson 2011-07-17 22:33:53 -0700 (In reply to comment #4) > The bug here is that the modifier key information like ctrl/alt is not being sent during mouse clicks. Hence, when ctrl-click is done to select multiple items, it fails. This is not a dup of 63081. > I will address your comment and upload a new patch. I wanted to capture why gdk_event_get_state may return false and hence I kept a variable indicating it. I will instead put it as a comment. Please accept my apologies. I meant to mark 64667 as a duplicate, not this bug! 438351 8 101126 webkit.review.bot 2011-07-17 23:30:43 -0700 Comment on attachment 101126 Enable multiple items selection in a multi select list Clearing flags on attachment: 101126 Committed r91173: <http://trac.webkit.org/changeset/91173> 438352 9 webkit.review.bot 2011-07-17 23:30:47 -0700 All reviewed patches have been landed. Closing bug. 101112 2011-07-17 00:38:08 -0700 2011-07-17 22:09:18 -0700 Enable multiple items selection in a multi select list fix-64666.patch text/plain 2343 amruthraj SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxMTY1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMTcgIEFtcnV0aCBS YWogIDxhbXJ1dGhyYWpAbW90b3JvbGEuY29tPgorCisgICAgICAgIFtHVEtdIEZpeCBzZWxlY3Rp b24gb2YgZWxlbWVudHMgaW4gYSBtdWx0aSBzZWxlY3QgbGlzdCBhbmQgcmVtb3ZlIGFuIHVubmVj ZXNzYXJ5IGluY2x1ZGUgaW4gV29ya1F1ZXVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NDY2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogUGxhdGZvcm0vZ3RrL1dvcmtRdWV1ZUd0ay5jcHA6IFJlbW92 ZSBhbiBpbmNsdWRlIHdoaWNoIGlzIG5vIGxvbmdlciByZXF1aXJlZAorICAgICAgICAqIFNoYXJl ZC9ndGsvV2ViRXZlbnRGYWN0b3J5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6bW9kaWZpZXJzRm9y RXZlbnQpOiBGaXggYW4gaW5jb3JyZWN0IEFTU0VSVCBzdGF0ZW1lbnQKKyAgICAgICAgKFdlYktp dDo6V2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWJNb3VzZUV2ZW50KTogQ2FsbCB0aGUgZnVuY3Rp b24gdG8gZGV0ZXJtaW5lIHRoZSBtb2RpZmllciBrZXlzCisKIDIwMTEtMDctMTYgIERhbmllbCBC YXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBXaW4gQ2Fpcm8gRGVidWcg YnVpbGQgYWZ0ZXIgPGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzkxMDg1Pi4KSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL2d0ay9Xb3JrUXVldWVHdGsuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL2d0ay9Xb3JrUXVldWVHdGsuY3BwCShyZXZp c2lvbiA5MTE2NSkKKysrIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL2d0ay9Xb3JrUXVldWVHdGsu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOSw3ICsyOSw2IEBACiAjaW5jbHVkZSAiV29ya1F1ZXVl LmgiCiAKICNpbmNsdWRlICJXS0Jhc2UuaCIKLSNpbmNsdWRlIDxXZWJDb3JlL05vdEltcGxlbWVu dGVkLmg+CiAjaW5jbHVkZSA8Z2lvL2dpby5oPgogI2luY2x1ZGUgPGdsaWIuaD4KICNpbmNsdWRl IDx3dGYvZ29iamVjdC9HUmVmUHRyLmg+CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvZ3Rr L1dlYkV2ZW50RmFjdG9yeS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVk L2d0ay9XZWJFdmVudEZhY3RvcnkuY3BwCShyZXZpc2lvbiA5MTE2NSkKKysrIFNvdXJjZS9XZWJL aXQyL1NoYXJlZC9ndGsvV2ViRXZlbnRGYWN0b3J5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTAs NyArNTAsOSBAQCBzdGF0aWMgaW5saW5lIFdlYkV2ZW50OjpNb2RpZmllcnMgbW9kaWZpCiAgICAg dW5zaWduZWQgbW9kaWZpZXJzID0gMDsKICAgICBHZGtNb2RpZmllclR5cGUgc3RhdGU7CiAKLSAg ICBBU1NFUlQoZ2RrX2V2ZW50X2dldF9zdGF0ZShldmVudCwgJnN0YXRlKSk7CisgICAgYm9vbCBp c1N0YXRlUHJlc2VudCA9IGdka19ldmVudF9nZXRfc3RhdGUoZXZlbnQsICZzdGF0ZSk7CisgICAg aWYgKCFpc1N0YXRlUHJlc2VudCkKKyAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PFdlYkV2ZW50 OjpNb2RpZmllcnM+KDApOwogCiAgICAgaWYgKHN0YXRlICYgR0RLX0NPTlRST0xfTUFTSykKICAg ICAgICAgbW9kaWZpZXJzIHw9IFdlYkV2ZW50OjpDb250cm9sS2V5OwpAQCAtMTI3LDcgKzEyOSw3 IEBAIFdlYk1vdXNlRXZlbnQgV2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWIKICAgICAgICAgICAg ICAgICAgICAgICAgICAwIC8qIGRlbHRhWSAqLywKICAgICAgICAgICAgICAgICAgICAgICAgICAw IC8qIGRlbHRhWiAqLywKICAgICAgICAgICAgICAgICAgICAgICAgICBjdXJyZW50Q2xpY2tDb3Vu dCwKLSAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0aWNfY2FzdDxXZWJFdmVudDo6TW9kaWZp ZXJzPigwKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICBtb2RpZmllcnNGb3JFdmVudChldmVu dCksCiAgICAgICAgICAgICAgICAgICAgICAgICAgZ2RrX2V2ZW50X2dldF90aW1lKGV2ZW50KSk7 CiB9CiAK 101125 2011-07-17 22:09:18 -0700 2011-07-17 22:14:09 -0700 Enable multiple items selection in a multi select list fix-64666-1.patch text/plain 2312 amruthraj SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxMTcxKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMTggIEFtcnV0aCBS YWogIDxhbXJ1dGhyYWpAbW90b3JvbGEuY29tPgorCisgICAgICAgIFtHVEtdIEZpeCBzZWxlY3Rp b24gb2YgZWxlbWVudHMgaW4gYSBtdWx0aSBzZWxlY3QgbGlzdCBhbmQgcmVtb3ZlIGFuIHVubmVj ZXNzYXJ5IGluY2x1ZGUgaW4gV29ya1F1ZXVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NDY2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogUGxhdGZvcm0vZ3RrL1dvcmtRdWV1ZUd0ay5jcHA6IFJlbW92 ZSBhbiBpbmNsdWRlIHdoaWNoIGlzIG5vIGxvbmdlciByZXF1aXJlZAorICAgICAgICAqIFNoYXJl ZC9ndGsvV2ViRXZlbnRGYWN0b3J5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6bW9kaWZpZXJzRm9y RXZlbnQpOiBGaXggYW4gaW5jb3JyZWN0IEFTU0VSVCBzdGF0ZW1lbnQKKyAgICAgICAgKFdlYktp dDo6V2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWJNb3VzZUV2ZW50KTogQ2FsbCB0aGUgZnVuY3Rp b24gdG8gZGV0ZXJtaW5lIHRoZSBtb2RpZmllciBrZXlzCisKIDIwMTEtMDctMTcgIEx1a2FzeiBT bGFjaGNpYWsgIDxsLnNsYWNoY2lha0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBNYXJ0aW4gUm9iaW5zb24uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9ndGsvV29y a1F1ZXVlR3RrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9ndGsv V29ya1F1ZXVlR3RrLmNwcAkocmV2aXNpb24gOTExNzEpCisrKyBTb3VyY2UvV2ViS2l0Mi9QbGF0 Zm9ybS9ndGsvV29ya1F1ZXVlR3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjksNyArMjksNiBA QAogI2luY2x1ZGUgIldvcmtRdWV1ZS5oIgogCiAjaW5jbHVkZSAiV0tCYXNlLmgiCi0jaW5jbHVk ZSA8V2ViQ29yZS9Ob3RJbXBsZW1lbnRlZC5oPgogI2luY2x1ZGUgPGdpby9naW8uaD4KICNpbmNs dWRlIDxnbGliLmg+CiAjaW5jbHVkZSA8d3RmL2dvYmplY3QvR1JlZlB0ci5oPgpJbmRleDogU291 cmNlL1dlYktpdDIvU2hhcmVkL2d0ay9XZWJFdmVudEZhY3RvcnkuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9ndGsvV2ViRXZlbnRGYWN0b3J5LmNwcAkocmV2aXNpb24g OTExNzEpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvZ3RrL1dlYkV2ZW50RmFjdG9yeS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTUwLDcgKzUwLDkgQEAgc3RhdGljIGlubGluZSBXZWJFdmVudDo6 TW9kaWZpZXJzIG1vZGlmaQogICAgIHVuc2lnbmVkIG1vZGlmaWVycyA9IDA7CiAgICAgR2RrTW9k aWZpZXJUeXBlIHN0YXRlOwogCi0gICAgQVNTRVJUKGdka19ldmVudF9nZXRfc3RhdGUoZXZlbnQs ICZzdGF0ZSkpOworICAgIC8qIGNoZWNrIGZvciBhIHZhbGlkIHN0YXRlIGluIEdka0V2ZW50ICov CisgICAgaWYgKCFnZGtfZXZlbnRfZ2V0X3N0YXRlKGV2ZW50LCAmc3RhdGUpKQorICAgICAgICBy ZXR1cm4gc3RhdGljX2Nhc3Q8V2ViRXZlbnQ6Ok1vZGlmaWVycz4oMCk7CiAKICAgICBpZiAoc3Rh dGUgJiBHREtfQ09OVFJPTF9NQVNLKQogICAgICAgICBtb2RpZmllcnMgfD0gV2ViRXZlbnQ6OkNv bnRyb2xLZXk7CkBAIC0xMjcsNyArMTI5LDcgQEAgV2ViTW91c2VFdmVudCBXZWJFdmVudEZhY3Rv cnk6OmNyZWF0ZVdlYgogICAgICAgICAgICAgICAgICAgICAgICAgIDAgLyogZGVsdGFZICovLAog ICAgICAgICAgICAgICAgICAgICAgICAgIDAgLyogZGVsdGFaICovLAogICAgICAgICAgICAgICAg ICAgICAgICAgIGN1cnJlbnRDbGlja0NvdW50LAotICAgICAgICAgICAgICAgICAgICAgICAgIHN0 YXRpY19jYXN0PFdlYkV2ZW50OjpNb2RpZmllcnM+KDApLAorICAgICAgICAgICAgICAgICAgICAg ICAgIG1vZGlmaWVyc0ZvckV2ZW50KGV2ZW50KSwKICAgICAgICAgICAgICAgICAgICAgICAgICBn ZGtfZXZlbnRfZ2V0X3RpbWUoZXZlbnQpKTsKIH0KIAo= 101126 2011-07-17 22:14:09 -0700 2011-07-17 23:30:43 -0700 Enable multiple items selection in a multi select list fix-64666-1.patch text/plain 2310 amruthraj SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxMTcxKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMTggIEFtcnV0aCBS YWogIDxhbXJ1dGhyYWpAbW90b3JvbGEuY29tPgorCisgICAgICAgIFtHVEtdIEZpeCBzZWxlY3Rp b24gb2YgZWxlbWVudHMgaW4gYSBtdWx0aSBzZWxlY3QgbGlzdCBhbmQgcmVtb3ZlIGFuIHVubmVj ZXNzYXJ5IGluY2x1ZGUgaW4gV29ya1F1ZXVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NDY2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogUGxhdGZvcm0vZ3RrL1dvcmtRdWV1ZUd0ay5jcHA6IFJlbW92 ZSBhbiBpbmNsdWRlIHdoaWNoIGlzIG5vIGxvbmdlciByZXF1aXJlZAorICAgICAgICAqIFNoYXJl ZC9ndGsvV2ViRXZlbnRGYWN0b3J5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6bW9kaWZpZXJzRm9y RXZlbnQpOiBGaXggYW4gaW5jb3JyZWN0IEFTU0VSVCBzdGF0ZW1lbnQKKyAgICAgICAgKFdlYktp dDo6V2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWJNb3VzZUV2ZW50KTogQ2FsbCB0aGUgZnVuY3Rp b24gdG8gZGV0ZXJtaW5lIHRoZSBtb2RpZmllciBrZXlzCisKIDIwMTEtMDctMTcgIEx1a2FzeiBT bGFjaGNpYWsgIDxsLnNsYWNoY2lha0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBNYXJ0aW4gUm9iaW5zb24uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9ndGsvV29y a1F1ZXVlR3RrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9ndGsv V29ya1F1ZXVlR3RrLmNwcAkocmV2aXNpb24gOTExNzEpCisrKyBTb3VyY2UvV2ViS2l0Mi9QbGF0 Zm9ybS9ndGsvV29ya1F1ZXVlR3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjksNyArMjksNiBA QAogI2luY2x1ZGUgIldvcmtRdWV1ZS5oIgogCiAjaW5jbHVkZSAiV0tCYXNlLmgiCi0jaW5jbHVk ZSA8V2ViQ29yZS9Ob3RJbXBsZW1lbnRlZC5oPgogI2luY2x1ZGUgPGdpby9naW8uaD4KICNpbmNs dWRlIDxnbGliLmg+CiAjaW5jbHVkZSA8d3RmL2dvYmplY3QvR1JlZlB0ci5oPgpJbmRleDogU291 cmNlL1dlYktpdDIvU2hhcmVkL2d0ay9XZWJFdmVudEZhY3RvcnkuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9ndGsvV2ViRXZlbnRGYWN0b3J5LmNwcAkocmV2aXNpb24g OTExNzEpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvZ3RrL1dlYkV2ZW50RmFjdG9yeS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTUwLDcgKzUwLDkgQEAgc3RhdGljIGlubGluZSBXZWJFdmVudDo6 TW9kaWZpZXJzIG1vZGlmaQogICAgIHVuc2lnbmVkIG1vZGlmaWVycyA9IDA7CiAgICAgR2RrTW9k aWZpZXJUeXBlIHN0YXRlOwogCi0gICAgQVNTRVJUKGdka19ldmVudF9nZXRfc3RhdGUoZXZlbnQs ICZzdGF0ZSkpOworICAgIC8vIENoZWNrIGZvciBhIHZhbGlkIHN0YXRlIGluIEdka0V2ZW50Lgor ICAgIGlmICghZ2RrX2V2ZW50X2dldF9zdGF0ZShldmVudCwgJnN0YXRlKSkKKyAgICAgICAgcmV0 dXJuIHN0YXRpY19jYXN0PFdlYkV2ZW50OjpNb2RpZmllcnM+KDApOwogCiAgICAgaWYgKHN0YXRl ICYgR0RLX0NPTlRST0xfTUFTSykKICAgICAgICAgbW9kaWZpZXJzIHw9IFdlYkV2ZW50OjpDb250 cm9sS2V5OwpAQCAtMTI3LDcgKzEyOSw3IEBAIFdlYk1vdXNlRXZlbnQgV2ViRXZlbnRGYWN0b3J5 OjpjcmVhdGVXZWIKICAgICAgICAgICAgICAgICAgICAgICAgICAwIC8qIGRlbHRhWSAqLywKICAg ICAgICAgICAgICAgICAgICAgICAgICAwIC8qIGRlbHRhWiAqLywKICAgICAgICAgICAgICAgICAg ICAgICAgICBjdXJyZW50Q2xpY2tDb3VudCwKLSAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0 aWNfY2FzdDxXZWJFdmVudDo6TW9kaWZpZXJzPigwKSwKKyAgICAgICAgICAgICAgICAgICAgICAg ICBtb2RpZmllcnNGb3JFdmVudChldmVudCksCiAgICAgICAgICAgICAgICAgICAgICAgICAgZ2Rr X2V2ZW50X2dldF90aW1lKGV2ZW50KSk7CiB9CiAK