64665 2011-07-16 21:43:55 -0700 [Cairo] Implement ShareableBitmap::paint() with scale factor 2014-04-10 12:03:51 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Cairo P2 Normal --- 74010 1 dbates mrobinson bfulgham cgarcia commit-queue kbalazs mrobinson otaylor oldest_to_newest 438246 0 dbates 2011-07-16 21:43:55 -0700 Implement the scale factor variant of ShareableBitmap::paint(). One such usage of this variant is in changeset <http://trac.webkit.org/changeset/91085>. In particular, the change to Source/WebKit2/UIProcess/FindIndicator.cpp. For completeness, the scale factor variant of ShareableBitmap::paint() was added to the CG port in <http://trac.webkit.org/changeset/90198>. 438248 1 dbates 2011-07-16 21:57:32 -0700 The WinCairo Debug build fails to compile because this variant of ShareableBitmap::paint() wasn't implemented for Cairo at the time changeset 91085 <http://trac.webkit.org/changeset/91085> landed: [[ 5>libjpeg.lib(jdapistd.obj) : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance 5>LINK : warning LNK4075: ignoring '/INCREMENTAL' due to '/LTCG' specification 5> Creating library D:\Projects\BuildSlave\win-cairo-debug\build\WebKitBuild\Debug_Cairo_CFLite\lib\WebKit_debug.lib and object D:\Projects\BuildSlave\win-cairo-debug\build\WebKitBuild\Debug_Cairo_CFLite\lib\WebKit_debug.exp 5>FindIndicator.obj : error LNK2001: unresolved external symbol "public: void __thiscall WebKit::ShareableBitmap::paint(class WebCore::GraphicsContext &,float,class WebCore::IntPoint const &,class WebCore::IntRect const &)" (?paint@ShareableBitmap@WebKit@@QAEXAAVGraphicsContext@WebCore@@MABVIntPoint@4@ABVIntRect@4@@Z) 5>D:\Projects\BuildSlave\win-cairo-debug\build\WebKitBuild\Debug_Cairo_CFLite\bin\WebKit_debug.dll : fatal error LNK1120: 1 unresolved externals 5>Build log was saved at "file://D:\Projects\BuildSlave\win-cairo-debug\build\WebKitBuild\Debug_Cairo_CFLite\obj\WebKit\BuildLog.htm" 5>WebKit - 2 error(s), 1 warning(s) ]] See <http://build.webkit.org/builders/WinCairo%20Debug%20%28Build%29/builds/8691/steps/compile-webkit/logs/stdio> for more details. Committed sub method in <http://trac.webkit.org/changeset/91163>. 516737 2 kbalazs 2011-12-07 10:45:07 -0800 *** This bug has been marked as a duplicate of bug 74010 *** 999591 3 mrobinson 2014-04-10 11:48:54 -0700 Reopening to attach new patch. 999592 4 229062 mrobinson 2014-04-10 11:48:58 -0700 Created attachment 229062 Patch 999601 5 229062 commit-queue 2014-04-10 12:03:47 -0700 Comment on attachment 229062 Patch Clearing flags on attachment: 229062 Committed r167080: <http://trac.webkit.org/changeset/167080> 999602 6 commit-queue 2014-04-10 12:03:51 -0700 All reviewed patches have been landed. Closing bug. 229062 2014-04-10 11:48:58 -0700 2014-04-10 12:03:46 -0700 Patch bug-64665-20140410114837.patch text/plain 2153 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzYwMDE0NjYxMDhmZmJh ZmYwYjQ3YzQ1YmI5YjcxNzU4M2I1NTA3NC4uN2NjOTQ0ZGNiODA5NWU5OGU4M2JjOTIxY2QwNTlk OWVjMGMwYThhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTA0LTEwICBPd2Vu IFRheWxvciAgPG90YXlsb3JAcmVkaGF0LmNvbT4KKworICAgICAgICBbQ2Fpcm9dIEltcGxlbWVu dCBTaGFyZWFibGVCaXRtYXA6OnBhaW50KCkgd2l0aCBzY2FsZSBmYWN0b3IKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0NjY1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgorCisgICAgICAgICogU2hhcmVkL2NhaXJvL1NoYXJl YWJsZUJpdG1hcENhaXJvLmNwcCAoV2ViS2l0OjpTaGFyZWFibGVCaXRtYXA6OnBhaW50KToKKwog MjAxNC0wNC0xMCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAg ICBHdGsgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL2NhaXJv L1NoYXJlYWJsZUJpdG1hcENhaXJvLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9jYWlyby9T aGFyZWFibGVCaXRtYXBDYWlyby5jcHAKaW5kZXggYzgzNmM5MzA5OGM5NTkwZmYxM2JjY2JmZGEx YTNkMGViYWQ5NDkwNC4uMzc4YmVlNzIyMDQ5NjEwODUyZDYzMTAzOTAzNDgyOTUwMzA1ZTdiNyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL2NhaXJvL1NoYXJlYWJsZUJpdG1hcENh aXJvLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvY2Fpcm8vU2hhcmVhYmxlQml0bWFw Q2Fpcm8uY3BwCkBAIC02MCwxOSArNjAsMTYgQEAgc3RkOjp1bmlxdWVfcHRyPEdyYXBoaWNzQ29u dGV4dD4gU2hhcmVhYmxlQml0bWFwOjpjcmVhdGVHcmFwaGljc0NvbnRleHQoKQogCiB2b2lkIFNo YXJlYWJsZUJpdG1hcDo6cGFpbnQoR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBjb25zdCBJbnRQ b2ludCYgZHN0UG9pbnQsIGNvbnN0IEludFJlY3QmIHNyY1JlY3QpCiB7Ci0gICAgUmVmUHRyPGNh aXJvX3N1cmZhY2VfdD4gc3VyZmFjZSA9IGNyZWF0ZVN1cmZhY2VGcm9tRGF0YShkYXRhKCksIG1f c2l6ZSk7Ci0gICAgRmxvYXRSZWN0IGRlc3RSZWN0KGRzdFBvaW50LCBzcmNSZWN0LnNpemUoKSk7 Ci0gICAgY29udGV4dC5wbGF0Zm9ybUNvbnRleHQoKS0+ZHJhd1N1cmZhY2VUb0NvbnRleHQoc3Vy ZmFjZS5nZXQoKSwgZGVzdFJlY3QsIHNyY1JlY3QsICZjb250ZXh0KTsKKyAgICBwYWludChjb250 ZXh0LCAxLCBkc3RQb2ludCwgc3JjUmVjdCk7CiB9CiAKIHZvaWQgU2hhcmVhYmxlQml0bWFwOjpw YWludChHcmFwaGljc0NvbnRleHQmIGNvbnRleHQsIGZsb2F0IHNjYWxlRmFjdG9yLCBjb25zdCBJ bnRQb2ludCYgZHN0UG9pbnQsIGNvbnN0IEludFJlY3QmIHNyY1JlY3QpCiB7Ci0gICAgaWYgKHNj YWxlRmFjdG9yICE9IDEpIHsKLSAgICAgICAgLy8gU2VlIDxodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjQ2NjU+LgotICAgICAgICBub3RJbXBsZW1lbnRlZCgpOwotICAg ICAgICByZXR1cm47Ci0gICAgfQotICAgIHBhaW50KGNvbnRleHQsIGRzdFBvaW50LCBzcmNSZWN0 KTsKKyAgICBSZWZQdHI8Y2Fpcm9fc3VyZmFjZV90PiBzdXJmYWNlID0gY3JlYXRlU3VyZmFjZUZy b21EYXRhKGRhdGEoKSwgbV9zaXplKTsKKyAgICBGbG9hdFJlY3QgZGVzdFJlY3QoZHN0UG9pbnQs IHNyY1JlY3Quc2l6ZSgpKTsKKyAgICBGbG9hdFJlY3Qgc3JjUmVjdFNjYWxlZChzcmNSZWN0KTsK KyAgICBzcmNSZWN0U2NhbGVkLnNjYWxlKHNjYWxlRmFjdG9yKTsKKyAgICBjb250ZXh0LnBsYXRm b3JtQ29udGV4dCgpLT5kcmF3U3VyZmFjZVRvQ29udGV4dChzdXJmYWNlLmdldCgpLCBkZXN0UmVj dCwgc3JjUmVjdFNjYWxlZCwgJmNvbnRleHQpOwogfQogCiBQYXNzUmVmUHRyPGNhaXJvX3N1cmZh Y2VfdD4gU2hhcmVhYmxlQml0bWFwOjpjcmVhdGVDYWlyb1N1cmZhY2UoKQo=