<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>64663</bug_id>
          
          <creation_ts>2011-07-16 21:04:56 -0700</creation_ts>
          <short_desc>[Qt] Implement ShareableBitmap::paint() with scale factor</short_desc>
          <delta_ts>2011-12-07 10:45:18 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>74010</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Bates">dbates</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>kbalazs</cc>
    
    <cc>kling</cc>
    
    <cc>noam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>438241</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-07-16 21:04:56 -0700</bug_when>
    <thetext>Implement the scale factor variant of ShareableBitmap::paint(). One such usage of this variant is in changeset &lt;http://trac.webkit.org/changeset/91085&gt;. In particular, the change to Source/WebKit2/UIProcess/FindIndicator.cpp.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>438242</commentid>
    <comment_count>1</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-07-16 21:06:28 -0700</bug_when>
    <thetext>For completeness, the scale factor variant of ShareableBitmap::paint() was added to the CG port in &lt;http://trac.webkit.org/changeset/90198&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>438243</commentid>
    <comment_count>2</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-07-16 21:22:18 -0700</bug_when>
    <thetext>The Qt Linux Release build fails to compile because this variant of ShareableBitmap::paint() wasn&apos;t implemented for the Qt WebKit2 port at the time changeset 91085 &lt;http://trac.webkit.org/changeset/91085&gt; landed:

[[
../../WebKit2/release/libwebkit2.a(FindIndicator.o): In function `WebKit::FindIndicator::draw(WebCore::GraphicsContext&amp;, WebCore::IntRect const&amp;)&apos;:
FindIndicator.cpp:(.text._ZN6WebKit13FindIndicator4drawERN7WebCore15GraphicsContextERKNS1_7IntRectE+0xf3): undefined reference to `WebKit::ShareableBitmap::paint(WebCore::GraphicsContext&amp;, float, WebCore::IntPoint const&amp;, WebCore::IntRect const&amp;)&apos;
collect2: ld returned 1 exit status
make[1]: *** [../../lib/libQtWebKit.so.4.10.0] Error 1
make[1]: Leaving directory `/ramdisk/qt-linux-release/build/WebKitBuild/Release/WebKit/qt&apos;
make: *** [sub-WebKit-qt-QtWebKit-pro-make_default-ordered] Error 2
]]

See &lt;http://build.webkit.org/builders/Qt%20Linux%20Release/builds/35470/steps/compile-webkit/logs/stdio&gt; for more details.

Committed stub method in &lt;http://trac.webkit.org/changeset/91162&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>516739</commentid>
    <comment_count>3</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2011-12-07 10:45:18 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 74010 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>