64653 2011-07-16 13:17:04 -0700 DFG speculative JIT has dead code for slow calls for branches 2011-07-16 16:14:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 fpizlo webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 438167 0 fpizlo 2011-07-16 13:17:04 -0700 http://trac.webkit.org/changeset/91099 changed how DFG handles branches, but neglected to remove dead code for the old way that branches were handled by the DFG speculative JIT. Specifically, the SpeculativeJIT::compilePeepHoleCall method is no longer called from anywhere, and is unlikely to ever be needed again since JITCodeGenerator now contains a more optimized version of that method. 438168 1 101097 fpizlo 2011-07-16 13:19:36 -0700 Created attachment 101097 the patch 438198 2 101097 webkit.review.bot 2011-07-16 16:14:22 -0700 Comment on attachment 101097 the patch Clearing flags on attachment: 101097 Committed r91156: <http://trac.webkit.org/changeset/91156> 438199 3 webkit.review.bot 2011-07-16 16:14:26 -0700 All reviewed patches have been landed. Closing bug. 101097 2011-07-16 13:19:36 -0700 2011-07-16 16:14:22 -0700 the patch deadcode_patch_1.diff text/plain 3164 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTExNTIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDctMTYgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE Rkcgc3BlY3VsYXRpdmUgSklUIGhhcyBkZWFkIGNvZGUgZm9yIHNsb3cgY2FsbHMgZm9yIGJyYW5j aGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ2 NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAg ICAgIFJlbW92ZWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVQZWVwSG9sZUNhbGwuCisKKyAgICAg ICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwOgorICAgICAgICAqIGRmZy9ERkdTcGVjdWxh dGl2ZUpJVC5oOgorCiAyMDExLTA3LTE1ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAK ICAgICAgICAgRml4IHRoZSBidWlsZC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHU3BlY3VsYXRpdmVKSVQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCShyZXZpc2lvbiA5MTE0NykKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zODAsMzcgKzM4MCw2IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVQZWVwSG9sZUlu dGUKICAgICAgICAgYWRkQnJhbmNoKG1faml0Lmp1bXAoKSwgbm90VGFrZW4pOwogfQogCi12b2lk IFNwZWN1bGF0aXZlSklUOjpjb21waWxlUGVlcEhvbGVDYWxsKE5vZGUmIG5vZGUsIE5vZGVJbmRl eCBicmFuY2hOb2RlSW5kZXgsIFpfREZHT3BlcmF0aW9uX0VKSiBvcGVyYXRpb24pCi17Ci0gICAg Tm9kZSYgYnJhbmNoTm9kZSA9IG1faml0LmdyYXBoKClbYnJhbmNoTm9kZUluZGV4XTsKLSAgICBC bG9ja0luZGV4IHRha2VuID0gbV9qaXQuZ3JhcGgoKS5ibG9ja0luZGV4Rm9yQnl0ZWNvZGVPZmZz ZXQoYnJhbmNoTm9kZS50YWtlbkJ5dGVjb2RlT2Zmc2V0KCkpOwotICAgIEJsb2NrSW5kZXggbm90 VGFrZW4gPSBtX2ppdC5ncmFwaCgpLmJsb2NrSW5kZXhGb3JCeXRlY29kZU9mZnNldChicmFuY2hO b2RlLm5vdFRha2VuQnl0ZWNvZGVPZmZzZXQoKSk7Ci0KLSAgICAvLyBUaGUgYnJhbmNoIGluc3Ry dWN0aW9uIHdpbGwgYnJhbmNoIHRvIHRoZSB0YWtlbiBibG9jay4KLSAgICAvLyBJZiB0YWtlbiBp cyBuZXh0LCBzd2l0Y2ggdGFrZW4gd2l0aCBub3RUYWtlbiAmIGludmVydCB0aGUgYnJhbmNoIGNv bmRpdGlvbiBzbyB3ZSBjYW4gZmFsbCB0aHJvdWdoLgotICAgIEpJVENvbXBpbGVyOjpSZXN1bHRD b25kaXRpb24gY29uZGl0aW9uID0gSklUQ29tcGlsZXI6Ok5vblplcm87Ci0gICAgaWYgKHRha2Vu ID09IChtX2Jsb2NrICsgMSkpIHsKLSAgICAgICAgY29uZGl0aW9uID0gSklUQ29tcGlsZXI6Olpl cm87Ci0gICAgICAgIEJsb2NrSW5kZXggdG1wID0gdGFrZW47Ci0gICAgICAgIHRha2VuID0gbm90 VGFrZW47Ci0gICAgICAgIG5vdFRha2VuID0gdG1wOwotICAgIH0KLQotICAgIEpTVmFsdWVPcGVy YW5kIG9wMSh0aGlzLCBub2RlLmNoaWxkMSgpKTsKLSAgICBKU1ZhbHVlT3BlcmFuZCBvcDIodGhp cywgbm9kZS5jaGlsZDIoKSk7Ci0gICAgR1BSUmVnIG9wMUdQUiA9IG9wMS5ncHIoKTsKLSAgICBH UFJSZWcgb3AyR1BSID0gb3AyLmdwcigpOwotICAgIGZsdXNoUmVnaXN0ZXJzKCk7Ci0KLSAgICBH UFJSZXN1bHQgcmVzdWx0KHRoaXMpOwotICAgIGNhbGxPcGVyYXRpb24ob3BlcmF0aW9uLCByZXN1 bHQuZ3ByKCksIG9wMUdQUiwgb3AyR1BSKTsKLSAgICBhZGRCcmFuY2gobV9qaXQuYnJhbmNoVGVz dDgoY29uZGl0aW9uLCByZXN1bHQuZ3ByKCkpLCB0YWtlbik7Ci0KLSAgICAvLyBDaGVjayBmb3Ig ZmFsbCB0aHJvdWdoLCBvdGhlcndpc2Ugd2UgbmVlZCB0byBqdW1wLgotICAgIGlmIChub3RUYWtl biAhPSAobV9ibG9jayArIDEpKQotICAgICAgICBhZGRCcmFuY2gobV9qaXQuanVtcCgpLCBub3RU YWtlbik7Ci19Ci0KIC8vIFJldHVybnMgdHJ1ZSBpZiB0aGUgY29tcGFyZSBpcyBmdXNlZCB3aXRo IGEgc3Vic2VxdWVudCBicmFuY2guCiBib29sIFNwZWN1bGF0aXZlSklUOjpjb21wYXJlKE5vZGUm IG5vZGUsIE1hY3JvQXNzZW1ibGVyOjpSZWxhdGlvbmFsQ29uZGl0aW9uIGNvbmRpdGlvbiwgWl9E RkdPcGVyYXRpb25fRUpKIG9wZXJhdGlvbikKIHsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgJKHJldmlzaW9uIDkxMTQ3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oCSh3b3JraW5nIGNvcHkpCkBA IC0xNzEsNyArMTcxLDYgQEAgcHJpdmF0ZToKIAogICAgIGJvb2wgY29tcGFyZShOb2RlJiwgTWFj cm9Bc3NlbWJsZXI6OlJlbGF0aW9uYWxDb25kaXRpb24sIFpfREZHT3BlcmF0aW9uX0VKSik7CiAg ICAgdm9pZCBjb21waWxlUGVlcEhvbGVJbnRlZ2VyQnJhbmNoKE5vZGUmLCBOb2RlSW5kZXggYnJh bmNoTm9kZUluZGV4LCBKSVRDb21waWxlcjo6UmVsYXRpb25hbENvbmRpdGlvbik7Ci0gICAgdm9p ZCBjb21waWxlUGVlcEhvbGVDYWxsKE5vZGUmLCBOb2RlSW5kZXggYnJhbmNoTm9kZUluZGV4LCBa X0RGR09wZXJhdGlvbl9FSkopOwogCiAgICAgLy8gQWRkIGEgc3BlY3VsYXRpb24gY2hlY2sgd2l0 aG91dCBhZGRpdGlvbmFsIHJlY292ZXJ5LgogICAgIHZvaWQgc3BlY3VsYXRpb25DaGVjayhNYWNy b0Fzc2VtYmxlcjo6SnVtcCBqdW1wVG9GYWlsKQo=