64649 2011-07-16 07:30:47 -0700 Remove RenderObject::addLayers second argument 2011-07-18 05:40:53 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jchaffraix jchaffraix webkit.review.bot oldest_to_newest 438142 0 jchaffraix 2011-07-16 07:30:47 -0700 I found it confusing when looking at the code and it was always |this|. Patch forthcoming. 438143 1 101091 jchaffraix 2011-07-16 07:34:26 -0700 Created attachment 101091 Proposed change 438417 2 101091 webkit.review.bot 2011-07-18 05:40:50 -0700 Comment on attachment 101091 Proposed change Clearing flags on attachment: 101091 Committed r91178: <http://trac.webkit.org/changeset/91178> 438418 3 webkit.review.bot 2011-07-18 05:40:53 -0700 All reviewed patches have been landed. Closing bug. 101091 2011-07-16 07:34:26 -0700 2011-07-18 05:40:50 -0700 Proposed change bug-64649-20110716073425.patch text/plain 4130 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogOTEwNzUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwMjMxNzRkNmQyYjgyYjBj NTg3YjQ0ZGI0NTRkZjM3MDg3ZjlkY2Y2Li4wMGI3ZjMyNzU1ODU2YWI5ZDhiODdiNzAwMGE3Nzlh ZDEwY2Q1Yjk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMDctMTYgIEp1bGll biBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIFJl bmRlck9iamVjdDo6YWRkTGF5ZXJzIHNlY29uZCBhcmd1bWVudAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ2NDkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAg ICAgICAgVGhlIGNvZGUgd2FzIGFsd2F5cyBwYXNzaW5nIHx0aGlzfCBhcyB0aGUgc2Vjb25kIGFy Z3VtZW50LiBUaHVzIGp1c3QKKyAgICAgICAgcmVtb3ZlZCB0aGUgYXJndW1lbnQgZm9yIGNsYXJp dHkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0Lmg6CisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6 OmFkZExheWVycyk6IFJlbW92ZWQgdGhlIGFyZ3VtZW50LCByZXBsYWNlZAorICAgICAgICBieSB8 dGhpc3wuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0Q2hpbGRMaXN0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdENoaWxkTGlzdDo6YXBwZW5kQ2hpbGROb2Rl KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdENoaWxkTGlzdDo6aW5zZXJ0Q2hpbGRO b2RlKToKKyAgICAgICAgUmVtb3ZlZCB0aGUgc2Vjb25kIGFyZ3VtZW50IGF0IHRob3NlIDIgY2Fs bCBzaXRlcy4KKwogMjAxMS0wNy0xNSAgUHJhdGlrIFNvbGFua2kgIDxwc29sYW5raUBhcHBsZS5j b20+CiAKICAgICAgICAgUmVtb3ZlIHVubmNlc3NhcnkgY3JlYXRpb24gb2YgY29ubmVjdGlvblBy b3BlcnRpZXMgZGljdGlvbmFyeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlck9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0 LmNwcAppbmRleCA0NDFiNjg4ZDRhY2ZmNjRjNDU2OWY1YTJjM2MxNzA0NTVhMTY1OWIxLi4zYzY3 OTA4ZjliZjY1ZDNmZmQ3ZDUzNjEyZjAyODY1NTkzNDVhYjk5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcApAQCAtNDQyLDEyICs0NDIsMTIgQEAgc3RhdGljIHZv aWQgYWRkTGF5ZXJzKFJlbmRlck9iamVjdCogb2JqLCBSZW5kZXJMYXllciogcGFyZW50TGF5ZXIs IFJlbmRlck9iamVjdCoKICAgICAgICAgYWRkTGF5ZXJzKGN1cnIsIHBhcmVudExheWVyLCBuZXdP YmplY3QsIGJlZm9yZUNoaWxkKTsKIH0KIAotdm9pZCBSZW5kZXJPYmplY3Q6OmFkZExheWVycyhS ZW5kZXJMYXllciogcGFyZW50TGF5ZXIsIFJlbmRlck9iamVjdCogbmV3T2JqZWN0KQordm9pZCBS ZW5kZXJPYmplY3Q6OmFkZExheWVycyhSZW5kZXJMYXllciogcGFyZW50TGF5ZXIpCiB7CiAgICAg aWYgKCFwYXJlbnRMYXllcikKICAgICAgICAgcmV0dXJuOwogCi0gICAgUmVuZGVyT2JqZWN0KiBv YmplY3QgPSBuZXdPYmplY3Q7CisgICAgUmVuZGVyT2JqZWN0KiBvYmplY3QgPSB0aGlzOwogICAg IFJlbmRlckxheWVyKiBiZWZvcmVDaGlsZCA9IDA7CiAgICAgV2ViQ29yZTo6YWRkTGF5ZXJzKHRo aXMsIHBhcmVudExheWVyLCBvYmplY3QsIGJlZm9yZUNoaWxkKTsKIH0KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJPYmplY3QuaAppbmRleCA5NzE0MTc1NzdkYWI2NjMzOTQ5MWEwMjE0YjNk N2I0ZGJlZmE1NTNhLi45NzdlODcwYjhmYjdjZGYyYzdiYzU0MzM4Mzg4YTUxN2I3OWI4MTkyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCkBAIC0xNzYsNyArMTc2LDcg QEAgcHVibGljOgogICAgIC8vIHByb3Blcmx5IGFkZGVkIGFuZCByZW1vdmVkLiAgU2luY2UgY29u dGFpbmVyc2hpcCBjYW4gYmUgaW1wbGVtZW50ZWQgYnkgYW55IHN1YmNsYXNzLCBhbmQgc2luY2Ug YSBoaWVyYXJjaHkKICAgICAvLyBjYW4gY29udGFpbiBhIG1peHR1cmUgb2YgYm94ZXMgYW5kIG90 aGVyIG9iamVjdCB0eXBlcywgdGhlc2UgZnVuY3Rpb25zIG5lZWQgdG8gYmUgaW4gdGhlIGJhc2Ug Y2xhc3MuCiAgICAgUmVuZGVyTGF5ZXIqIGVuY2xvc2luZ0xheWVyKCkgY29uc3Q7Ci0gICAgdm9p ZCBhZGRMYXllcnMoUmVuZGVyTGF5ZXIqIHBhcmVudExheWVyLCBSZW5kZXJPYmplY3QqIG5ld09i amVjdCk7CisgICAgdm9pZCBhZGRMYXllcnMoUmVuZGVyTGF5ZXIqIHBhcmVudExheWVyKTsKICAg ICB2b2lkIHJlbW92ZUxheWVycyhSZW5kZXJMYXllciogcGFyZW50TGF5ZXIpOwogICAgIHZvaWQg bW92ZUxheWVycyhSZW5kZXJMYXllciogb2xkUGFyZW50LCBSZW5kZXJMYXllciogbmV3UGFyZW50 KTsKICAgICBSZW5kZXJMYXllciogZmluZE5leHRMYXllcihSZW5kZXJMYXllciogcGFyZW50TGF5 ZXIsIFJlbmRlck9iamVjdCogc3RhcnRQb2ludCwgYm9vbCBjaGVja1BhcmVudCA9IHRydWUpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdENoaWxkTGlz dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0Q2hpbGRMaXN0LmNw cAppbmRleCAzNmMzZGQ0YWNkMDcyZjY1OTZkNDEzNTE4NDgyNTEyMDIxOWNlYTRhLi42NmM0YjEw YTUxYjIzMDE5N2VlZmMyY2ZmNWE1NWE0YjkxYTk1N2RkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0Q2hpbGRMaXN0LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0Q2hpbGRMaXN0LmNwcApAQCAtMTYwLDcgKzE2MCw3 IEBAIHZvaWQgUmVuZGVyT2JqZWN0Q2hpbGRMaXN0OjphcHBlbmRDaGlsZE5vZGUoUmVuZGVyT2Jq ZWN0KiBvd25lciwgUmVuZGVyT2JqZWN0KiBuCiAgICAgICAgIFJlbmRlckxheWVyKiBsYXllciA9 IDA7CiAgICAgICAgIGlmIChuZXdDaGlsZC0+Zmlyc3RDaGlsZCgpIHx8IG5ld0NoaWxkLT5oYXNM YXllcigpKSB7CiAgICAgICAgICAgICBsYXllciA9IG93bmVyLT5lbmNsb3NpbmdMYXllcigpOwot ICAgICAgICAgICAgbmV3Q2hpbGQtPmFkZExheWVycyhsYXllciwgbmV3Q2hpbGQpOworICAgICAg ICAgICAgbmV3Q2hpbGQtPmFkZExheWVycyhsYXllcik7CiAgICAgICAgIH0KIAogICAgICAgICAv LyBpZiB0aGUgbmV3IGNoaWxkIGlzIHZpc2libGUgYnV0IHRoaXMgb2JqZWN0IHdhcyBub3QsIHRl bGwgdGhlIGxheWVyIGl0IGhhcyBzb21lIHZpc2libGUgY29udGVudApAQCAtMjIwLDcgKzIyMCw3 IEBAIHZvaWQgUmVuZGVyT2JqZWN0Q2hpbGRMaXN0OjppbnNlcnRDaGlsZE5vZGUoUmVuZGVyT2Jq ZWN0KiBvd25lciwgUmVuZGVyT2JqZWN0KiBjCiAgICAgICAgIFJlbmRlckxheWVyKiBsYXllciA9 IDA7CiAgICAgICAgIGlmIChjaGlsZC0+Zmlyc3RDaGlsZCgpIHx8IGNoaWxkLT5oYXNMYXllcigp KSB7CiAgICAgICAgICAgICBsYXllciA9IG93bmVyLT5lbmNsb3NpbmdMYXllcigpOwotICAgICAg ICAgICAgY2hpbGQtPmFkZExheWVycyhsYXllciwgY2hpbGQpOworICAgICAgICAgICAgY2hpbGQt PmFkZExheWVycyhsYXllcik7CiAgICAgICAgIH0KIAogICAgICAgICAvLyBpZiB0aGUgbmV3IGNo aWxkIGlzIHZpc2libGUgYnV0IHRoaXMgb2JqZWN0IHdhcyBub3QsIHRlbGwgdGhlIGxheWVyIGl0 IGhhcyBzb21lIHZpc2libGUgY29udGVudAo=