64648 2011-07-15 21:18:28 -0700 Rename variable isEmptyTextPatch in svn-{apply, unapply} 2011-07-19 12:01:16 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates dbates aroben ddkilzer webkit.review.bot oldest_to_newest 438122 0 dbates 2011-07-15 21:18:28 -0700 Rename variable isEmptyTextPatch to hasTextChunks, which is more descriptive. 438123 1 101089 dbates 2011-07-15 21:21:10 -0700 Created attachment 101089 Patch 439327 2 101089 webkit.review.bot 2011-07-19 12:01:12 -0700 Comment on attachment 101089 Patch Clearing flags on attachment: 101089 Committed r91282: <http://trac.webkit.org/changeset/91282> 439328 3 webkit.review.bot 2011-07-19 12:01:16 -0700 All reviewed patches have been landed. Closing bug. 101089 2011-07-15 21:21:10 -0700 2011-07-19 12:01:12 -0700 Patch bug-64648-20110715212108.patch text/plain 2906 dbates SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkxMTQ0KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTggQEAKKzIwMTEtMDctMTUgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgor CisgICAgICAgIFJlbmFtZSB2YXJpYWJsZSBpc0VtcHR5VGV4dFBhdGNoIGluIHN2bi17YXBwbHks IHVuYXBwbHl9CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02NDY0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbmFtZSB0aGUgdmFyaWFibGUgaXNFbXB0eVRleHRQYXRjaCB0byBoYXNUZXh0Q2h1bmtzLCB3 aGljaCBpcworICAgICAgICBtb3JlIGRlc2NyaXB0aXZlIGFuZCBtYWtlcyBpdHMgdXNhZ2UgcmVh ZCB3ZWxsIGluIGNvbnRyb2wgc3RhdGVtZW50cy4KKworICAgICAgICAqIFNjcmlwdHMvc3ZuLWFw cGx5OgorICAgICAgICAocGF0Y2gpOgorICAgICAgICAqIFNjcmlwdHMvc3ZuLXVuYXBwbHk6Cisg ICAgICAgIChwYXRjaCk6CisKIDIwMTEtMDctMTUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KIAogICAgICAgICBnYXJkZW5pbmcgc2VydmVyIHNob3VsZCBwcm94eSBidWlsZGJvdCBz dGF0dXMgZm9yIGdhcmRlbi1vLW1hdGljCkluZGV4OiBUb29scy9TY3JpcHRzL3N2bi1hcHBseQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3N2bi1hcHBseQkocmV2aXNpb24gOTExNDQpCisr KyBUb29scy9TY3JpcHRzL3N2bi1hcHBseQkod29ya2luZyBjb3B5KQpAQCAtMzE1LDcgKzMxNSw3 IEBAIHN1YiBwYXRjaCgkKQogICAgIG15ICRmdWxsUGF0aCA9ICRkaWZmSGFzaFJlZi0+e2luZGV4 UGF0aH07CiAgICAgbXkgJGlzQmluYXJ5ID0gJGRpZmZIYXNoUmVmLT57aXNCaW5hcnl9OwogICAg IG15ICRpc0dpdCA9ICRkaWZmSGFzaFJlZi0+e2lzR2l0fTsKLSAgICBteSAkaXNFbXB0eVRleHRQ YXRjaCA9ICEkcGF0Y2ggfHwgISRkaWZmSGFzaFJlZi0+e251bVRleHRDaHVua3N9OworICAgIG15 ICRoYXNUZXh0Q2h1bmtzID0gJHBhdGNoICYmICRkaWZmSGFzaFJlZi0+e251bVRleHRDaHVua3N9 OwogCiAgICAgbXkgJGRlbGV0aW9uID0gMDsKICAgICBteSAkYWRkaXRpb24gPSAwOwpAQCAtMzIz LDcgKzMyMyw3IEBAIHN1YiBwYXRjaCgkKQogICAgICRhZGRpdGlvbiA9IDEgaWYgKCRkaWZmSGFz aFJlZi0+e2lzTmV3fSB8fCAkcGF0Y2ggPX4gL1xuQEAgLTAsMCAuKiBAQC8pOwogICAgICRkZWxl dGlvbiA9IDEgaWYgKCRkaWZmSGFzaFJlZi0+e2lzRGVsZXRpb259IHx8ICRwYXRjaCA9fiAvXG5A QCAuKiBcKzAsMCBAQC8pOwogCi0gICAgaWYgKCEkYWRkaXRpb24gJiYgISRkZWxldGlvbiAmJiAh JGlzQmluYXJ5ICYmICEkaXNFbXB0eVRleHRQYXRjaCkgeworICAgIGlmICghJGFkZGl0aW9uICYm ICEkZGVsZXRpb24gJiYgISRpc0JpbmFyeSAmJiAkaGFzVGV4dENodW5rcykgewogICAgICAgICAj IFN0YW5kYXJkIHBhdGNoLCBwYXRjaCB0b29sIGNhbiBoYW5kbGUgdGhpcy4KICAgICAgICAgaWYg KGJhc2VuYW1lKCRmdWxsUGF0aCkgZXEgIkNoYW5nZUxvZyIpIHsKICAgICAgICAgICAgIG15ICRj aGFuZ2VMb2dEb3RPcmlnRXhpc3RlZCA9IC1mICIke2Z1bGxQYXRofS5vcmlnIjsKSW5kZXg6IFRv b2xzL1NjcmlwdHMvc3ZuLXVuYXBwbHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9zdm4t dW5hcHBseQkocmV2aXNpb24gOTExNDQpCisrKyBUb29scy9TY3JpcHRzL3N2bi11bmFwcGx5CSh3 b3JraW5nIGNvcHkpCkBAIC0xNDUsNyArMTQ1LDcgQEAgc3ViIHBhdGNoKCQpCiAKICAgICBteSAk ZnVsbFBhdGggPSAkZGlmZkhhc2hSZWYtPntpbmRleFBhdGh9OwogICAgIG15ICRpc1N2bkJpbmFy eSA9ICRkaWZmSGFzaFJlZi0+e2lzQmluYXJ5fSAmJiAkZGlmZkhhc2hSZWYtPntpc1N2bn07Ci0g ICAgbXkgJGlzRW1wdHlUZXh0UGF0Y2ggPSAhJHBhdGNoIHx8ICEkZGlmZkhhc2hSZWYtPntudW1U ZXh0Q2h1bmtzfTsKKyAgICBteSAkaGFzVGV4dENodW5rcyA9ICRwYXRjaCAmJiAkZGlmZkhhc2hS ZWYtPntudW1UZXh0Q2h1bmtzfTsKIAogICAgICRkaXJlY3Rvcmllc1RvQ2hlY2t7ZGlybmFtZSgk ZnVsbFBhdGgpfSA9IDE7CiAKQEAgLTE1NSw3ICsxNTUsNyBAQCBzdWIgcGF0Y2goJCkKICAgICAk YWRkaXRpb24gPSAxIGlmICgkZGlmZkhhc2hSZWYtPntpc05ld30gfHwgJGRpZmZIYXNoUmVmLT57 Y29waWVkRnJvbVBhdGh9IHx8ICRwYXRjaCA9fiAvXG5AQCAtMCwwIC4qIEBALyk7CiAgICAgJGRl bGV0aW9uID0gMSBpZiAoJGRpZmZIYXNoUmVmLT57aXNEZWxldGlvbn0gfHwgJHBhdGNoID1+IC9c bkBAIC4qIFwrMCwwIEBALyk7CiAKLSAgICBpZiAoISRhZGRpdGlvbiAmJiAhJGRlbGV0aW9uICYm ICEkaXNTdm5CaW5hcnkgJiYgISRpc0VtcHR5VGV4dFBhdGNoKSB7CisgICAgaWYgKCEkYWRkaXRp b24gJiYgISRkZWxldGlvbiAmJiAhJGlzU3ZuQmluYXJ5ICYmICRoYXNUZXh0Q2h1bmtzKSB7CiAg ICAgICAgICMgU3RhbmRhcmQgcGF0Y2gsIHBhdGNoIHRvb2wgY2FuIGhhbmRsZSB0aGlzLgogICAg ICAgICBpZiAoYmFzZW5hbWUoJGZ1bGxQYXRoKSBlcSAiQ2hhbmdlTG9nIikgewogICAgICAgICAg ICAgbXkgJGNoYW5nZUxvZ0RvdE9yaWdFeGlzdGVkID0gLWYgIiR7ZnVsbFBhdGh9Lm9yaWciOwo=