64637 2011-07-15 15:37:14 -0700 DFG JIT operationCompareEqual does not inline JSValue::equalSlowCaseInline 2011-07-17 02:02:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 fpizlo webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 438024 0 fpizlo 2011-07-15 15:37:14 -0700 The DFG JIT's slow-case implementation of operationCompareEqual makes an inline call to JSValue::equal, which checks if the operands are integers, and if not, makes a slow call to JSValue::equalSlowCase. But operationCompareEqual will only be called if the operands are known to not be integers. Thus, operationCompareEqual should inline the slow-case implementation. 438025 1 101056 fpizlo 2011-07-15 15:39:25 -0700 Created attachment 101056 the patch 438270 2 101056 webkit.review.bot 2011-07-17 02:02:39 -0700 Comment on attachment 101056 the patch Clearing flags on attachment: 101056 Committed r91168: <http://trac.webkit.org/changeset/91168> 438271 3 webkit.review.bot 2011-07-17 02:02:43 -0700 All reviewed patches have been landed. Closing bug. 101056 2011-07-15 15:39:25 -0700 2011-07-17 02:02:39 -0700 the patch fasterequal_patch_1.diff text/plain 1352 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTExMjApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDctMTUgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE RkcgSklUIG9wZXJhdGlvbkNvbXBhcmVFcXVhbCBkb2VzIG5vdCBpbmxpbmUgSlNWYWx1ZTo6ZXF1 YWxTbG93Q2FzZUlubGluZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY0NjM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBkZmcvREZHT3BlcmF0aW9ucy5jcHA6CisKIDIwMTEtMDctMTUgIEdhdmluIEJh cnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIE5hdGl2ZUVycm9y LnByb3RvdHlwZSBvYmplY3RzIGhhdmUgW1tDbGFzc11dIG9mICJPYmplY3QiIGJ1dCBzaG91bGQg YmUgIkVycm9yIgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25z LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlv bnMuY3BwCShyZXZpc2lvbiA5MTExOCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH T3BlcmF0aW9ucy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQyMSw3ICs0MjYsNyBAQCBib29sIG9w ZXJhdGlvbkNvbXBhcmVHcmVhdGVyRXEoRXhlY1N0YXRlCiAKIGJvb2wgb3BlcmF0aW9uQ29tcGFy ZUVxKEV4ZWNTdGF0ZSogZXhlYywgRW5jb2RlZEpTVmFsdWUgZW5jb2RlZE9wMSwgRW5jb2RlZEpT VmFsdWUgZW5jb2RlZE9wMikKIHsKLSAgICByZXR1cm4gSlNWYWx1ZTo6ZXF1YWwoZXhlYywgSlNW YWx1ZTo6ZGVjb2RlKGVuY29kZWRPcDEpLCBKU1ZhbHVlOjpkZWNvZGUoZW5jb2RlZE9wMikpOwor ICAgIHJldHVybiBKU1ZhbHVlOjplcXVhbFNsb3dDYXNlSW5saW5lKGV4ZWMsIEpTVmFsdWU6OmRl Y29kZShlbmNvZGVkT3AxKSwgSlNWYWx1ZTo6ZGVjb2RlKGVuY29kZWRPcDIpKTsKIH0KIAogYm9v bCBvcGVyYXRpb25Db21wYXJlU3RyaWN0RXEoRXhlY1N0YXRlKiBleGVjLCBFbmNvZGVkSlNWYWx1 ZSBlbmNvZGVkT3AxLCBFbmNvZGVkSlNWYWx1ZSBlbmNvZGVkT3AyKQo=