64625 2011-07-15 13:55:01 -0700 Add isSpeechInputEnabled flag to WebContextMenuData 2011-07-20 10:02:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 39485 0 gshires webkit-unassigned fishd satish tonyg webkit.review.bot oldest_to_newest 437966 0 101040 gshires 2011-07-15 13:55:01 -0700 Created attachment 101040 Proposed patch This flag is to be used by a new menu item "Voice recognition options" which will be added to Chromium. This patch is necessary so that the menu item only appears for input-fields containing the x-webkit-speech attribute. The chromium code that will make use of this patch and that implements the context menu item "Voice recognition options" is: http://codereview.chromium.org/7086005 439020 1 satish 2011-07-19 00:46:21 -0700 +Darin to approve the addition to WebKit/chromium/public API All patches should have an entry to the appropriate ChangeLog file. For this patch, please add an entry to WebKit/ChangeLog. You can do this with the 'Tools/Scripts/prepare-ChangeLog' script. For more info see http://www.webkit.org/coding/contributing.html#changelogs ContextMenuClientImpl.cpp:264 - should indent by 4 spaces, not 2. 439374 2 101363 gshires 2011-07-19 12:49:11 -0700 Created attachment 101363 Proposed patch Fixed spacing and added ChangeLog entry. 439821 3 101363 tonyg 2011-07-20 08:29:15 -0700 Comment on attachment 101363 Proposed patch For future reference, when you want a reviewer to add a patch to the commit queue for you just set the cq field to "?". Some committers like to commit manually and it is hard to remember who has committer rights, so typically reviewers will not cq+ unless it is requested. 439858 4 101363 webkit.review.bot 2011-07-20 10:02:02 -0700 Comment on attachment 101363 Proposed patch Clearing flags on attachment: 101363 Committed r91377: <http://trac.webkit.org/changeset/91377> 439859 5 webkit.review.bot 2011-07-20 10:02:06 -0700 All reviewed patches have been landed. Closing bug. 101040 2011-07-15 13:55:01 -0700 2011-07-19 12:49:11 -0700 Proposed patch isSpeechInputEnabled-WebKitPatch.txt text/plain 1792 gshires ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51 RGF0YS5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRh LmgKaW5kZXggZWQ2ZTNjNC4uMTkzN2FhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRhLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRhLmgKQEAgLTEwOSw2ICsxMDksOSBAQCBzdHJ1 Y3QgV2ViQ29udGV4dE1lbnVEYXRhIHsKICAgICAvLyBUaGUgcmF3IHRleHQgb2YgdGhlIHNlbGVj dGlvbiBpbiBjb250ZXh0LgogICAgIFdlYlN0cmluZyBzZWxlY3RlZFRleHQ7CiAKKyAgICAvLyBX aGV0aGVyIHNwZWVjaCBpbnB1dCBpcyBlbmFibGVkLgorICAgIGJvb2wgaXNTcGVlY2hJbnB1dEVu YWJsZWQ7CisKICAgICAvLyBXaGV0aGVyIHNwZWxsIGNoZWNraW5nIGlzIGVuYWJsZWQuCiAgICAg Ym9vbCBpc1NwZWxsQ2hlY2tpbmdFbmFibGVkOwogCkBAIC0xNjIsNiArMTY1LDcgQEAgc3RydWN0 IFdlYkNvbnRleHRNZW51RGF0YSB7CiAgICAgICAgIDogbWVkaWFUeXBlKE1lZGlhVHlwZU5vbmUp CiAgICAgICAgICwgaXNJbWFnZUJsb2NrZWQoZmFsc2UpCiAgICAgICAgICwgbWVkaWFGbGFncyhN ZWRpYU5vbmUpCisgICAgICAgICwgaXNTcGVlY2hJbnB1dEVuYWJsZWQoZmFsc2UpCiAgICAgICAg ICwgaXNTcGVsbENoZWNraW5nRW5hYmxlZChmYWxzZSkKICAgICAgICAgLCBpc0VkaXRhYmxlKGZh bHNlKQogICAgICAgICAsIHdyaXRpbmdEaXJlY3Rpb25EZWZhdWx0KENoZWNrYWJsZU1lbnVJdGVt RGlzYWJsZWQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0 TWVudUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29udGV4dE1l bnVDbGllbnRJbXBsLmNwcAppbmRleCA1YzliMmUwLi5hOTc0Y2NjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAKQEAgLTI1 OSw2ICsyNTksMTIgQEAgUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gQ29udGV4dE1lbnVDbGllbnRJ bXBsOjpnZXRDdXN0b21NZW51RnJvbURlZmF1bHRJdGVtcygKIAogICAgIGlmIChyLmlzQ29udGVu dEVkaXRhYmxlKCkpIHsKICAgICAgICAgZGF0YS5pc0VkaXRhYmxlID0gdHJ1ZTsKKyNpZiBFTkFC TEUoSU5QVVRfU1BFRUNIKQorICAgICAgICBpZiAoci5pbm5lck5vblNoYXJlZE5vZGUoKS0+aGFz VGFnTmFtZShIVE1MTmFtZXM6OmlucHV0VGFnKSkgeworICAgICAgICAgIGRhdGEuaXNTcGVlY2hJ bnB1dEVuYWJsZWQgPSAKKyAgICAgICAgICAgICAgc3RhdGljX2Nhc3Q8SFRNTElucHV0RWxlbWVu dCo+KHIuaW5uZXJOb25TaGFyZWROb2RlKCkpLT5pc1NwZWVjaEVuYWJsZWQoKTsKKyAgICAgICAg fSAgCisjZW5kaWYKICAgICAgICAgaWYgKG1fd2ViVmlldy0+Zm9jdXNlZFdlYkNvcmVGcmFtZSgp LT5lZGl0b3IoKS0+aXNDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQoKSkgewogICAgICAg ICAgICAgZGF0YS5pc1NwZWxsQ2hlY2tpbmdFbmFibGVkID0gdHJ1ZTsKICAgICAgICAgICAgIC8v IFNwZWxsY2hlY2tpbmcgbWlnaHQgYmUgZW5hYmxlZCBmb3IgdGhlIGZpZWxkLCBidXQgY291bGQg YmUgZGlzYWJsZWQgb24gdGhlIG5vZGUuCg== 101363 2011-07-19 12:49:11 -0700 2011-07-20 10:02:01 -0700 Proposed patch patch_64625_b.txt text/plain 2591 gshires ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNDA0NTgzMS4uNzg4NjkxZmYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMTkgIEdsZW4gU2hp cmVzICA8Z3NoaXJlc0Bnb29nbGUuY29tPgorCisgICAgICAgIEJ1ZyA2NDYyNTogQWRkIGlzU3Bl ZWNoSW5wdXRFbmFibGVkIGZsYWcgdG8gV2ViQ29udGV4dE1lbnVEYXRhLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ2MjUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHB1YmxpYy9XZWJDb250ZXh0TWVu dURhdGEuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dE1lbnVEYXRhOjpXZWJDb250ZXh0 TWVudURhdGEpOiBhZGRlZCBmbGFnIGlzU3BlZWNoSW5wdXRFbmFibGVkCisgICAgICAgICogc3Jj L0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNvbnRleHRNZW51 Q2xpZW50SW1wbDo6Z2V0Q3VzdG9tTWVudUZyb21EZWZhdWx0SXRlbXMpOiBzZXQgZmxhZyBpc1Nw ZWVjaElucHV0RW5hYmxlZAorCiAyMDExLTA3LTE0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJvbGxlZCBDaHJvbWl1bSByZXZpc2lvbiB0byA5MjYwNi4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0 YS5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRhLmgK aW5kZXggZWQ2ZTNjNC4uMTkzN2FhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRhLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRhLmgKQEAgLTEwOSw2ICsxMDksOSBAQCBzdHJ1Y3Qg V2ViQ29udGV4dE1lbnVEYXRhIHsKICAgICAvLyBUaGUgcmF3IHRleHQgb2YgdGhlIHNlbGVjdGlv biBpbiBjb250ZXh0LgogICAgIFdlYlN0cmluZyBzZWxlY3RlZFRleHQ7CiAKKyAgICAvLyBXaGV0 aGVyIHNwZWVjaCBpbnB1dCBpcyBlbmFibGVkLgorICAgIGJvb2wgaXNTcGVlY2hJbnB1dEVuYWJs ZWQ7CisKICAgICAvLyBXaGV0aGVyIHNwZWxsIGNoZWNraW5nIGlzIGVuYWJsZWQuCiAgICAgYm9v bCBpc1NwZWxsQ2hlY2tpbmdFbmFibGVkOwogCkBAIC0xNjIsNiArMTY1LDcgQEAgc3RydWN0IFdl YkNvbnRleHRNZW51RGF0YSB7CiAgICAgICAgIDogbWVkaWFUeXBlKE1lZGlhVHlwZU5vbmUpCiAg ICAgICAgICwgaXNJbWFnZUJsb2NrZWQoZmFsc2UpCiAgICAgICAgICwgbWVkaWFGbGFncyhNZWRp YU5vbmUpCisgICAgICAgICwgaXNTcGVlY2hJbnB1dEVuYWJsZWQoZmFsc2UpCiAgICAgICAgICwg aXNTcGVsbENoZWNraW5nRW5hYmxlZChmYWxzZSkKICAgICAgICAgLCBpc0VkaXRhYmxlKGZhbHNl KQogICAgICAgICAsIHdyaXRpbmdEaXJlY3Rpb25EZWZhdWx0KENoZWNrYWJsZU1lbnVJdGVtRGlz YWJsZWQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVu dUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29udGV4dE1lbnVD bGllbnRJbXBsLmNwcAppbmRleCA1YzliMmUwLi40ZmJmYjliIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAKQEAgLTI1OSw2 ICsyNTksMTIgQEAgUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gQ29udGV4dE1lbnVDbGllbnRJbXBs OjpnZXRDdXN0b21NZW51RnJvbURlZmF1bHRJdGVtcygKIAogICAgIGlmIChyLmlzQ29udGVudEVk aXRhYmxlKCkpIHsKICAgICAgICAgZGF0YS5pc0VkaXRhYmxlID0gdHJ1ZTsKKyNpZiBFTkFCTEUo SU5QVVRfU1BFRUNIKQorICAgICAgICBpZiAoci5pbm5lck5vblNoYXJlZE5vZGUoKS0+aGFzVGFn TmFtZShIVE1MTmFtZXM6OmlucHV0VGFnKSkgeworICAgICAgICAgICAgZGF0YS5pc1NwZWVjaElu cHV0RW5hYmxlZCA9IAorICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PEhUTUxJbnB1dEVsZW1l bnQqPihyLmlubmVyTm9uU2hhcmVkTm9kZSgpKS0+aXNTcGVlY2hFbmFibGVkKCk7CisgICAgICAg IH0gIAorI2VuZGlmCiAgICAgICAgIGlmIChtX3dlYlZpZXctPmZvY3VzZWRXZWJDb3JlRnJhbWUo KS0+ZWRpdG9yKCktPmlzQ29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkKCkpIHsKICAgICAg ICAgICAgIGRhdGEuaXNTcGVsbENoZWNraW5nRW5hYmxlZCA9IHRydWU7CiAgICAgICAgICAgICAv LyBTcGVsbGNoZWNraW5nIG1pZ2h0IGJlIGVuYWJsZWQgZm9yIHRoZSBmaWVsZCwgYnV0IGNvdWxk IGJlIGRpc2FibGVkIG9uIHRoZSBub2RlLgo=