64612 2011-07-15 11:53:22 -0700 [SKIA] Must make skia's GL context current before drawing in GraphicsContext::clearRect 2011-07-19 14:41:01 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 bsalomon bsalomon jamesr senorblanco webkit.review.bot oldest_to_newest 437869 0 bsalomon 2011-07-15 11:53:22 -0700 Must make skia's GL context current before drawing in GraphicsContext::clearRect 437872 1 101017 bsalomon 2011-07-15 11:54:46 -0700 Created attachment 101017 Patch 437875 2 101019 bsalomon 2011-07-15 11:59:53 -0700 Created attachment 101019 Patch 437879 3 bsalomon 2011-07-15 12:01:12 -0700 (In reply to comment #2) > Created an attachment (id=101019) [details] > Patch Second patch fixes the Changelog. 437884 4 101019 senorblanco 2011-07-15 12:05:20 -0700 Comment on attachment 101019 Patch Looks good. compositing/shadows/shadow-drawing.html looks like it was passing after James's change. I'm guessing it's only exercised when run with --enable-accelerated-drawing? 437887 5 bsalomon 2011-07-15 12:08:29 -0700 (In reply to comment #4) > (From update of attachment 101019 [details]) > Looks good. > > compositing/shadows/shadow-drawing.html looks like it was passing after James's change. I'm guessing it's only exercised when run with --enable-accelerated-drawing? Oh, yes, that is true. 437920 6 101019 webkit.review.bot 2011-07-15 12:44:36 -0700 Comment on attachment 101019 Patch Clearing flags on attachment: 101019 Committed r91093: <http://trac.webkit.org/changeset/91093> 437921 7 webkit.review.bot 2011-07-15 12:44:40 -0700 All reviewed patches have been landed. Closing bug. 439446 8 senorblanco 2011-07-19 14:19:58 -0700 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 101019 [details] [details]) > > Looks good. > > > > compositing/shadows/shadow-drawing.html looks like it was passing after James's change. I'm guessing it's only exercised when run with --enable-accelerated-drawing? > > Oh, yes, that is true. In the future, IWBN to have a test which exercises this case directly. 439453 9 bsalomon 2011-07-19 14:24:57 -0700 (In reply to comment #8) > (In reply to comment #5) > > (In reply to comment #4) > > > (From update of attachment 101019 [details] [details] [details]) > > > Looks good. > > > > > > compositing/shadows/shadow-drawing.html looks like it was passing after James's change. I'm guessing it's only exercised when run with --enable-accelerated-drawing? > > > > Oh, yes, that is true. > > In the future, IWBN to have a test which exercises this case directly. There are a bunch of clearRect tests in canvas/philip/tests. I guess they didn't provoke the bug because we lucked into being in the right GL context. Maybe a test having a popup would force us to have two SGC3Ds? 439463 10 senorblanco 2011-07-19 14:37:12 -0700 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #5) > > > (In reply to comment #4) > > > > (From update of attachment 101019 [details] [details] [details] [details]) > > > > Looks good. > > > > > > > > compositing/shadows/shadow-drawing.html looks like it was passing after James's change. I'm guessing it's only exercised when run with --enable-accelerated-drawing? > > > > > > Oh, yes, that is true. > > > > In the future, IWBN to have a test which exercises this case directly. > > There are a bunch of clearRect tests in canvas/philip/tests. I guess they didn't provoke the bug because we lucked into being in the right GL context. Maybe a test having a popup would force us to have two SGC3Ds? Hmm, that could be tricky in DRT. How about a test where the clear is the first call? (And clears to something other than transparent black). Would that leave the graphics context unset? 439465 11 bsalomon 2011-07-19 14:41:01 -0700 (In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #8) > > > (In reply to comment #5) > > > > (In reply to comment #4) > > > > > (From update of attachment 101019 [details] [details] [details] [details] [details]) > > > > > Looks good. > > > > > > > > > > compositing/shadows/shadow-drawing.html looks like it was passing after James's change. I'm guessing it's only exercised when run with --enable-accelerated-drawing? > > > > > > > > Oh, yes, that is true. > > > > > > In the future, IWBN to have a test which exercises this case directly. > > > > There are a bunch of clearRect tests in canvas/philip/tests. I guess they didn't provoke the bug because we lucked into being in the right GL context. Maybe a test having a popup would force us to have two SGC3Ds? > > Hmm, that could be tricky in DRT. How about a test where the clear is the first call? (And clears to something other than transparent black). Would that leave the graphics context unset? I don't think so because PlatformContextSkia::setSharedGraphicsContext() call makes it current. I'm not really sure how it is getting unset in these failures, though. 101017 2011-07-15 11:54:46 -0700 2011-07-15 11:59:48 -0700 Patch bug-64612-20110715145445.patch text/plain 1368 bsalomon SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxMDg0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMTUgIEJyaWFuIFNh bG9tb24gIDxic2Fsb21vbkBnb29nbGUuY29tPgorCisgICAgICAgIE11c3QgbWFrZSBza2lhJ3Mg R0wgY29udGV4dCBjdXJyZW50IGJlZm9yZSBkcmF3aW5nIGluIEdyYXBoaWNzQ29udGV4dDo6Y2xl YXJSZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 NDYxMgorCisgICAgICAgIFRlc3RlZCBieSBjb21wb3NpdGluZy9zaGFkb3dzL3NoYWRvdy1kcmF3 aW5nLmh0bWwKKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmNsZWFyUmVjdCk6CisKIDIwMTEtMDctMTUgIFByYXRp ayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgogCiAgICAgICAgIFBhcnQgb2YgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzNjc0CkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3ND b250ZXh0U2tpYS5jcHAJKHJldmlzaW9uIDkxMDgyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMzI2LDYgKzMyNiw4IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpjbGVhclJlY3QoY29uc3Qg RmwKICAgICBpZiAoIWlzUmVjdFNraWFTYWZlKGdldENUTSgpLCByKSkKICAgICAgICAgQ2xpcFJl Y3RUb0NhbnZhcygqcGxhdGZvcm1Db250ZXh0KCktPmNhbnZhcygpLCByLCAmcik7CiAKKyAgICBw bGF0Zm9ybUNvbnRleHQoKS0+bWFrZUdyQ29udGV4dEN1cnJlbnQoKTsKKwogICAgIFNrUGFpbnQg cGFpbnQ7CiAgICAgcGxhdGZvcm1Db250ZXh0KCktPnNldHVwUGFpbnRGb3JGaWxsaW5nKCZwYWlu dCk7CiAgICAgcGFpbnQuc2V0WGZlcm1vZGVNb2RlKFNrWGZlcm1vZGU6OmtDbGVhcl9Nb2RlKTsK 101019 2011-07-15 11:59:53 -0700 2011-07-15 12:44:35 -0700 Patch bug-64612-20110715145952.patch text/plain 1381 bsalomon SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxMDg0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMTUgIEJyaWFuIFNh bG9tb24gIDxic2Fsb21vbkBnb29nbGUuY29tPgorCisgICAgICAgIFtTS0lBXSBNdXN0IG1ha2Ug c2tpYSdzIEdMIGNvbnRleHQgY3VycmVudCBiZWZvcmUgZHJhd2luZyBpbiBHcmFwaGljc0NvbnRl eHQ6OmNsZWFyUmVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjQ2MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUZXN0ZWQgYnkgY29tcG9zaXRpbmcvc2hhZG93cy9zaGFkb3ctZHJhd2luZy5odG1sCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpjbGVhclJlY3QpOgorCiAyMDEx LTA3LTE1ICBQcmF0aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KIAogICAgICAgICBQ YXJ0IG9mIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzY3NApJbmRl eDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRT a2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9z a2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwCShyZXZpc2lvbiA5MTA4MikKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTMyNiw2ICszMjYsOCBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6Y2xl YXJSZWN0KGNvbnN0IEZsCiAgICAgaWYgKCFpc1JlY3RTa2lhU2FmZShnZXRDVE0oKSwgcikpCiAg ICAgICAgIENsaXBSZWN0VG9DYW52YXMoKnBsYXRmb3JtQ29udGV4dCgpLT5jYW52YXMoKSwgciwg JnIpOwogCisgICAgcGxhdGZvcm1Db250ZXh0KCktPm1ha2VHckNvbnRleHRDdXJyZW50KCk7CisK ICAgICBTa1BhaW50IHBhaW50OwogICAgIHBsYXRmb3JtQ29udGV4dCgpLT5zZXR1cFBhaW50Rm9y RmlsbGluZygmcGFpbnQpOwogICAgIHBhaW50LnNldFhmZXJtb2RlTW9kZShTa1hmZXJtb2RlOjpr Q2xlYXJfTW9kZSk7Cg==