64590 2011-07-15 03:16:53 -0700 Printing of notImplemented() when logging enabled 2011-09-23 20:20:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 63346 0 l.slachciak webkit-unassigned webkit.review.bot oldest_to_newest 437644 0 l.slachciak 2011-07-15 03:16:53 -0700 Printing of notImplemented() method was enabled on Debug builds only. Now it is enabled when logging is enabled 437645 1 100952 l.slachciak 2011-07-15 03:22:51 -0700 Created attachment 100952 notImplemented function patch 465968 2 100952 eric 2011-09-12 17:02:10 -0700 Comment on attachment 100952 notImplemented function patch I'm confused. Will this result in a situation where notImplemented is not defined? Or was it always defined and just re-defined by this #define in situations where we didn't use it? 472701 3 100952 webkit.review.bot 2011-09-23 20:19:59 -0700 Comment on attachment 100952 notImplemented function patch Clearing flags on attachment: 100952 Committed r95898: <http://trac.webkit.org/changeset/95898> 472702 4 webkit.review.bot 2011-09-23 20:20:04 -0700 All reviewed patches have been landed. Closing bug. 100952 2011-07-15 03:22:51 -0700 2011-09-23 20:19:59 -0700 notImplemented function patch notimplemented.patch text/plain 1201 l.slachciak ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhYmI5ZTg0Li5iYjZiNDFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDctMTUgIEx1a2FzeiBTbGFjaGNpYWsgIDxsLnNsYWNoY2lha0BzYW1zdW5nLmNv bT4KKworICAgICAgICBQcmludGluZyBvZiBub3RJbXBsZW1lbnRlZCgpIHdoZW4gbG9nZ2luZyBl bmFibGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjQ1OTAKKworICAgICAgICBQcmludGluZyBvZiBub3RJbXBsZW1lbnRlZCgpIG1ldGhvZCB3YXMg ZW5hYmxlZCBvbiBEZWJ1ZyBidWlsZHMgb25seS4KKyAgICAgICAgTm93IGl0IGlzIGVuYWJsZWQg d2hlbiBsb2dnaW5nIGlzIGVuYWJsZWQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlcmUgaXMgbm8gbmV3IGZ1 bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9Ob3RJbXBsZW1lbnRlZC5oOiBOb24t ZGVidWcgbW9kZSByZXBsYWNlZCB3aXRoIG5vbi1sb2dnaW5nIG1vZGUuCisKIDIwMTEtMDctMTUg IEpvbmF0aGFuIERvbmcgIDxqb25hdGhhbi5kb25nQHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAg ICAgICBMb2NhbFN0b3JhZ2U6IENoYW5nZWQgdGhlIHZhbHVlIHR5cGUgb2YgSXRlbVRhYmxlIGZy b20gVEVYVCB0byBCTE9CCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Ob3RJ bXBsZW1lbnRlZC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTm90SW1wbGVtZW50ZWQuaApp bmRleCBlOTc1OGIwLi5lNTA0MDc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9Ob3RJbXBsZW1lbnRlZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL05vdEltcGxl bWVudGVkLmgKQEAgLTM4LDcgKzM4LDcgQEAKICAgICAjZGVmaW5lIHN1cHJlc3NOb3RJbXBsZW1l bnRlZFdhcm5pbmcoKSBmYWxzZQogI2VuZGlmCiAKLSNpZiBkZWZpbmVkKE5ERUJVRykKKyNpZiBM T0dfRElTQUJMRUQKICAgICAjZGVmaW5lIG5vdEltcGxlbWVudGVkKCkgKCh2b2lkKTApCiAjZWxz ZQogCg==