<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>6459</bug_id>
          
          <creation_ts>2006-01-09 23:31:51 -0800</creation_ts>
          <short_desc>build-webkit should exit with non-zero status when build fails</short_desc>
          <delta_ts>2006-01-10 14:16:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>420+</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Rowe (bdash)">mrowe</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>28104</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2006-01-09 23:31:51 -0800</bug_when>
    <thetext>When xcodebuild fails, it prints &apos;** BUILD FAILED **&apos; but build-webkit exits with a zero exit code.  This 
makes scripting build-webkit trickier than necessary.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>28105</commentid>
    <comment_count>1</comment_count>
      <attachid>5587</attachid>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2006-01-09 23:36:38 -0800</bug_when>
    <thetext>Created attachment 5587
Use correct bits of subprocess exit code when passing back through as build-webkit&apos;s exit code</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>28106</commentid>
    <comment_count>2</comment_count>
      <attachid>5587</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2006-01-09 23:40:35 -0800</bug_when>
    <thetext>Comment on attachment 5587
Use correct bits of subprocess exit code when passing back through as build-webkit&apos;s exit code

Finally! r=me.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>5587</attachid>
            <date>2006-01-09 23:36:38 -0800</date>
            <delta_ts>2006-01-09 23:40:35 -0800</delta_ts>
            <desc>Use correct bits of subprocess exit code when passing back through as build-webkit&apos;s exit code</desc>
            <filename>webkit-bug-6459-v1.patch</filename>
            <type>text/plain</type>
            <size>1576</size>
            <attacher name="Mark Rowe (bdash)">mrowe</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0Cj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl
YktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CShyZXZpc2lvbiAxMTk3NikKKysrIFdlYktp
dFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw3
IEBAIHVzZSBGaW5kQmluOwogdXNlIEdldG9wdDo6TG9uZyBxdyg6Y29uZmlnIHBhc3NfdGhyb3Vn
aCk7CiB1c2UgbGliICRGaW5kQmluOjpCaW47CiB1c2Ugd2Via2l0ZGlyczsKK3VzZSBQT1NJWDsK
IAogbXkgJHN2Z1N1cHBvcnQgPSAxOwogR2V0T3B0aW9ucygnc3ZnIScgPT4gXCRzdmdTdXBwb3J0
KTsKQEAgLTgyLDEwICs4MywxMCBAQCBmb3IgbXkgJGRpciAoQHByb2plY3RzKSB7CiAgICAgfSBl
bHNlIHsKICAgICAgICAgJHJlc3VsdCA9IHN5c3RlbSAieGNvZGVidWlsZCIsICItcHJvamVjdCIs
ICIkZGlyLnhjb2RlcHJvaiIsIEBvcHRpb25zLCBAQVJHVjsKICAgICB9Ci0gICAgZXhpdCAkcmVz
dWx0IGlmICRyZXN1bHQ7CisgICAgZXhpdCBXRVhJVFNUQVRVUygkcmVzdWx0KSBpZiBXRVhJVFNU
QVRVUygkcmVzdWx0KTsKICAgICBpZiAoJGRpciBlcSAiSmF2YVNjcmlwdENvcmUiKSB7CiAgICAg
ICAgICRyZXN1bHQgPSBzeXN0ZW0gInhjb2RlYnVpbGQiLCAiLXByb2plY3QiLCAiJGRpci54Y29k
ZXByb2oiLCAiLXRhcmdldCIsICJ0ZXN0a2pzIiwgQG9wdGlvbnMsIEBBUkdWOwotICAgICAgICBl
eGl0ICRyZXN1bHQgaWYgJHJlc3VsdDsKKyAgICAgICAgZXhpdCBXRVhJVFNUQVRVUygkcmVzdWx0
KSBpZiBXRVhJVFNUQVRVUygkcmVzdWx0KTsKICAgICB9CiAgICAgY2hkaXIgIi4uIiBvciBkaWU7
CiB9CkluZGV4OiBXZWJLaXRUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9v
bHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTk3OCkKKysrIFdlYktpdFRvb2xzL0NoYW5nZUxvZwko
d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDA2LTAxLTEwICBNYXJrIFJvd2UgIDxv
cGVuZGFyd2luLm9yZ0BiZGFzaC5uZXQubno+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgLSBidWlsZC13ZWJraXQgc2hvdWxkIGV4aXQgd2l0aCBub24t
emVybyBzdGF0dXMgd2hlbiBidWlsZCBmYWlscworICAgICAgICBodHRwOi8vYnVnemlsbGEub3Bl
bmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTY0NTkKKworICAgICAgICAqIFNjcmlwdHMvYnVp
bGQtd2Via2l0OgorICAgICAgICBVc2UgY29ycmVjdCBiaXRzIG9mIHN1YnByb2Nlc3MgZXhpdCBj
b2RlIHdoZW4gcGFzc2luZyBiYWNrIHRocm91Z2gKKyAgICAgICAgYXMgYnVpbGQtd2Via2l0J3Mg
ZXhpdCBjb2RlLgorCiAyMDA2LTAxLTEwICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBtYWMu
Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRpbW90aHkuCg==
</data>
<flag name="review"
          id="1231"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>