64586 2011-07-15 00:39:51 -0700 NRWT stores the Chromium revision number in full_results.json 2022-03-01 02:49:45 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth abarth eric ojan oldest_to_newest 437613 0 abarth 2011-07-15 00:39:51 -0700 http://test-results.appspot.com/testfile?builder=Webkit%20Linux%20(dbg)(1)&name=full_results.json "revision":"92662" ===== [chrome] Repository: Index of / Files shown: 2 Directory revision: 92662 (of 92662) Sticky Revision: ===== Whereas, in WebKit: 07/15/2011: Today 00:23 Changeset [91057] by commit-queue@webkit.org I don't really understand how that's possible: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py#L212 437615 1 eric 2011-07-15 00:42:56 -0700 I'm confused what this bug is saying. It's very possible our svn info parsing is broken. Can you show me an example full_results.json with invalid values? 437617 2 abarth 2011-07-15 00:49:36 -0700 http://test-results.appspot.com/testfile?builder=Webkit%20Linux%20(dbg)(1)&name=full_results.json is one such file. 437625 3 100946 abarth 2011-07-15 01:19:46 -0700 Created attachment 100946 Patch 437626 4 100946 eric 2011-07-15 01:20:49 -0700 Comment on attachment 100946 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100946&action=review OK. > Tools/Scripts/webkitpy/layout_tests/port/base.py:612 > + # FIXME: Due to Chromium's insane DEPS system, the root of the WebKit Well the DEPS system isn't insane, just their setup. 437627 5 abarth 2011-07-15 01:22:46 -0700 Committed r91059: <http://trac.webkit.org/changeset/91059> 100946 2011-07-15 01:19:46 -0700 2022-03-01 02:49:45 -0800 Patch bug-64586-20110715011945.patch text/plain 3113 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTEwNTQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4N2JmNmI2ZDMzMGI3NmRjMDc5NGNjNzlmNTFhOTBiZGM4 NTAzYTg4Li4yYzZjYTg4MzliNmQzMDYyNmI5Njc3ZWZkMWE5Zjc5MzE5MGYzZDI1IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDctMTUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAg ICBOUldUIHN0b3JlcyB0aGUgQ2hyb21pdW0gcmV2aXNpb24gbnVtYmVyIGluIGZ1bGxfcmVzdWx0 cy5qc29uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 NDU4NgorCisgICAgICAgIEkgaGF2ZSBubyBlYXJ0aGx5IGlkZWEgaG93IHRvIHRlc3QgdGhpcyBj aGFuZ2UuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9s bGVycy9tYW5hZ2VyLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvYmFzZS5weToKKwogMjAxMS0wNy0xNCAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIGZpeCByZW1haW5pbmcgc3R5bGUgaXNzdWVzIGluIHRoZSBzdGF0aWMt ZGFzaGJvYXJkcyBkaXJlY3RvcnkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5CmluZGV4IGExMmUzMWI1YjY3 ODhjNzY1ZWFmZjNlYzg3YzYxZTRlZThiMDU5NGUuLmQ2MjkwMGZlOGIyMjE4NjEyYzBiOTkyMmFh OWE4MzVjODM0MmZmYjYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weQpAQCAtMjA5LDcgKzIwOSw3IEBA IGRlZiBzdW1tYXJpemVfcmVzdWx0cyhwb3J0X29iaiwgZXhwZWN0YXRpb25zLCByZXN1bHRfc3Vt bWFyeSwgcmV0cnlfc3VtbWFyeSwgdGVzCiAgICAgcmVzdWx0c1snaGFzX3dkaWZmJ10gPSBwb3J0 X29iai53ZGlmZl9hdmFpbGFibGUoKQogICAgIHJlc3VsdHNbJ2hhc19wcmV0dHlfcGF0Y2gnXSA9 IHBvcnRfb2JqLnByZXR0eV9wYXRjaF9hdmFpbGFibGUoKQogICAgIHRyeToKLSAgICAgICAgcmVz dWx0c1sncmV2aXNpb24nXSA9IHBvcnRfb2JqLndlYmtpdF9zY20oKS5oZWFkX3N2bl9yZXZpc2lv bigpCisgICAgICAgIHJlc3VsdHNbJ3JldmlzaW9uJ10gPSBwb3J0X29iai53ZWJraXRfc291cmNl X3NjbSgpLmhlYWRfc3ZuX3JldmlzaW9uKCkKICAgICBleGNlcHQgRXhjZXB0aW9uLCBlOgogICAg ICAgICAjIEZJWE1FOiBXZSB3b3VsZCBsaWtlIHRvIHdhcm4gaGVyZSwgYnV0IHRoYXQgd291bGQg Y2F1c2UgYWxsIHBhc3NpbmdfcnVuIGludGVncmF0aW9uIHRlc3RzCiAgICAgICAgICMgdG8gZmFp bCwgc2luY2UgdGhleSBhc3NlcnQgdGhhdCB3ZSBoYXZlIG5vIGxvZ2dpbmcgb3V0cHV0LgpkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5 IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5CmluZGV4 IDQzNzc3ZTkyNDdiODQ4MWQ4NTU5OWIxNDA2OGNjZDk0NjRiNjVmNWMuLjEzMmQxYTYwYjgyYjc2 YTU4MDRlM2ExMjBhM2Q4NmM2YmYxZTI2ZGQgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkKQEAgLTYwMywxMiArNjAzLDE2IEBAIGNsYXNz IFBvcnQob2JqZWN0KToKICAgICAgICAgcmV0dXJuIHNlbGYuX2NvbmZpZy5wYXRoX2Zyb21fd2Vi a2l0X2Jhc2UoKmNvbXBzKQogCiAgICAgQG1lbW9pemVkCi0gICAgZGVmIHdlYmtpdF9zY20oc2Vs Zik6CisgICAgZGVmIHdlYmtpdF9zb3VyY2Vfc2NtKHNlbGYpOgogICAgICAgICAjIE9uIHRoZSBj aHJvbWl1bSBib3RzLCB0aGUgY3dkIGlzIHRoZSByb290IG9mIHRoZSBjaHJvbWl1bSBjaGVja291 dC4KICAgICAgICAgIyBzZWxmLl9jb25maWcud2Via2l0X2Jhc2VfZGlyKCkga25vd3Mgd2hlcmUg dGhlIHdlYmtpdCByb290IGlzLCBubyBvdGhlcgotICAgICAgICAjIG9iamVjdCBpbiBOUldUIHNl ZW1zIHRvIGtlZXAgYW4gU0NNIGFyb3VuZC4gIChVbmxpa2Ugd2Via2l0LXBhdGNoIHdoZXJlIGl0 J3Mgb24gdGhlIFRvb2wvSG9zdCBvYmplY3QuKQorICAgICAgICAjIG9iamVjdCBpbiBOUldUIHNl ZW1zIHRvIGtlZXAgYW4gU0NNIGFyb3VuZC4gKFVubGlrZSB3ZWJraXQtcGF0Y2gKKyAgICAgICAg IyB3aGVyZSBpdCdzIG9uIHRoZSBUb29sL0hvc3Qgb2JqZWN0LikKICAgICAgICAgIyBGSVhNRTog V2Ugc2hvdWxkIGJlIGFibGUgdG8gZ2V0IHRoZSBTQ00gZnJvbSBzb21ld2hlcmUgZWxzZS4KLSAg ICAgICAgcmV0dXJuIGRldGVjdF9zY21fc3lzdGVtKHNlbGYuX2NvbmZpZy53ZWJraXRfYmFzZV9k aXIoKSkKKyAgICAgICAgIyBGSVhNRTogRHVlIHRvIENocm9taXVtJ3MgaW5zYW5lIERFUFMgc3lz dGVtLCB0aGUgcm9vdCBvZiB0aGUgV2ViS2l0CisgICAgICAgICMgY2hlY2tvdXQgaXNuJ3QgYWN0 dWFsbHkgZnJvbSBzdm4ud2Via2l0Lm9yZy4gSW5zdGVhZCwgd2UgZGV0ZWN0IHRoZQorICAgICAg ICAjIHNjbSBmcm9tIHRoZSBTb3VyY2UgZGlyZWN0b3J5LCB3aGljaCByZWFsbHkgZG9lcyBtYXAg dG8gc3ZuLndlYmtpdC5vcmcuCisgICAgICAgIHJldHVybiBkZXRlY3Rfc2NtX3N5c3RlbShzZWxm LnBhdGhfZnJvbV93ZWJraXRfYmFzZSgnU291cmNlJykpCiAKICAgICBkZWYgcGF0aF90b190ZXN0 X2V4cGVjdGF0aW9uc19maWxlKHNlbGYpOgogICAgICAgICAiIiJVcGRhdGUgdGhlIHRlc3QgZXhw ZWN0YXRpb25zIHRvIHRoZSBwYXNzZWQtaW4gc3RyaW5nLgo=