64576 2011-07-14 17:35:46 -0700 Add regression tests for legacy color parsing of valid CSS colors 2011-07-18 15:49:56 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tabatkins tabatkins darin simon.fraser webkit.review.bot oldest_to_newest 437431 0 tabatkins 2011-07-14 17:35:46 -0700 Using a valid CSS color other than a named color or a 3/6 digit hex color should use the legacy parsing code, rather than accepting the value and treating it like a valid CSS color. There aren't currently enough regression tests surrounding this. Specifically, we seem to need tests for "currentColor", the rgba() function, and the hsl() and hsla() functions. 438739 1 101206 tabatkins 2011-07-18 14:50:23 -0700 Created attachment 101206 Patch 438744 2 tabatkins 2011-07-18 14:51:50 -0700 Newly added people, can I get a quick r+? This is just a four-line addition to the tests, plus updated expectations. 438786 3 101206 webkit.review.bot 2011-07-18 15:49:51 -0700 Comment on attachment 101206 Patch Clearing flags on attachment: 101206 Committed r91217: <http://trac.webkit.org/changeset/91217> 438787 4 webkit.review.bot 2011-07-18 15:49:56 -0700 All reviewed patches have been landed. Closing bug. 101206 2011-07-18 14:50:23 -0700 2011-07-18 15:49:51 -0700 Patch bug-64576-20110718145022.patch text/plain 3312 tabatkins U3VidmVyc2lvbiBSZXZpc2lvbjogOTEwMjQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlZWM5YmU5M2IwMGE3MzUyOTc1OWY5 NTdlNTU2NDcwYjQ4M2IyOTQ5Li5mNzE1ZjNlM2FlZmYzOTNjZTRiYmE2NTQxZTRmZjFkNWUxYWE4 YTExIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDctMTggIFRhYiBBdGtpbnMgIDxqYWNr YWxtYWdlQGdtYWlsLmNvbT4KKworICAgICAgICBBZGQgcmVncmVzc2lvbiB0ZXN0cyBmb3IgbGVn YWN5IGNvbG9yIHBhcnNpbmcgb2YgdmFsaWQgQ1NTIGNvbG9ycworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ1NzYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZG9tL2F0dHJpYnV0ZS1sZWdhY3kt Y29sb3JzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2RvbS9zY3JpcHQtdGVzdHMvYXR0 cmlidXRlLWxlZ2FjeS1jb2xvcnMuanM6CisKIDIwMTEtMDctMTQgIFZpbmNlbnQgU2NoZWliICA8 c2NoZWliQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIHVwZGF0ZWQgdGVzdCBl eHBlY3RhdGlvbnMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9hdHRyaWJ1dGUt bGVnYWN5LWNvbG9ycy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9hdHRyaWJ1 dGUtbGVnYWN5LWNvbG9ycy1leHBlY3RlZC50eHQKaW5kZXggZmMxNWI5MTM1MTQ3NDFjZmZlMDk4 MzFlMDUwZWM2MDA4ZmNlMTRiYS4uNjQ4MDVmNTdhZTgxYzJmYjYyNmJmMTUwYzU4M2JhZmM0MTNl NjEzNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vYXR0cmlidXRlLWxlZ2FjeS1j b2xvcnMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL2F0dHJpYnV0ZS1s ZWdhY3ktY29sb3JzLWV4cGVjdGVkLnR4dApAQCAtMjIsNiArMjIsMTAgQEAgUEFTUyBkb2N1bWVu dC5ib2R5LmJnQ29sb3I9J2NoZWVzZSc7Z2V0Q29tcHV0ZWRTdHlsZShkb2N1bWVudC5ib2R5KS5i YWNrZ3JvdW5kQ28KIFBBU1MgZG9jdW1lbnQuYm9keS5iZ0NvbG9yPSdmZvKAv79mZic7Z2V0Q29t cHV0ZWRTdHlsZShkb2N1bWVudC5ib2R5KS5iYWNrZ3JvdW5kQ29sb3I7IGlzICdyZ2IoMjU1LCAw LCAyNTUpJwogUEFTUyBkb2N1bWVudC5ib2R5LmJnQ29sb3I9J2bygL+/Zic7Z2V0Q29tcHV0ZWRT dHlsZShkb2N1bWVudC5ib2R5KS5iYWNrZ3JvdW5kQ29sb3I7IGlzICdyZ2IoMjQwLCAxNSwgMCkn CiBQQVNTIGRvY3VtZW50LmJvZHkuYmdDb2xvcj0ncmdiKDI1NSwgMCwgMCknO2dldENvbXB1dGVk U3R5bGUoZG9jdW1lbnQuYm9keSkuYmFja2dyb3VuZENvbG9yOyBpcyAncmdiKDAsIDg1LCAwKScK K1BBU1MgZG9jdW1lbnQuYm9keS5iZ0NvbG9yPSdyZ2JhKDI1NSwyNTUsMjU1LDUwJSknO2dldENv bXB1dGVkU3R5bGUoZG9jdW1lbnQuYm9keSkuYmFja2dyb3VuZENvbG9yOyBpcyAncmdiKDAsIDgw LCA4NSknCitQQVNTIGRvY3VtZW50LmJvZHkuYmdDb2xvcj0naHNsKDE4MCwxMDAlLDUwJSknO2dl dENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuYm9keSkuYmFja2dyb3VuZENvbG9yOyBpcyAncmdiKDAs IDEsIDgwKScKK1BBU1MgZG9jdW1lbnQuYm9keS5iZ0NvbG9yPSdoc2xhKDE4MCwxMDAlLDUwJSw1 MCUpJztnZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmJvZHkpLmJhY2tncm91bmRDb2xvcjsgaXMg J3JnYigwLCAxNiwgNSknCitQQVNTIGRvY3VtZW50LmJvZHkuYmdDb2xvcj0nY3VycmVudENvbG9y JztnZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmJvZHkpLmJhY2tncm91bmRDb2xvcjsgaXMgJ3Jn YigxOTIsIDIyNCwgMCknCiBQQVNTIGRvY3VtZW50LmJvZHkuYmdDb2xvcj0nNTUwMDAwMDAxMTU1 MDAwMDAwMTE1NTAwMDAwMDExJztnZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmJvZHkpLmJhY2tn cm91bmRDb2xvcjsgaXMgJ3JnYigxNywgMTcsIDE3KScKIFBBU1MgZG9jdW1lbnQuYm9keS5iZ0Nv bG9yPSc1NTAwMDAwMDAxNTUwMDAwMDAwMTU1MDAwMDAwMDEnO2dldENvbXB1dGVkU3R5bGUoZG9j dW1lbnQuYm9keSkuYmFja2dyb3VuZENvbG9yOyBpcyAncmdiKDEsIDEsIDEpJwogUEFTUyBkb2N1 bWVudC5ib2R5LmJnQ29sb3I9JzU1MDAwMDAwMDA1NTAwMDAwMDAwNTUwMDAwMDAwMCc7Z2V0Q29t cHV0ZWRTdHlsZShkb2N1bWVudC5ib2R5KS5iYWNrZ3JvdW5kQ29sb3I7IGlzICdyZ2IoMCwgMCwg MCknCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zY3JpcHQtdGVzdHMvYXR0cmli dXRlLWxlZ2FjeS1jb2xvcnMuanMgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zY3JpcHQtdGVzdHMv YXR0cmlidXRlLWxlZ2FjeS1jb2xvcnMuanMKaW5kZXggZDZmZDdkOTFkMmJkYTNmYjRhMzc2MmVj YTBlNGU2NGU2N2U5NjIyYi4uNzY4MmMxZDM2ZDVkNWI1YTBlMmQxNjFjYTI4MTRjYWFkYzlkMDJl OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2NyaXB0LXRlc3RzL2F0dHJpYnV0 ZS1sZWdhY3ktY29sb3JzLmpzCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NjcmlwdC10ZXN0 cy9hdHRyaWJ1dGUtbGVnYWN5LWNvbG9ycy5qcwpAQCAtMjEsNiArMjEsMTAgQEAgdmFyIHRlc3Rz ID0gWwogCXsndGVzdCc6J2Zm8oC/v2ZmJywgJ2V4cGVjdGVkJzpbMjU1LCAwLCAyNTVdfSwKIAl7 J3Rlc3QnOidm8oC/v2YnLCAnZXhwZWN0ZWQnOlsyNDAsIDE1LCAwXX0sCiAJeyd0ZXN0Jzoncmdi KDI1NSwgMCwgMCknLCAnZXhwZWN0ZWQnOlswLCA4NSwgMF19LAorCXsndGVzdCc6J3JnYmEoMjU1 LDI1NSwyNTUsNTAlKScsICdleHBlY3RlZCc6WzAsODAsODVdfSwKKwl7J3Rlc3QnOidoc2woMTgw LDEwMCUsNTAlKScsICdleHBlY3RlZCc6WzAsMSw4MF19LAorCXsndGVzdCc6J2hzbGEoMTgwLDEw MCUsNTAlLDUwJSknLCAnZXhwZWN0ZWQnOlswLDE2LDVdfSwKKwl7J3Rlc3QnOidjdXJyZW50Q29s b3InLCAnZXhwZWN0ZWQnOlsxOTIsMjI0LDBdfSwKIAl7J3Rlc3QnOic1NTAwMDAwMDExNTUwMDAw MDAxMTU1MDAwMDAwMTEnLCAnZXhwZWN0ZWQnOlsxNywgMTcsIDE3XX0sCiAJeyd0ZXN0JzonNTUw MDAwMDAwMTU1MDAwMDAwMDE1NTAwMDAwMDAxJywgJ2V4cGVjdGVkJzpbMSwgMSwgMV19LAogCXsn dGVzdCc6JzU1MDAwMDAwMDA1NTAwMDAwMDAwNTUwMDAwMDAwMCcsICdleHBlY3RlZCc6WzAsIDAs IDBdfSwK