64568 2011-07-14 16:01:04 -0700 REGRESSION: webkit-patch roll-chromium-deps is broken 2011-07-14 16:23:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa abarth dpranke eric oldest_to_newest 437383 0 rniwa 2011-07-14 16:01:04 -0700 webkit-patch roll-chromium-deps blows up with the following error: rniwa-macpro:webkit2 rniwa$ Tools/Scripts/webkit-patch roll-chromium-deps 92606 Traceback (most recent call last): File "Tools/Scripts/webkit-patch", line 66, in <module> main() File "Tools/Scripts/webkit-patch", line 61, in main WebKitPatch(__file__).main() File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/steps/updatechromiumdeps.py", line 69, in run deps = self._tool.checkout().chromium_deps() File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 151, in chromium_deps return DEPS(self._scm.absolute_path("Source", "WebKit", "chromium", "DEPS")) TypeError: absolute_path() takes exactly 2 arguments (5 given) 437388 1 100884 rniwa 2011-07-14 16:08:26 -0700 Created attachment 100884 Patch 437390 2 100884 eric 2011-07-14 16:12:15 -0700 Comment on attachment 100884 Patch LGTM too. Sorry for the trouble. We really should test this method.... 437397 3 100889 rniwa 2011-07-14 16:20:08 -0700 Created attachment 100889 Patch 437401 4 rniwa 2011-07-14 16:23:15 -0700 Committed r91033: <http://trac.webkit.org/changeset/91033> 100884 2011-07-14 16:08:26 -0700 2011-07-14 16:20:04 -0700 Patch bug-64568-20110714160825.patch text/plain 1317 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkxMDMxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTEtMDctMTQgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUkVHUkVTU0lPTjogd2Via2l0LXBhdGNoIHJvbGwtY2hyb21pdW0tZGVwcyBpcyBi cm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0 NTY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkKKworICAgICAgICBVc2Ug X2ZpbGVzeXN0ZW0uam9pbi4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2No ZWNrb3V0L2NoZWNrb3V0LnB5OgorCiAyMDExLTA3LTE0ICBOb2FtIFJvc2VudGhhbCAgPG5vYW0u cm9zZW50aGFsQG5va2lhLmNvbT4KIAogICAgICAgICBBZGRpbmcgbXlzZWxmIHRvIHRoZSByZXZp ZXdlcnMgbGlzdDsgTm8gcmV2aWV3IG5lZWRlZC4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL2NoZWNrb3V0L2NoZWNrb3V0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoZWNrb3V0LnB5CShyZXZpc2lvbiA5MTAzMSkK KysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoZWNrb3V0LnB5CSh3 b3JraW5nIGNvcHkpCkBAIC0xNDgsNyArMTQ4LDcgQEAgY2xhc3MgQ2hlY2tvdXQob2JqZWN0KToK ICAgICAgICAgICAgIHBhc3MgIyBXZSBtaWdodCBub3QgaGF2ZSBDaGFuZ2VMb2dzLgogCiAgICAg ZGVmIGNocm9taXVtX2RlcHMoc2VsZik6Ci0gICAgICAgIHJldHVybiBERVBTKHNlbGYuX3NjbS5h YnNvbHV0ZV9wYXRoKCJTb3VyY2UiLCAiV2ViS2l0IiwgImNocm9taXVtIiwgIkRFUFMiKSkKKyAg ICAgICAgcmV0dXJuIERFUFMoc2VsZi5fc2NtLmFic29sdXRlX3BhdGgoc2VsZi5fZmlsZXN5c3Rl bS5qb2luKCJTb3VyY2UiLCAiV2ViS2l0IiwgImNocm9taXVtIiwgIkRFUFMiKSkpCiAKICAgICBk ZWYgYXBwbHlfcGF0Y2goc2VsZiwgcGF0Y2gsIGZvcmNlPUZhbHNlKToKICAgICAgICAgIyBJdCdz IHBvc3NpYmxlIHRoYXQgdGhlIHBhdGNoIHdhcyBub3QgbWFkZSBmcm9tIHRoZSByb290IGRpcmVj dG9yeS4K 100889 2011-07-14 16:20:08 -0700 2011-07-14 16:21:08 -0700 Patch bug-64568-20110714162007.patch text/plain 2172 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkxMDMxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDctMTQgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUkVHUkVTU0lPTjogd2Via2l0LXBhdGNoIHJvbGwtY2hyb21pdW0tZGVwcyBpcyBi cm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0 NTY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkKKworICAgICAgICBVc2Ug X2ZpbGVzeXN0ZW0uam9pbi4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2No ZWNrb3V0L2NoZWNrb3V0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2No ZWNrb3V0L2NoZWNrb3V0X3VuaXR0ZXN0cy5weToKKwogMjAxMS0wNy0xNCAgTm9hbSBSb3NlbnRo YWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CiAKICAgICAgICAgQWRkaW5nIG15c2VsZiB0 byB0aGUgcmV2aWV3ZXJzIGxpc3Q7IE5vIHJldmlldyBuZWVkZWQuCkluZGV4OiBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGVja291dC5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGVja291dC5weQkocmV2aXNp b24gOTEwMzEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGVj a291dC5weQkod29ya2luZyBjb3B5KQpAQCAtMTQ4LDcgKzE0OCw3IEBAIGNsYXNzIENoZWNrb3V0 KG9iamVjdCk6CiAgICAgICAgICAgICBwYXNzICMgV2UgbWlnaHQgbm90IGhhdmUgQ2hhbmdlTG9n cy4KIAogICAgIGRlZiBjaHJvbWl1bV9kZXBzKHNlbGYpOgotICAgICAgICByZXR1cm4gREVQUyhz ZWxmLl9zY20uYWJzb2x1dGVfcGF0aCgiU291cmNlIiwgIldlYktpdCIsICJjaHJvbWl1bSIsICJE RVBTIikpCisgICAgICAgIHJldHVybiBERVBTKHNlbGYuX3NjbS5hYnNvbHV0ZV9wYXRoKHNlbGYu X2ZpbGVzeXN0ZW0uam9pbigiU291cmNlIiwgIldlYktpdCIsICJjaHJvbWl1bSIsICJERVBTIikp KQogCiAgICAgZGVmIGFwcGx5X3BhdGNoKHNlbGYsIHBhdGNoLCBmb3JjZT1GYWxzZSk6CiAgICAg ICAgICMgSXQncyBwb3NzaWJsZSB0aGF0IHRoZSBwYXRjaCB3YXMgbm90IG1hZGUgZnJvbSB0aGUg cm9vdCBkaXJlY3RvcnkuCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVj a291dC9jaGVja291dF91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGVja291dF91bml0dGVzdC5weQkocmV2aXNpb24gOTEw MzEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGVja291dF91 bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMjQzLDMgKzI0Myw4IEBAIGNsYXNzIENoZWNr b3V0VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIHJldmlld2VycyA9IGNoZWNrb3V0 LnN1Z2dlc3RlZF9yZXZpZXdlcnMoZ2l0X2NvbW1pdD1Ob25lKQogICAgICAgICByZXZpZXdlcl9u YW1lcyA9IFtyZXZpZXdlci5mdWxsX25hbWUgZm9yIHJldmlld2VyIGluIHJldmlld2Vyc10KICAg ICAgICAgc2VsZi5hc3NlcnRFcXVhbChyZXZpZXdlcl9uYW1lcywgW3UnVG9yIEFybmUgVmVzdGJc eGY4J10pCisKKyAgICBkZWYgdGVzdF9jaHJvbWl1bV9kZXBzKHNlbGYpOgorICAgICAgICBjaGVj a291dCA9IHNlbGYuX21ha2VfY2hlY2tvdXQoKQorICAgICAgICBjaGVja291dC5fc2NtLmNoZWNr b3V0X3Jvb3QgPSAiL2Zvby9iYXIiCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoY2hlY2tvdXQu Y2hyb21pdW1fZGVwcygpLl9wYXRoLCAnL2Zvby9iYXIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9E RVBTJykK