64557 2011-07-14 13:45:27 -0700 REGRESSION: Should not dispatch didFirstVisuallyNonEmptyLayout for the initial empty document 2011-07-14 14:16:59 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned oldest_to_newest 437295 0 koivisto 2011-07-14 13:45:27 -0700 If layout happens when a frame is showing the initial empty document we end up dispatching didFirstVisuallyNonEmptyLayout for it. This may be unexpected for clients. Regressed in http://trac.webkit.org/changeset/90900 437305 1 100856 koivisto 2011-07-14 13:59:09 -0700 Created attachment 100856 patch 437311 2 100856 kenneth 2011-07-14 14:05:30 -0700 Comment on attachment 100856 patch LGTM 437322 3 koivisto 2011-07-14 14:16:59 -0700 http://trac.webkit.org/changeset/91027 100856 2011-07-14 13:59:09 -0700 2011-07-14 14:05:30 -0700 patch first-visual-inital-empty.patch text/plain 1484 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxMDI2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMTQgIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT046IFNob3VsZCBu b3QgZGlzcGF0Y2ggZGlkRmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0IGZvciB0aGUgaW5pdGlh bCBlbXB0eSBkb2N1bWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjQ1NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBdm9pZCBzZW5kaW5nIGRpZEZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dCBmb3Ig dGhlIGluaXRpYWwgZW1wdHkgZG9jdW1lbnQgb2YgdGhlIGZyYW1lLiBUaGUKKyAgICAgICAgY2xp ZW50cyBtYXkgbm90IGV4cGVjdCBpdCBhbmQgaXQgZG9lc24ndCBtYWtlIG11Y2ggc2Vuc2UgaW4g YW55IGNhc2UuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJD b3JlOjpGcmFtZVZpZXc6OnBlcmZvcm1Qb3N0TGF5b3V0VGFza3MpOgorCiAyMDExLTA3LTE0ICBK ZWZmcmV5IFBmYXUgIDxqcGZhdUBhcHBsZS5jb20+CiAKICAgICAgICAgQ2hhcmFjdGVyIHJlZmVy ZW5jZSBwYXJzZXIgZm9yIG5ldyBYTUwgcGFyc2VyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdl L0ZyYW1lVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZp ZXcuY3BwCShyZXZpc2lvbiA5MDkwMCkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjA0Niw3ICsyMDQ2LDcgQEAgdm9pZCBGcmFtZVZpZXc6 OnBlcmZvcm1Qb3N0TGF5b3V0VGFza3MoKQogICAgICAgICB9CiAKICAgICAgICAgLy8gRW5zdXJl IHRoYXQgd2UgYWx3YXlzIHNlbmQgdGhpcyBldmVudHVhbGx5LgotICAgICAgICBpZiAoIW1fZnJh bWUtPmRvY3VtZW50KCktPnBhcnNpbmcoKSkKKyAgICAgICAgaWYgKCFtX2ZyYW1lLT5kb2N1bWVu dCgpLT5wYXJzaW5nKCkgJiYgbV9mcmFtZS0+bG9hZGVyKCktPnN0YXRlTWFjaGluZSgpLT5jb21t aXR0ZWRGaXJzdFJlYWxEb2N1bWVudExvYWQoKSkKICAgICAgICAgICAgIG1faXNWaXN1YWxseU5v bkVtcHR5ID0gdHJ1ZTsKIAogICAgICAgICAvLyBJZiB0aGUgbGF5b3V0IHdhcyBkb25lIHdpdGgg cGVuZGluZyBzaGVldHMsIHdlIGFyZSBub3QgaW4gZmFjdCB2aXN1YWxseSBub24tZW1wdHkgeWV0 Lgo=