64555 2011-07-14 13:19:28 -0700 [chromium] WebFontImpl::drawText needs to handle the canvasIsOpaque input. 2011-07-18 13:36:49 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 yzshen yzshen brettw webkit.review.bot oldest_to_newest 437289 0 yzshen 2011-07-14 13:19:28 -0700 Currently this input parameter is ignored. 437371 1 100877 yzshen 2011-07-14 15:39:40 -0700 Created attachment 100877 Proposed patch 438539 2 brettw 2011-07-18 10:11:12 -0700 This code looks good to me. I'm not a WebKit reviewer so we still need an official review. 438634 3 100877 jamesr 2011-07-18 12:29:18 -0700 Comment on attachment 100877 Proposed patch R=me 438672 4 100877 webkit.review.bot 2011-07-18 13:36:44 -0700 Comment on attachment 100877 Proposed patch Clearing flags on attachment: 100877 Committed r91205: <http://trac.webkit.org/changeset/91205> 438673 5 webkit.review.bot 2011-07-18 13:36:49 -0700 All reviewed patches have been landed. Closing bug. 100877 2011-07-14 15:39:40 -0700 2011-07-18 13:36:43 -0700 Proposed patch HandleCanvasIsOpaque.txt text/plain 4442 yzshen SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5MDk3MSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDctMTQgIFl1emh1IFNoZW4gIDx5enNoZW5AY2hyb21pdW0uY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gV2Vi Rm9udEltcGw6OmRyYXdUZXh0IG5lZWRzIHRvIGhhbmRsZSB0aGUgY2FudmFzSXNPcGFxdWUgaW5w dXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDU1 NQorICAgICAgICAKKyAgICAgICAgVGhpcyBjaGFuZ2UgaGFuZGxlcyBjYW52YXNJc09wYXF1ZSBm b3IgdGhlIFdFQktJVF9VU0lOR19TS0lBIGNhc2UuCisgCisgICAgICAgICogc3JjL1dlYkZvbnRJ bXBsLmNwcDogaGFuZGxlZCBjYW52YXNJc09wYXF1ZS4KKyAgICAgICAgKiBzcmMvV2ViRm9udElt cGwuaDogYWRkZWQgbWV0aG9kIGRlY2xhcmF0aW9uLgorCiAyMDExLTA3LTEzICBOb2VsIEdvcmRv biAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KIAogICAgICAgICBbY2hyb21pdW1dIENsZWFuIHVu ZGVlZGVkIFdlYkNvcmU6OiBuYW1lc3BhY2UgcHJlZml4aW5nIGZyb20gV2ViQmluZGluZ3MuCklu ZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGb250SW1wbC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRm9udEltcGwuY3BwCShyZXZpc2lv biA5MDk3MSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZvbnRJbXBsLmNwcAko d29ya2luZyBjb3B5KQpAQCAtOTEsMTggKzkxLDQ0IEBAIHZvaWQgV2ViRm9udEltcGw6OmRyYXdU ZXh0KFdlYkNhbnZhcyogY2EKICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdlYkNvbG9yIGNv bG9yLCBjb25zdCBXZWJSZWN0JiBjbGlwLCBib29sIGNhbnZhc0lzT3BhcXVlLAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgaW50IGZyb20sIGludCB0bykgY29uc3QKIHsKLSAgICAvLyBGSVhN RSBob29rIGNhbnZhc0lzT3BhcXVlIHVwIHRvIHRoZSBwbGF0Zm9ybS1zcGVjaWZpYyBpbmRpY2F0 b3JzIGZvcgotICAgIC8vIHdoZXRoZXIgc3VicGl4ZWwgQUEgY2FuIGJlIHVzZWQgZm9yIHRoaXMg ZHJhdy4gT24gV2luZG93cywgdGhpcyBpcwotICAgIC8vIFBsYXRmb3JtQ29udGV4dFNraWE6OnNl dERyYXdpbmdUb0ltYWdlQnVmZmVyLgotCiAgICAgR3JhcGhpY3NDb250ZXh0QnVpbGRlciBidWls ZGVyKGNhbnZhcyk7CiAgICAgR3JhcGhpY3NDb250ZXh0JiBnYyA9IGJ1aWxkZXIuY29udGV4dCgp OwogCisjaWYgV0VCS0lUX1VTSU5HX1NLSUEKKyAgICBnYy5wbGF0Zm9ybUNvbnRleHQoKS0+c2V0 RHJhd2luZ1RvSW1hZ2VCdWZmZXIoIWNhbnZhc0lzT3BhcXVlKTsKKyNlbGlmIFdFQktJVF9VU0lO R19DRworICAgIC8vIEZJWE1FIGhvb2sgY2FudmFzSXNPcGFxdWUgdXAgdG8gdGhlIHBsYXRmb3Jt LXNwZWNpZmljIGluZGljYXRvcnMgZm9yCisgICAgLy8gd2hldGhlciBzdWJwaXhlbCBBQSBjYW4g YmUgdXNlZCBmb3IgdGhpcyBkcmF3LgorI2VuZGlmCisKICAgICBnYy5zYXZlKCk7CiAgICAgZ2Mu c2V0RmlsbENvbG9yKGNvbG9yLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsKICAgICBnYy5jbGlwKFdl YkNvcmU6OkZsb2F0UmVjdChjbGlwKSk7CiAgICAgbV9mb250LmRyYXdUZXh0KCZnYywgcnVuLCBs ZWZ0QmFzZWxpbmUsIGZyb20sIHRvKTsKICAgICBnYy5yZXN0b3JlKCk7CisKKyNpZiBkZWZpbmVk KFdJTjMyKQorICAgIGlmIChjYW52YXNJc09wYXF1ZSAmJiBTa0NvbG9yR2V0QShjb2xvcikgPT0g MHhGRikgeworICAgICAgICBTa0NhbnZhczo6TGF5ZXJJdGVyIGl0ZXIoY29uc3RfY2FzdDxTa0Nh bnZhcyo+KGNhbnZhcyksIGZhbHNlKTsKKyAgICAgICAgaXRlci5uZXh0KCk7IC8vIFRoZXJlIGlz IGFsd2F5cyBhdCBsZWFzdCBvbmUgbGF5ZXIuCisgICAgICAgIGJvb2wgbXVsdGlwbGVMYXllcnMg PSAhaXRlci5kb25lKCk7CisgICAgICAgIGlmICghbXVsdGlwbGVMYXllcnMpIHsKKyAgICAgICAg ICAgIC8vIFRoZSB0ZXh0IGRyYXdpbmcgbG9naWMgb24gV2luZG93cyBpZ25vcmVzIHRoZSBhbHBo YSBjb21wb25lbnQKKyAgICAgICAgICAgIC8vIGludGVudGlvbmFsbHksIGZvciBwZXJmb3JtYW5j ZSByZWFzb25zLgorICAgICAgICAgICAgLy8gKFBsZWFzZSBzZWUgVHJhbnNwYXJlbmN5QXdhcmVG b250UGFpbnRlcjo6aW5pdGlhbGl6ZUZvckdESSBpbgorICAgICAgICAgICAgLy8gRm9udENocm9t aXVtV2luLmNwcC4pCisgICAgICAgICAgICBjb25zdCBTa0JpdG1hcCYgYml0bWFwID0gY2FudmFz LT5nZXRUb3BEZXZpY2UoKS0+YWNjZXNzQml0bWFwKHRydWUpOworICAgICAgICAgICAgSW50UmVj dCB0ZXh0Qm91bmRzID0gZXN0aW1hdGVUZXh0Qm91bmRzKHJ1biwgbGVmdEJhc2VsaW5lKTsKKyAg ICAgICAgICAgIEludFJlY3QgZGVzdFJlY3QgPSBnYy5nZXRDVE0oKS5tYXBSZWN0KHRleHRCb3Vu ZHMpOworICAgICAgICAgICAgZGVzdFJlY3QuaW50ZXJzZWN0KEludFJlY3QoMCwgMCwgYml0bWFw LndpZHRoKCksIGJpdG1hcC5oZWlnaHQoKSkpOworICAgICAgICAgICAgZm9yIChpbnQgeSA9IGRl c3RSZWN0LnkoKSwgbWF4WSA9IGRlc3RSZWN0Lm1heFkoKTsgeSA8IG1heFk7IHkrKykgeworICAg ICAgICAgICAgICAgIHVpbnQzMl90KiByb3cgPSBiaXRtYXAuZ2V0QWRkcjMyKDAsIHkpOworICAg ICAgICAgICAgICAgIGZvciAoaW50IHggPSBkZXN0UmVjdC54KCksIG1heFggPSBkZXN0UmVjdC5t YXhYKCk7IHggPCBtYXhYOyB4KyspCisgICAgICAgICAgICAgICAgICAgIHJvd1t4XSB8PSAoMHhG RiA8PCBTS19BMzJfU0hJRlQpOworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgfQorI2Vu ZGlmCiB9CiAKIGludCBXZWJGb250SW1wbDo6Y2FsY3VsYXRlV2lkdGgoY29uc3QgV2ViVGV4dFJ1 biYgcnVuKSBjb25zdApAQCAtMTIwLDQgKzE0NiwxNCBAQCBXZWJGbG9hdFJlY3QgV2ViRm9udElt cGw6OnNlbGVjdGlvblJlY3RGCiAgICAgcmV0dXJuIG1fZm9udC5zZWxlY3Rpb25SZWN0Rm9yVGV4 dChydW4sIGxlZnRCYXNlbGluZSwgaGVpZ2h0LCBmcm9tLCB0byk7CiB9CiAKK1dlYlJlY3QgV2Vi Rm9udEltcGw6OmVzdGltYXRlVGV4dEJvdW5kcyhjb25zdCBXZWJUZXh0UnVuJiBydW4sIGNvbnN0 IFdlYkZsb2F0UG9pbnQmIGxlZnRCYXNlbGluZSkgY29uc3QKK3sKKyAgICBpbnQgdG90YWxXaWR0 aCA9IG1fZm9udC53aWR0aChydW4sIDApOworICAgIGNvbnN0IEZvbnRNZXRyaWNzJiBmb250TWV0 cmljcyA9IG1fZm9udC5mb250TWV0cmljcygpOworICAgIHJldHVybiBXZWJSZWN0KGxlZnRCYXNl bGluZS54IC0gKGZvbnRNZXRyaWNzLmFzY2VudCgpICsgZm9udE1ldHJpY3MuZGVzY2VudCgpKSAv IDIsCisgICAgICAgICAgICAgICAgICAgbGVmdEJhc2VsaW5lLnkgLSBmb250TWV0cmljcy5hc2Nl bnQoKSAtIGZvbnRNZXRyaWNzLmxpbmVHYXAoKSwKKyAgICAgICAgICAgICAgICAgICB0b3RhbFdp ZHRoICsgZm9udE1ldHJpY3MuYXNjZW50KCkgKyBmb250TWV0cmljcy5kZXNjZW50KCksCisgICAg ICAgICAgICAgICAgICAgZm9udE1ldHJpY3MubGluZVNwYWNpbmcoKSk7IAorfQorCiB9IC8vIG5h bWVzcGFjZSBXZWJLaXQKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZvbnRJ bXBsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRm9udElt cGwuaAkocmV2aXNpb24gOTA5NzEpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJG b250SW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC01OCw2ICs1OCw5IEBAIHB1YmxpYzoKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgaGVpZ2h0LCBpbnQg ZnJvbSA9IDAsIGludCB0byA9IC0xKSBjb25zdDsKIAogcHJpdmF0ZToKKyAgICAvLyBFc3RpbWF0 ZXMgdGhlIGJvdW5kaW5nIGJveCBvZiB0aGUgZ2l2ZW4gdGV4dC4KKyAgICBXZWJSZWN0IGVzdGlt YXRlVGV4dEJvdW5kcyhjb25zdCBXZWJUZXh0UnVuJiwgY29uc3QgV2ViRmxvYXRQb2ludCYgbGVm dEJhc2VsaW5lKSBjb25zdDsKKwogICAgIFdlYkNvcmU6OkZvbnQgbV9mb250OwogfTsKIAo=