64540 2011-07-14 10:35:30 -0700 Fullscreen content doesn't use fullscreen controller on Windows 2011-07-15 07:03:37 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Normal --- 1 jeffm jeffm jer.noble oldest_to_newest 437179 0 jeffm 2011-07-14 10:35:30 -0700 When watching video fullscreen on Windows, we're still using the inline controller. 1. Go to <http://www.apple.com/ipad/>. 2. Start playing the iPad 2 video. 3. Click on the fullscreen button. The controller at the bottom of the fullscreen window is the inline controller, not the HUD. 437180 1 jeffm 2011-07-14 10:37:10 -0700 <rdar://problem/9510455> 437181 2 jeffm 2011-07-14 10:38:03 -0700 It appears that we just need to implement RenderThemeWin::extraFullScreenStyleSheet() on Windows, as we did in RenderThemeMac. 437419 3 100896 jeffm 2011-07-14 17:00:03 -0700 Created attachment 100896 Patch 437718 4 jeffm 2011-07-15 07:03:37 -0700 Committed r91066: <http://trac.webkit.org/changeset/91066> 100896 2011-07-14 17:00:03 -0700 2011-07-14 17:29:16 -0700 Patch FullscreenController.patch text/plain 5745 jeffm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxMDM3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDctMTQgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIEZ1bGxzY3JlZW4gY29udGVudCBkb2Vz bid0IHVzZSBmdWxsc2NyZWVuIGNvbnRyb2xsZXIgb24gV2luZG93cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ1NDAKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzk1MTA0NTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmVuZGVyVGhlbWVXaW4gbmVlZHMgdG8gb3ZlcnJpZGUgZXh0cmFGdWxsU2NyZWVu U3R5bGVTaGVldCgpIHRvIHJldHVybgorICAgICAgICB0aGUgZnVsbHNjcmVlblF1aWNrVGltZSBz dHlsZXNoZWV0LgorCisgICAgICAgIFRlc3QgYWRkZWQgdG8gZnVsbHNjcmVlbi92aWRlby1jb250 cm9scy1vdmVycmlkZS5odG1sLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lV2lu LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lV2luOjpleHRyYUZ1bGxTY3JlZW5T dHlsZVNoZWV0KTogQWRkZWQuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmg6 IE92ZXJyaWRlIGV4dHJhRnVsbFNjcmVlblN0eWxlU2hlZXQoKS4KKwogMjAxMS0wNy0xNCAgQW50 dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogU2hv dWxkIG5vdCBkaXNwYXRjaCBkaWRGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXQgZm9yIHRoZSBp bml0aWFsIGVtcHR5IGRvY3VtZW50CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGhlbWVXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUaGVtZVdpbi5jcHAJKHJldmlzaW9uIDkxMDMwKQorKysgU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRoZW1lV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAzNSw2ICsxMDM1 LDEzIEBAIFN0cmluZyBSZW5kZXJUaGVtZVdpbjo6ZXh0cmFNZWRpYUNvbnRyb2wKICAgICByZXR1 cm4gU3RyaW5nKG1lZGlhQ29udHJvbHNRdWlja1RpbWVVc2VyQWdlbnRTdHlsZVNoZWV0LCBzaXpl b2YobWVkaWFDb250cm9sc1F1aWNrVGltZVVzZXJBZ2VudFN0eWxlU2hlZXQpKTsKIH0KIAorI2lm IEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKK1N0cmluZyBSZW5kZXJUaGVtZVdpbjo6ZXh0cmFGdWxs U2NyZWVuU3R5bGVTaGVldCgpCit7CisgICAgcmV0dXJuIFN0cmluZyhmdWxsc2NyZWVuUXVpY2tU aW1lVXNlckFnZW50U3R5bGVTaGVldCwgc2l6ZW9mKGZ1bGxzY3JlZW5RdWlja1RpbWVVc2VyQWdl bnRTdHlsZVNoZWV0KSk7Cit9CisjZW5kaWYKKwogYm9vbCBSZW5kZXJUaGVtZVdpbjo6c3VwcG9y dHNDbG9zZWRDYXB0aW9uaW5nKCkgY29uc3QKIHsKICAgICAgICAgLy8gV2UgcmVseSBvbiBRdWlj a1RpbWUgdG8gcmVuZGVyIGNhcHRpb25zIHNvIG9ubHkgZW5hYmxlIHRoZSBidXR0b24gZm9yIGEg dmlkZW8gZWxlbWVudC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVt ZVdpbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVt ZVdpbi5oCShyZXZpc2lvbiA5MTAzMCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUaGVtZVdpbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMjQsNiArMTI0LDkgQEAgcHVibGljOgog CiAjaWYgRU5BQkxFKFZJREVPKQogICAgIHZpcnR1YWwgU3RyaW5nIGV4dHJhTWVkaWFDb250cm9s c1N0eWxlU2hlZXQoKTsKKyNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCisgICAgdmlydHVhbCBT dHJpbmcgZXh0cmFGdWxsU2NyZWVuU3R5bGVTaGVldCgpOworI2VuZGlmCiAgICAgdmlydHVhbCBi b29sIHN1cHBvcnRzQ2xvc2VkQ2FwdGlvbmluZygpIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBw YWludE1lZGlhQ29udHJvbHNCYWNrZ3JvdW5kKFJlbmRlck9iamVjdCosIGNvbnN0IFBhaW50SW5m byYsIGNvbnN0IEludFJlY3QmKTsKICAgICB2aXJ0dWFsIGJvb2wgcGFpbnRNZWRpYUZ1bGxzY3Jl ZW5CdXR0b24oUmVuZGVyT2JqZWN0KiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYp OwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L0NoYW5nZUxvZwkocmV2aXNpb24gOTEwMzcpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwyMyBAQAorMjAxMS0wNy0xNCAgSmVmZiBNaWxsZXIgIDxq ZWZmbUBhcHBsZS5jb20+CisKKyAgICAgICAgRnVsbHNjcmVlbiBjb250ZW50IGRvZXNuJ3QgdXNl IGZ1bGxzY3JlZW4gY29udHJvbGxlciBvbiBXaW5kb3dzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDU0MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v OTUxMDQ1NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAg CisgICAgICAgIEFkZCBhbm90aGVyIHRlc3QgdG8gdmlkZW8tY29udHJvbHMtb3ZlcnJpZGUuaHRt bCB0byB2ZXJpZnkgdGhhdAorICAgICAgICB3ZSdyZSB1c2luZyB0aGUgY29ycmVjdCBmdWxsc2Ny ZWVuIGNvbnRyb2xsZXIgYnkgY2hlY2tpbmcgdGhlCisgICAgICAgIGhlaWdodCBvZiB0aGUgY29u dHJvbGxlciBwYW5lbCwgd2hpY2ggaXMgdGFsbGVyIHRoYW4gdGhlIG5vbi1mdWxsc2NyZWVuCisg ICAgICAgIHZlcnNpb24uIFVuZm9ydHVuYXRlbHksIHRoZSBmdWxsc2NyZWVuIHRlc3RzIGRvbid0 IHdvcmsgb24gV2luZG93cworICAgICAgICB5ZXQsIGJ1dCBJIHZlcmlmaWVkIHRoaXMgd291bGQg aGF2ZSBjYXVnaHQgdGhpcyBpc3N1ZSBieSBzaW11bGF0aW5nCisgICAgICAgIHRoZSBidWcgb24g dGhlIE1hYy4KKworICAgICAgICAqIGZ1bGxzY3JlZW4vdmlkZW8tY29udHJvbHMtb3ZlcnJpZGUt ZXhwZWN0ZWQudHh0OiBBZGQgbmV3IHRlc3QgdG8gY2hlY2sgdGhlIGhlaWdodCBvZiB0aGUgcGFu ZWwuCisKKyAgICAgICAgKiBmdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLmh0bWw6 IEFkZCBuZXcgdGVzdCB0byBjaGVjayB0aGUgaGVpZ2h0IG9mIHRoZSBwYW5lbCwgYW5kCisgICAg ICAgIGxvZyBlcnJvcnMgaWYgd2luZG93LmludGVybmFscyBvciB3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIgYXJlIHVuZGVmaW5lZC4KKwogMjAxMS0wNy0xNCAgVmluY2VudCBTY2hlaWIgIDxz Y2hlaWJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gdXBkYXRlZCB0ZXN0IGV4 cGVjdGF0aW9ucy4KSW5kZXg6IExheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8tY29udHJvbHMt b3ZlcnJpZGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Z1bGxzY3Jl ZW4vdmlkZW8tY29udHJvbHMtb3ZlcnJpZGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA5MTAzMCkK KysrIExheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8tY29udHJvbHMtb3ZlcnJpZGUtZXhwZWN0 ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC01LDYgKzUsNyBAQCBFWFBFQ1RFRCAoc2hhZG93Um9v dCA9IGludGVybmFscy5zaGFkb3dSCiBFWFBFQ1RFRCAocGFuZWwgPSBzaGFkb3dSb290LmZpcnN0 Q2hpbGQuZmlyc3RDaGlsZCAhPSAnbnVsbCcpIE9LCiBFWFBFQ1RFRCAoaW50ZXJuYWxzLnNoYWRv d1BzZXVkb0lkKHBhbmVsKSA9PSAnLXdlYmtpdC1tZWRpYS1jb250cm9scy1wYW5lbCcpIE9LCiBF WFBFQ1RFRCAoZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0ZWRTdHlsZShwYW5lbClbJ2Rp c3BsYXknXSAhPSAnbm9uZScpIE9LCitFWFBFQ1RFRCAoZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0 Q29tcHV0ZWRTdHlsZShwYW5lbClbJ2hlaWdodCddID09ICc0OHB4JykgT0sKIEVWRU5UKHdlYmtp dGZ1bGxzY3JlZW5jaGFuZ2UpCiBFWFBFQ1RFRCAoZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29t cHV0ZWRTdHlsZShwYW5lbClbJ2Rpc3BsYXknXSA9PSAnbm9uZScpIE9LCiBFTkQgT0YgVEVTVApJ bmRleDogTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1vdmVycmlkZS5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8tY29udHJvbHMtb3Zl cnJpZGUuaHRtbAkocmV2aXNpb24gOTEwMzApCisrKyBMYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3Zp ZGVvLWNvbnRyb2xzLW92ZXJyaWRlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTIyLDcgKzIyLDEx IEBACiAgICAgICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJwYW5lbCA9IHNoYWRvd1Jvb3QuZmly c3RDaGlsZC5maXJzdENoaWxkIiwgbnVsbCwgIiE9Iik7CiAgICAgICAgICAgICAgICAgdGVzdEV4 cGVjdGVkKCJpbnRlcm5hbHMuc2hhZG93UHNldWRvSWQocGFuZWwpIiwgIi13ZWJraXQtbWVkaWEt Y29udHJvbHMtcGFuZWwiKTsKICAgICAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoImRvY3VtZW50 LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUocGFuZWwpWydkaXNwbGF5J10iLCAnbm9uZScs ICIhPSIpOworICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgiZG9jdW1lbnQuZGVmYXVsdFZp ZXcuZ2V0Q29tcHV0ZWRTdHlsZShwYW5lbClbJ2hlaWdodCddIiwgJzQ4cHgnKTsKICAgICAgICAg ICAgIH0KKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBsb2dSZXN1bHQoZmFsc2Us ICJ3aW5kb3cuaW50ZXJuYWxzID09IHVuZGVmaW5lZCIpOworICAgICAgICAgICAgCiAgICAgICAg ICAgICBjYWxsYmFjayA9IGNhbmNlbGxlZEZ1bGxTY3JlZW47CiAgICAgICAgICAgICBkb2N1bWVu dC53ZWJraXRDYW5jZWxGdWxsU2NyZWVuKCk7CiAgICAgICAgIH07CkBAIC0zMCw2ICszNCw5IEBA CiAgICAgICAgIHZhciBjYW5jZWxsZWRGdWxsU2NyZWVuID0gZnVuY3Rpb24oKSB7CiAgICAgICAg ICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogICAgICAgICAgICAgICAgIHRl c3RFeHBlY3RlZCgiZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0ZWRTdHlsZShwYW5lbClb J2Rpc3BsYXknXSIsICdub25lJyk7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAg bG9nUmVzdWx0KGZhbHNlLCAid2luZG93LmxheW91dFRlc3RDb250cm9sbGVyID09IHVuZGVmaW5l ZCIpOworCiAgICAgICAgICAgICBlbmRUZXN0KCk7CiAgICAgICAgIH07CiAK