64536 2011-07-14 10:06:07 -0700 [EFL] Ignore empty requests on policy decisions. 2011-08-02 12:50:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rakuco webkit-unassigned gyuyoung.kim leandro tonikitoo webkit.review.bot oldest_to_newest 437151 0 rakuco 2011-07-14 10:06:07 -0700 [EFL] Ignore empty requests on policy decisions. 437152 1 100821 rakuco 2011-07-14 10:07:13 -0700 Created attachment 100821 Patch 439598 2 gyuyoung.kim 2011-07-19 19:02:40 -0700 LGTM. 441873 3 rakuco 2011-07-25 14:42:15 -0700 CC'ing tonikitoo in hopes that the patch gets an r+. 445398 4 100821 kenneth 2011-08-02 12:01:53 -0700 Comment on attachment 100821 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100821&action=review As other ports are doing this, I will go ahead and say r+, but maybe it could/should be fixed elsewhere. > Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:292 > + > + if (resourceRequest.isNull()) { > + callPolicyFunction(function, PolicyIgnore); Why would this be called when the resource request is empty anyway? I mean, shouldn't this be fixed elsewhere? 445446 5 100821 webkit.review.bot 2011-08-02 12:50:19 -0700 Comment on attachment 100821 Patch Clearing flags on attachment: 100821 Committed r92216: <http://trac.webkit.org/changeset/92216> 445447 6 webkit.review.bot 2011-08-02 12:50:25 -0700 All reviewed patches have been landed. Closing bug. 100821 2011-07-14 10:07:13 -0700 2011-08-02 12:50:19 -0700 Patch bug-64536-20110714141039.patch text/plain 3553 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTEwMDQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCAxM2Q5MDhiN2Zl NjAyZTE1MDNjZjdjN2ZkYTJhYTI0MTQ1ZDIwNDMzLi5lYTA3OTI5NTMxYmZhZWQyMTk0NDRlMDI5 Y2QyYTUxOGRmNWE2NjQyIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEt MDctMTQgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgW0VGTF0gSWdub3JlIGVtcHR5IHJlcXVlc3RzIG9uIHBvbGljeSBkZWNpc2lvbnMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDUzNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgdGhl IHNhbWUgZml4IGludHJvZHVjZWQgaW4gdGhlIEdUSysgcG9ydCBpbiByNDEzMTM6IGVtcHR5Cisg ICAgICAgIHJlcXVlc3Qgc2hvdWxkIGJlIGlnbm9yZWQsIHNvIHRlc3RzIHN1Y2ggYXMKKyAgICAg ICAgZmFzdC9sb2FkZXIvZW1wdHktZW1iZWQtc3JjLWF0dHJpYnV0ZS5odG1sIGRvIG5vdCBjcmFz aC4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZsLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50RWZsOjpkaXNwYXRjaERlY2lkZVBv bGljeUZvclJlc3BvbnNlKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50RWZs OjpkaXNwYXRjaERlY2lkZVBvbGljeUZvck5ld1dpbmRvd0FjdGlvbik6CisgICAgICAgIChXZWJD b3JlOjpGcmFtZUxvYWRlckNsaWVudEVmbDo6ZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JOYXZpZ2F0 aW9uQWN0aW9uKToKKwogMjAxMS0wNy0xMiAgSm9zZXBoIFBlY29yYXJvICA8am9lcGVja0B3ZWJr aXQub3JnPgogCiAgICAgICAgIEFwcGxpY2F0aW9uQ2FjaGUgdXBkYXRlIHNob3VsZCBub3QgaW1t ZWRpYXRlbHkgZmFpbCB3aGVuIHJlYWNoaW5nIHBlci1vcmlnaW4gcXVvdGEKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZsLmNw cCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZs LmNwcAppbmRleCA5ZTI3NTdmYjg0YTM3MDg1MmY3MTRjYzQzODZkYmYwMjE3YTYxOWY0Li4yYzNm ZTcyNmVmMjYxOTlmNzMwZWJiYzMwODNmMjJmYmFjNDE4OTM1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEVmbC5jcHAKKysrIGIv U291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRFZmwuY3Bw CkBAIC0yODMsMjAgKzI4MywzMiBAQCB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50RWZsOjpkaXNwYXRj aERpZFJlY2VpdmVSZXNwb25zZShEb2N1bWVudExvYWRlciosIHVuc2lnbmVkCiAgICAgbV9yZXNw b25zZSA9IHJlc3BvbnNlOwogfQogCi12b2lkIEZyYW1lTG9hZGVyQ2xpZW50RWZsOjpkaXNwYXRj aERlY2lkZVBvbGljeUZvclJlc3BvbnNlKEZyYW1lUG9saWN5RnVuY3Rpb24gZnVuY3Rpb24sIGNv bnN0IFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNlLCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmKQor dm9pZCBGcmFtZUxvYWRlckNsaWVudEVmbDo6ZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JSZXNwb25z ZShGcmFtZVBvbGljeUZ1bmN0aW9uIGZ1bmN0aW9uLCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiBy ZXNwb25zZSwgY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXNvdXJjZVJlcXVlc3QpCiB7CiAgICAg Ly8gd2UgbmVlZCB0byBjYWxsIGRpcmVjdGx5IGhlcmUgKGN1cnJlbnRseSBjYWxsUG9saWN5RnVu Y3Rpb24gZG9lcyB0aGF0ISkKICAgICBBU1NFUlQoZnVuY3Rpb24pOworCisgICAgaWYgKHJlc291 cmNlUmVxdWVzdC5pc051bGwoKSkgeworICAgICAgICBjYWxsUG9saWN5RnVuY3Rpb24oZnVuY3Rp b24sIFBvbGljeUlnbm9yZSk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBpZiAoY2Fu U2hvd01JTUVUeXBlKHJlc3BvbnNlLm1pbWVUeXBlKCkpKQogICAgICAgICBjYWxsUG9saWN5RnVu Y3Rpb24oZnVuY3Rpb24sIFBvbGljeVVzZSk7CiAgICAgZWxzZQogICAgICAgICBjYWxsUG9saWN5 RnVuY3Rpb24oZnVuY3Rpb24sIFBvbGljeURvd25sb2FkKTsKIH0KIAotdm9pZCBGcmFtZUxvYWRl ckNsaWVudEVmbDo6ZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JOZXdXaW5kb3dBY3Rpb24oRnJhbWVQ b2xpY3lGdW5jdGlvbiBmdW5jdGlvbiwgY29uc3QgTmF2aWdhdGlvbkFjdGlvbiYgYWN0aW9uLCBj b25zdCBSZXNvdXJjZVJlcXVlc3QmLCBQYXNzUmVmUHRyPEZvcm1TdGF0ZT4sIGNvbnN0IFN0cmlu ZyYpCit2b2lkIEZyYW1lTG9hZGVyQ2xpZW50RWZsOjpkaXNwYXRjaERlY2lkZVBvbGljeUZvck5l d1dpbmRvd0FjdGlvbihGcmFtZVBvbGljeUZ1bmN0aW9uIGZ1bmN0aW9uLCBjb25zdCBOYXZpZ2F0 aW9uQWN0aW9uJiBhY3Rpb24sIGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVzb3VyY2VSZXF1ZXN0 LCBQYXNzUmVmUHRyPEZvcm1TdGF0ZT4sIGNvbnN0IFN0cmluZyYpCiB7CiAgICAgQVNTRVJUKGZ1 bmN0aW9uKTsKICAgICBBU1NFUlQobV9mcmFtZSk7CisKKyAgICBpZiAocmVzb3VyY2VSZXF1ZXN0 LmlzTnVsbCgpKSB7CisgICAgICAgIGNhbGxQb2xpY3lGdW5jdGlvbihmdW5jdGlvbiwgUG9saWN5 SWdub3JlKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIC8vIGlmIG5vdCBhY2NlcHRO YXZpZ2F0aW9uUmVxdWVzdCAtIGxvb2sgYXQgUXQgLT4gUG9saWN5SWdub3JlOwogICAgIC8vIEZJ WE1FOiBkbyBwcm9wZXIgY2hlY2sgYW5kIG9ubHkgcmVzZXQgZm9ybXMgd2hlbiBvbiBQb2xpY3lJ Z25vcmUKICAgICBGcmFtZSogZiA9IGV3a19mcmFtZV9jb3JlX2dldChtX2ZyYW1lKTsKQEAgLTMw OCw2ICszMjAsMTIgQEAgdm9pZCBGcmFtZUxvYWRlckNsaWVudEVmbDo6ZGlzcGF0Y2hEZWNpZGVQ b2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKEZyYW1lUG9saWN5RnUKIHsKICAgICBBU1NFUlQoZnVu Y3Rpb24pOwogICAgIEFTU0VSVChtX2ZyYW1lKTsKKworICAgIGlmIChyZXNvdXJjZVJlcXVlc3Qu aXNOdWxsKCkpIHsKKyAgICAgICAgY2FsbFBvbGljeUZ1bmN0aW9uKGZ1bmN0aW9uLCBQb2xpY3lJ Z25vcmUpOworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgLy8gaWYgbm90IGFjY2VwdE5h dmlnYXRpb25SZXF1ZXN0IC0gbG9vayBhdCBRdCAtPiBQb2xpY3lJZ25vcmU7CiAgICAgLy8gRklY TUU6IGRvIHByb3BlciBjaGVjayBhbmQgb25seSByZXNldCBmb3JtcyB3aGVuIG9uIFBvbGljeUln bm9yZQogICAgIGNoYXIqIHVybCA9IHN0cmR1cChyZXNvdXJjZVJlcXVlc3QudXJsKCkuc3RyaW5n KCkudXRmOCgpLmRhdGEoKSk7Cg==