64521 2011-07-14 03:14:51 -0700 [EFL] Remove unused codes in ewk_tiled_model.c 2011-07-25 22:12:05 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 jungjik.lee webkit-unassigned dbates gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 437021 0 jungjik.lee 2011-07-14 03:14:51 -0700 A dirty flag in Ewk_Tile_Unused_Cache is not referenced anywhere and ewk_tile_unused_cache_dirty function is not called. This is a patch for removing the dirty flag and the function for keeping source code clean. 437022 1 100794 jungjik.lee 2011-07-14 03:34:29 -0700 Created attachment 100794 proposed patch A patch for removing the dirty flag and the function which are not using anymore in ewk_tiled_model.c. 437023 2 gyuyoung.kim 2011-07-14 03:40:13 -0700 LGTM. This removal was announced in webkit-efl mailing list. https://lists.webkit.org/pipermail/webkit-efl/2011-July/000018.html 437057 3 rakuco 2011-07-14 06:43:47 -0700 Informal r+ from my side too. 441986 4 100794 dbates 2011-07-25 16:42:46 -0700 Comment on attachment 100794 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=100794&action=review OK to the changes. On another note, the first diff in this patch (i.e. Source/WebKit/efl/ChangeLog) has a messed up chunk range of @@ -1,3 +1,15 @@. It should be @@ -1,3 +1,18 @@. Hence patch(1) fails to apply this patch. Did you edit the diff by hand? > Source/WebKit/efl/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). > + > + [EFL] Remove unused code in ewk_tile_model.c > + https://bugs.webkit.org/show_bug.cgi?id=64521 Nit: We changed our changelog entry format such that a changelog entry should have the bug title and URL then the Reviewed by line. 442081 5 101963 jungjik.lee 2011-07-25 20:09:29 -0700 Created attachment 101963 updated patch I am sorry for inconvenience. I updated the patch. 442084 6 101965 jungjik.lee 2011-07-25 20:20:01 -0700 Created attachment 101965 Changed the patch by following the patch rule. Update the patch again to make obsolete the previous patch and change the flags 442086 7 dbates 2011-07-25 20:27:37 -0700 (In reply to comment #6) > Created an attachment (id=101965) [details] > Changed the patch by following the patch rule. > > Update the patch again to make obsolete the previous patch and change the flags The patch is still malformed and hence cannot be landed by the commit-queue. How are you generating these patches? 442087 8 101965 dbates 2011-07-25 20:31:45 -0700 Comment on attachment 101965 Changed the patch by following the patch rule. View in context: https://bugs.webkit.org/attachment.cgi?id=101965&action=review > Source/WebKit/efl/ChangeLog:1 > +2011-07-25 jungjik.lee <jungjik.lee@samsung.com> You used your username for your name. 442092 9 101966 jungjik.lee 2011-07-25 21:07:33 -0700 Created attachment 101966 updated patch Sorry for inconvenience. I would not do such a mistake again. 442107 10 101966 webkit.review.bot 2011-07-25 22:12:00 -0700 Comment on attachment 101966 updated patch Clearing flags on attachment: 101966 Committed r91741: <http://trac.webkit.org/changeset/91741> 442108 11 webkit.review.bot 2011-07-25 22:12:05 -0700 All reviewed patches have been landed. Closing bug. 100794 2011-07-14 03:34:29 -0700 2011-07-25 20:27:46 -0700 proposed patch patch-[20110713]-[jungjik.lee@samsung.com]-[Remove_unused_code].patch text/plain 3001 jungjik.lee ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAxM2Q5MDhiLi40OTM2NDYzIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMTQgIEp1bmdKaWsgTGVlICA8anVuZ2ppay5sZWVAc2Ft c3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0VGTF0gUmVtb3ZlIHVudXNlZCBjb2RlIGluIGV3a190aWxlX21vZGVsLmMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0NTIxCisKKyAgICAgICAg UmVtb3ZlIHVudXNlZCBjb2RlIGluIGV3a190aWxlX21vZGVsLmMuIERpcnR5IGZsYWcgaXMgbm90 IHJlZmVyZW5jZWQgYW55d2hlcmUuCisKKyAgICAgICAgKiBld2svZXdrX3RpbGVkX21vZGVsLmM6 CisgICAgICAgIChld2tfdGlsZV91bnVzZWRfY2FjaGVfY2xlYXIpOgorICAgICAgICAoZXdrX3Rp bGVfdW51c2VkX2NhY2hlX2ZsdXNoKToKKyAgICAgICAgKGV3a190aWxlX3VudXNlZF9jYWNoZV90 aWxlX2dldCk6CisgICAgICAgIChld2tfdGlsZV91bnVzZWRfY2FjaGVfdGlsZV9wdXQpOgorCiAy MDExLTA3LTEyICBKb3NlcGggUGVjb3Jhcm8gIDxqb2VwZWNrQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgQXBwbGljYXRpb25DYWNoZSB1cGRhdGUgc2hvdWxkIG5vdCBpbW1lZGlhdGVseSBmYWlsIHdo ZW4gcmVhY2hpbmcgcGVyLW9yaWdpbiBxdW90YQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a190aWxlZF9tb2RlbC5jIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxl ZF9tb2RlbC5jCmluZGV4IDg1NmRkZmMuLmNlNDgzZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfdGlsZWRfbW9kZWwuYworKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3RpbGVkX21vZGVsLmMKQEAgLTUxNiw3ICs1MTYsNiBAQCBzdHJ1Y3QgX0V3a19UaWxlX1Vu dXNlZF9DYWNoZSB7CiAgICAgfSBsb2NrZWQ7CiAgICAgaW50IHJlZmVyZW5jZXM7CiAgICAgdW5z aWduZWQgaW50IGZyb3plbjsKLSAgICBFaW5hX0Jvb2wgZGlydHk6MTsKIH07CiAKIHN0YXRpYyBj b25zdCBzaXplX3QgVElMRV9VTlVTRURfQ0FDSEVfQUxMT0NBVEVfSU5JVElBTCA9IDEyODsKQEAg LTYxMiw3ICs2MTEsNiBAQCB2b2lkIGV3a190aWxlX3VudXNlZF9jYWNoZV9jbGVhcihFd2tfVGls ZV9VbnVzZWRfQ2FjaGUgKnR1YykKIAogICAgIHR1Yy0+bWVtb3J5LnVzZWQgPSAwOwogICAgIHR1 Yy0+ZW50cmllcy5jb3VudCA9IDA7Ci0gICAgdHVjLT5kaXJ0eSA9IEVJTkFfRkFMU0U7CiB9CiAK IC8qKgpAQCAtNzA3LDkgKzcwNSw2IEBAIHNpemVfdCBld2tfdGlsZV91bnVzZWRfY2FjaGVfZmx1 c2goRXdrX1RpbGVfVW51c2VkX0NhY2hlICp0dWMsIHNpemVfdCBieXRlcykKICAgICAgKiBEb24n dCBuZWVkIHRvIHNvcnQgYW55IG1vcmUuCiAgICAgICovCiAKLSAgICBpZiAodHVjLT5kaXJ0eSkK LSAgICAgICAgdHVjLT5kaXJ0eSA9IEVJTkFfRkFMU0U7Ci0KICAgICBkb25lID0gMDsKICAgICBj b3VudCA9IDA7CiAgICAgRUlOQV9MSVNUX0ZPUkVBQ0hfU0FGRSh0dWMtPmVudHJpZXMubGlzdCwg bCwgbF9uZXh0LCBpdHIpIHsKQEAgLTc2MCwyMCArNzU1LDYgQEAgdm9pZCBld2tfdGlsZV91bnVz ZWRfY2FjaGVfYXV0b19mbHVzaChFd2tfVGlsZV9VbnVzZWRfQ2FjaGUgKnR1YykKIH0KIAogLyoq Ci0gKiBGbGFnIGNhY2hlIGFzIGRpcnR5LgotICoKLSAqIElmIGNhY2hlIGlzIGRpcnR5IHRoZW4g bmV4dCBmbHVzaCBvcGVyYXRpb25zIHdpbGwgaGF2ZSB0byByZWNvbXB1dGUKLSAqIHdlaWdodCBh bmQgc29ydCBhZ2FpbiB0byBmaW5kIHRoZSBiZXN0IHRpbGVzIHRvIGV4cGlyZS4KLSAqCi0gKiBP bmUgbXVzdCBjYWxsIHRoaXMgZnVuY3Rpb24gd2hlbiB0aWxlIHByb3BlcnRpZXMgdGhhdCBtYXkg Y2hhbmdlCi0gKiBsaWtlbmVzcyBvZiB0aWxlIHRvIGJlIGZsdXNoZWQgY2hhbmdlLCBsaWtlIFRp bGU6OnN0YXRzLgotICovCi12b2lkIGV3a190aWxlX3VudXNlZF9jYWNoZV9kaXJ0eShFd2tfVGls ZV9VbnVzZWRfQ2FjaGUgKnR1YykKLXsKLSAgICB0dWMtPmRpcnR5ID0gRUlOQV9UUlVFOwotfQot Ci0vKioKICAqIEZyZWV6ZSBjYWNoZSB0byBub3QgZG8gbWFpbnRlbmFuY2UgdGFza3MuCiAgKgog ICogTWFpbnRlbmFuY2UgdGFza3Mgb3B0aW1pemUgY2FjaGUgdXNhZ2UsIGJ1dCBtYXliZSB3ZSBr bm93IHdlIHNob3VsZApAQCAtODM3LDkgKzgxOCw2IEBAIEVpbmFfQm9vbCBld2tfdGlsZV91bnVz ZWRfY2FjaGVfdGlsZV9nZXQoRXdrX1RpbGVfVW51c2VkX0NhY2hlICp0dWMsIEV3a19UaWxlICp0 CiAgICAgdHVjLT5tZW1vcnkudXNlZCAtPSBzaXplb2YoRXdrX1RpbGUpICsgdC0+Ynl0ZXM7CiAg ICAgdHVjLT5lbnRyaWVzLmxpc3QgPSBlaW5hX2xpc3RfcmVtb3ZlX2xpc3QodHVjLT5lbnRyaWVz Lmxpc3QsIGUpOwogICAgIGZyZWUoZW50cnkpOwotICAgIC8vIFRPRE8gYXNzdW1lIGRpcnR5IGZv ciBub3csIGJ1dCBtYXkgaXQncyBub3QsCi0gICAgLy8gaWYgdGhlIGl0ZW0gd2FzIGF0IHRoZSBi ZWdpbm5pbmcgb2YgdGhlIHF1ZXVlCi0gICAgdHVjLT5kaXJ0eSA9IEVJTkFfVFJVRTsKIAogICAg IHJldHVybiBFSU5BX1RSVUU7CiB9CkBAIC04ODksOCArODY3LDYgQEAgRWluYV9Cb29sIGV3a190 aWxlX3VudXNlZF9jYWNoZV90aWxlX3B1dChFd2tfVGlsZV9VbnVzZWRfQ2FjaGUgKnR1YywgRXdr X1RpbGUgKnQKIAogICAgIHR1Yy0+ZW50cmllcy5jb3VudCsrOwogICAgIHR1Yy0+bWVtb3J5LnVz ZWQgKz0gc2l6ZW9mKEV3a19UaWxlKSArIHQtPmJ5dGVzOwotICAgIHR1Yy0+ZGlydHkgPSBFSU5B X1RSVUU7Ci0KICAgICByZXR1cm4gRUlOQV9UUlVFOwogfQogCg== 101963 2011-07-25 20:09:29 -0700 2011-07-25 20:20:01 -0700 updated patch updated.patch text/plain 2999 jungjik.lee ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAxM2Q5MDhiLi5jOTU2M2NlIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMjUgIGp1bmdqaWsubGVlICA8anVuZ2ppay5sZWVAc2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUmVtb3ZlIHVudXNlZCBjb2RlIGluIGV3a190aWxl X21vZGVsLmMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY0NTIxCisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBjb2RlIGluIGV3a190aWxlX21vZGVsLmMu IERpcnR5IGZsYWcgaXMgbm90IHJlZmVyZW5jZWQgYW55d2hlcmUuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBld2svZXdrX3RpbGVkX21vZGVsLmM6 CisgICAgICAgIChld2tfdGlsZV91bnVzZWRfY2FjaGVfY2xlYXIpOgorICAgICAgICAoZXdrX3Rp bGVfdW51c2VkX2NhY2hlX2ZsdXNoKToKKyAgICAgICAgKGV3a190aWxlX3VudXNlZF9jYWNoZV90 aWxlX2dldCk6CisgICAgICAgIChld2tfdGlsZV91bnVzZWRfY2FjaGVfdGlsZV9wdXQpOgorCiAy MDExLTA3LTEyICBKb3NlcGggUGVjb3Jhcm8gIDxqb2VwZWNrQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgQXBwbGljYXRpb25DYWNoZSB1cGRhdGUgc2hvdWxkIG5vdCBpbW1lZGlhdGVseSBmYWlsIHdo ZW4gcmVhY2hpbmcgcGVyLW9yaWdpbiBxdW90YQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a190aWxlZF9tb2RlbC5jIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxl ZF9tb2RlbC5jCmluZGV4IDg1NmRkZmMuLjRhMTQxOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfdGlsZWRfbW9kZWwuYworKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3RpbGVkX21vZGVsLmMKQEAgLTUxNiw3ICs1MTYsNiBAQCBzdHJ1Y3QgX0V3a19UaWxlX1Vu dXNlZF9DYWNoZSB7CiAgICAgfSBsb2NrZWQ7CiAgICAgaW50IHJlZmVyZW5jZXM7CiAgICAgdW5z aWduZWQgaW50IGZyb3plbjsKLSAgICBFaW5hX0Jvb2wgZGlydHk6MTsKIH07CiAKIHN0YXRpYyBj b25zdCBzaXplX3QgVElMRV9VTlVTRURfQ0FDSEVfQUxMT0NBVEVfSU5JVElBTCA9IDEyODsKQEAg LTYxMiw3ICs2MTEsNiBAQCB2b2lkIGV3a190aWxlX3VudXNlZF9jYWNoZV9jbGVhcihFd2tfVGls ZV9VbnVzZWRfQ2FjaGUgKnR1YykKIAogICAgIHR1Yy0+bWVtb3J5LnVzZWQgPSAwOwogICAgIHR1 Yy0+ZW50cmllcy5jb3VudCA9IDA7Ci0gICAgdHVjLT5kaXJ0eSA9IEVJTkFfRkFMU0U7CiB9CiAK IC8qKgpAQCAtNzA3LDkgKzcwNSw2IEBAIHNpemVfdCBld2tfdGlsZV91bnVzZWRfY2FjaGVfZmx1 c2goRXdrX1RpbGVfVW51c2VkX0NhY2hlICp0dWMsIHNpemVfdCBieXRlcykKICAgICAgKiBEb24n dCBuZWVkIHRvIHNvcnQgYW55IG1vcmUuCiAgICAgICovCiAKLSAgICBpZiAodHVjLT5kaXJ0eSkK LSAgICAgICAgdHVjLT5kaXJ0eSA9IEVJTkFfRkFMU0U7Ci0KICAgICBkb25lID0gMDsKICAgICBj b3VudCA9IDA7CiAgICAgRUlOQV9MSVNUX0ZPUkVBQ0hfU0FGRSh0dWMtPmVudHJpZXMubGlzdCwg bCwgbF9uZXh0LCBpdHIpIHsKQEAgLTc2MCwyMCArNzU1LDYgQEAgdm9pZCBld2tfdGlsZV91bnVz ZWRfY2FjaGVfYXV0b19mbHVzaChFd2tfVGlsZV9VbnVzZWRfQ2FjaGUgKnR1YykKIH0KIAogLyoq Ci0gKiBGbGFnIGNhY2hlIGFzIGRpcnR5LgotICoKLSAqIElmIGNhY2hlIGlzIGRpcnR5IHRoZW4g bmV4dCBmbHVzaCBvcGVyYXRpb25zIHdpbGwgaGF2ZSB0byByZWNvbXB1dGUKLSAqIHdlaWdodCBh bmQgc29ydCBhZ2FpbiB0byBmaW5kIHRoZSBiZXN0IHRpbGVzIHRvIGV4cGlyZS4KLSAqCi0gKiBP bmUgbXVzdCBjYWxsIHRoaXMgZnVuY3Rpb24gd2hlbiB0aWxlIHByb3BlcnRpZXMgdGhhdCBtYXkg Y2hhbmdlCi0gKiBsaWtlbmVzcyBvZiB0aWxlIHRvIGJlIGZsdXNoZWQgY2hhbmdlLCBsaWtlIFRp bGU6OnN0YXRzLgotICovCi12b2lkIGV3a190aWxlX3VudXNlZF9jYWNoZV9kaXJ0eShFd2tfVGls ZV9VbnVzZWRfQ2FjaGUgKnR1YykKLXsKLSAgICB0dWMtPmRpcnR5ID0gRUlOQV9UUlVFOwotfQot Ci0vKioKICAqIEZyZWV6ZSBjYWNoZSB0byBub3QgZG8gbWFpbnRlbmFuY2UgdGFza3MuCiAgKgog ICogTWFpbnRlbmFuY2UgdGFza3Mgb3B0aW1pemUgY2FjaGUgdXNhZ2UsIGJ1dCBtYXliZSB3ZSBr bm93IHdlIHNob3VsZApAQCAtODM3LDkgKzgxOCw2IEBAIEVpbmFfQm9vbCBld2tfdGlsZV91bnVz ZWRfY2FjaGVfdGlsZV9nZXQoRXdrX1RpbGVfVW51c2VkX0NhY2hlICp0dWMsIEV3a19UaWxlICp0 CiAgICAgdHVjLT5tZW1vcnkudXNlZCAtPSBzaXplb2YoRXdrX1RpbGUpICsgdC0+Ynl0ZXM7CiAg ICAgdHVjLT5lbnRyaWVzLmxpc3QgPSBlaW5hX2xpc3RfcmVtb3ZlX2xpc3QodHVjLT5lbnRyaWVz Lmxpc3QsIGUpOwogICAgIGZyZWUoZW50cnkpOwotICAgIC8vIFRPRE8gYXNzdW1lIGRpcnR5IGZv ciBub3csIGJ1dCBtYXkgaXQncyBub3QsCi0gICAgLy8gaWYgdGhlIGl0ZW0gd2FzIGF0IHRoZSBi ZWdpbm5pbmcgb2YgdGhlIHF1ZXVlCi0gICAgdHVjLT5kaXJ0eSA9IEVJTkFfVFJVRTsKIAogICAg IHJldHVybiBFSU5BX1RSVUU7CiB9CkBAIC04ODksNyArODY3LDYgQEAgRWluYV9Cb29sIGV3a190 aWxlX3VudXNlZF9jYWNoZV90aWxlX3B1dChFd2tfVGlsZV9VbnVzZWRfQ2FjaGUgKnR1YywgRXdr X1RpbGUgKnQKIAogICAgIHR1Yy0+ZW50cmllcy5jb3VudCsrOwogICAgIHR1Yy0+bWVtb3J5LnVz ZWQgKz0gc2l6ZW9mKEV3a19UaWxlKSArIHQtPmJ5dGVzOwotICAgIHR1Yy0+ZGlydHkgPSBFSU5B X1RSVUU7CiAKICAgICByZXR1cm4gRUlOQV9UUlVFOwogfQo= 101965 2011-07-25 20:20:01 -0700 2011-07-25 21:07:33 -0700 Changed the patch by following the patch rule. updated.patch text/plain 2999 jungjik.lee ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAxM2Q5MDhiLi5jOTU2M2NlIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMjUgIGp1bmdqaWsubGVlICA8anVuZ2ppay5sZWVAc2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUmVtb3ZlIHVudXNlZCBjb2RlIGluIGV3a190aWxl X21vZGVsLmMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY0NTIxCisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBjb2RlIGluIGV3a190aWxlX21vZGVsLmMu IERpcnR5IGZsYWcgaXMgbm90IHJlZmVyZW5jZWQgYW55d2hlcmUuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBld2svZXdrX3RpbGVkX21vZGVsLmM6 CisgICAgICAgIChld2tfdGlsZV91bnVzZWRfY2FjaGVfY2xlYXIpOgorICAgICAgICAoZXdrX3Rp bGVfdW51c2VkX2NhY2hlX2ZsdXNoKToKKyAgICAgICAgKGV3a190aWxlX3VudXNlZF9jYWNoZV90 aWxlX2dldCk6CisgICAgICAgIChld2tfdGlsZV91bnVzZWRfY2FjaGVfdGlsZV9wdXQpOgorCiAy MDExLTA3LTEyICBKb3NlcGggUGVjb3Jhcm8gIDxqb2VwZWNrQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgQXBwbGljYXRpb25DYWNoZSB1cGRhdGUgc2hvdWxkIG5vdCBpbW1lZGlhdGVseSBmYWlsIHdo ZW4gcmVhY2hpbmcgcGVyLW9yaWdpbiBxdW90YQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a190aWxlZF9tb2RlbC5jIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxl ZF9tb2RlbC5jCmluZGV4IDg1NmRkZmMuLjRhMTQxOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfdGlsZWRfbW9kZWwuYworKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3RpbGVkX21vZGVsLmMKQEAgLTUxNiw3ICs1MTYsNiBAQCBzdHJ1Y3QgX0V3a19UaWxlX1Vu dXNlZF9DYWNoZSB7CiAgICAgfSBsb2NrZWQ7CiAgICAgaW50IHJlZmVyZW5jZXM7CiAgICAgdW5z aWduZWQgaW50IGZyb3plbjsKLSAgICBFaW5hX0Jvb2wgZGlydHk6MTsKIH07CiAKIHN0YXRpYyBj b25zdCBzaXplX3QgVElMRV9VTlVTRURfQ0FDSEVfQUxMT0NBVEVfSU5JVElBTCA9IDEyODsKQEAg LTYxMiw3ICs2MTEsNiBAQCB2b2lkIGV3a190aWxlX3VudXNlZF9jYWNoZV9jbGVhcihFd2tfVGls ZV9VbnVzZWRfQ2FjaGUgKnR1YykKIAogICAgIHR1Yy0+bWVtb3J5LnVzZWQgPSAwOwogICAgIHR1 Yy0+ZW50cmllcy5jb3VudCA9IDA7Ci0gICAgdHVjLT5kaXJ0eSA9IEVJTkFfRkFMU0U7CiB9CiAK IC8qKgpAQCAtNzA3LDkgKzcwNSw2IEBAIHNpemVfdCBld2tfdGlsZV91bnVzZWRfY2FjaGVfZmx1 c2goRXdrX1RpbGVfVW51c2VkX0NhY2hlICp0dWMsIHNpemVfdCBieXRlcykKICAgICAgKiBEb24n dCBuZWVkIHRvIHNvcnQgYW55IG1vcmUuCiAgICAgICovCiAKLSAgICBpZiAodHVjLT5kaXJ0eSkK LSAgICAgICAgdHVjLT5kaXJ0eSA9IEVJTkFfRkFMU0U7Ci0KICAgICBkb25lID0gMDsKICAgICBj b3VudCA9IDA7CiAgICAgRUlOQV9MSVNUX0ZPUkVBQ0hfU0FGRSh0dWMtPmVudHJpZXMubGlzdCwg bCwgbF9uZXh0LCBpdHIpIHsKQEAgLTc2MCwyMCArNzU1LDYgQEAgdm9pZCBld2tfdGlsZV91bnVz ZWRfY2FjaGVfYXV0b19mbHVzaChFd2tfVGlsZV9VbnVzZWRfQ2FjaGUgKnR1YykKIH0KIAogLyoq Ci0gKiBGbGFnIGNhY2hlIGFzIGRpcnR5LgotICoKLSAqIElmIGNhY2hlIGlzIGRpcnR5IHRoZW4g bmV4dCBmbHVzaCBvcGVyYXRpb25zIHdpbGwgaGF2ZSB0byByZWNvbXB1dGUKLSAqIHdlaWdodCBh bmQgc29ydCBhZ2FpbiB0byBmaW5kIHRoZSBiZXN0IHRpbGVzIHRvIGV4cGlyZS4KLSAqCi0gKiBP bmUgbXVzdCBjYWxsIHRoaXMgZnVuY3Rpb24gd2hlbiB0aWxlIHByb3BlcnRpZXMgdGhhdCBtYXkg Y2hhbmdlCi0gKiBsaWtlbmVzcyBvZiB0aWxlIHRvIGJlIGZsdXNoZWQgY2hhbmdlLCBsaWtlIFRp bGU6OnN0YXRzLgotICovCi12b2lkIGV3a190aWxlX3VudXNlZF9jYWNoZV9kaXJ0eShFd2tfVGls ZV9VbnVzZWRfQ2FjaGUgKnR1YykKLXsKLSAgICB0dWMtPmRpcnR5ID0gRUlOQV9UUlVFOwotfQot Ci0vKioKICAqIEZyZWV6ZSBjYWNoZSB0byBub3QgZG8gbWFpbnRlbmFuY2UgdGFza3MuCiAgKgog ICogTWFpbnRlbmFuY2UgdGFza3Mgb3B0aW1pemUgY2FjaGUgdXNhZ2UsIGJ1dCBtYXliZSB3ZSBr bm93IHdlIHNob3VsZApAQCAtODM3LDkgKzgxOCw2IEBAIEVpbmFfQm9vbCBld2tfdGlsZV91bnVz ZWRfY2FjaGVfdGlsZV9nZXQoRXdrX1RpbGVfVW51c2VkX0NhY2hlICp0dWMsIEV3a19UaWxlICp0 CiAgICAgdHVjLT5tZW1vcnkudXNlZCAtPSBzaXplb2YoRXdrX1RpbGUpICsgdC0+Ynl0ZXM7CiAg ICAgdHVjLT5lbnRyaWVzLmxpc3QgPSBlaW5hX2xpc3RfcmVtb3ZlX2xpc3QodHVjLT5lbnRyaWVz Lmxpc3QsIGUpOwogICAgIGZyZWUoZW50cnkpOwotICAgIC8vIFRPRE8gYXNzdW1lIGRpcnR5IGZv ciBub3csIGJ1dCBtYXkgaXQncyBub3QsCi0gICAgLy8gaWYgdGhlIGl0ZW0gd2FzIGF0IHRoZSBi ZWdpbm5pbmcgb2YgdGhlIHF1ZXVlCi0gICAgdHVjLT5kaXJ0eSA9IEVJTkFfVFJVRTsKIAogICAg IHJldHVybiBFSU5BX1RSVUU7CiB9CkBAIC04ODksNyArODY3LDYgQEAgRWluYV9Cb29sIGV3a190 aWxlX3VudXNlZF9jYWNoZV90aWxlX3B1dChFd2tfVGlsZV9VbnVzZWRfQ2FjaGUgKnR1YywgRXdr X1RpbGUgKnQKIAogICAgIHR1Yy0+ZW50cmllcy5jb3VudCsrOwogICAgIHR1Yy0+bWVtb3J5LnVz ZWQgKz0gc2l6ZW9mKEV3a19UaWxlKSArIHQtPmJ5dGVzOwotICAgIHR1Yy0+ZGlydHkgPSBFSU5B X1RSVUU7CiAKICAgICByZXR1cm4gRUlOQV9UUlVFOwogfQo= 101966 2011-07-25 21:07:33 -0700 2011-07-25 22:12:00 -0700 updated patch updated.patch text/plain 2999 jungjik.lee ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAxM2Q5MDhiLi4wMThlNDNlIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTEtMDctMjUgIEp1bmdKaWsgTGVlICA8anVuZ2ppay5sZWVAc2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUmVtb3ZlIHVudXNlZCBjb2RlIGluIGV3a190aWxl X21vZGVsLmMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY0NTIxCisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBjb2RlIGluIGV3a190aWxlX21vZGVsLmMu IERpcnR5IGZsYWcgaXMgbm90IHJlZmVyZW5jZWQgYW55d2hlcmUuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBld2svZXdrX3RpbGVkX21vZGVsLmM6 CisgICAgICAgIChld2tfdGlsZV91bnVzZWRfY2FjaGVfY2xlYXIpOgorICAgICAgICAoZXdrX3Rp bGVfdW51c2VkX2NhY2hlX2ZsdXNoKToKKyAgICAgICAgKGV3a190aWxlX3VudXNlZF9jYWNoZV90 aWxlX2dldCk6CisgICAgICAgIChld2tfdGlsZV91bnVzZWRfY2FjaGVfdGlsZV9wdXQpOgorCiAy MDExLTA3LTEyICBKb3NlcGggUGVjb3Jhcm8gIDxqb2VwZWNrQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgQXBwbGljYXRpb25DYWNoZSB1cGRhdGUgc2hvdWxkIG5vdCBpbW1lZGlhdGVseSBmYWlsIHdo ZW4gcmVhY2hpbmcgcGVyLW9yaWdpbiBxdW90YQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a190aWxlZF9tb2RlbC5jIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxl ZF9tb2RlbC5jCmluZGV4IDg1NmRkZmMuLjRhMTQxOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfdGlsZWRfbW9kZWwuYworKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3RpbGVkX21vZGVsLmMKQEAgLTUxNiw3ICs1MTYsNiBAQCBzdHJ1Y3QgX0V3a19UaWxlX1Vu dXNlZF9DYWNoZSB7CiAgICAgfSBsb2NrZWQ7CiAgICAgaW50IHJlZmVyZW5jZXM7CiAgICAgdW5z aWduZWQgaW50IGZyb3plbjsKLSAgICBFaW5hX0Jvb2wgZGlydHk6MTsKIH07CiAKIHN0YXRpYyBj b25zdCBzaXplX3QgVElMRV9VTlVTRURfQ0FDSEVfQUxMT0NBVEVfSU5JVElBTCA9IDEyODsKQEAg LTYxMiw3ICs2MTEsNiBAQCB2b2lkIGV3a190aWxlX3VudXNlZF9jYWNoZV9jbGVhcihFd2tfVGls ZV9VbnVzZWRfQ2FjaGUgKnR1YykKIAogICAgIHR1Yy0+bWVtb3J5LnVzZWQgPSAwOwogICAgIHR1 Yy0+ZW50cmllcy5jb3VudCA9IDA7Ci0gICAgdHVjLT5kaXJ0eSA9IEVJTkFfRkFMU0U7CiB9CiAK IC8qKgpAQCAtNzA3LDkgKzcwNSw2IEBAIHNpemVfdCBld2tfdGlsZV91bnVzZWRfY2FjaGVfZmx1 c2goRXdrX1RpbGVfVW51c2VkX0NhY2hlICp0dWMsIHNpemVfdCBieXRlcykKICAgICAgKiBEb24n dCBuZWVkIHRvIHNvcnQgYW55IG1vcmUuCiAgICAgICovCiAKLSAgICBpZiAodHVjLT5kaXJ0eSkK LSAgICAgICAgdHVjLT5kaXJ0eSA9IEVJTkFfRkFMU0U7Ci0KICAgICBkb25lID0gMDsKICAgICBj b3VudCA9IDA7CiAgICAgRUlOQV9MSVNUX0ZPUkVBQ0hfU0FGRSh0dWMtPmVudHJpZXMubGlzdCwg bCwgbF9uZXh0LCBpdHIpIHsKQEAgLTc2MCwyMCArNzU1LDYgQEAgdm9pZCBld2tfdGlsZV91bnVz ZWRfY2FjaGVfYXV0b19mbHVzaChFd2tfVGlsZV9VbnVzZWRfQ2FjaGUgKnR1YykKIH0KIAogLyoq Ci0gKiBGbGFnIGNhY2hlIGFzIGRpcnR5LgotICoKLSAqIElmIGNhY2hlIGlzIGRpcnR5IHRoZW4g bmV4dCBmbHVzaCBvcGVyYXRpb25zIHdpbGwgaGF2ZSB0byByZWNvbXB1dGUKLSAqIHdlaWdodCBh bmQgc29ydCBhZ2FpbiB0byBmaW5kIHRoZSBiZXN0IHRpbGVzIHRvIGV4cGlyZS4KLSAqCi0gKiBP bmUgbXVzdCBjYWxsIHRoaXMgZnVuY3Rpb24gd2hlbiB0aWxlIHByb3BlcnRpZXMgdGhhdCBtYXkg Y2hhbmdlCi0gKiBsaWtlbmVzcyBvZiB0aWxlIHRvIGJlIGZsdXNoZWQgY2hhbmdlLCBsaWtlIFRp bGU6OnN0YXRzLgotICovCi12b2lkIGV3a190aWxlX3VudXNlZF9jYWNoZV9kaXJ0eShFd2tfVGls ZV9VbnVzZWRfQ2FjaGUgKnR1YykKLXsKLSAgICB0dWMtPmRpcnR5ID0gRUlOQV9UUlVFOwotfQot Ci0vKioKICAqIEZyZWV6ZSBjYWNoZSB0byBub3QgZG8gbWFpbnRlbmFuY2UgdGFza3MuCiAgKgog ICogTWFpbnRlbmFuY2UgdGFza3Mgb3B0aW1pemUgY2FjaGUgdXNhZ2UsIGJ1dCBtYXliZSB3ZSBr bm93IHdlIHNob3VsZApAQCAtODM3LDkgKzgxOCw2IEBAIEVpbmFfQm9vbCBld2tfdGlsZV91bnVz ZWRfY2FjaGVfdGlsZV9nZXQoRXdrX1RpbGVfVW51c2VkX0NhY2hlICp0dWMsIEV3a19UaWxlICp0 CiAgICAgdHVjLT5tZW1vcnkudXNlZCAtPSBzaXplb2YoRXdrX1RpbGUpICsgdC0+Ynl0ZXM7CiAg ICAgdHVjLT5lbnRyaWVzLmxpc3QgPSBlaW5hX2xpc3RfcmVtb3ZlX2xpc3QodHVjLT5lbnRyaWVz Lmxpc3QsIGUpOwogICAgIGZyZWUoZW50cnkpOwotICAgIC8vIFRPRE8gYXNzdW1lIGRpcnR5IGZv ciBub3csIGJ1dCBtYXkgaXQncyBub3QsCi0gICAgLy8gaWYgdGhlIGl0ZW0gd2FzIGF0IHRoZSBi ZWdpbm5pbmcgb2YgdGhlIHF1ZXVlCi0gICAgdHVjLT5kaXJ0eSA9IEVJTkFfVFJVRTsKIAogICAg IHJldHVybiBFSU5BX1RSVUU7CiB9CkBAIC04ODksNyArODY3LDYgQEAgRWluYV9Cb29sIGV3a190 aWxlX3VudXNlZF9jYWNoZV90aWxlX3B1dChFd2tfVGlsZV9VbnVzZWRfQ2FjaGUgKnR1YywgRXdr X1RpbGUgKnQKIAogICAgIHR1Yy0+ZW50cmllcy5jb3VudCsrOwogICAgIHR1Yy0+bWVtb3J5LnVz ZWQgKz0gc2l6ZW9mKEV3a19UaWxlKSArIHQtPmJ5dGVzOwotICAgIHR1Yy0+ZGlydHkgPSBFSU5B X1RSVUU7CiAKICAgICByZXR1cm4gRUlOQV9UUlVFOwogfQo=