64518 2011-07-14 01:47:28 -0700 removes #if ENABLE(DRAG_SUPPORT) check 2011-07-25 11:08:53 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 0 a.renevier webkit-unassigned dbates mrobinson webkit.review.bot oldest_to_newest 437000 0 a.renevier 2011-07-14 01:47:28 -0700 Hi, Source/WebCore/platform/gtk/ClipboardGtk.h has a #if ENABLE(DRAG_SUPPORT) check. It's the only place in gtk port where there is this check. In all other places, DRAG_SUPPORT is supposed to be enabled. So, if I understand correctly, it makes little sense to keep it. 437001 1 100788 a.renevier 2011-07-14 01:51:56 -0700 Created attachment 100788 removes last ENABLE(DRAG_SUPPORT) gtk check 441520 2 100788 mrobinson 2011-07-24 18:12:52 -0700 Comment on attachment 100788 removes last ENABLE(DRAG_SUPPORT) gtk check View in context: https://bugs.webkit.org/attachment.cgi?id=100788&action=review This seems fine. It's still used in other places throughout WebCore, but otherwise, only Mac uses it in the platform layer. Please fix the ChangeLog, then we can use the commit-queue to commit this. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) You should remove this line. 441585 3 101855 a.renevier 2011-07-25 02:00:22 -0700 Created attachment 101855 patch v1.1 441750 4 101855 webkit.review.bot 2011-07-25 11:08:49 -0700 Comment on attachment 101855 patch v1.1 Clearing flags on attachment: 101855 Committed r91681: <http://trac.webkit.org/changeset/91681> 441751 5 webkit.review.bot 2011-07-25 11:08:53 -0700 All reviewed patches have been landed. Closing bug. 100788 2011-07-14 01:51:56 -0700 2011-07-25 02:00:22 -0700 removes last ENABLE(DRAG_SUPPORT) gtk check bug-64518-20110714105154.patch text/plain 1424 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogOTA2ODgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiOTk4MzQ4ZDMxZTM0YWU3 YzAyMzViMjZlNjE3NDEwZjhmNDQ0NGVmLi40MDFhNWEzOTZjMmU5OGFjM2QzYTQwYjlhZTI4MmE2 ODEzMTg3NDcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDctMTQgIEFybm8g UmVuZXZpZXIgIDxhcm5vQHJlbmV2aWVyLm5ldD4KKworICAgICAgICByZW1vdmVzIGxhc3QgRU5B QkxFKERSQUdfU1VQUE9SVCkgZ3RrIGNoZWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NDUxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogcGxh dGZvcm0vZ3RrL0NsaXBib2FyZEd0ay5oOgorCiAyMDExLTA3LTEzICBBcm5vIFJlbmV2aWVyICA8 YXJub0ByZW5ldmllci5uZXQ+CiAKICAgICAgICAgV2VDb3JlIGRyYWcgaHlzdGVyZXNpcyBpcyBh dCBsZWFzdCAiZ3RrLWRuZC1kcmFnLXRocmVzaG9sZCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2d0ay9DbGlwYm9hcmRHdGsuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9DbGlwYm9hcmRHdGsuaAppbmRleCA2MDdkNTE4NTEzMDc3ZGU5OWVmOTc1MjUyMThlNTVj NmI1MDUzOWY5Li4yYmRhZTY1YTcyYzVhNDI1YzAyYjA4NjgzOGM0NzNkZTE1N2ZhNzYwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ2xpcGJvYXJkR3RrLmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0NsaXBib2FyZEd0ay5oCkBAIC02NSw5ICs2NSw3 IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9pZCBzZXREcmFnSW1hZ2UoQ2FjaGVk SW1hZ2UqLCBOb2RlKiwgY29uc3QgSW50UG9pbnQmKTsKIAogICAgICAgICB2aXJ0dWFsIERyYWdJ bWFnZVJlZiBjcmVhdGVEcmFnSW1hZ2UoSW50UG9pbnQmKSBjb25zdDsKLSNpZiBFTkFCTEUoRFJB R19TVVBQT1JUKQogICAgICAgICB2aXJ0dWFsIHZvaWQgZGVjbGFyZUFuZFdyaXRlRHJhZ0ltYWdl KEVsZW1lbnQqLCBjb25zdCBLVVJMJiwgY29uc3QgU3RyaW5nJiwgRnJhbWUqKTsKLSNlbmRpZgog ICAgICAgICB2aXJ0dWFsIHZvaWQgd3JpdGVVUkwoY29uc3QgS1VSTCYsIGNvbnN0IFN0cmluZyYs IEZyYW1lKik7CiAgICAgICAgIHZpcnR1YWwgdm9pZCB3cml0ZVJhbmdlKFJhbmdlKiwgRnJhbWUq KTsKICAgICAgICAgdmlydHVhbCB2b2lkIHdyaXRlUGxhaW5UZXh0KGNvbnN0IFN0cmluZyYpOwo= 101855 2011-07-25 02:00:22 -0700 2011-07-25 11:08:49 -0700 patch v1.1 0001-64518.patch text/plain 1606 a.renevier RnJvbSBhNGU2OGM2MDU5YjU0MDk1MDBiMGNlMjM5MzE3ZTRmMDMxNWMxNzM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBcm5vIFJlbmV2aWVyIDxhcm5vQHJlbmV2aWVyLm5ldD4KRGF0 ZTogTW9uLCAyNSBKdWwgMjAxMSAxMDo1NzozOSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIDY0NTE4 CgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICB8ICAgIDkg KysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ2xpcGJvYXJkR3RrLmggfCAg ICAyIC0tCiAyIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKaW5kZXggNDdkNDVlNS4uMGM1ODZkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDExLTA3LTI1ICBBcm5vIFJlbmV2aWVyICA8YXJub0ByZW5ldmllci5uZXQ+CisKKyAg ICAgICAgcmVtb3ZlcyBsYXN0IEVOQUJMRShEUkFHX1NVUFBPUlQpIGd0ayBjaGVjaworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ1MTgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9D bGlwYm9hcmRHdGsuaDoKKwogMjAxMS0wNy0xOSAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8a3Vi b0Bwcm9mdXNpb24ubW9iaT4KIAogICAgICAgICBbRUZMXSBBY2NvdW50IGZvciB0aGUgaW52YWxp ZCBwb2ludGVyIGNhc2UgaW4gV2ViQ29yZTo6c2NyZWVuUmVjdCgpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ2xpcGJvYXJkR3RrLmggYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ndGsvQ2xpcGJvYXJkR3RrLmgKaW5kZXggNjA3ZDUxOC4uMmJkYWU2NSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0NsaXBib2FyZEd0ay5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9DbGlwYm9hcmRHdGsuaApAQCAtNjUsOSArNjUsNyBA QCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZvaWQgc2V0RHJhZ0ltYWdlKENhY2hlZElt YWdlKiwgTm9kZSosIGNvbnN0IEludFBvaW50Jik7CiAKICAgICAgICAgdmlydHVhbCBEcmFnSW1h Z2VSZWYgY3JlYXRlRHJhZ0ltYWdlKEludFBvaW50JikgY29uc3Q7Ci0jaWYgRU5BQkxFKERSQUdf U1VQUE9SVCkKICAgICAgICAgdmlydHVhbCB2b2lkIGRlY2xhcmVBbmRXcml0ZURyYWdJbWFnZShF bGVtZW50KiwgY29uc3QgS1VSTCYsIGNvbnN0IFN0cmluZyYsIEZyYW1lKik7Ci0jZW5kaWYKICAg ICAgICAgdmlydHVhbCB2b2lkIHdyaXRlVVJMKGNvbnN0IEtVUkwmLCBjb25zdCBTdHJpbmcmLCBG cmFtZSopOwogICAgICAgICB2aXJ0dWFsIHZvaWQgd3JpdGVSYW5nZShSYW5nZSosIEZyYW1lKik7 CiAgICAgICAgIHZpcnR1YWwgdm9pZCB3cml0ZVBsYWluVGV4dChjb25zdCBTdHJpbmcmKTsKLS0g CjEuNy41LjQKCg==