64515 2011-07-14 00:18:15 -0700 [EFL] Add OwnPtr specialization for Ecore_Pipe. 2011-07-14 11:03:06 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 64337 1 ryuan.choi ryuan.choi gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 436968 0 ryuan.choi 2011-07-14 00:18:15 -0700 It's needed for Bug 64337. 436974 1 100781 ryuan.choi 2011-07-14 00:25:35 -0700 Created attachment 100781 Patch 436975 2 ryuan.choi 2011-07-14 00:28:31 -0700 The style bot will complain struct name, but it's false positive. 436976 3 webkit.review.bot 2011-07-14 00:28:33 -0700 Attachment 100781 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/OwnPtrCommon.h:55: Ecore_Pipe is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 436987 4 100781 gyuyoung.kim 2011-07-14 00:56:18 -0700 Comment on attachment 100781 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100781&action=review LGTM except for changelog. > Source/JavaScriptCore/ChangeLog:5 > + Though this patch is clear, do you need to add simple description for this patch ? 436990 5 100785 ryuan.choi 2011-07-14 01:07:46 -0700 Created attachment 100785 Patch 436991 6 ryuan.choi 2011-07-14 01:08:14 -0700 (In reply to comment #4) > (From update of attachment 100781 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100781&action=review > > LGTM except for changelog. > > > Source/JavaScriptCore/ChangeLog:5 > > + > > Though this patch is clear, do you need to add simple description for this patch ? I update changelog. 436992 7 webkit.review.bot 2011-07-14 01:09:16 -0700 Attachment 100785 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/OwnPtrCommon.h:55: Ecore_Pipe is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 437056 8 rakuco 2011-07-14 06:42:35 -0700 LGTM, we just need to find a willing reviewer now. 437079 9 100785 xan.lopez 2011-07-14 07:34:28 -0700 Comment on attachment 100785 Patch Looks good. You should figure out a way of teaching the style scripts to ignore your types. 437202 10 100785 webkit.review.bot 2011-07-14 11:02:59 -0700 Comment on attachment 100785 Patch Clearing flags on attachment: 100785 Committed r91018: <http://trac.webkit.org/changeset/91018> 437203 11 webkit.review.bot 2011-07-14 11:03:06 -0700 All reviewed patches have been landed. Closing bug. 100781 2011-07-14 00:25:35 -0700 2011-07-14 01:07:40 -0700 Patch bug-64515-20110714162555.patch text/plain 1991 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogOTA5ODMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGZm NjBhYTg4YzBkN2JhODRjNWM2NDA5ZDI3YTAwZTBkNTBiOWZlMmIuLmVhOTE2ZDE1ZjA1N2FiY2M4 ZjM3NjNiZjk2YThjODU3YmNiYWY0NGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE0IEBACisyMDExLTA3LTE0ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNv bT4KKworICAgICAgICBbRUZMXSBBZGQgT3duUHRyIHNwZWNpYWxpemF0aW9uIGZvciBFY29yZV9Q aXBlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ1 MTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0 Zi9Pd25QdHJDb21tb24uaDoKKyAgICAgICAgKiB3dGYvZWZsL093blB0ckVmbC5jcHA6CisgICAg ICAgIChXVEY6OmRlbGV0ZU93bmVkUHRyKToKKwogMjAxMS0wNy0xMyAgTWljaGFlbCBTYWJvZmYg IDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjQyMDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93 dGYvT3duUHRyQ29tbW9uLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL093blB0ckNvbW1v bi5oCmluZGV4IGQyYWJkYjUzZWM3MDQ0ZTUzNTUzMTg0Y2JmNDEzNThmZmIyY2I3M2EuLjE2OGNl MDhkYzNiZGIyMTlhZTQ0ZGFmMzkxZjU4YTQwMzYzNTlkYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvT3duUHRyQ29tbW9uLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3d0Zi9Pd25QdHJDb21tb24uaApAQCAtNTIsNiArNTIsNyBAQCB0eXBlZGVmIHN0cnVjdCBJ TWVtU3BhY2UgSU1lbVNwYWNlOwogCiAjaWYgUExBVEZPUk0oRUZMKQogdHlwZWRlZiBzdHJ1Y3Qg X0Vjb3JlX0V2YXMgRWNvcmVfRXZhczsKK3R5cGVkZWYgc3RydWN0IF9FY29yZV9QaXBlIEVjb3Jl X1BpcGU7CiB0eXBlZGVmIHN0cnVjdCBfRXZhc19PYmplY3QgRXZhc19PYmplY3Q7CiAjZW5kaWYK IApAQCAtODYsNiArODcsNyBAQCBuYW1lc3BhY2UgV1RGIHsKIAogI2lmIFBMQVRGT1JNKEVGTCkK ICAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKEVjb3JlX0V2YXMqKTsKKyAgICB2b2lkIGRlbGV0ZU93 bmVkUHRyKEVjb3JlX1BpcGUqKTsKICAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKEV2YXNfT2JqZWN0 Kik7CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9lZmwv T3duUHRyRWZsLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvZWZsL093blB0ckVmbC5j cHAKaW5kZXggNjZlZWFlOWMyMGFiNzY2YTE4MTk2YTBkNWM1YWNjNzkxNzQyNTJlYS4uN2VjNTE3 MDI5MWYwMTI5ODBkZmI3MGYxMmUzNTdjOThhMGM5NGQwOCAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL3d0Zi9lZmwvT3duUHRyRWZsLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL2VmbC9Pd25QdHJFZmwuY3BwCkBAIC0yNyw2ICsyNyw3IEBACiAjaW5jbHVkZSAi Y29uZmlnLmgiCiAjaW5jbHVkZSAiT3duUHRyLmgiCiAKKyNpbmNsdWRlIDxFY29yZS5oPgogI2lu Y2x1ZGUgPEVjb3JlX0V2YXMuaD4KICNpbmNsdWRlIDxFdmFzLmg+CiAKQEAgLTQzLDQgKzQ0LDEw IEBAIHZvaWQgZGVsZXRlT3duZWRQdHIoRXZhc19PYmplY3QqIHB0cikKICAgICBldmFzX29iamVj dF9kZWwocHRyKTsKIH0KIAordm9pZCBkZWxldGVPd25lZFB0cihFY29yZV9QaXBlKiBwdHIpCit7 CisgICAgaWYgKHB0cikKKyAgICAgICAgZWNvcmVfcGlwZV9kZWwocHRyKTsKK30KKwogfQo= 100785 2011-07-14 01:07:46 -0700 2011-07-14 11:02:59 -0700 Patch bug-64515-20110714170807.patch text/plain 2063 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogOTA5ODMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGZm NjBhYTg4YzBkN2JhODRjNWM2NDA5ZDI3YTAwZTBkNTBiOWZlMmIuLmIwMWMyNjRjY2FlOGQ1ODRh NGQ4ZGM1NzJiZDYwMDFlYWUxNDk0OTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDExLTA3LTE0ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNv bT4KKworICAgICAgICBbRUZMXSBBZGQgT3duUHRyIHNwZWNpYWxpemF0aW9uIGZvciBFY29yZV9Q aXBlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ1 MTUKKworICAgICAgICBBZGQgYW4gb3ZlcmxvYWQgZm9yIGRlbGV0ZU93bmVkUHRyKEVjb3JlX1Bp cGUqKSBvbiBFRkwgcG9ydC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHd0Zi9Pd25QdHJDb21tb24uaDoKKyAgICAgICAgKiB3dGYvZWZsL093blB0 ckVmbC5jcHA6CisgICAgICAgIChXVEY6OmRlbGV0ZU93bmVkUHRyKToKKwogMjAxMS0wNy0xMyAg TWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQyMDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvT3duUHRyQ29tbW9uLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL093blB0ckNvbW1vbi5oCmluZGV4IGQyYWJkYjUzZWM3MDQ0ZTUzNTUzMTg0Y2JmNDEzNThm ZmIyY2I3M2EuLjE2OGNlMDhkYzNiZGIyMTlhZTQ0ZGFmMzkxZjU4YTQwMzYzNTlkYzkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvT3duUHRyQ29tbW9uLmgKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9Pd25QdHJDb21tb24uaApAQCAtNTIsNiArNTIsNyBAQCB0 eXBlZGVmIHN0cnVjdCBJTWVtU3BhY2UgSU1lbVNwYWNlOwogCiAjaWYgUExBVEZPUk0oRUZMKQog dHlwZWRlZiBzdHJ1Y3QgX0Vjb3JlX0V2YXMgRWNvcmVfRXZhczsKK3R5cGVkZWYgc3RydWN0IF9F Y29yZV9QaXBlIEVjb3JlX1BpcGU7CiB0eXBlZGVmIHN0cnVjdCBfRXZhc19PYmplY3QgRXZhc19P YmplY3Q7CiAjZW5kaWYKIApAQCAtODYsNiArODcsNyBAQCBuYW1lc3BhY2UgV1RGIHsKIAogI2lm IFBMQVRGT1JNKEVGTCkKICAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKEVjb3JlX0V2YXMqKTsKKyAg ICB2b2lkIGRlbGV0ZU93bmVkUHRyKEVjb3JlX1BpcGUqKTsKICAgICB2b2lkIGRlbGV0ZU93bmVk UHRyKEV2YXNfT2JqZWN0Kik7CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3d0Zi9lZmwvT3duUHRyRWZsLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYv ZWZsL093blB0ckVmbC5jcHAKaW5kZXggNjZlZWFlOWMyMGFiNzY2YTE4MTk2YTBkNWM1YWNjNzkx NzQyNTJlYS4uN2VjNTE3MDI5MWYwMTI5ODBkZmI3MGYxMmUzNTdjOThhMGM5NGQwOCAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9lZmwvT3duUHRyRWZsLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL2VmbC9Pd25QdHJFZmwuY3BwCkBAIC0yNyw2ICsyNyw3 IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiT3duUHRyLmgiCiAKKyNpbmNsdWRl IDxFY29yZS5oPgogI2luY2x1ZGUgPEVjb3JlX0V2YXMuaD4KICNpbmNsdWRlIDxFdmFzLmg+CiAK QEAgLTQzLDQgKzQ0LDEwIEBAIHZvaWQgZGVsZXRlT3duZWRQdHIoRXZhc19PYmplY3QqIHB0cikK ICAgICBldmFzX29iamVjdF9kZWwocHRyKTsKIH0KIAordm9pZCBkZWxldGVPd25lZFB0cihFY29y ZV9QaXBlKiBwdHIpCit7CisgICAgaWYgKHB0cikKKyAgICAgICAgZWNvcmVfcGlwZV9kZWwocHRy KTsKK30KKwogfQo=