6451 2006-01-09 08:10:45 -0800 REGRESSION: After Find, selected text sometimes includes preceding img element 2006-01-11 17:37:03 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED DUPLICATE 5127 InRadar P1 Normal --- 1 sullivan webkit-unassigned oldest_to_newest 28051 0 sullivan 2006-01-09 08:10:45 -0800 This is also in Radar as: <rdar://problem/4402375> REGRESSION (417.8 - TOT): finding text sometimes also selects previous image In certain cases, after performing a Find, the resulting selection highlights both the found text and a preceding image element. This did not happen on the last released version of WebKit/Safari. I'll attach a test case with steps that are appropriate to that test case momentarily. 28052 1 5570 sullivan 2006-01-09 08:13:47 -0800 Created attachment 5570 A few test cases that show this bug. To reproduce with this test page: 1. Load the test page 2. Command-F in Safari to bring up Find UI 3. Type "Throw" and hit Return to find first instance of Throw Note that the text "Throw" has the selection highlight, and the image right before the text also has the selection highlight. If you search for more instances with Find Next (command-G) the same thing occurs for the other test cases. 28053 2 sullivan 2006-01-09 08:14:41 -0800 From <rdar://problem/4402375>: This bug does not occur in Safari-417.8, so it's a regression in TOT. The bug is probably in KWQKHTMLPart::findString, perhaps in this line: setSelection(SelectionController(resultRange.get(), DOWNSTREAM, VP_UPSTREAM_IF_POSSIBLE)); 28054 3 sullivan 2006-01-09 08:16:18 -0800 It's possible that I introduced this bug at some point since I did some work in findString a while back, but I suspect that the regression is instead caused by some other change, perhaps editing-related. 28063 4 ap 2006-01-09 10:02:48 -0800 Mitz points out that this looks very similar to bug 5127, and I agree. 28064 5 sullivan 2006-01-09 10:28:51 -0800 Yep, it seems extremely likely that this is the same as 5127 (and thus not directly related to findString). 28188 6 alice.barraclough 2006-01-10 14:37:42 -0800 *** This bug has been marked as a duplicate of 5127 *** 5570 2006-01-09 08:13:47 -0800 2006-01-09 08:13:47 -0800 A few test cases that show this bug. 6451-examples.html text/html 899 sullivan IAo8cD5JbWFnZSBjb250YWluZWQgaW4gVEQgZWxlbWVudCB3aXRoIHRleHQ8L3A+Cjx0YWJsZT48 dHI+PHRkPjxpbWcgc3JjPSJodHRwOi8vaW1hZ2VzLmFtYXpvbi5jb20vaW1hZ2VzL1AvQjAwMEJU U1RPRS4wMS5fUEVfU0NUWlpaWlpaWl8uanBnIiB3aWR0aD0iMTIxIiBhbGlnbj0ibGVmdCIgaGVp Z2h0PSI5OSIgYm9yZGVyPSIwIj5UaHJvdyBvdXQ8L3RkPjwvdHI+PC90YWJsZT4KCgo8cD5JbWFn ZSBjb250YWluZWQgaW4gUCBlbGVtZW50IHdpdGggdGV4dDwvcD4KIDxwPjxpbWcgc3JjPSJodHRw Oi8vaW1hZ2VzLmFtYXpvbi5jb20vaW1hZ2VzL1AvQjAwMEJUU1RPRS4wMS5fUEVfU0NUWlpaWlpa Wl8uanBnIiB3aWR0aD0iMTIxIiBhbGlnbj0ibGVmdCIgaGVpZ2h0PSI5OSIgYm9yZGVyPSIwIj5U aHJvdyBvdXQ8L3A+PGJyPjxicj48YnI+CgoKCjxwIGFsaWduPSJsZWZ0Ij5JbWFnZSBjb250YWlu ZWQgaW4gRElWIGVsZW1lbnQgd2l0aCB0ZXh0PC9wPjxCUj4KIDxESVYgYWxpZ249ImxlZnQiPjxp bWcgc3JjPSJodHRwOi8vaW1hZ2VzLmFtYXpvbi5jb20vaW1hZ2VzL1AvQjAwMEJUU1RPRS4wMS5f UEVfU0NUWlpaWlpaWl8uanBnIiB3aWR0aD0iMTIxIiBhbGlnbj0ibGVmdCIgaGVpZ2h0PSI5OSIg Ym9yZGVyPSIwIj5UaHJvdyBvdXQ8L0RJVj4KCjxiciBjbGVhcj1hbGw+CgoKPHAgYWxpZ249Imxl ZnQiPkltYWdlIGNvbnRhaW5lZCBpbiBESVYgZWxlbWVudCB3aXRoIHRleHQ8L3A+PEJSPgogPERJ ViBhbGlnbj0ibGVmdCI+PGltZyBzcmM9Imh0dHA6Ly9pbWFnZXMuYW1hem9uLmNvbS9pbWFnZXMv UC9CMDAwQlRTVE9FLjAxLl9QRV9TQ1RaWlpaWlpaXy5qcGciIHdpZHRoPSIxMjEiIGFsaWduPSJy aWdodCIgaGVpZ2h0PSI5OSIgYm9yZGVyPSIwIj5UaHJvdyBvdXQ8L0RJVj4=