64500 2011-07-13 19:22:02 -0700 Select elements expose the wrong children if children are added dynamically 2011-07-16 05:31:12 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Windows 7 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 jhoneycutt jhoneycutt bdakin oldest_to_newest 436874 0 jhoneycutt 2011-07-13 19:22:02 -0700 Non-multiple select elements expose the wrong children to accessibility clients if child <option> elements are added dynamically. 436876 1 jhoneycutt 2011-07-13 19:22:39 -0700 <rdar://problem/9773066> 436965 2 100779 jhoneycutt 2011-07-14 00:07:11 -0700 Created attachment 100779 Patch 437196 3 ap 2011-07-14 10:54:03 -0700 - // would be a WMLElement, but WML builds don't use accessbility features at all. + // would be a WMLElement, but WML builds don't use accessibility features at all. We don't have WML any more. 437970 4 100779 bdakin 2011-07-15 14:06:30 -0700 Comment on attachment 100779 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100779&action=review > Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp:99 > + // would be a WMLElement, but WML builds don't use accessibility features at all. You should consider just deleting this comment based on Alexey's info. 438138 5 jhoneycutt 2011-07-16 05:31:12 -0700 Removed comment and landed in <http://trac.webkit.org/changeset/91128>. 100779 2011-07-14 00:07:11 -0700 2011-07-15 14:06:30 -0700 Patch 0001-ensure-that-a-single-select-element-s-child-option-e.patch text/plain 7065 jhoneycutt RnJvbSBiMmEzZWYxODAyNjQ3ODQ1NWZlZTk0YWQ3ZGRiYjU3ZmMzMDllOWY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gSG9uZXljdXR0IDxqaG9uZXljdXR0QGFwcGxlLmNvbT4K RGF0ZTogVHVlLCAxMiBKdWwgMjAxMSAxNzowNzoxMyAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEVu c3VyZSB0aGF0IGEgc2luZ2xlIHNlbGVjdCBlbGVtZW50J3MgY2hpbGQgb3B0aW9uIGVsZW1lbnRz IGFyZQogcmVwb3J0ZWQgY29ycmVjdGx5IHRvIGFjY2Vzc2liaWxpdHkgY2xpZW50cyBpZiB0aGUg Y2hpbGRyZW4gYXJlCiBjaGFuZ2VkLgoKaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTY0NTAwCjxyZGFyOi8vcHJvYmxlbS85NzczMDY2PgoKUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCgpTb3VyY2UvV2ViQ29yZToKClRlc3Q6IHBsYXRmb3JtL3dpbi9hY2Nlc3NpYmls aXR5L3NpbmdsZS1zZWxlY3QtY2hpbGRyZW4tY2hhbmdlZC5odG1sCgoqIGFjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eU1lbnVMaXN0UG9wdXAuY3BwOgooV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU1l bnVMaXN0UG9wdXA6OmFkZENoaWxkcmVuKToKRml4IGEgdHlwby4KKFdlYkNvcmU6OkFjY2Vzc2li aWxpdHlNZW51TGlzdFBvcHVwOjpjaGlsZHJlbkNoYW5nZWQpOgpEb24ndCBqdXN0IHJlbW92ZSBj aGlsZHJlbiB0aGF0IHdlcmUgZGV0YWNoZWQgLSB0aGlzIHdpbGwgbWlzcyBjaGlsZGVuCnRoYXQg d2VyZSBkeW5hbWljYWxseSBhZGRlZC4gQ2xlYXIgdGhlIGNoaWxkcmVuIGFuZCByZS1hZGQgdGhl bS4KCkxheW91dFRlc3RzOgoKKiBwbGF0Zm9ybS93aW4vYWNjZXNzaWJpbGl0eS9zaW5nbGUtc2Vs ZWN0LWNoaWxkcmVuLWNoYW5nZWQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKiBwbGF0Zm9ybS93aW4v YWNjZXNzaWJpbGl0eS9zaW5nbGUtc2VsZWN0LWNoaWxkcmVuLWNoYW5nZWQuaHRtbDogQWRkZWQu Ci0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg fCAgIDE0ICsrKysrKysKIC4uLi9zaW5nbGUtc2VsZWN0LWNoaWxkcmVuLWNoYW5nZWQtZXhwZWN0 ZWQudHh0ICAgIHwgICAgNyArKysKIC4uLi9zaW5nbGUtc2VsZWN0LWNoaWxkcmVuLWNoYW5nZWQu aHRtbCAgICAgICAgICAgIHwgICA0MSArKysrKysrKysrKysrKysrKysrKwogU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDIwICsrKysrKysrKysK IC4uLi9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlNZW51TGlzdFBvcHVwLmNwcCAgIHwgICAg NiArKy0KIDUgZmlsZXMgY2hhbmdlZCwgODYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK IGNyZWF0ZSBtb2RlIDEwMDY0NCBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vYWNjZXNzaWJpbGl0 eS9zaW5nbGUtc2VsZWN0LWNoaWxkcmVuLWNoYW5nZWQtZXhwZWN0ZWQudHh0CiBjcmVhdGUgbW9k ZSAxMDA2NDQgTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2FjY2Vzc2liaWxpdHkvc2luZ2xlLXNl bGVjdC1jaGlsZHJlbi1jaGFuZ2VkLmh0bWwKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDg1MjQ4Yy4uMzUzMTExNyAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTA3LTEyICBKb24gSG9uZXljdXR0ICA8amhvbmV5Y3V0 dEBhcHBsZS5jb20+CisKKyAgICAgICAgRW5zdXJlIHRoYXQgYSBzaW5nbGUgc2VsZWN0IGVsZW1l bnQncyBjaGlsZCBvcHRpb24gZWxlbWVudHMgYXJlCisgICAgICAgIHJlcG9ydGVkIGNvcnJlY3Rs eSB0byBhY2Nlc3NpYmlsaXR5IGNsaWVudHMgaWYgdGhlIGNoaWxkcmVuIGFyZQorICAgICAgICBj aGFuZ2VkLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02NDUwMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vOTc3MzA2Nj4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9hY2Nlc3Np YmlsaXR5L3NpbmdsZS1zZWxlY3QtY2hpbGRyZW4tY2hhbmdlZC1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIHBsYXRmb3JtL3dpbi9hY2Nlc3NpYmlsaXR5L3NpbmdsZS1zZWxlY3QtY2hp bGRyZW4tY2hhbmdlZC5odG1sOiBBZGRlZC4KKwogMjAxMS0wNy0xMyAgVmluY2VudCBTY2hlaWIg IDxzY2hlaWJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gVXBkYXRlIGNocm9t aXVtIHRlc3QgZXhwZWN0YXRpb25zLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v d2luL2FjY2Vzc2liaWxpdHkvc2luZ2xlLXNlbGVjdC1jaGlsZHJlbi1jaGFuZ2VkLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9hY2Nlc3NpYmlsaXR5L3NpbmdsZS1zZWxl Y3QtY2hpbGRyZW4tY2hhbmdlZC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMC4uNTM4YTVlMQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL3dpbi9hY2Nlc3NpYmlsaXR5L3NpbmdsZS1zZWxlY3QtY2hpbGRyZW4tY2hhbmdlZC1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSw3IEBACisKK1RoaXMgdGVzdHMgdGhhdCBub24tbXVsdGlwbGUg c2VsZWN0IGVsZW1lbnRzIGV4cG9zZSB0aGVpciB1cGRhdGVkIGNoaWxkcmVuIGlmIHRoZXkgY2hh bmdlLgorCisKK1BBU1Mgb3B0aW9uLnRpdGxlID09PSAiT3B0aW9uIDEiIGlzIHRydWUKK1BBU1Mg b3B0aW9uMi50aXRsZSA9PT0gIk9wdGlvbiAyIiBpcyB0cnVlCisKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL3dpbi9hY2Nlc3NpYmlsaXR5L3NpbmdsZS1zZWxlY3QtY2hpbGRyZW4t Y2hhbmdlZC5odG1sIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2FjY2Vzc2liaWxpdHkvc2lu Z2xlLXNlbGVjdC1jaGlsZHJlbi1jaGFuZ2VkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMC4uYTEzYjAyNAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL3dpbi9hY2Nlc3NpYmlsaXR5L3NpbmdsZS1zZWxlY3QtY2hpbGRyZW4tY2hhbmdlZC5odG1s CkBAIC0wLDAgKzEsNDEgQEAKKzxodG1sPgorPGhlYWQ+CisgICAgPGxpbmsgcmVsPSJzdHlsZXNo ZWV0IiBocmVmPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+ CisgICAgPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJl LmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKworPGJvZHkgaWQ9ImJvZHkiPgorCis8c2VsZWN0IGlk PSJzZWxlY3RFbGVtZW50IiB0aXRsZT0ic2VsZWN0RWxlbWVudCI+CisgICAgPG9wdGlvbiBTRUxF Q1RFRD5PcHRpb24gMTwvb3B0aW9uPgorPC9zZWxlY3Q+CisKKzxwPlRoaXMgdGVzdHMgdGhhdCBu b24tbXVsdGlwbGUgc2VsZWN0IGVsZW1lbnRzIGV4cG9zZSB0aGVpciB1cGRhdGVkIGNoaWxkcmVu IGlmIHRoZXkgY2hhbmdlLjwvcD4KKworPHAgaWQ9Im5vdERSVCI+VGhpcyB0ZXN0IHNob3VsZCBv bmx5IGJlIHJ1biBpbnNpZGUgb2YgRHVtcFJlbmRlclRyZWUuPC9wPgorCis8cCBpZD0iY29uc29s ZSI+PC9wPgorCis8c2NyaXB0PgorICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIg JiYgd2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisgICAgICAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJub3REUlQiKS5zdHlsZS52aXNpYmlsaXR5ID0gImhpZGRlbiI7CisKKyAg ICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgICAgIGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJzZWxlY3RFbGVtZW50IikuZm9jdXMoKTsKKyAgICAgICAgdmFy IHNlbGVjdEVsZW1lbnQgPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudDsK KyAgICAgICAgdmFyIGxpc3QgPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVu dC5jaGlsZEF0SW5kZXgoMCk7CisKKyAgICAgICAgdmFyIG9wdGlvbiA9IGxpc3QuY2hpbGRBdElu ZGV4KDApOworICAgICAgICBzaG91bGRCZVRydWUoJ29wdGlvbi50aXRsZSA9PT0gIk9wdGlvbiAx IicpOworCisgICAgICAgIHZhciBuZXdPcHRpb24gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJv cHRpb24iKTsKKyAgICAgICAgbmV3T3B0aW9uLmlubmVySFRNTCA9ICJPcHRpb24gMiI7CisgICAg ICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJzZWxlY3RFbGVtZW50IikuYXBwZW5kQ2hpbGQo bmV3T3B0aW9uKTsKKworICAgICAgICB2YXIgb3B0aW9uMiA9IGxpc3QuY2hpbGRBdEluZGV4KDEp OworICAgICAgICBzaG91bGRCZVRydWUoJ29wdGlvbjIudGl0bGUgPT09ICJPcHRpb24gMiInKTsK KyAgICB9Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5NmYzNGU3 Li42Y2E1MThjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDctMTIgIEpvbiBI b25leWN1dHQgIDxqaG9uZXljdXR0QGFwcGxlLmNvbT4KKworICAgICAgICBFbnN1cmUgdGhhdCBh IHNpbmdsZSBzZWxlY3QgZWxlbWVudCdzIGNoaWxkIG9wdGlvbiBlbGVtZW50cyBhcmUKKyAgICAg ICAgcmVwb3J0ZWQgY29ycmVjdGx5IHRvIGFjY2Vzc2liaWxpdHkgY2xpZW50cyBpZiB0aGUgY2hp bGRyZW4gYXJlCisgICAgICAgIGNoYW5nZWQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTY0NTAwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85Nzcz MDY2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRl c3Q6IHBsYXRmb3JtL3dpbi9hY2Nlc3NpYmlsaXR5L3NpbmdsZS1zZWxlY3QtY2hpbGRyZW4tY2hh bmdlZC5odG1sCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlNZW51TGlz dFBvcHVwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlNZW51TGlzdFBvcHVw OjphZGRDaGlsZHJlbik6CisgICAgICAgIEZpeCBhIHR5cG8uCisgICAgICAgIChXZWJDb3JlOjpB Y2Nlc3NpYmlsaXR5TWVudUxpc3RQb3B1cDo6Y2hpbGRyZW5DaGFuZ2VkKToKKyAgICAgICAgRG9u J3QganVzdCByZW1vdmUgY2hpbGRyZW4gdGhhdCB3ZXJlIGRldGFjaGVkIC0gdGhpcyB3aWxsIG1p c3MgY2hpbGRlbgorICAgICAgICB0aGF0IHdlcmUgZHluYW1pY2FsbHkgYWRkZWQuIENsZWFyIHRo ZSBjaGlsZHJlbiBhbmQgcmUtYWRkIHRoZW0uCisKIDIwMTEtMDctMTIgIERvbWluaWMgQ29vbmV5 ICA8ZG9taW5pY2NAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJhaXNlIGlmIGRpc3BhdGNoRXZl bnQgZGlzcGF0Y2hlcyBhbiBldmVudCB0aGF0IGlzIGJlaW5nIGRpc3BhdGNoZWQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU1lbnVMaXN0UG9w dXAuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TWVudUxp c3RQb3B1cC5jcHAKaW5kZXggOWUyZWQ2Yi4uNDVkZGU4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TWVudUxpc3RQb3B1cC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TWVudUxpc3RQb3B1cC5j cHAKQEAgLTk2LDcgKzk2LDcgQEAgdm9pZCBBY2Nlc3NpYmlsaXR5TWVudUxpc3RQb3B1cDo6YWRk Q2hpbGRyZW4oKQogICAgIHVuc2lnbmVkIGxlbmd0aCA9IGxpc3RJdGVtcy5zaXplKCk7CiAgICAg Zm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGxlbmd0aDsgaSsrKSB7CiAgICAgICAgIC8vIFRoZSBj YXN0IHRvIEhUTUxFbGVtZW50IGJlbG93IGlzIHNhZmUgYmVjYXVzZSB0aGUgb25seSBvdGhlciBw b3NzaWJsZSBsaXN0SXRlbSB0eXBlCi0gICAgICAgIC8vIHdvdWxkIGJlIGEgV01MRWxlbWVudCwg YnV0IFdNTCBidWlsZHMgZG9uJ3QgdXNlIGFjY2Vzc2JpbGl0eSBmZWF0dXJlcyBhdCBhbGwuCisg ICAgICAgIC8vIHdvdWxkIGJlIGEgV01MRWxlbWVudCwgYnV0IFdNTCBidWlsZHMgZG9uJ3QgdXNl IGFjY2Vzc2liaWxpdHkgZmVhdHVyZXMgYXQgYWxsLgogICAgICAgICBBY2Nlc3NpYmlsaXR5TWVu dUxpc3RPcHRpb24qIG9wdGlvbiA9IG1lbnVMaXN0T3B0aW9uQWNjZXNzaWJpbGl0eU9iamVjdCh0 b0hUTUxFbGVtZW50KGxpc3RJdGVtc1tpXSkpOwogICAgICAgICBpZiAob3B0aW9uKSB7CiAgICAg ICAgICAgICBvcHRpb24tPnNldFBhcmVudCh0aGlzKTsKQEAgLTExMSw5ICsxMTEsMTEgQEAgdm9p ZCBBY2Nlc3NpYmlsaXR5TWVudUxpc3RQb3B1cDo6Y2hpbGRyZW5DaGFuZ2VkKCkKICAgICAgICAg QWNjZXNzaWJpbGl0eU9iamVjdCogY2hpbGQgPSBtX2NoaWxkcmVuW2kgLSAxXS5nZXQoKTsKICAg ICAgICAgaWYgKGNoaWxkLT5hY3Rpb25FbGVtZW50KCkgJiYgIWNoaWxkLT5hY3Rpb25FbGVtZW50 KCktPmF0dGFjaGVkKCkpIHsKICAgICAgICAgICAgIG1fbWVudUxpc3QtPnJlbmRlcmVyKCktPmRv Y3VtZW50KCktPmF4T2JqZWN0Q2FjaGUoKS0+cmVtb3ZlKGNoaWxkLT5heE9iamVjdElEKCkpOwot ICAgICAgICAgICAgbV9jaGlsZHJlbi5yZW1vdmUoaSAtIDEpOwogICAgICAgICB9CiAgICAgfQor ICAgIG1fY2hpbGRyZW4uY2xlYXIoKTsKKyAgICBtX2hhdmVDaGlsZHJlbiA9IGZhbHNlOworICAg IGFkZENoaWxkcmVuKCk7CiB9CiAKIHZvaWQgQWNjZXNzaWJpbGl0eU1lbnVMaXN0UG9wdXA6OnNl dE1lbnVMaXN0KEFjY2Vzc2liaWxpdHlNZW51TGlzdCogbWVudUxpc3QpCi0tIAoxLjcuNAoK