64499 2011-07-13 19:13:57 -0700 new-run-webkit-tests: print baseline search path as part of config output 2011-07-13 19:35:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth dglazkov eric ojan tony oldest_to_newest 436859 0 dpranke 2011-07-13 19:13:57 -0700 new-run-webkit-tests: print baseline search path as part of config output 436861 1 100756 dpranke 2011-07-13 19:15:21 -0700 Created attachment 100756 Patch 436872 2 100756 eric 2011-07-13 19:21:20 -0700 Comment on attachment 100756 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100756&action=review I would have just printed it one-per line. Some of these might get very long. But it's definitely better than what we have. > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:1103 > + fallback_path = [x.split(self._port.filesystem.sep)[-1] for x in self._port.baseline_search_path()] Why not use filesystem.split? I would probably have written this map(lambda path: self._port.filesystem.split(path)[-1], self._port.baseline_search_path()) 436881 3 dpranke 2011-07-13 19:27:58 -0700 (In reply to comment #2) > (From update of attachment 100756 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100756&action=review > > I would have just printed it one-per line. Some of these might get very long. But it's definitely better than what we have. > I intentionally didn't do this because one-per line is much more verbose and harder to read (IMO). The longest each component might get is something like 'chromium-gpu-mac-snowleopard', which prints: Baseline search path: chromium-gpu-mac -> chromium-gpu -> chromium-mac -> chromium -> mac-snowleopard -> mac -> generic which is still significantly shorter than, say, the command line for DRT from the same output: /Volumes/Src/src/dev2/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt.pyc --platform chromium-gpu-mac-snowleopard --test-shell --pixel-tests=/Volumes/Src/src/dev2/src/webkit/Release/layout-test-results/png_result0.png --enable-accelerated-compositing --enable-accelerated-2d-canvas > > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:1103 > > + fallback_path = [x.split(self._port.filesystem.sep)[-1] for x in self._port.baseline_search_path()] > > Why not use filesystem.split? I would probably have written this map(lambda path: self._port.filesystem.split(path)[-1], self._port.baseline_search_path()) Hm. I was thinking filesystem.split() would return the full dirname and an empty basename, but I guess in this case the full dirname is to .../LayoutTests/platform, and the basename is what you want. Will change. 436884 4 dpranke 2011-07-13 19:30:29 -0700 Note that you can use this command to see the baseline search path of any port, even one for an operating system different than the one you are running on: % new-run-webkit-tests --platform XX --no-build --nocheck-sys-deps --print config -n 436886 5 eric 2011-07-13 19:30:58 -0700 Seems useful, thanks! 436889 6 dpranke 2011-07-13 19:33:01 -0700 Committed r90973: <http://trac.webkit.org/changeset/90973> 436893 7 dpranke 2011-07-13 19:35:52 -0700 sample output: $ new-run-webkit-tests --platform chromium-gpu-mac-leopard --no-build --nocheck-sys-deps --print config -n Using port 'chromium-gpu-mac-leopard' Test configuration: <leopard, x86, release, gpu> Placing test results in /Volumes/Src/src/master/src/webkit/Release/layout-test-results Baseline search path: chromium-gpu-mac -> chromium-gpu -> chromium-mac-leopard -> chromium-mac -> chromium -> mac-leopard -> mac-snowleopard -> mac -> generic Using Release build Pixel tests enabled Regular timeout: 6000, slow test timeout: 30000 Command line: /Volumes/Src/src/master/src/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree --test-shell --pixel-tests=/Volumes/Src/src/master/src/webkit/Release/layout-test-results/png_result0.png --enable-accelerated-compositing --enable-accelerated-2d-canvas Worker model: processes Running 1 DumpRenderTree over 1 shard $ 100756 2011-07-13 19:15:21 -0700 2011-07-13 19:28:09 -0700 Patch bug-64499-20110713191519.patch text/plain 3102 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogOTA5NjkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4YTY5YTFlYWE0MDUzYzk5YjgzYjE4NzgyZDk4NjVjZTI0 ZTQxNWJhLi44NDNkMjc0MzRkZTdiMmY3OTkzYmU2MWViODU0NGRiY2Y0ZjNmZmNhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDctMTMgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgbmV3LXJ1bi13ZWJraXQtdGVzdHM6IHByaW50IGJhc2VsaW5lIHNlYXJjaCBwYXRoIGFz IHBhcnQgb2YgY29uZmlnIG91dHB1dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjQ0OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJz L21hbmFnZXIucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29u dHJvbGxlcnMvbWFuYWdlcl91bml0dGVzdC5weToKKwogMjAxMS0wNy0xMyAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIGdhcmRlbmluZyBzZXJ2ZXIgc2hvdWxkIGhh dmUgYW4gQVBJIGZvciBwYXJzaW5nIGNoYW5nZWxvZ3MKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5CmluZGV4 IDVmZGYyYjA1YWRjMDM1Nzg2NmY1NzZjNGNhMWY2ZjMxYWI1NmVkZTQuLjY1MzBiMTQyZDYyYzA2 NjI3ZGE3OWM3OThjNGFmNmEyZDI1OTgxZDggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkKKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weQpAQCAtMTA5 OSw2ICsxMDk5LDEwIEBAIGNsYXNzIE1hbmFnZXIob2JqZWN0KToKICAgICAgICAgaWYgc2VsZi5f b3B0aW9ucy5uZXdfYmFzZWxpbmU6CiAgICAgICAgICAgICBwLnByaW50X2NvbmZpZygiUGxhY2lu ZyBuZXcgYmFzZWxpbmVzIGluICVzIiAlCiAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxm Ll9wb3J0LmJhc2VsaW5lX3BhdGgoKSkKKworICAgICAgICBmYWxsYmFja19wYXRoID0gW3guc3Bs aXQoc2VsZi5fcG9ydC5maWxlc3lzdGVtLnNlcClbLTFdIGZvciB4IGluIHNlbGYuX3BvcnQuYmFz ZWxpbmVfc2VhcmNoX3BhdGgoKV0KKyAgICAgICAgcC5wcmludF9jb25maWcoIkJhc2VsaW5lIHNl YXJjaCBwYXRoOiAlcyAtPiBnZW5lcmljIiAlICIgLT4gIi5qb2luKGZhbGxiYWNrX3BhdGgpKQor CiAgICAgICAgIHAucHJpbnRfY29uZmlnKCJVc2luZyAlcyBidWlsZCIgJSBzZWxmLl9vcHRpb25z LmNvbmZpZ3VyYXRpb24pCiAgICAgICAgIGlmIHNlbGYuX29wdGlvbnMucGl4ZWxfdGVzdHM6CiAg ICAgICAgICAgICBwLnByaW50X2NvbmZpZygiUGl4ZWwgdGVzdHMgZW5hYmxlZCIpCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5h Z2VyX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29u dHJvbGxlcnMvbWFuYWdlcl91bml0dGVzdC5weQppbmRleCBjMWEzMWQzMWVhNmE4OTEwNzE2Nzc2 NGNjODYyY2FhMjc4MjZmYTMyLi5mMjgwMTY0YjRlZDUyMmMyY2IyOWE5MmNjMGQxNzVmOTA5NTE4 YjY1IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250 cm9sbGVycy9tYW5hZ2VyX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXJfdW5pdHRlc3QucHkKQEAgLTE0MSw2ICsx NDEsMjggQEAgY2xhc3MgU2hhcmRpbmdUZXN0cyh1bml0dGVzdC5UZXN0Q2FzZSk6CiAKIAogY2xh c3MgTWFuYWdlclRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgorICAgIGRlZiBnZXRfb3B0aW9ucyhz ZWxmKToKKyAgICAgICAgcmV0dXJuIE1vY2tPcHRpb25zKHBpeGVsX3Rlc3RzPUZhbHNlLCBuZXdf YmFzZWxpbmU9RmFsc2UsIHRpbWVfb3V0X21zPTYwMDAsIHNsb3dfdGltZV9vdXRfbXM9MzAwMDAs IHdvcmtlcl9tb2RlbD0naW5saW5lJykKKworICAgIGRlZiBnZXRfcHJpbnRlcihzZWxmKToKKyAg ICAgICAgY2xhc3MgRmFrZVByaW50ZXIob2JqZWN0KToKKyAgICAgICAgICAgIGRlZiBfX2luaXRf XyhzZWxmKToKKyAgICAgICAgICAgICAgICBzZWxmLm91dHB1dCA9IFtdCisKKyAgICAgICAgICAg IGRlZiBwcmludF9jb25maWcoc2VsZiwgbXNnKToKKyAgICAgICAgICAgICAgICBzZWxmLm91dHB1 dC5hcHBlbmQobXNnKQorCisgICAgICAgIHJldHVybiBGYWtlUHJpbnRlcigpCisKKyAgICBkZWYg dGVzdF9mYWxsYmFja19wYXRoX2luX2NvbmZpZyhzZWxmKToKKyAgICAgICAgb3B0aW9ucyA9IHNl bGYuZ2V0X29wdGlvbnMoKQorCisgICAgICAgIHBvcnQgPSBsYXlvdXRfdGVzdHMucG9ydC5nZXQo J3Rlc3QtbWFjLWxlb3BhcmQnLCBvcHRpb25zPW9wdGlvbnMpCisgICAgICAgIHByaW50ZXIgPSBz ZWxmLmdldF9wcmludGVyKCkKKyAgICAgICAgbWFuYWdlciA9IE1hbmFnZXIocG9ydCwgcG9ydC5v cHRpb25zLCBwcmludGVyKQorICAgICAgICBtYW5hZ2VyLnByaW50X2NvbmZpZygpCisgICAgICAg IHNlbGYuYXNzZXJ0VHJ1ZSgnQmFzZWxpbmUgc2VhcmNoIHBhdGg6IHRlc3QtbWFjLWxlb3BhcmQg LT4gdGVzdC1tYWMtc25vd2xlb3BhcmQgLT4gZ2VuZXJpYycgaW4gcHJpbnRlci5vdXRwdXQpCisK ICAgICBkZWYgdGVzdF9odHRwX2xvY2tpbmcodGVzdGVyKToKICAgICAgICAgY2xhc3MgTG9ja0No ZWNraW5nTWFuYWdlcihNYW5hZ2VyKToKICAgICAgICAgICAgIGRlZiBfX2luaXRfXyhzZWxmLCBw b3J0LCBvcHRpb25zLCBwcmludGVyKToK