64494 2011-07-13 17:48:21 -0700 Fix leveldb crash when compacting during destruction 2011-07-25 16:28:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dgrogan dgrogan cevans hans japhet webkit.review.bot oldest_to_newest 436794 0 dgrogan 2011-07-13 17:48:21 -0700 Fix leveldb crash when compacting during destruction 436797 1 100740 dgrogan 2011-07-13 17:50:08 -0700 Created attachment 100740 Patch 436819 2 dgrogan 2011-07-13 18:13:47 -0700 Hans, this is the patch I mentioned in crbug.com/88944. This is obviously a lame way to control order of destruction among sibling objects. Open to suggestions. 441600 3 100740 hans 2011-07-25 04:18:15 -0700 Comment on attachment 100740 Patch Thanks for looking at this! View in context: https://bugs.webkit.org/attachment.cgi?id=100740&action=review > Source/WebCore/platform/leveldb/LevelDBDatabase.cpp:97 > + delete db; I was staring a bit at this to see what was going on. This makes us destroy the leveldb::DB object before we destroy m_comparatorAdapter, which is probably exactly the right thing to do. But we should do it by re-ordering the members of the class instead. > Source/WebCore/storage/IDBLevelDBBackingStore.cpp:130 > + delete db; Ditto. I'm not set up to reproduce this at the moment. Can you see if the following patch does the trick? diff --git a/Source/WebCore/platform/leveldb/LevelDBDatabase.h b/Source/WebCore/platform/leveldb/LevelDBDatabase.h index cbc28f6..c8f6b56 100644 --- a/Source/WebCore/platform/leveldb/LevelDBDatabase.h +++ b/Source/WebCore/platform/leveldb/LevelDBDatabase.h @@ -60,9 +60,9 @@ public: private: LevelDBDatabase(); - OwnPtr<leveldb::DB> m_db; const LevelDBComparator* m_comparator; OwnPtr<leveldb::Comparator> m_comparatorAdapter; + OwnPtr<leveldb::DB> m_db; }; } diff --git a/Source/WebCore/storage/IDBLevelDBBackingStore.h b/Source/WebCore/storage/IDBLevelDBBackingStore.h index d28a90c..ea6ec48 100644 --- a/Source/WebCore/storage/IDBLevelDBBackingStore.h +++ b/Source/WebCore/storage/IDBLevelDBBackingStore.h @@ -83,8 +83,8 @@ private: String m_identifier; RefPtr<IDBFactoryBackendImpl> m_factory; - OwnPtr<LevelDBDatabase> m_db; OwnPtr<LevelDBComparator> m_comparator; + OwnPtr<LevelDBDatabase> m_db; RefPtr<LevelDBTransaction> m_currentTransaction; 441761 4 101887 dgrogan 2011-07-25 11:37:48 -0700 Created attachment 101887 Patch 441775 5 dgrogan 2011-07-25 11:52:12 -0700 I couldn't reproduce the original problem on latest ToT. Going back to r92772, picked somewhat arbitrarily, worked though. Hans, your re-order suggestion indeed fixed the problem. I had forgotten that member variables are guaranteed to be destroyed in reverse order of declaration. 441780 6 dgrogan 2011-07-25 12:00:42 -0700 Nate, sorry to bug you again. Could you do another, quicker, review? 441798 7 101887 japhet 2011-07-25 12:32:17 -0700 Comment on attachment 101887 Patch Rather than depending on the ordering in the header file, we should probably manually destroy the OwnPtr<>s in the destructor by calling .clear() on them in the proper order. 441815 8 101898 dgrogan 2011-07-25 13:13:00 -0700 Created attachment 101898 Patch 441816 9 101898 japhet 2011-07-25 13:14:20 -0700 Comment on attachment 101898 Patch Great, thanks! 441972 10 101898 webkit.review.bot 2011-07-25 16:28:51 -0700 Comment on attachment 101898 Patch Clearing flags on attachment: 101898 Committed r91721: <http://trac.webkit.org/changeset/91721> 441974 11 webkit.review.bot 2011-07-25 16:28:56 -0700 All reviewed patches have been landed. Closing bug. 100740 2011-07-13 17:50:08 -0700 2011-07-25 11:37:46 -0700 Patch bug-64494-20110713175007.patch text/plain 2350 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogOTA2MzUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNGE1NDA4ODVlZjhjNmQz NDExODc0YzExMWMzMTVlZGZjZTVhZTMyLi4wMTM3YzY0NjQwMjY4NzJiNmZkMzhlMjUwYWI1OTYy OWNjYTAyN2JjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDctMTMgIERhdmlk IEdyb2dhbiAgPGRncm9nYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBsZXZlbGRiIGNy YXNoIHdoZW4gY29tcGFjdGluZyBkdXJpbmcgZGVzdHJ1Y3Rpb24KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0NDk0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT25seSB0ZXN0ZWQgbWFudWFsbHkgc28gZmFy IGJ5IGZvbGxvd2luZyB0aGUgcmVwcm8gaW5zdHJ1Y3Rpb25zIGF0CisgICAgICAgIGNyYnVnLmNv bS84ODk0NAorCisgICAgICAgICogcGxhdGZvcm0vbGV2ZWxkYi9MZXZlbERCRGF0YWJhc2UuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6TGV2ZWxEQkRhdGFiYXNlOjp+TGV2ZWxEQkRhdGFiYXNlKToK KyAgICAgICAgKiBzdG9yYWdlL0lEQkxldmVsREJCYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SURCTGV2ZWxEQkJhY2tpbmdTdG9yZTo6fklEQkxldmVsREJCYWNraW5nU3RvcmUp OgorCiAyMDExLTA3LTA4ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBOZXR3b3JrUGFuZWwgc2VhcmNoIGZhaWxlZCBpZiB0 aGUgbWF0Y2hlZCBzdGluZyBpcyBpbiB0aGUgcXVlcnkgcGFydCBvZiB1cmwKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2xldmVsZGIvTGV2ZWxEQkRhdGFiYXNlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2xldmVsZGIvTGV2ZWxEQkRhdGFiYXNlLmNwcAppbmRleCAw YmFkOWM4OTQwYjNmNDQyYjI0YTI4NmE5YjNjZmNkYTdkNjRlOGI0Li4wNGQxYzAxYWJlNTQyZDM2 NWJhOWU4YTI4NmM2YTc1ZjJlNDhlODRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9sZXZlbGRiL0xldmVsREJEYXRhYmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbGV2ZWxkYi9MZXZlbERCRGF0YWJhc2UuY3BwCkBAIC05Myw2ICs5Myw4IEBAIExldmVs REJEYXRhYmFzZTo6TGV2ZWxEQkRhdGFiYXNlKCkKIAogTGV2ZWxEQkRhdGFiYXNlOjp+TGV2ZWxE QkRhdGFiYXNlKCkKIHsKKyAgICBsZXZlbGRiOjpEQiogZGIgPSBtX2RiLmxlYWtQdHIoKTsKKyAg ICBkZWxldGUgZGI7CiB9CiAKIFBhc3NPd25QdHI8TGV2ZWxEQkRhdGFiYXNlPiBMZXZlbERCRGF0 YWJhc2U6Om9wZW4oY29uc3QgU3RyaW5nJiBmaWxlTmFtZSwgY29uc3QgTGV2ZWxEQkNvbXBhcmF0 b3IqIGNvbXBhcmF0b3IpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL0lEQkxl dmVsREJCYWNraW5nU3RvcmUuY3BwIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9JREJMZXZlbERC QmFja2luZ1N0b3JlLmNwcAppbmRleCBlODA1NmU1ZjQ1MWQzMTBiZGIwNjVkNDJhZDAxNTZmOWNj NGZlZWEwLi4yMWFkYzc4OGU5OTQ2ZjU4NjhjZDQxODJkNmUyNzcwYTM1NGE0M2E5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL0lEQkxldmVsREJCYWNraW5nU3RvcmUuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURCTGV2ZWxEQkJhY2tpbmdTdG9yZS5jcHAKQEAg LTEyNiw2ICsxMjYsOCBAQCBJREJMZXZlbERCQmFja2luZ1N0b3JlOjpJREJMZXZlbERCQmFja2lu Z1N0b3JlKGNvbnN0IFN0cmluZyYgaWRlbnRpZmllciwgSURCRmFjdAogSURCTGV2ZWxEQkJhY2tp bmdTdG9yZTo6fklEQkxldmVsREJCYWNraW5nU3RvcmUoKQogewogICAgIG1fZmFjdG9yeS0+cmVt b3ZlSURCQmFja2luZ1N0b3JlKG1faWRlbnRpZmllcik7CisgICAgTGV2ZWxEQkRhdGFiYXNlKiBk YiA9IG1fZGIubGVha1B0cigpOworICAgIGRlbGV0ZSBkYjsKIH0KIAogUGFzc1JlZlB0cjxJREJC YWNraW5nU3RvcmU+IElEQkxldmVsREJCYWNraW5nU3RvcmU6Om9wZW4oU2VjdXJpdHlPcmlnaW4q IHNlY3VyaXR5T3JpZ2luLCBjb25zdCBTdHJpbmcmIHBhdGhCYXNlQXJnLCBpbnQ2NF90IG1heGlt dW1TaXplLCBjb25zdCBTdHJpbmcmIGZpbGVJZGVudGlmaWVyLCBJREJGYWN0b3J5QmFja2VuZElt cGwqIGZhY3RvcnkpCg== 101887 2011-07-25 11:37:48 -0700 2011-07-25 13:12:57 -0700 Patch bug-64494-20110725113747.patch text/plain 2157 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogOTEwNjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ZjdiZWEzYjM4MzY4MWM5 Y2I1ODlmNTE4NDFhNDI2MjkxZDk1ODlkLi4yNGUzODExZThjNGNkNjYxZDRhYzRhZDYwZDhjOWVj Yjc4NGI2NDA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDctMTMgIERhdmlk IEdyb2dhbiAgPGRncm9nYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBsZXZlbGRiIGNy YXNoIHdoZW4gY29tcGFjdGluZyBkdXJpbmcgZGVzdHJ1Y3Rpb24KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0NDk0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT25seSB0ZXN0ZWQgbWFudWFsbHkgc28gZmFy IGJ5IGZvbGxvd2luZyB0aGUgcmVwcm8gaW5zdHJ1Y3Rpb25zIGF0CisgICAgICAgIGNyYnVnLmNv bS84ODk0NAorCisgICAgICAgICogcGxhdGZvcm0vbGV2ZWxkYi9MZXZlbERCRGF0YWJhc2UuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6TGV2ZWxEQkRhdGFiYXNlOjp+TGV2ZWxEQkRhdGFiYXNlKToK KyAgICAgICAgKiBzdG9yYWdlL0lEQkxldmVsREJCYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SURCTGV2ZWxEQkJhY2tpbmdTdG9yZTo6fklEQkxldmVsREJCYWNraW5nU3RvcmUp OgorCiAyMDExLTA3LTE1ICBNaWtlIFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogUmVuYW1lIGNvbnNvbGUubWFya1RpbWVsaW5lKCkgdG8gY29uc29s ZS50aW1lU3RhbXAoKSBmb3IgRmlyZWJ1ZyBjb21wYXRpYmlsaXR5LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbGV2ZWxkYi9MZXZlbERCRGF0YWJhc2UuaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2xldmVsZGIvTGV2ZWxEQkRhdGFiYXNlLmgKaW5kZXggY2JjMjhmNjU5 M2M3MDFlMjQ5ZGI4N2U2ZDEzOWNiYmM2NWUwY2QzMS4uYzhmNmI1NjBkNGIyOWU0Njc0MDk4MTdl MDA4NjcwN2U5NmJmZjM3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbGV2 ZWxkYi9MZXZlbERCRGF0YWJhc2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9sZXZl bGRiL0xldmVsREJEYXRhYmFzZS5oCkBAIC02MCw5ICs2MCw5IEBAIHB1YmxpYzoKIHByaXZhdGU6 CiAgICAgTGV2ZWxEQkRhdGFiYXNlKCk7CiAKLSAgICBPd25QdHI8bGV2ZWxkYjo6REI+IG1fZGI7 CiAgICAgY29uc3QgTGV2ZWxEQkNvbXBhcmF0b3IqIG1fY29tcGFyYXRvcjsKICAgICBPd25QdHI8 bGV2ZWxkYjo6Q29tcGFyYXRvcj4gbV9jb21wYXJhdG9yQWRhcHRlcjsKKyAgICBPd25QdHI8bGV2 ZWxkYjo6REI+IG1fZGI7CiB9OwogCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdG9y YWdlL0lEQkxldmVsREJCYWNraW5nU3RvcmUuaCBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURC TGV2ZWxEQkJhY2tpbmdTdG9yZS5oCmluZGV4IGQyOGE5MGM0YTYyMDZhNjU1ZTQ3ZGIyNzUxMzEz YTY1NzQ2NmNiODEuLmVhNmVjNDhkYjgxMThjMDIwN2EwZWExZDBiZjNiZWRhMzc1ZjM2NDggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURCTGV2ZWxEQkJhY2tpbmdTdG9yZS5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURCTGV2ZWxEQkJhY2tpbmdTdG9yZS5oCkBA IC04Myw4ICs4Myw4IEBAIHByaXZhdGU6CiAKICAgICBTdHJpbmcgbV9pZGVudGlmaWVyOwogICAg IFJlZlB0cjxJREJGYWN0b3J5QmFja2VuZEltcGw+IG1fZmFjdG9yeTsKLSAgICBPd25QdHI8TGV2 ZWxEQkRhdGFiYXNlPiBtX2RiOwogICAgIE93blB0cjxMZXZlbERCQ29tcGFyYXRvcj4gbV9jb21w YXJhdG9yOworICAgIE93blB0cjxMZXZlbERCRGF0YWJhc2U+IG1fZGI7CiAgICAgUmVmUHRyPExl dmVsREJUcmFuc2FjdGlvbj4gbV9jdXJyZW50VHJhbnNhY3Rpb247CiAKICAgICBjbGFzcyBUcmFu c2FjdGlvbiA6IHB1YmxpYyBJREJCYWNraW5nU3RvcmU6OlRyYW5zYWN0aW9uIHsK 101898 2011-07-25 13:13:00 -0700 2011-07-25 16:28:51 -0700 Patch bug-64494-20110725131259.patch text/plain 2502 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogOTEwNjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ZjdiZWEzYjM4MzY4MWM5 Y2I1ODlmNTE4NDFhNDI2MjkxZDk1ODlkLi4yNGUzODExZThjNGNkNjYxZDRhYzRhZDYwZDhjOWVj Yjc4NGI2NDA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDctMTMgIERhdmlk IEdyb2dhbiAgPGRncm9nYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBsZXZlbGRiIGNy YXNoIHdoZW4gY29tcGFjdGluZyBkdXJpbmcgZGVzdHJ1Y3Rpb24KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0NDk0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT25seSB0ZXN0ZWQgbWFudWFsbHkgc28gZmFy IGJ5IGZvbGxvd2luZyB0aGUgcmVwcm8gaW5zdHJ1Y3Rpb25zIGF0CisgICAgICAgIGNyYnVnLmNv bS84ODk0NAorCisgICAgICAgICogcGxhdGZvcm0vbGV2ZWxkYi9MZXZlbERCRGF0YWJhc2UuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6TGV2ZWxEQkRhdGFiYXNlOjp+TGV2ZWxEQkRhdGFiYXNlKToK KyAgICAgICAgKiBzdG9yYWdlL0lEQkxldmVsREJCYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SURCTGV2ZWxEQkJhY2tpbmdTdG9yZTo6fklEQkxldmVsREJCYWNraW5nU3RvcmUp OgorCiAyMDExLTA3LTE1ICBNaWtlIFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogUmVuYW1lIGNvbnNvbGUubWFya1RpbWVsaW5lKCkgdG8gY29uc29s ZS50aW1lU3RhbXAoKSBmb3IgRmlyZWJ1ZyBjb21wYXRpYmlsaXR5LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbGV2ZWxkYi9MZXZlbERCRGF0YWJhc2UuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbGV2ZWxkYi9MZXZlbERCRGF0YWJhc2UuY3BwCmluZGV4IDBiYWQ5 Yzg5NDBiM2Y0NDJiMjRhMjg2YTliM2NmY2RhN2Q2NGU4YjQuLjVhMWNmNmFlNTE4NmE2NzBmOTFj YzNjZTI5MzFkYmMxZGE5NWU1ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2xldmVsZGIvTGV2ZWxEQkRhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9sZXZlbGRiL0xldmVsREJEYXRhYmFzZS5jcHAKQEAgLTkzLDYgKzkzLDkgQEAgTGV2ZWxEQkRh dGFiYXNlOjpMZXZlbERCRGF0YWJhc2UoKQogCiBMZXZlbERCRGF0YWJhc2U6On5MZXZlbERCRGF0 YWJhc2UoKQogeworICAgIC8vIG1fZGIncyBkZXN0cnVjdG9yIHVzZXMgbV9jb21wYXJhdG9yQWRh cHRlcjsgb3JkZXIgb2YgZGVsZXRpb24gaXMgaW1wb3J0YW50LgorICAgIG1fZGIuY2xlYXIoKTsK KyAgICBtX2NvbXBhcmF0b3JBZGFwdGVyLmNsZWFyKCk7CiB9CiAKIFBhc3NPd25QdHI8TGV2ZWxE QkRhdGFiYXNlPiBMZXZlbERCRGF0YWJhc2U6Om9wZW4oY29uc3QgU3RyaW5nJiBmaWxlTmFtZSwg Y29uc3QgTGV2ZWxEQkNvbXBhcmF0b3IqIGNvbXBhcmF0b3IpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9zdG9yYWdlL0lEQkxldmVsREJCYWNraW5nU3RvcmUuY3BwIGIvU291cmNlL1dlYkNv cmUvc3RvcmFnZS9JREJMZXZlbERCQmFja2luZ1N0b3JlLmNwcAppbmRleCBlODA1NmU1ZjQ1MWQz MTBiZGIwNjVkNDJhZDAxNTZmOWNjNGZlZWEwLi5iMGM1YmUwZmQ4MWIyZTg1Yjc5YmJlMTM3NGUy ZWMwNTRlY2VmMTZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL0lEQkxldmVs REJCYWNraW5nU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURCTGV2ZWxE QkJhY2tpbmdTdG9yZS5jcHAKQEAgLTEyNiw2ICsxMjYsMTAgQEAgSURCTGV2ZWxEQkJhY2tpbmdT dG9yZTo6SURCTGV2ZWxEQkJhY2tpbmdTdG9yZShjb25zdCBTdHJpbmcmIGlkZW50aWZpZXIsIElE QkZhY3QKIElEQkxldmVsREJCYWNraW5nU3RvcmU6On5JREJMZXZlbERCQmFja2luZ1N0b3JlKCkK IHsKICAgICBtX2ZhY3RvcnktPnJlbW92ZUlEQkJhY2tpbmdTdG9yZShtX2lkZW50aWZpZXIpOwor CisgICAgLy8gbV9kYidzIGRlc3RydWN0b3IgdXNlcyBtX2NvbXBhcmF0b3IuIFRoZSBvcmRlciBv ZiBkZXN0cnVjdGlvbiBpcyBpbXBvcnRhbnQuCisgICAgbV9kYi5jbGVhcigpOworICAgIG1fY29t cGFyYXRvci5jbGVhcigpOwogfQogCiBQYXNzUmVmUHRyPElEQkJhY2tpbmdTdG9yZT4gSURCTGV2 ZWxEQkJhY2tpbmdTdG9yZTo6b3BlbihTZWN1cml0eU9yaWdpbiogc2VjdXJpdHlPcmlnaW4sIGNv bnN0IFN0cmluZyYgcGF0aEJhc2VBcmcsIGludDY0X3QgbWF4aW11bVNpemUsIGNvbnN0IFN0cmlu ZyYgZmlsZUlkZW50aWZpZXIsIElEQkZhY3RvcnlCYWNrZW5kSW1wbCogZmFjdG9yeSkK