64488 2011-07-13 15:15:09 -0700 Fix WTF header guard style check 2011-07-13 16:45:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 isherman isherman eric isherman levin webkit.review.bot oldest_to_newest 436696 0 isherman 2011-07-13 15:15:09 -0700 Fix WTF header guard style check 436697 1 100719 isherman 2011-07-13 15:15:32 -0700 Created attachment 100719 Patch 436703 2 100719 levin 2011-07-13 15:25:39 -0700 Comment on attachment 100719 Patch A test would be nice. I guess you ran this such that the filename was '/wtf/...' and the call should have been filename.find() >= 0 (or even better how you wrote it). 436747 3 100727 isherman 2011-07-13 16:18:19 -0700 Created attachment 100727 Patch 436748 4 isherman 2011-07-13 16:19:24 -0700 (In reply to comment #2) > (From update of attachment 100719 [details]) > A test would be nice. I guess you ran this such that the filename was '/wtf/...' and the call should have been filename.find() >= 0 (or even better how you wrote it). Added a test. This was patch was originally motivated by a false-positive style warning for https://bugs.webkit.org/show_bug.cgi?id=64333 436750 5 100727 levin 2011-07-13 16:21:59 -0700 Comment on attachment 100727 Patch Oh of course. Thanks! 436767 6 100727 webkit.review.bot 2011-07-13 16:45:31 -0700 Comment on attachment 100727 Patch Clearing flags on attachment: 100727 Committed r90965: <http://trac.webkit.org/changeset/90965> 436768 7 webkit.review.bot 2011-07-13 16:45:35 -0700 All reviewed patches have been landed. Closing bug. 100719 2011-07-13 15:15:32 -0700 2011-07-13 16:18:15 -0700 Patch bug-64488-20110713151531.patch text/plain 1255 isherman U3VidmVyc2lvbiBSZXZpc2lvbjogOTA5MTUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyOTI1ZDgzZDczMDM4ZGQxNGE5ZGU2ZWFjNTYyOWFhMzc1 NjVkMzk2Li41NmYwYjA4NTg0M2UxNWVlMzBlZDUxYzc0NGIyNTE1YzEzNTU3ZDBkIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDctMTMgIElseWEgU2hlcm1hbiAgPGlzaGVybWFuQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBGaXggV1RGIGhlYWRlciBndWFyZCBzdHlsZSBjaGVjaworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ0ODgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwLnB5OgorCiAyMDExLTA3LTEzICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZp ZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByOTA4 OTMgYW5kIHI5MDg5NC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHAucHkKaW5kZXggMDk0NjMyNzJiMDNmZjkzZDk3ODY1YTY2Mzc2NTY0ZWE3MzQxNWY4My4uOTYz YzBmMmJlYjgyZTFjZmM3OWY2Yzc4NGVhYmI5YmQ4OWFiMzFmZSAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTkyMyw3ICs5MjMsNyBAQCBkZWYg Z2V0X2hlYWRlcl9ndWFyZF9jcHBfdmFyaWFibGUoZmlsZW5hbWUpOgogICAgIHN0YW5kYXJkX25h bWUgPSBzdWIocidbLS5cc10nLCAnXycsIG9zLnBhdGguYmFzZW5hbWUoZmlsZW5hbWUpKQogCiAg ICAgIyBGaWxlcyB1bmRlciBXVEYgdHlwaWNhbGx5IGhhdmUgaGVhZGVyIGd1YXJkcyB0aGF0IHN0 YXJ0IHdpdGggV1RGXy4KLSAgICBpZiBmaWxlbmFtZS5maW5kKCcvd3RmLycpOgorICAgIGlmICcv d3RmLycgaW4gZmlsZW5hbWU6CiAgICAgICAgIHNwZWNpYWxfbmFtZSA9ICJXVEZfIiArIHN0YW5k YXJkX25hbWUKICAgICBlbHNlOgogICAgICAgICBzcGVjaWFsX25hbWUgPSBzdGFuZGFyZF9uYW1l Cg== 100727 2011-07-13 16:18:19 -0700 2011-07-13 16:45:31 -0700 Patch bug-64488-20110713161818.patch text/plain 2579 isherman U3VidmVyc2lvbiBSZXZpc2lvbjogOTA5MTUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyOTI1ZDgzZDczMDM4ZGQxNGE5ZGU2ZWFjNTYyOWFhMzc1 NjVkMzk2Li4zMWFiZmQyYzZjODhlNzcwZDU0MWU0MmVkNTQxMmE4MjdkMTNjOGZjIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDctMTMgIElseWEgU2hlcm1hbiAgPGlzaGVybWFuQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBGaXggV1RGIGhlYWRlciBndWFyZCBzdHlsZSBjaGVjaworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ0ODgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvY3BwX3VuaXR0ZXN0LnB5OiBWZXJpZnkgdGhhdCB3ZSBkb24ndCAqYWx3YXlzKiBzdWdnZXN0 ICJXVEZfIiBhcyBhIHByZWZpeAorCiAyMDExLTA3LTEzICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5y ZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCBy OTA4OTMgYW5kIHI5MDg5NC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHAucHkKaW5kZXggMDk0NjMyNzJiMDNmZjkzZDk3ODY1YTY2Mzc2NTY0ZWE3MzQxNWY4My4u OTYzYzBmMmJlYjgyZTFjZmM3OWY2Yzc4NGVhYmI5YmQ4OWFiMzFmZSAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTkyMyw3ICs5MjMsNyBAQCBk ZWYgZ2V0X2hlYWRlcl9ndWFyZF9jcHBfdmFyaWFibGUoZmlsZW5hbWUpOgogICAgIHN0YW5kYXJk X25hbWUgPSBzdWIocidbLS5cc10nLCAnXycsIG9zLnBhdGguYmFzZW5hbWUoZmlsZW5hbWUpKQog CiAgICAgIyBGaWxlcyB1bmRlciBXVEYgdHlwaWNhbGx5IGhhdmUgaGVhZGVyIGd1YXJkcyB0aGF0 IHN0YXJ0IHdpdGggV1RGXy4KLSAgICBpZiBmaWxlbmFtZS5maW5kKCcvd3RmLycpOgorICAgIGlm ICcvd3RmLycgaW4gZmlsZW5hbWU6CiAgICAgICAgIHNwZWNpYWxfbmFtZSA9ICJXVEZfIiArIHN0 YW5kYXJkX25hbWUKICAgICBlbHNlOgogICAgICAgICBzcGVjaWFsX25hbWUgPSBzdGFuZGFyZF9u YW1lCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nw cF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw X3VuaXR0ZXN0LnB5CmluZGV4IDgwMGUyZTMzZjE0MGIyYWQ1MDMzZGFjYWFmMjE1Y2RlY2ViODJh ZWYuLjI4MjlhOWY2ZWRlMTRlZjg3YzY4YzAzNTRmM2JhNTY5NjAxMDdhZjQgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5 CkBAIC0xLDcgKzEsNyBAQAogIyEvdXNyL2Jpbi9weXRob24KICMgLSotIGNvZGluZzogdXRmLTg7 IC0qLQogIwotIyBDb3B5cmlnaHQgKEMpIDIwMDksIDIwMTAgR29vZ2xlIEluYy4gQWxsIHJpZ2h0 cyByZXNlcnZlZC4KKyMgQ29weXJpZ2h0IChDKSAyMDExIEdvb2dsZSBJbmMuIEFsbCByaWdodHMg cmVzZXJ2ZWQuCiAjIENvcHlyaWdodCAoQykgMjAwOSBUb3JjaCBNb2JpbGUgSW5jLgogIyBDb3B5 cmlnaHQgKEMpIDIwMDkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogIyBDb3B5cmln aHQgKEMpIDIwMTAgQ2hyaXMgSmVyZG9uZWsgKGNqZXJkb25la0B3ZWJraXQub3JnKQpAQCAtMjE3 Niw2ICsyMTc2LDkgQEAgY2xhc3MgQ3BwU3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAg ICAgICAgICAgICAgICcgIFtidWlsZC9oZWFkZXJfZ3VhcmRdIFs1XScgJSBleHBlY3RlZF9ndWFy ZCksCiAgICAgICAgICAgICBlcnJvcl9jb2xsZWN0b3IucmVzdWx0X2xpc3QoKSkKIAorICAgICAg ICAjIFZlcmlmeSB0aGF0IHdlIGRvbid0IGJsaW5kbHkgc3VnZ2VzdCB0aGUgV1RGIHByZWZpeCBm b3IgYWxsIGhlYWRlcnMuCisgICAgICAgIHNlbGYuYXNzZXJ0RmFsc2UoZXhwZWN0ZWRfZ3VhcmQu c3RhcnRzd2l0aCgnV1RGXycpKQorCiAgICAgICAgICMgQWxsb3cgdGhlIFdURl8gcHJlZml4IGZv ciBmaWxlcyBpbiB0aGF0IGRpcmVjdG9yeS4KICAgICAgICAgaGVhZGVyX2d1YXJkX2ZpbHRlciA9 IEZpbHRlckNvbmZpZ3VyYXRpb24oKCctJywgJytidWlsZC9oZWFkZXJfZ3VhcmQnKSkKICAgICAg ICAgZXJyb3JfY29sbGVjdG9yID0gRXJyb3JDb2xsZWN0b3Ioc2VsZi5hc3NlcnRfLCBoZWFkZXJf Z3VhcmRfZmlsdGVyKQo=