64481 2011-07-13 13:45:05 -0700 Implement WKPageCenterSelectionInVisibleArea 2011-07-14 10:44:57 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 adachan adachan jeffm sam oldest_to_newest 436635 0 adachan 2011-07-13 13:45:05 -0700 This is the WebKit2 counterpart of WebView::centerSelectionInVisibleArea() in WebKit1. Related to <rdar://problem/9732174> 436658 1 100712 adachan 2011-07-13 14:28:45 -0700 Created attachment 100712 Patch 436722 2 100712 jeffm 2011-07-13 15:51:18 -0700 Comment on attachment 100712 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100712&action=review > Source/WebKit2/ChangeLog:9 > + (WKPageCenterSelectionInVisibleArea): You should add a description here, even it it's just to note that this function was added. 436731 3 adachan 2011-07-13 15:57:26 -0700 (In reply to comment #2) > (From update of attachment 100712 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100712&action=review > > > Source/WebKit2/ChangeLog:9 > > + (WKPageCenterSelectionInVisibleArea): > > You should add a description here, even it it's just to note that this function was added. OK, added this comment: (WKPageCenterSelectionInVisibleArea): Added. Call WebPageProxy::centerSelectionInVisibleArea(). 437164 4 100712 andersca 2011-07-14 10:18:33 -0700 Comment on attachment 100712 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100712&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1244 > + if (!frameSelection) > + return; Frame::selection can never return null, so you can just call coreFrame->selection()->revealSelection directly. 437165 5 adachan 2011-07-14 10:20:39 -0700 (In reply to comment #4) > (From update of attachment 100712 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100712&action=review > > > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1244 > > + if (!frameSelection) > > + return; > > Frame::selection can never return null, so you can just call coreFrame->selection()->revealSelection directly. OK, will do. Thanks! 437190 6 adachan 2011-07-14 10:44:57 -0700 Fixed in http://trac.webkit.org/changeset/91012 100712 2011-07-13 14:28:45 -0700 2011-07-14 10:18:33 -0700 Patch 64481.patch.txt text/plain 5801 adachan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwOTQ1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDctMTMgIEFkYSBDaGFu ICA8YWRhY2hhbkBhcHBsZS5jb20+CisKKyAgICAgICAgSW1wbGVtZW50IHN1cHBvcnQgdG8gY2Vu dGVyIHNlbGVjdGlvbiBvbiBhIHBhZ2UgZm9yIFdlYktpdDIuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDQ4MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHA6 CisgICAgICAgIChXS1BhZ2VDZW50ZXJTZWxlY3Rpb25JblZpc2libGVBcmVhKToKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6Y2VudGVyU2VsZWN0aW9u SW5WaXNpYmxlQXJlYSk6IFNlbmQgbWVzc2FnZSB0byB0aGUgV2ViUHJvY2VzcyB0byBjZW50ZXIg c2VsZWN0aW9uLgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDoKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBh Z2U6OmNlbnRlclNlbGVjdGlvbkluVmlzaWJsZUFyZWEpOiBHZXQgdGhlIEZyYW1lU2VsZWN0aW9u IGZyb20gdGhlIG1haW4gZnJhbWUgYW5kIGNhbGwKKyAgICAgICAgcmV2ZWFsU2VsZWN0aW9uKCkg dG8gY2VudGVyIGl0LgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmg6Cisg ICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMuaW46IEFkZCB0aGUg Q2VudGVyU2VsZWN0aW9uSW5WaXNpYmxlQXJlYSBtZXNzYWdlLgorCiAyMDExLTA3LTEzICBEYXZp ZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBQb3NzaWJsZSByYWNlIGNv bmRpdGlvbiBpbiBUaHJlYWRJZGVudGlmaWVyRGF0YTo6aW5pdGlhbGl6ZUtleU9uY2UgYW5kIHNo b3VsZENhbGxSZWFsRGVidWdnZXIuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi UGFnZVByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi UGFnZVByb3h5LmNwcAkocmV2aXNpb24gOTA5NDQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAwNiw2ICsxMDA2LDE0IEBA IHZvaWQgV2ViUGFnZVByb3h5OjpzY3JvbGxCeShTY3JvbGxEaXJlY3QKICAgICBwcm9jZXNzKCkt PnNlbmQoTWVzc2FnZXM6OldlYlBhZ2U6OlNjcm9sbEJ5KGRpcmVjdGlvbiwgZ3JhbnVsYXJpdHkp LCBtX3BhZ2VJRCk7CiB9CiAKK3ZvaWQgV2ViUGFnZVByb3h5OjpjZW50ZXJTZWxlY3Rpb25JblZp c2libGVBcmVhKCkKK3sKKyAgICBpZiAoIWlzVmFsaWQoKSkKKyAgICAgICAgcmV0dXJuOworCisg ICAgcHJvY2VzcygpLT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlOjpDZW50ZXJTZWxlY3Rpb25JblZp c2libGVBcmVhKCksIG1fcGFnZUlEKTsKK30KKwogdm9pZCBXZWJQYWdlUHJveHk6OnJlY2VpdmVk UG9saWN5RGVjaXNpb24oUG9saWN5QWN0aW9uIGFjdGlvbiwgV2ViRnJhbWVQcm94eSogZnJhbWUs IHVpbnQ2NF90IGxpc3RlbmVySUQpCiB7CiAgICAgaWYgKCFpc1ZhbGlkKCkpCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCShyZXZpc2lvbiA5MDk0NCkKKysrIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAkod29ya2luZyBjb3B5KQpAQCAt MzUxLDYgKzM1MSw3IEBAIHB1YmxpYzoKICNlbmRpZgogCiAgICAgdm9pZCBzY3JvbGxCeShXZWJD b3JlOjpTY3JvbGxEaXJlY3Rpb24sIFdlYkNvcmU6OlNjcm9sbEdyYW51bGFyaXR5KTsKKyAgICB2 b2lkIGNlbnRlclNlbGVjdGlvbkluVmlzaWJsZUFyZWEoKTsKIAogICAgIFN0cmluZyBwYWdlVGl0 bGUoKSBjb25zdDsKICAgICBjb25zdCBTdHJpbmcmIHRvb2xUaXAoKSBjb25zdCB7IHJldHVybiBt X3Rvb2xUaXA7IH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2Uu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2Uu Y3BwCShyZXZpc2lvbiA5MDk0NCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9X S1BhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTQsNiArMzU0LDExIEBAIHZvaWQgV0tQYWdl U2V0TWFpbnRhaW5zSW5hY3RpdmVTZWxlY3Rpb24KICAgICByZXR1cm4gdG9JbXBsKHBhZ2VSZWYp LT5zZXRNYWludGFpbnNJbmFjdGl2ZVNlbGVjdGlvbihuZXdWYWx1ZSk7CiB9CiAKK3ZvaWQgV0tQ YWdlQ2VudGVyU2VsZWN0aW9uSW5WaXNpYmxlQXJlYShXS1BhZ2VSZWYgcGFnZVJlZikKK3sKKyAg ICByZXR1cm4gdG9JbXBsKHBhZ2VSZWYpLT5jZW50ZXJTZWxlY3Rpb25JblZpc2libGVBcmVhKCk7 Cit9CisKIHZvaWQgV0tQYWdlRmluZFN0cmluZyhXS1BhZ2VSZWYgcGFnZVJlZiwgV0tTdHJpbmdS ZWYgc3RyaW5nLCBXS0ZpbmRPcHRpb25zIG9wdGlvbnMsIHVuc2lnbmVkIG1heE1hdGNoQ291bnQp CiB7CiAgICAgdG9JbXBsKHBhZ2VSZWYpLT5maW5kU3RyaW5nKHRvSW1wbChzdHJpbmcpLT5zdHJp bmcoKSwgdG9GaW5kT3B0aW9ucyhvcHRpb25zKSwgbWF4TWF0Y2hDb3VudCk7CkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5oCShyZXZpc2lvbiA5MDk0NCkKKysrIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuaAkod29ya2luZyBjb3B5KQpAQCAt MzY3LDYgKzM2Nyw3IEBAIFdLX0VYUE9SVCBib29sIFdLUGFnZUhhc1NlbGVjdGVkUmFuZ2UoV0sK IFdLX0VYUE9SVCBib29sIFdLUGFnZUlzQ29udGVudEVkaXRhYmxlKFdLUGFnZVJlZiBwYWdlKTsK IAogV0tfRVhQT1JUIHZvaWQgV0tQYWdlU2V0TWFpbnRhaW5zSW5hY3RpdmVTZWxlY3Rpb24oV0tQ YWdlUmVmIHBhZ2UsIGJvb2wgbWFpbnRhaW5zSW5hY3RpdmVTZWxlY3Rpb24pOworV0tfRVhQT1JU IHZvaWQgV0tQYWdlQ2VudGVyU2VsZWN0aW9uSW5WaXNpYmxlQXJlYShXS1BhZ2VSZWYgcGFnZSk7 CiAgICAgCiBXS19FWFBPUlQgdm9pZCBXS1BhZ2VGaW5kU3RyaW5nKFdLUGFnZVJlZiBwYWdlLCBX S1N0cmluZ1JlZiBzdHJpbmcsIFdLRmluZE9wdGlvbnMgZmluZE9wdGlvbnMsIHVuc2lnbmVkIG1h eE1hdGNoQ291bnQpOwogV0tfRVhQT1JUIHZvaWQgV0tQYWdlSGlkZUZpbmRVSShXS1BhZ2VSZWYg cGFnZSk7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwCShyZXZpc2lvbiA5MDk0NCkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTIzMyw2ICsxMjMzLDE5IEBAIHZv aWQgV2ViUGFnZTo6c2Nyb2xsQnkodWludDMyX3Qgc2Nyb2xsRGkKICAgICBzY3JvbGwobV9wYWdl LmdldCgpLCBzdGF0aWNfY2FzdDxTY3JvbGxEaXJlY3Rpb24+KHNjcm9sbERpcmVjdGlvbiksIHN0 YXRpY19jYXN0PFNjcm9sbEdyYW51bGFyaXR5PihzY3JvbGxHcmFudWxhcml0eSkpOwogfQogCit2 b2lkIFdlYlBhZ2U6OmNlbnRlclNlbGVjdGlvbkluVmlzaWJsZUFyZWEoKQoreworICAgIEZyYW1l KiBjb3JlRnJhbWUgPSBtX21haW5GcmFtZS0+Y29yZUZyYW1lKCk7CisgICAgaWYgKCFjb3JlRnJh bWUpCisgICAgICAgIHJldHVybjsKKworICAgIEZyYW1lU2VsZWN0aW9uKiBmcmFtZVNlbGVjdGlv biA9IGNvcmVGcmFtZS0+c2VsZWN0aW9uKCk7CisgICAgaWYgKCFmcmFtZVNlbGVjdGlvbikKKyAg ICAgICAgcmV0dXJuOworCisgICAgZnJhbWVTZWxlY3Rpb24tPnJldmVhbFNlbGVjdGlvbihTY3Jv bGxBbGlnbm1lbnQ6OmFsaWduQ2VudGVyQWx3YXlzKTsKK30KKwogdm9pZCBXZWJQYWdlOjpzZXRB Y3RpdmUoYm9vbCBpc0FjdGl2ZSkKIHsKICAgICBtX3BhZ2UtPmZvY3VzQ29udHJvbGxlcigpLT5z ZXRBY3RpdmUoaXNBY3RpdmUpOwpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL1dlYlBhZ2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5oCShyZXZpc2lvbiA5MDk0NCkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgJKHdvcmtpbmcgY29weSkKQEAgLTE1Myw2ICsxNTMsOCBA QCBwdWJsaWM6CiAKICAgICB2b2lkIHNjcm9sbEJ5KHVpbnQzMl90IHNjcm9sbERpcmVjdGlvbiwg dWludDMyX3Qgc2Nyb2xsR3JhbnVsYXJpdHkpOwogCisgICAgdm9pZCBjZW50ZXJTZWxlY3Rpb25J blZpc2libGVBcmVhKCk7CisKICNpZiBFTkFCTEUoSU5TUEVDVE9SKQogICAgIFdlYkluc3BlY3Rv ciogaW5zcGVjdG9yKCk7CiAjZW5kaWYKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2VzLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2VzLmluCShyZXZpc2lvbiA5MDk0NCkK KysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2VzLmlu CSh3b3JraW5nIGNvcHkpCkBAIC00NSw2ICs0NSw3IEBAIG1lc3NhZ2VzIC0+IFdlYlBhZ2Ugewog ICAgIENvbnRleHRNZW51SGlkZGVuKCkKIAogICAgIFNjcm9sbEJ5KHVpbnQzMl90IHNjcm9sbERp cmVjdGlvbiwgdWludDMyX3Qgc2Nyb2xsR3JhbnVsYXJpdHkpCisgICAgQ2VudGVyU2VsZWN0aW9u SW5WaXNpYmxlQXJlYSgpCiAKICAgICBHb0JhY2sodWludDY0X3QgYmFja0ZvcndhcmRJdGVtSUQs IFdlYktpdDo6U2FuZGJveEV4dGVuc2lvbjo6SGFuZGxlIHNhbmRib3hFeHRlbnNpb25IYW5kbGUp CiAgICAgR29Gb3J3YXJkKHVpbnQ2NF90IGJhY2tGb3J3YXJkSXRlbUlELCBXZWJLaXQ6OlNhbmRi b3hFeHRlbnNpb246OkhhbmRsZSBzYW5kYm94RXh0ZW5zaW9uSGFuZGxlKQo=