64453 2011-07-13 07:36:19 -0700 [Qt] Build error when trying to build with QRawFontSupport 2011-07-13 08:44:00 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 1 pierre.rossi pierre.rossi kling webkit.review.bot oldest_to_newest 436433 0 pierre.rossi 2011-07-13 07:36:19 -0700 Essentially due to ContextShadow being taken over by ShadowBlur. 436435 1 100673 pierre.rossi 2011-07-13 07:40:36 -0700 Created attachment 100673 patch 436436 2 100673 kling 2011-07-13 07:44:52 -0700 Comment on attachment 100673 patch LGTM. 436459 3 100673 webkit.review.bot 2011-07-13 08:43:56 -0700 Comment on attachment 100673 patch Clearing flags on attachment: 100673 Committed r90919: <http://trac.webkit.org/changeset/90919> 436460 4 webkit.review.bot 2011-07-13 08:44:00 -0700 All reviewed patches have been landed. Closing bug. 100673 2011-07-13 07:40:36 -0700 2011-07-13 08:43:56 -0700 patch 0001-Fix-compile-for-QRawFont.patch text/plain 4091 pierre.rossi RnJvbSBiMzJiZGRhN2NkZDRkMjAwYWUzYjIyYzRkNzFjYjlmMWRmNzZhYWY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaWVycmUgUm9zc2kgPHBpZXJyZS5yb3NzaUBnbWFpbC5jb20+ CkRhdGU6IFdlZCwgMTMgSnVsIDIwMTEgMTU6NDE6NTMgKzAyMDAKU3ViamVjdDogRml4IGNvbXBp bGUgZm9yIFFSYXdGb250LgoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmggfCAgICAxIC0KIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRRdC5jcHAgICAgIHwgICAyMyArKysrKysrKysrLS0tLS0t LS0tCiAzIGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjYzFiMWY5Li42ZmU4ODNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDctMTMgIFBpZXJyZSBSb3NzaSAgPHBpZXJyZS5yb3NzaUBnbWFpbC5jb20+CisK KyAgICAgICAgRml4IGNvbXBpbGUgZm9yIFFSYXdGb250LgorCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDQ1MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3ND b250ZXh0Lmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRm9udFF0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkZvbnQ6OmRyYXdHbHlwaHMpOgorCiAyMDExLTA3LTEyICBQcmF0aWsg U29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZp ZCBLaWx6ZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9H cmFwaGljc0NvbnRleHQuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBo aWNzQ29udGV4dC5oCmluZGV4IDRhNGNiYjAuLmE2YjRjYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oCkBAIC01Myw3ICs1Myw2 IEBAIHR5cGVkZWYgY2xhc3MgV2ViQ29yZTo6U3VyZmFjZU9wZW5WRyBQbGF0Zm9ybUdyYXBoaWNz Q29udGV4dDsKICNlbGlmIFBMQVRGT1JNKFFUKQogI2luY2x1ZGUgPFFQYWludGVyPgogbmFtZXNw YWNlIFdlYkNvcmUgewotY2xhc3MgQ29udGV4dFNoYWRvdzsKIGNsYXNzIFNoYWRvd0JsdXI7CiB9 CiB0eXBlZGVmIFFQYWludGVyIFBsYXRmb3JtR3JhcGhpY3NDb250ZXh0OwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRm9udFF0LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRRdC5jcHAKaW5kZXggYTIxMmVlZi4uNTEx OTMzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRm9u dFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Gb250UXQu Y3BwCkBAIC00Miw2ICs0Miw5IEBACiAjaW5jbHVkZSA8UVBhaW50ZXI+CiAjaW5jbHVkZSA8UVBh aW50ZXJQYXRoPgogI2luY2x1ZGUgPFFQZW4+CisjaWYgSEFWRShRUkFXRk9OVCkKKyNpbmNsdWRl IDxRUG9pbnRGPgorI2VuZGlmCiAjaW5jbHVkZSA8UVRleHRMYXlvdXQ+CiAjaW5jbHVkZSA8cWFs Z29yaXRobXMuaD4KICNpbmNsdWRlIDxxZGVidWcuaD4KQEAgLTMzMyw5ICszMzYsNiBAQCB2b2lk IEZvbnQ6OmRyYXdHbHlwaHMoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBTaW1wbGVG b250RGF0YSogZm9udERhdGEsCiAgICAgLy8gU3Ryb2tpbmcgdGV4dCBzaG91bGQgYWx3YXlzIHRh a2UgdGhlIGNvbXBsZXggcGF0aC4KICAgICBBU1NFUlQoIXNob3VsZFN0cm9rZSk7CiAKLSAgICAv LyBTaGFkb3dlZCB0ZXh0IHNob3VsZCBhbHdheXMgdGFrZSB0aGUgY29tcGxleCBwYXRoLgotICAg IEFTU0VSVChjb250ZXh0LT5jb250ZXh0U2hhZG93KCktPnR5cGUoKSA9PSBTaGFkb3dCbHVyOjpO b1NoYWRvdyk7Ci0KICAgICBpZiAoIXNob3VsZEZpbGwgJiYgIXNob3VsZFN0cm9rZSkKICAgICAg ICAgcmV0dXJuOwogCkBAIC0zNjYsMzAgKzM2NiwzMSBAQCB2b2lkIEZvbnQ6OmRyYXdHbHlwaHMo R3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBTaW1wbGVGb250RGF0YSogZm9udERhdGEs CiAKICAgICBRUGFpbnRlciogcGFpbnRlciA9IGNvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgpOwog Ci0gICAgQ29udGV4dFNoYWRvdyogc2hhZG93ID0gY29udGV4dC0+Y29udGV4dFNoYWRvdygpOwor ICAgIFNoYWRvd0JsdXIqIHNoYWRvdyA9IGNvbnRleHQtPnNoYWRvd0JsdXIoKTsKICAgICBzd2l0 Y2ggKHNoYWRvdy0+dHlwZSgpKSB7Ci0gICAgY2FzZSBDb250ZXh0U2hhZG93OjpTb2xpZFNoYWRv dzogeworICAgIGNhc2UgU2hhZG93Qmx1cjo6U29saWRTaGFkb3c6IHsKICAgICAgICAgUVBlbiBw cmV2aW91c1BlbiA9IHBhaW50ZXItPnBlbigpOwotICAgICAgICBwYWludGVyLT5zZXRQZW4oc2hh ZG93LT5tX2NvbG9yKTsKLSAgICAgICAgcGFpbnRlci0+dHJhbnNsYXRlKHNoYWRvdy0+b2Zmc2V0 KCkpOworICAgICAgICBwYWludGVyLT5zZXRQZW4oY29udGV4dC0+c3RhdGUoKS5zaGFkb3dDb2xv cik7CisgICAgICAgIGNvbnN0IFFQb2ludEYgc2hhZG93T2Zmc2V0KGNvbnRleHQtPnN0YXRlKCku c2hhZG93T2Zmc2V0LndpZHRoKCksIGNvbnRleHQtPnN0YXRlKCkuc2hhZG93T2Zmc2V0LmhlaWdo dCgpKTsKKyAgICAgICAgcGFpbnRlci0+dHJhbnNsYXRlKHNoYWRvd09mZnNldCk7CiAgICAgICAg IHBhaW50ZXItPmRyYXdHbHlwaFJ1bihwb2ludCwgcXRHbHlwaHMpOwotICAgICAgICBwYWludGVy LT50cmFuc2xhdGUoLXNoYWRvdy0+b2Zmc2V0KCkpOworICAgICAgICBwYWludGVyLT50cmFuc2xh dGUoLXNoYWRvd09mZnNldCk7CiAgICAgICAgIHBhaW50ZXItPnNldFBlbihwcmV2aW91c1Blbik7 CiAgICAgICAgIGJyZWFrOwogICAgIH0KLSAgICBjYXNlIENvbnRleHRTaGFkb3c6OkJsdXJTaGFk b3c6IHsKKyAgICBjYXNlIFNoYWRvd0JsdXI6OkJsdXJTaGFkb3c6IHsKICAgICAgICAgcXJlYWwg aGVpZ2h0ID0gcmF3Rm9udC5hc2NlbnQoKSArIHJhd0ZvbnQuZGVzY2VudCgpICsgMTsKICAgICAg ICAgUVJlY3RGIGJvdW5kaW5nUmVjdChwb2ludC54KCksIHBvaW50LnkoKSAtIHJhd0ZvbnQuYXNj ZW50KCksIHdpZHRoLCBoZWlnaHQpOwogICAgICAgICBHcmFwaGljc0NvbnRleHQqIHNoYWRvd0Nv bnRleHQgPSBzaGFkb3ctPmJlZ2luU2hhZG93TGF5ZXIoY29udGV4dCwgYm91bmRpbmdSZWN0KTsK ICAgICAgICAgaWYgKHNoYWRvd0NvbnRleHQpIHsKICAgICAgICAgICAgIFFQYWludGVyKiBzaGFk b3dQYWludGVyID0gc2hhZG93Q29udGV4dC0+cGxhdGZvcm1Db250ZXh0KCk7Ci0gICAgICAgICAg ICBzaGFkb3dQYWludGVyLT5zZXRQZW4oc2hhZG93LT5tX2NvbG9yKTsKKyAgICAgICAgICAgIHNo YWRvd1BhaW50ZXItPnNldFBlbihjb250ZXh0LT5zdGF0ZSgpLnNoYWRvd0NvbG9yKTsKICAgICAg ICAgICAgIHNoYWRvd1BhaW50ZXItPmRyYXdHbHlwaFJ1bihwb2ludCwgcXRHbHlwaHMpOwogICAg ICAgICAgICAgc2hhZG93LT5lbmRTaGFkb3dMYXllcihjb250ZXh0KTsKICAgICAgICAgfQogICAg ICAgICBicmVhazsKICAgICB9Ci0gICAgY2FzZSBDb250ZXh0U2hhZG93OjpOb1NoYWRvdzoKKyAg ICBjYXNlIFNoYWRvd0JsdXI6Ok5vU2hhZG93OgogICAgICAgICBicmVhazsKICAgICBkZWZhdWx0 OgogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLS0gCjEuNy42Cgo=